summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorGravatar Lioncash2018-01-17 20:21:14 -0500
committerGravatar Lioncash2018-01-17 20:21:16 -0500
commit3d19102c48adb397ae4c86ced7c2345eea1c28ee (patch)
tree81743be0f586655bc142ec61a93376e8bcce456d /src
parentvi: Add missing override specifiers (diff)
downloadyuzu-3d19102c48adb397ae4c86ced7c2345eea1c28ee.tar.gz
yuzu-3d19102c48adb397ae4c86ced7c2345eea1c28ee.tar.xz
yuzu-3d19102c48adb397ae4c86ced7c2345eea1c28ee.zip
vi: Make constructors explicit where applicable
Prevents implicit conversions.
Diffstat (limited to 'src')
-rw-r--r--src/core/hle/service/vi/vi.cpp27
1 files changed, 14 insertions, 13 deletions
diff --git a/src/core/hle/service/vi/vi.cpp b/src/core/hle/service/vi/vi.cpp
index dac681605..02aab6df1 100644
--- a/src/core/hle/service/vi/vi.cpp
+++ b/src/core/hle/service/vi/vi.cpp
@@ -26,7 +26,7 @@ public:
26 // This default size was chosen arbitrarily. 26 // This default size was chosen arbitrarily.
27 static constexpr size_t DefaultBufferSize = 0x40; 27 static constexpr size_t DefaultBufferSize = 0x40;
28 Parcel() : buffer(DefaultBufferSize) {} 28 Parcel() : buffer(DefaultBufferSize) {}
29 Parcel(std::vector<u8> data) : buffer(std::move(data)) {} 29 explicit Parcel(std::vector<u8> data) : buffer(std::move(data)) {}
30 virtual ~Parcel() = default; 30 virtual ~Parcel() = default;
31 31
32 template <typename T> 32 template <typename T>
@@ -121,7 +121,7 @@ private:
121 121
122class NativeWindow : public Parcel { 122class NativeWindow : public Parcel {
123public: 123public:
124 NativeWindow(u32 id) : Parcel() { 124 explicit NativeWindow(u32 id) : Parcel() {
125 data.id = id; 125 data.id = id;
126 } 126 }
127 ~NativeWindow() override = default; 127 ~NativeWindow() override = default;
@@ -147,7 +147,7 @@ private:
147 147
148class IGBPConnectRequestParcel : public Parcel { 148class IGBPConnectRequestParcel : public Parcel {
149public: 149public:
150 IGBPConnectRequestParcel(const std::vector<u8>& buffer) : Parcel(buffer) { 150 explicit IGBPConnectRequestParcel(const std::vector<u8>& buffer) : Parcel(buffer) {
151 Deserialize(); 151 Deserialize();
152 } 152 }
153 ~IGBPConnectRequestParcel() override = default; 153 ~IGBPConnectRequestParcel() override = default;
@@ -168,7 +168,7 @@ public:
168 168
169class IGBPConnectResponseParcel : public Parcel { 169class IGBPConnectResponseParcel : public Parcel {
170public: 170public:
171 IGBPConnectResponseParcel(u32 width, u32 height) : Parcel() { 171 explicit IGBPConnectResponseParcel(u32 width, u32 height) : Parcel() {
172 data.width = width; 172 data.width = width;
173 data.height = height; 173 data.height = height;
174 } 174 }
@@ -194,7 +194,8 @@ private:
194 194
195class IGBPSetPreallocatedBufferRequestParcel : public Parcel { 195class IGBPSetPreallocatedBufferRequestParcel : public Parcel {
196public: 196public:
197 IGBPSetPreallocatedBufferRequestParcel(const std::vector<u8>& buffer) : Parcel(buffer) { 197 explicit IGBPSetPreallocatedBufferRequestParcel(const std::vector<u8>& buffer)
198 : Parcel(buffer) {
198 Deserialize(); 199 Deserialize();
199 } 200 }
200 ~IGBPSetPreallocatedBufferRequestParcel() override = default; 201 ~IGBPSetPreallocatedBufferRequestParcel() override = default;
@@ -231,7 +232,7 @@ protected:
231 232
232class IGBPDequeueBufferRequestParcel : public Parcel { 233class IGBPDequeueBufferRequestParcel : public Parcel {
233public: 234public:
234 IGBPDequeueBufferRequestParcel(const std::vector<u8>& buffer) : Parcel(buffer) { 235 explicit IGBPDequeueBufferRequestParcel(const std::vector<u8>& buffer) : Parcel(buffer) {
235 Deserialize(); 236 Deserialize();
236 } 237 }
237 ~IGBPDequeueBufferRequestParcel() override = default; 238 ~IGBPDequeueBufferRequestParcel() override = default;
@@ -254,7 +255,7 @@ public:
254 255
255class IGBPDequeueBufferResponseParcel : public Parcel { 256class IGBPDequeueBufferResponseParcel : public Parcel {
256public: 257public:
257 IGBPDequeueBufferResponseParcel(u32 slot) : Parcel(), slot(slot) {} 258 explicit IGBPDequeueBufferResponseParcel(u32 slot) : Parcel(), slot(slot) {}
258 ~IGBPDequeueBufferResponseParcel() override = default; 259 ~IGBPDequeueBufferResponseParcel() override = default;
259 260
260protected: 261protected:
@@ -271,7 +272,7 @@ protected:
271 272
272class IGBPRequestBufferRequestParcel : public Parcel { 273class IGBPRequestBufferRequestParcel : public Parcel {
273public: 274public:
274 IGBPRequestBufferRequestParcel(const std::vector<u8>& buffer) : Parcel(buffer) { 275 explicit IGBPRequestBufferRequestParcel(const std::vector<u8>& buffer) : Parcel(buffer) {
275 Deserialize(); 276 Deserialize();
276 } 277 }
277 ~IGBPRequestBufferRequestParcel() override = default; 278 ~IGBPRequestBufferRequestParcel() override = default;
@@ -286,7 +287,7 @@ public:
286 287
287class IGBPRequestBufferResponseParcel : public Parcel { 288class IGBPRequestBufferResponseParcel : public Parcel {
288public: 289public:
289 IGBPRequestBufferResponseParcel(IGBPBuffer buffer) : Parcel(), buffer(buffer) {} 290 explicit IGBPRequestBufferResponseParcel(IGBPBuffer buffer) : Parcel(), buffer(buffer) {}
290 ~IGBPRequestBufferResponseParcel() override = default; 291 ~IGBPRequestBufferResponseParcel() override = default;
291 292
292protected: 293protected:
@@ -307,7 +308,7 @@ protected:
307 308
308class IGBPQueueBufferRequestParcel : public Parcel { 309class IGBPQueueBufferRequestParcel : public Parcel {
309public: 310public:
310 IGBPQueueBufferRequestParcel(const std::vector<u8>& buffer) : Parcel(buffer) { 311 explicit IGBPQueueBufferRequestParcel(const std::vector<u8>& buffer) : Parcel(buffer) {
311 Deserialize(); 312 Deserialize();
312 } 313 }
313 ~IGBPQueueBufferRequestParcel() override = default; 314 ~IGBPQueueBufferRequestParcel() override = default;
@@ -330,7 +331,7 @@ public:
330 331
331class IGBPQueueBufferResponseParcel : public Parcel { 332class IGBPQueueBufferResponseParcel : public Parcel {
332public: 333public:
333 IGBPQueueBufferResponseParcel(u32 width, u32 height) : Parcel() { 334 explicit IGBPQueueBufferResponseParcel(u32 width, u32 height) : Parcel() {
334 data.width = width; 335 data.width = width;
335 data.height = height; 336 data.height = height;
336 } 337 }
@@ -356,7 +357,7 @@ private:
356 357
357class IHOSBinderDriver final : public ServiceFramework<IHOSBinderDriver> { 358class IHOSBinderDriver final : public ServiceFramework<IHOSBinderDriver> {
358public: 359public:
359 IHOSBinderDriver(std::shared_ptr<NVFlinger> nv_flinger) 360 explicit IHOSBinderDriver(std::shared_ptr<NVFlinger> nv_flinger)
360 : ServiceFramework("IHOSBinderDriver"), nv_flinger(std::move(nv_flinger)) { 361 : ServiceFramework("IHOSBinderDriver"), nv_flinger(std::move(nv_flinger)) {
361 static const FunctionInfo functions[] = { 362 static const FunctionInfo functions[] = {
362 {0, &IHOSBinderDriver::TransactParcel, "TransactParcel"}, 363 {0, &IHOSBinderDriver::TransactParcel, "TransactParcel"},
@@ -506,7 +507,7 @@ private:
506 507
507class IManagerDisplayService final : public ServiceFramework<IManagerDisplayService> { 508class IManagerDisplayService final : public ServiceFramework<IManagerDisplayService> {
508public: 509public:
509 IManagerDisplayService(std::shared_ptr<NVFlinger> nv_flinger) 510 explicit IManagerDisplayService(std::shared_ptr<NVFlinger> nv_flinger)
510 : ServiceFramework("IManagerDisplayService"), nv_flinger(std::move(nv_flinger)) { 511 : ServiceFramework("IManagerDisplayService"), nv_flinger(std::move(nv_flinger)) {
511 static const FunctionInfo functions[] = { 512 static const FunctionInfo functions[] = {
512 {1020, &IManagerDisplayService::CloseDisplay, "CloseDisplay"}, 513 {1020, &IManagerDisplayService::CloseDisplay, "CloseDisplay"},