diff options
| author | 2020-03-13 15:35:15 +0700 | |
|---|---|---|
| committer | 2020-03-13 15:35:15 +0700 | |
| commit | 325977c0c6947597618afca51494df62bacefb76 (patch) | |
| tree | fc55f5010bc92fc59c81c67064bf27db5cf27b7b /src | |
| parent | shader_decode: BFE add ref of reverse parallel method. (diff) | |
| download | yuzu-325977c0c6947597618afca51494df62bacefb76.tar.gz yuzu-325977c0c6947597618afca51494df62bacefb76.tar.xz yuzu-325977c0c6947597618afca51494df62bacefb76.zip | |
Apply suggestions from code review
Co-Authored-By: Mat M. <mathew1800@gmail.com>
Diffstat (limited to 'src')
| -rw-r--r-- | src/video_core/shader/decode/bfe.cpp | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/src/video_core/shader/decode/bfe.cpp b/src/video_core/shader/decode/bfe.cpp index 39587e0df..7f2647973 100644 --- a/src/video_core/shader/decode/bfe.cpp +++ b/src/video_core/shader/decode/bfe.cpp | |||
| @@ -44,14 +44,14 @@ u32 ShaderIR::DecodeBfe(NodeBlock& bb, u32 pc) { | |||
| 44 | Node v1 = | 44 | Node v1 = |
| 45 | SignedOperation(OperationCode::ILogicalShiftRight, is_signed, op_a, Immediate(s)); | 45 | SignedOperation(OperationCode::ILogicalShiftRight, is_signed, op_a, Immediate(s)); |
| 46 | if (mask != 0) { | 46 | if (mask != 0) { |
| 47 | v1 = SignedOperation(OperationCode::IBitwiseAnd, is_signed, v1, Immediate(mask)); | 47 | v1 = SignedOperation(OperationCode::IBitwiseAnd, is_signed, std::move(v1), Immediate(mask)); |
| 48 | } | 48 | } |
| 49 | Node v2 = op_a; | 49 | Node v2 = op_a; |
| 50 | if (mask != 0) { | 50 | if (mask != 0) { |
| 51 | v2 = SignedOperation(OperationCode::IBitwiseAnd, is_signed, op_a, Immediate(mask)); | 51 | v2 = SignedOperation(OperationCode::IBitwiseAnd, is_signed, std::move(v2), Immediate(mask)); |
| 52 | } | 52 | } |
| 53 | v2 = SignedOperation(OperationCode::ILogicalShiftLeft, is_signed, v2, Immediate(s)); | 53 | v2 = SignedOperation(OperationCode::ILogicalShiftLeft, is_signed, std::move(v2), Immediate(s)); |
| 54 | return SignedOperation(OperationCode::IBitwiseOr, is_signed, v1, v2); | 54 | return SignedOperation(OperationCode::IBitwiseOr, is_signed, std::move(v1), std::move(v2)); |
| 55 | }; | 55 | }; |
| 56 | op_a = swap(1, 0x55555555U); | 56 | op_a = swap(1, 0x55555555U); |
| 57 | op_a = swap(2, 0x33333333U); | 57 | op_a = swap(2, 0x33333333U); |
| @@ -66,7 +66,7 @@ u32 ShaderIR::DecodeBfe(NodeBlock& bb, u32 pc) { | |||
| 66 | Immediate(8), Immediate(8)); | 66 | Immediate(8), Immediate(8)); |
| 67 | const auto result = | 67 | const auto result = |
| 68 | SignedOperation(OperationCode::IBitfieldExtract, is_signed, op_a, offset, bits); | 68 | SignedOperation(OperationCode::IBitfieldExtract, is_signed, op_a, offset, bits); |
| 69 | SetRegister(bb, instr.gpr0, result); | 69 | SetRegister(bb, instr.gpr0, std::move(result)); |
| 70 | 70 | ||
| 71 | return pc; | 71 | return pc; |
| 72 | } | 72 | } |