summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorGravatar Lioncash2018-10-02 19:45:09 -0400
committerGravatar Lioncash2018-10-02 19:45:12 -0400
commit226dc914b397894539f5bbee0be5f49dd996b655 (patch)
tree87a8d7817f7a3695394796553d92214a68747faf /src
parentMerge pull request #1330 from raven02/tlds (diff)
downloadyuzu-226dc914b397894539f5bbee0be5f49dd996b655.tar.gz
yuzu-226dc914b397894539f5bbee0be5f49dd996b655.tar.xz
yuzu-226dc914b397894539f5bbee0be5f49dd996b655.zip
configure_audio: Add disambiguation comment for the volume percentage string
Disambiguates what the string represents to help translators more easily understand what it is that they're translating. While we're at it, we can move the code to its own function, so that we don't need to specify the same string twice.
Diffstat (limited to 'src')
-rw-r--r--src/yuzu/configuration/configure_audio.cpp11
-rw-r--r--src/yuzu/configuration/configure_audio.h1
2 files changed, 8 insertions, 4 deletions
diff --git a/src/yuzu/configuration/configure_audio.cpp b/src/yuzu/configuration/configure_audio.cpp
index 6ea59f2a3..f11aaa172 100644
--- a/src/yuzu/configuration/configure_audio.cpp
+++ b/src/yuzu/configuration/configure_audio.cpp
@@ -21,9 +21,8 @@ ConfigureAudio::ConfigureAudio(QWidget* parent)
21 ui->output_sink_combo_box->addItem(sink_detail.id); 21 ui->output_sink_combo_box->addItem(sink_detail.id);
22 } 22 }
23 23
24 connect(ui->volume_slider, &QSlider::valueChanged, [this] { 24 connect(ui->volume_slider, &QSlider::valueChanged, this,
25 ui->volume_indicator->setText(tr("%1 %").arg(ui->volume_slider->sliderPosition())); 25 &ConfigureAudio::setVolumeIndicatorText);
26 });
27 26
28 this->setConfiguration(); 27 this->setConfiguration();
29 connect(ui->output_sink_combo_box, 28 connect(ui->output_sink_combo_box,
@@ -62,7 +61,11 @@ void ConfigureAudio::setConfiguration() {
62 ui->audio_device_combo_box->setCurrentIndex(new_device_index); 61 ui->audio_device_combo_box->setCurrentIndex(new_device_index);
63 62
64 ui->volume_slider->setValue(Settings::values.volume * ui->volume_slider->maximum()); 63 ui->volume_slider->setValue(Settings::values.volume * ui->volume_slider->maximum());
65 ui->volume_indicator->setText(tr("%1 %").arg(ui->volume_slider->sliderPosition())); 64 setVolumeIndicatorText(ui->volume_slider->sliderPosition());
65}
66
67void ConfigureAudio::setVolumeIndicatorText(int percentage) {
68 ui->volume_indicator->setText(tr("%1%", "Volume percentage (e.g. 50%)").arg(percentage));
66} 69}
67 70
68void ConfigureAudio::applyConfiguration() { 71void ConfigureAudio::applyConfiguration() {
diff --git a/src/yuzu/configuration/configure_audio.h b/src/yuzu/configuration/configure_audio.h
index 4f0af4163..069e79d56 100644
--- a/src/yuzu/configuration/configure_audio.h
+++ b/src/yuzu/configuration/configure_audio.h
@@ -26,6 +26,7 @@ public slots:
26 26
27private: 27private:
28 void setConfiguration(); 28 void setConfiguration();
29 void setVolumeIndicatorText(int percentage);
29 30
30 std::unique_ptr<Ui::ConfigureAudio> ui; 31 std::unique_ptr<Ui::ConfigureAudio> ui;
31}; 32};