summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorGravatar bunnei2018-01-23 19:52:18 -0500
committerGravatar bunnei2018-01-24 22:24:10 -0500
commit1b1d399e5f9018e7e4c5da9dfa0932eacfc392e9 (patch)
treed8c1b02cd3db313c0b26cea3e52fed3910d79aae /src
parentservice: Fix all incorrect IPC response headers. (diff)
downloadyuzu-1b1d399e5f9018e7e4c5da9dfa0932eacfc392e9.tar.gz
yuzu-1b1d399e5f9018e7e4c5da9dfa0932eacfc392e9.tar.xz
yuzu-1b1d399e5f9018e7e4c5da9dfa0932eacfc392e9.zip
hle: Rename RequestBuilder to ResponseBuilder.
Diffstat (limited to 'src')
-rw-r--r--src/core/hle/ipc_helpers.h41
-rw-r--r--src/core/hle/kernel/server_session.cpp2
-rw-r--r--src/core/hle/service/acc/acc_u0.cpp12
-rw-r--r--src/core/hle/service/am/applet_oe.cpp66
-rw-r--r--src/core/hle/service/apm/apm.cpp6
-rw-r--r--src/core/hle/service/audio/audout_u.cpp14
-rw-r--r--src/core/hle/service/filesystem/fsp_srv.cpp18
-rw-r--r--src/core/hle/service/hid/hid.cpp4
-rw-r--r--src/core/hle/service/lm/lm.cpp4
-rw-r--r--src/core/hle/service/nvdrv/interface.cpp10
-rw-r--r--src/core/hle/service/pctl/pctl_a.cpp2
-rw-r--r--src/core/hle/service/service.cpp2
-rw-r--r--src/core/hle/service/set/set.cpp2
-rw-r--r--src/core/hle/service/sm/controller.cpp6
-rw-r--r--src/core/hle/service/sm/sm.cpp6
-rw-r--r--src/core/hle/service/sockets/bsd_u.cpp8
-rw-r--r--src/core/hle/service/time/time.cpp16
-rw-r--r--src/core/hle/service/vi/vi.cpp36
-rw-r--r--src/core/hle/service/vi/vi_m.cpp2
19 files changed, 129 insertions, 128 deletions
diff --git a/src/core/hle/ipc_helpers.h b/src/core/hle/ipc_helpers.h
index aa7ffd036..8a7fa25c8 100644
--- a/src/core/hle/ipc_helpers.h
+++ b/src/core/hle/ipc_helpers.h
@@ -54,18 +54,18 @@ public:
54 } 54 }
55}; 55};
56 56
57class RequestBuilder : public RequestHelperBase { 57class ResponseBuilder : public RequestHelperBase {
58public: 58public:
59 RequestBuilder(u32* command_buffer) : RequestHelperBase(command_buffer) {} 59 ResponseBuilder(u32* command_buffer) : RequestHelperBase(command_buffer) {}
60 60
61 u32 normal_params_size; 61 u32 normal_params_size;
62 u32 num_handles_to_copy; 62 u32 num_handles_to_copy;
63 u32 num_objects_to_move; ///< Domain objects or move handles, context dependent 63 u32 num_objects_to_move; ///< Domain objects or move handles, context dependent
64 std::ptrdiff_t datapayload_index; 64 std::ptrdiff_t datapayload_index;
65 65
66 RequestBuilder(Kernel::HLERequestContext& context, u32 normal_params_size, 66 ResponseBuilder(Kernel::HLERequestContext& context, u32 normal_params_size,
67 u32 num_handles_to_copy = 0, u32 num_objects_to_move = 0, 67 u32 num_handles_to_copy = 0, u32 num_objects_to_move = 0,
68 bool always_move_handle = false) 68 bool always_move_handles = false)
69 69
70 : RequestHelperBase(context), normal_params_size(normal_params_size), 70 : RequestHelperBase(context), normal_params_size(normal_params_size),
71 num_handles_to_copy(num_handles_to_copy), num_objects_to_move(num_objects_to_move) { 71 num_handles_to_copy(num_handles_to_copy), num_objects_to_move(num_objects_to_move) {
@@ -83,7 +83,7 @@ public:
83 u32 num_handles_to_move{}; 83 u32 num_handles_to_move{};
84 u32 num_domain_objects{}; 84 u32 num_domain_objects{};
85 85
86 if (!context.Session()->IsDomain() || always_move_handle) { 86 if (!context.Session()->IsDomain() || always_move_handles) {
87 num_handles_to_move = num_objects_to_move; 87 num_handles_to_move = num_objects_to_move;
88 } else { 88 } else {
89 num_domain_objects = num_objects_to_move; 89 num_domain_objects = num_objects_to_move;
@@ -154,7 +154,7 @@ public:
154 } 154 }
155 155
156 // Validate on destruction, as there shouldn't be any case where we don't want it 156 // Validate on destruction, as there shouldn't be any case where we don't want it
157 ~RequestBuilder() { 157 ~ResponseBuilder() {
158 ValidateHeader(); 158 ValidateHeader();
159 } 159 }
160 160
@@ -182,52 +182,52 @@ public:
182/// Push /// 182/// Push ///
183 183
184template <> 184template <>
185inline void RequestBuilder::Push(u32 value) { 185inline void ResponseBuilder::Push(u32 value) {
186 cmdbuf[index++] = value; 186 cmdbuf[index++] = value;
187} 187}
188 188
189template <typename T> 189template <typename T>
190void RequestBuilder::PushRaw(const T& value) { 190void ResponseBuilder::PushRaw(const T& value) {
191 std::memcpy(cmdbuf + index, &value, sizeof(T)); 191 std::memcpy(cmdbuf + index, &value, sizeof(T));
192 index += (sizeof(T) + 3) / 4; // round up to word length 192 index += (sizeof(T) + 3) / 4; // round up to word length
193} 193}
194 194
195template <> 195template <>
196inline void RequestBuilder::Push(ResultCode value) { 196inline void ResponseBuilder::Push(ResultCode value) {
197 // Result codes are actually 64-bit in the IPC buffer, but only the high part is discarded. 197 // Result codes are actually 64-bit in the IPC buffer, but only the high part is discarded.
198 Push(value.raw); 198 Push(value.raw);
199 Push<u32>(0); 199 Push<u32>(0);
200} 200}
201 201
202template <> 202template <>
203inline void RequestBuilder::Push(u8 value) { 203inline void ResponseBuilder::Push(u8 value) {
204 PushRaw(value); 204 PushRaw(value);
205} 205}
206 206
207template <> 207template <>
208inline void RequestBuilder::Push(u16 value) { 208inline void ResponseBuilder::Push(u16 value) {
209 PushRaw(value); 209 PushRaw(value);
210} 210}
211 211
212template <> 212template <>
213inline void RequestBuilder::Push(u64 value) { 213inline void ResponseBuilder::Push(u64 value) {
214 Push(static_cast<u32>(value)); 214 Push(static_cast<u32>(value));
215 Push(static_cast<u32>(value >> 32)); 215 Push(static_cast<u32>(value >> 32));
216} 216}
217 217
218template <> 218template <>
219inline void RequestBuilder::Push(bool value) { 219inline void ResponseBuilder::Push(bool value) {
220 Push(static_cast<u8>(value)); 220 Push(static_cast<u8>(value));
221} 221}
222 222
223template <typename First, typename... Other> 223template <typename First, typename... Other>
224void RequestBuilder::Push(const First& first_value, const Other&... other_values) { 224void ResponseBuilder::Push(const First& first_value, const Other&... other_values) {
225 Push(first_value); 225 Push(first_value);
226 Push(other_values...); 226 Push(other_values...);
227} 227}
228 228
229template <typename... O> 229template <typename... O>
230inline void RequestBuilder::PushCopyObjects(Kernel::SharedPtr<O>... pointers) { 230inline void ResponseBuilder::PushCopyObjects(Kernel::SharedPtr<O>... pointers) {
231 auto objects = {pointers...}; 231 auto objects = {pointers...};
232 for (auto& object : objects) { 232 for (auto& object : objects) {
233 context->AddCopyObject(std::move(object)); 233 context->AddCopyObject(std::move(object));
@@ -235,7 +235,7 @@ inline void RequestBuilder::PushCopyObjects(Kernel::SharedPtr<O>... pointers) {
235} 235}
236 236
237template <typename... O> 237template <typename... O>
238inline void RequestBuilder::PushMoveObjects(Kernel::SharedPtr<O>... pointers) { 238inline void ResponseBuilder::PushMoveObjects(Kernel::SharedPtr<O>... pointers) {
239 auto objects = {pointers...}; 239 auto objects = {pointers...};
240 for (auto& object : objects) { 240 for (auto& object : objects) {
241 context->AddMoveObject(std::move(object)); 241 context->AddMoveObject(std::move(object));
@@ -254,9 +254,10 @@ public:
254 Skip(CommandIdSize, false); 254 Skip(CommandIdSize, false);
255 } 255 }
256 256
257 RequestBuilder MakeBuilder(u32 normal_params_size, u32 num_handles_to_copy, 257 ResponseBuilder MakeBuilder(u32 normal_params_size, u32 num_handles_to_copy,
258 u32 num_handles_to_move, bool validate_header = true) { 258 u32 num_handles_to_move, bool always_move_handles = false) {
259 return {*context, normal_params_size, num_handles_to_copy, num_handles_to_move}; 259 return {*context, normal_params_size, num_handles_to_copy, num_handles_to_move,
260 always_move_handles};
260 } 261 }
261 262
262 template <typename T> 263 template <typename T>
diff --git a/src/core/hle/kernel/server_session.cpp b/src/core/hle/kernel/server_session.cpp
index b79bf7bab..7f215d0bb 100644
--- a/src/core/hle/kernel/server_session.cpp
+++ b/src/core/hle/kernel/server_session.cpp
@@ -82,7 +82,7 @@ ResultCode ServerSession::HandleSyncRequest(SharedPtr<Thread> thread) {
82 82
83 domain_request_handlers[object_id - 1] = nullptr; 83 domain_request_handlers[object_id - 1] = nullptr;
84 84
85 IPC::RequestBuilder rb{context, 2}; 85 IPC::ResponseBuilder rb{context, 2};
86 rb.Push(RESULT_SUCCESS); 86 rb.Push(RESULT_SUCCESS);
87 return RESULT_SUCCESS; 87 return RESULT_SUCCESS;
88 } 88 }
diff --git a/src/core/hle/service/acc/acc_u0.cpp b/src/core/hle/service/acc/acc_u0.cpp
index 5b0c3bcb5..67f05aad4 100644
--- a/src/core/hle/service/acc/acc_u0.cpp
+++ b/src/core/hle/service/acc/acc_u0.cpp
@@ -22,7 +22,7 @@ private:
22 void GetBase(Kernel::HLERequestContext& ctx) { 22 void GetBase(Kernel::HLERequestContext& ctx) {
23 LOG_WARNING(Service, "(STUBBED) called"); 23 LOG_WARNING(Service, "(STUBBED) called");
24 ProfileBase profile_base{}; 24 ProfileBase profile_base{};
25 IPC::RequestBuilder rb{ctx, 16}; 25 IPC::ResponseBuilder rb{ctx, 16};
26 rb.Push(RESULT_SUCCESS); 26 rb.Push(RESULT_SUCCESS);
27 rb.PushRaw(profile_base); 27 rb.PushRaw(profile_base);
28 } 28 }
@@ -40,7 +40,7 @@ public:
40private: 40private:
41 void CheckAvailability(Kernel::HLERequestContext& ctx) { 41 void CheckAvailability(Kernel::HLERequestContext& ctx) {
42 LOG_WARNING(Service, "(STUBBED) called"); 42 LOG_WARNING(Service, "(STUBBED) called");
43 IPC::RequestBuilder rb{ctx, 3}; 43 IPC::ResponseBuilder rb{ctx, 3};
44 rb.Push(RESULT_SUCCESS); 44 rb.Push(RESULT_SUCCESS);
45 rb.Push(true); // TODO: Check when this is supposed to return true and when not 45 rb.Push(true); // TODO: Check when this is supposed to return true and when not
46 } 46 }
@@ -48,13 +48,13 @@ private:
48 48
49void ACC_U0::GetUserExistence(Kernel::HLERequestContext& ctx) { 49void ACC_U0::GetUserExistence(Kernel::HLERequestContext& ctx) {
50 LOG_WARNING(Service, "(STUBBED) called"); 50 LOG_WARNING(Service, "(STUBBED) called");
51 IPC::RequestBuilder rb{ctx, 3}; 51 IPC::ResponseBuilder rb{ctx, 3};
52 rb.Push(RESULT_SUCCESS); 52 rb.Push(RESULT_SUCCESS);
53 rb.Push(true); // TODO: Check when this is supposed to return true and when not 53 rb.Push(true); // TODO: Check when this is supposed to return true and when not
54} 54}
55 55
56void ACC_U0::GetProfile(Kernel::HLERequestContext& ctx) { 56void ACC_U0::GetProfile(Kernel::HLERequestContext& ctx) {
57 IPC::RequestBuilder rb{ctx, 2, 0, 1}; 57 IPC::ResponseBuilder rb{ctx, 2, 0, 1};
58 rb.Push(RESULT_SUCCESS); 58 rb.Push(RESULT_SUCCESS);
59 rb.PushIpcInterface<IProfile>(); 59 rb.PushIpcInterface<IProfile>();
60 LOG_DEBUG(Service, "called"); 60 LOG_DEBUG(Service, "called");
@@ -62,12 +62,12 @@ void ACC_U0::GetProfile(Kernel::HLERequestContext& ctx) {
62 62
63void ACC_U0::InitializeApplicationInfo(Kernel::HLERequestContext& ctx) { 63void ACC_U0::InitializeApplicationInfo(Kernel::HLERequestContext& ctx) {
64 LOG_WARNING(Service, "(STUBBED) called"); 64 LOG_WARNING(Service, "(STUBBED) called");
65 IPC::RequestBuilder rb{ctx, 2}; 65 IPC::ResponseBuilder rb{ctx, 2};
66 rb.Push(RESULT_SUCCESS); 66 rb.Push(RESULT_SUCCESS);
67} 67}
68 68
69void ACC_U0::GetBaasAccountManagerForApplication(Kernel::HLERequestContext& ctx) { 69void ACC_U0::GetBaasAccountManagerForApplication(Kernel::HLERequestContext& ctx) {
70 IPC::RequestBuilder rb{ctx, 2, 0, 1}; 70 IPC::ResponseBuilder rb{ctx, 2, 0, 1};
71 rb.Push(RESULT_SUCCESS); 71 rb.Push(RESULT_SUCCESS);
72 rb.PushIpcInterface<IManagerForApplication>(); 72 rb.PushIpcInterface<IManagerForApplication>();
73 LOG_DEBUG(Service, "called"); 73 LOG_DEBUG(Service, "called");
diff --git a/src/core/hle/service/am/applet_oe.cpp b/src/core/hle/service/am/applet_oe.cpp
index 3e15e4970..15b7701e0 100644
--- a/src/core/hle/service/am/applet_oe.cpp
+++ b/src/core/hle/service/am/applet_oe.cpp
@@ -25,14 +25,14 @@ public:
25private: 25private:
26 void GetAppletResourceUserId(Kernel::HLERequestContext& ctx) { 26 void GetAppletResourceUserId(Kernel::HLERequestContext& ctx) {
27 LOG_WARNING(Service, "(STUBBED) called"); 27 LOG_WARNING(Service, "(STUBBED) called");
28 IPC::RequestBuilder rb{ctx, 4}; 28 IPC::ResponseBuilder rb{ctx, 4};
29 rb.Push(RESULT_SUCCESS); 29 rb.Push(RESULT_SUCCESS);
30 rb.Push<u64>(0); 30 rb.Push<u64>(0);
31 } 31 }
32 32
33 void AcquireForegroundRights(Kernel::HLERequestContext& ctx) { 33 void AcquireForegroundRights(Kernel::HLERequestContext& ctx) {
34 LOG_WARNING(Service, "(STUBBED) called"); 34 LOG_WARNING(Service, "(STUBBED) called");
35 IPC::RequestBuilder rb{ctx, 2}; 35 IPC::ResponseBuilder rb{ctx, 2};
36 rb.Push(RESULT_SUCCESS); 36 rb.Push(RESULT_SUCCESS);
37 } 37 }
38}; 38};
@@ -86,14 +86,14 @@ private:
86 }; 86 };
87 auto flags = rp.PopRaw<FocusHandlingModeParams>(); 87 auto flags = rp.PopRaw<FocusHandlingModeParams>();
88 88
89 IPC::RequestBuilder rb{ctx, 2}; 89 IPC::ResponseBuilder rb{ctx, 2};
90 rb.Push(RESULT_SUCCESS); 90 rb.Push(RESULT_SUCCESS);
91 91
92 LOG_WARNING(Service, "(STUBBED) called"); 92 LOG_WARNING(Service, "(STUBBED) called");
93 } 93 }
94 94
95 void SetRestartMessageEnabled(Kernel::HLERequestContext& ctx) { 95 void SetRestartMessageEnabled(Kernel::HLERequestContext& ctx) {
96 IPC::RequestBuilder rb{ctx, 2}; 96 IPC::ResponseBuilder rb{ctx, 2};
97 rb.Push(RESULT_SUCCESS); 97 rb.Push(RESULT_SUCCESS);
98 98
99 LOG_WARNING(Service, "(STUBBED) called"); 99 LOG_WARNING(Service, "(STUBBED) called");
@@ -104,7 +104,7 @@ private:
104 104
105 bool flag = rp.Pop<bool>(); 105 bool flag = rp.Pop<bool>();
106 106
107 IPC::RequestBuilder rb{ctx, 2}; 107 IPC::ResponseBuilder rb{ctx, 2};
108 rb.Push(RESULT_SUCCESS); 108 rb.Push(RESULT_SUCCESS);
109 109
110 LOG_WARNING(Service, "(STUBBED) called flag=%u", static_cast<u32>(flag)); 110 LOG_WARNING(Service, "(STUBBED) called flag=%u", static_cast<u32>(flag));
@@ -115,7 +115,7 @@ private:
115 115
116 bool flag = rp.Pop<bool>(); 116 bool flag = rp.Pop<bool>();
117 117
118 IPC::RequestBuilder rb{ctx, 2}; 118 IPC::ResponseBuilder rb{ctx, 2};
119 rb.Push(RESULT_SUCCESS); 119 rb.Push(RESULT_SUCCESS);
120 120
121 LOG_WARNING(Service, "(STUBBED) called flag=%u", static_cast<u32>(flag)); 121 LOG_WARNING(Service, "(STUBBED) called flag=%u", static_cast<u32>(flag));
@@ -128,21 +128,21 @@ private:
128 128
129 bool enabled = rp.Pop<bool>(); 129 bool enabled = rp.Pop<bool>();
130 130
131 IPC::RequestBuilder rb{ctx, 2}; 131 IPC::ResponseBuilder rb{ctx, 2};
132 rb.Push(RESULT_SUCCESS); 132 rb.Push(RESULT_SUCCESS);
133 133
134 LOG_WARNING(Service, "(STUBBED) called enabled=%u", static_cast<u32>(enabled)); 134 LOG_WARNING(Service, "(STUBBED) called enabled=%u", static_cast<u32>(enabled));
135 } 135 }
136 136
137 void LockExit(Kernel::HLERequestContext& ctx) { 137 void LockExit(Kernel::HLERequestContext& ctx) {
138 IPC::RequestBuilder rb{ctx, 2}; 138 IPC::ResponseBuilder rb{ctx, 2};
139 rb.Push(RESULT_SUCCESS); 139 rb.Push(RESULT_SUCCESS);
140 140
141 LOG_WARNING(Service, "(STUBBED) called"); 141 LOG_WARNING(Service, "(STUBBED) called");
142 } 142 }
143 143
144 void UnlockExit(Kernel::HLERequestContext& ctx) { 144 void UnlockExit(Kernel::HLERequestContext& ctx) {
145 IPC::RequestBuilder rb{ctx, 2}; 145 IPC::ResponseBuilder rb{ctx, 2};
146 rb.Push(RESULT_SUCCESS); 146 rb.Push(RESULT_SUCCESS);
147 147
148 LOG_WARNING(Service, "(STUBBED) called"); 148 LOG_WARNING(Service, "(STUBBED) called");
@@ -154,7 +154,7 @@ private:
154 u64 display_id = nvflinger->OpenDisplay("Default"); 154 u64 display_id = nvflinger->OpenDisplay("Default");
155 u64 layer_id = nvflinger->CreateLayer(display_id); 155 u64 layer_id = nvflinger->CreateLayer(display_id);
156 156
157 IPC::RequestBuilder rb{ctx, 4}; 157 IPC::ResponseBuilder rb{ctx, 4};
158 rb.Push(RESULT_SUCCESS); 158 rb.Push(RESULT_SUCCESS);
159 rb.Push(layer_id); 159 rb.Push(layer_id);
160 160
@@ -193,7 +193,7 @@ private:
193 void GetEventHandle(Kernel::HLERequestContext& ctx) { 193 void GetEventHandle(Kernel::HLERequestContext& ctx) {
194 event->Signal(); 194 event->Signal();
195 195
196 IPC::RequestBuilder rb{ctx, 2, 1}; 196 IPC::ResponseBuilder rb{ctx, 2, 1};
197 rb.Push(RESULT_SUCCESS); 197 rb.Push(RESULT_SUCCESS);
198 rb.PushCopyObjects(event); 198 rb.PushCopyObjects(event);
199 199
@@ -201,7 +201,7 @@ private:
201 } 201 }
202 202
203 void ReceiveMessage(Kernel::HLERequestContext& ctx) { 203 void ReceiveMessage(Kernel::HLERequestContext& ctx) {
204 IPC::RequestBuilder rb{ctx, 3}; 204 IPC::ResponseBuilder rb{ctx, 3};
205 rb.Push(RESULT_SUCCESS); 205 rb.Push(RESULT_SUCCESS);
206 rb.Push<u32>(15); 206 rb.Push<u32>(15);
207 207
@@ -209,7 +209,7 @@ private:
209 } 209 }
210 210
211 void GetCurrentFocusState(Kernel::HLERequestContext& ctx) { 211 void GetCurrentFocusState(Kernel::HLERequestContext& ctx) {
212 IPC::RequestBuilder rb{ctx, 3}; 212 IPC::ResponseBuilder rb{ctx, 3};
213 rb.Push(RESULT_SUCCESS); 213 rb.Push(RESULT_SUCCESS);
214 rb.Push(static_cast<u8>(FocusState::InFocus)); 214 rb.Push(static_cast<u8>(FocusState::InFocus));
215 215
@@ -217,7 +217,7 @@ private:
217 } 217 }
218 218
219 void GetOperationMode(Kernel::HLERequestContext& ctx) { 219 void GetOperationMode(Kernel::HLERequestContext& ctx) {
220 IPC::RequestBuilder rb{ctx, 3}; 220 IPC::ResponseBuilder rb{ctx, 3};
221 rb.Push(RESULT_SUCCESS); 221 rb.Push(RESULT_SUCCESS);
222 rb.Push(static_cast<u8>(OperationMode::Handheld)); 222 rb.Push(static_cast<u8>(OperationMode::Handheld));
223 223
@@ -225,7 +225,7 @@ private:
225 } 225 }
226 226
227 void GetPerformanceMode(Kernel::HLERequestContext& ctx) { 227 void GetPerformanceMode(Kernel::HLERequestContext& ctx) {
228 IPC::RequestBuilder rb{ctx, 3}; 228 IPC::ResponseBuilder rb{ctx, 3};
229 rb.Push(RESULT_SUCCESS); 229 rb.Push(RESULT_SUCCESS);
230 rb.Push(static_cast<u32>(APM::PerformanceMode::Handheld)); 230 rb.Push(static_cast<u32>(APM::PerformanceMode::Handheld));
231 231
@@ -250,7 +250,7 @@ private:
250 std::vector<u8> buffer; 250 std::vector<u8> buffer;
251 251
252 void GetSize(Kernel::HLERequestContext& ctx) { 252 void GetSize(Kernel::HLERequestContext& ctx) {
253 IPC::RequestBuilder rb{ctx, 4}; 253 IPC::ResponseBuilder rb{ctx, 4};
254 254
255 rb.Push(RESULT_SUCCESS); 255 rb.Push(RESULT_SUCCESS);
256 rb.Push(static_cast<u64>(buffer.size())); 256 rb.Push(static_cast<u64>(buffer.size()));
@@ -269,7 +269,7 @@ private:
269 269
270 Memory::WriteBlock(output_buffer.Address(), buffer.data() + offset, output_buffer.Size()); 270 Memory::WriteBlock(output_buffer.Address(), buffer.data() + offset, output_buffer.Size());
271 271
272 IPC::RequestBuilder rb{ctx, 2}; 272 IPC::ResponseBuilder rb{ctx, 2};
273 273
274 rb.Push(RESULT_SUCCESS); 274 rb.Push(RESULT_SUCCESS);
275 275
@@ -291,7 +291,7 @@ private:
291 std::vector<u8> buffer; 291 std::vector<u8> buffer;
292 292
293 void Open(Kernel::HLERequestContext& ctx) { 293 void Open(Kernel::HLERequestContext& ctx) {
294 IPC::RequestBuilder rb{ctx, 2, 0, 1}; 294 IPC::ResponseBuilder rb{ctx, 2, 0, 1};
295 295
296 rb.Push(RESULT_SUCCESS); 296 rb.Push(RESULT_SUCCESS);
297 rb.PushIpcInterface<AM::IStorageAccessor>(buffer); 297 rb.PushIpcInterface<AM::IStorageAccessor>(buffer);
@@ -328,7 +328,7 @@ private:
328 328
329 std::vector<u8> buffer(data, data + sizeof(data)); 329 std::vector<u8> buffer(data, data + sizeof(data));
330 330
331 IPC::RequestBuilder rb{ctx, 2, 0, 1}; 331 IPC::ResponseBuilder rb{ctx, 2, 0, 1};
332 332
333 rb.Push(RESULT_SUCCESS); 333 rb.Push(RESULT_SUCCESS);
334 rb.PushIpcInterface<AM::IStorage>(buffer); 334 rb.PushIpcInterface<AM::IStorage>(buffer);
@@ -343,34 +343,34 @@ private:
343 IPC::RequestParser rp{ctx}; 343 IPC::RequestParser rp{ctx};
344 u32 result = rp.Pop<u32>(); 344 u32 result = rp.Pop<u32>();
345 345
346 IPC::RequestBuilder rb{ctx, 2}; 346 IPC::ResponseBuilder rb{ctx, 2};
347 rb.Push(RESULT_SUCCESS); 347 rb.Push(RESULT_SUCCESS);
348 348
349 LOG_WARNING(Service, "(STUBBED) called, result=0x%08X", result); 349 LOG_WARNING(Service, "(STUBBED) called, result=0x%08X", result);
350 } 350 }
351 351
352 void GetDesiredLanguage(Kernel::HLERequestContext& ctx) { 352 void GetDesiredLanguage(Kernel::HLERequestContext& ctx) {
353 IPC::RequestBuilder rb{ctx, 4}; 353 IPC::ResponseBuilder rb{ctx, 4};
354 rb.Push(RESULT_SUCCESS); 354 rb.Push(RESULT_SUCCESS);
355 rb.Push<u64>(SystemLanguage::English); 355 rb.Push<u64>(SystemLanguage::English);
356 LOG_WARNING(Service, "(STUBBED) called"); 356 LOG_WARNING(Service, "(STUBBED) called");
357 } 357 }
358 358
359 void InitializeGamePlayRecording(Kernel::HLERequestContext& ctx) { 359 void InitializeGamePlayRecording(Kernel::HLERequestContext& ctx) {
360 IPC::RequestBuilder rb{ctx, 2}; 360 IPC::ResponseBuilder rb{ctx, 2};
361 rb.Push(RESULT_SUCCESS); 361 rb.Push(RESULT_SUCCESS);
362 LOG_WARNING(Service, "(STUBBED) called"); 362 LOG_WARNING(Service, "(STUBBED) called");
363 } 363 }
364 364
365 void SetGamePlayRecordingState(Kernel::HLERequestContext& ctx) { 365 void SetGamePlayRecordingState(Kernel::HLERequestContext& ctx) {
366 IPC::RequestBuilder rb{ctx, 2}; 366 IPC::ResponseBuilder rb{ctx, 2};
367 rb.Push(RESULT_SUCCESS); 367 rb.Push(RESULT_SUCCESS);
368 368
369 LOG_WARNING(Service, "(STUBBED) called"); 369 LOG_WARNING(Service, "(STUBBED) called");
370 } 370 }
371 371
372 void NotifyRunning(Kernel::HLERequestContext& ctx) { 372 void NotifyRunning(Kernel::HLERequestContext& ctx) {
373 IPC::RequestBuilder rb{ctx, 3}; 373 IPC::ResponseBuilder rb{ctx, 3};
374 rb.Push(RESULT_SUCCESS); 374 rb.Push(RESULT_SUCCESS);
375 rb.Push<u8>(0); // Unknown, seems to be ignored by official processes 375 rb.Push<u8>(0); // Unknown, seems to be ignored by official processes
376 376
@@ -402,56 +402,56 @@ public:
402 402
403private: 403private:
404 void GetAudioController(Kernel::HLERequestContext& ctx) { 404 void GetAudioController(Kernel::HLERequestContext& ctx) {
405 IPC::RequestBuilder rb{ctx, 2, 0, 1}; 405 IPC::ResponseBuilder rb{ctx, 2, 0, 1};
406 rb.Push(RESULT_SUCCESS); 406 rb.Push(RESULT_SUCCESS);
407 rb.PushIpcInterface<IAudioController>(); 407 rb.PushIpcInterface<IAudioController>();
408 LOG_DEBUG(Service, "called"); 408 LOG_DEBUG(Service, "called");
409 } 409 }
410 410
411 void GetDisplayController(Kernel::HLERequestContext& ctx) { 411 void GetDisplayController(Kernel::HLERequestContext& ctx) {
412 IPC::RequestBuilder rb{ctx, 2, 0, 1}; 412 IPC::ResponseBuilder rb{ctx, 2, 0, 1};
413 rb.Push(RESULT_SUCCESS); 413 rb.Push(RESULT_SUCCESS);
414 rb.PushIpcInterface<IDisplayController>(); 414 rb.PushIpcInterface<IDisplayController>();
415 LOG_DEBUG(Service, "called"); 415 LOG_DEBUG(Service, "called");
416 } 416 }
417 417
418 void GetDebugFunctions(Kernel::HLERequestContext& ctx) { 418 void GetDebugFunctions(Kernel::HLERequestContext& ctx) {
419 IPC::RequestBuilder rb{ctx, 2, 0, 1}; 419 IPC::ResponseBuilder rb{ctx, 2, 0, 1};
420 rb.Push(RESULT_SUCCESS); 420 rb.Push(RESULT_SUCCESS);
421 rb.PushIpcInterface<IDebugFunctions>(); 421 rb.PushIpcInterface<IDebugFunctions>();
422 LOG_DEBUG(Service, "called"); 422 LOG_DEBUG(Service, "called");
423 } 423 }
424 424
425 void GetWindowController(Kernel::HLERequestContext& ctx) { 425 void GetWindowController(Kernel::HLERequestContext& ctx) {
426 IPC::RequestBuilder rb{ctx, 2, 0, 1}; 426 IPC::ResponseBuilder rb{ctx, 2, 0, 1};
427 rb.Push(RESULT_SUCCESS); 427 rb.Push(RESULT_SUCCESS);
428 rb.PushIpcInterface<IWindowController>(); 428 rb.PushIpcInterface<IWindowController>();
429 LOG_DEBUG(Service, "called"); 429 LOG_DEBUG(Service, "called");
430 } 430 }
431 431
432 void GetSelfController(Kernel::HLERequestContext& ctx) { 432 void GetSelfController(Kernel::HLERequestContext& ctx) {
433 IPC::RequestBuilder rb{ctx, 2, 0, 1}; 433 IPC::ResponseBuilder rb{ctx, 2, 0, 1};
434 rb.Push(RESULT_SUCCESS); 434 rb.Push(RESULT_SUCCESS);
435 rb.PushIpcInterface<ISelfController>(nvflinger); 435 rb.PushIpcInterface<ISelfController>(nvflinger);
436 LOG_DEBUG(Service, "called"); 436 LOG_DEBUG(Service, "called");
437 } 437 }
438 438
439 void GetCommonStateGetter(Kernel::HLERequestContext& ctx) { 439 void GetCommonStateGetter(Kernel::HLERequestContext& ctx) {
440 IPC::RequestBuilder rb{ctx, 2, 0, 1}; 440 IPC::ResponseBuilder rb{ctx, 2, 0, 1};
441 rb.Push(RESULT_SUCCESS); 441 rb.Push(RESULT_SUCCESS);
442 rb.PushIpcInterface<ICommonStateGetter>(); 442 rb.PushIpcInterface<ICommonStateGetter>();
443 LOG_DEBUG(Service, "called"); 443 LOG_DEBUG(Service, "called");
444 } 444 }
445 445
446 void GetLibraryAppletCreator(Kernel::HLERequestContext& ctx) { 446 void GetLibraryAppletCreator(Kernel::HLERequestContext& ctx) {
447 IPC::RequestBuilder rb{ctx, 2, 0, 1}; 447 IPC::ResponseBuilder rb{ctx, 2, 0, 1};
448 rb.Push(RESULT_SUCCESS); 448 rb.Push(RESULT_SUCCESS);
449 rb.PushIpcInterface<ILibraryAppletCreator>(); 449 rb.PushIpcInterface<ILibraryAppletCreator>();
450 LOG_DEBUG(Service, "called"); 450 LOG_DEBUG(Service, "called");
451 } 451 }
452 452
453 void GetApplicationFunctions(Kernel::HLERequestContext& ctx) { 453 void GetApplicationFunctions(Kernel::HLERequestContext& ctx) {
454 IPC::RequestBuilder rb{ctx, 2, 0, 1}; 454 IPC::ResponseBuilder rb{ctx, 2, 0, 1};
455 rb.Push(RESULT_SUCCESS); 455 rb.Push(RESULT_SUCCESS);
456 rb.PushIpcInterface<IApplicationFunctions>(); 456 rb.PushIpcInterface<IApplicationFunctions>();
457 LOG_DEBUG(Service, "called"); 457 LOG_DEBUG(Service, "called");
@@ -461,7 +461,7 @@ private:
461}; 461};
462 462
463void AppletOE::OpenApplicationProxy(Kernel::HLERequestContext& ctx) { 463void AppletOE::OpenApplicationProxy(Kernel::HLERequestContext& ctx) {
464 IPC::RequestBuilder rb{ctx, 2, 0, 1}; 464 IPC::ResponseBuilder rb{ctx, 2, 0, 1};
465 rb.Push(RESULT_SUCCESS); 465 rb.Push(RESULT_SUCCESS);
466 rb.PushIpcInterface<IApplicationProxy>(nvflinger); 466 rb.PushIpcInterface<IApplicationProxy>(nvflinger);
467 LOG_DEBUG(Service, "called"); 467 LOG_DEBUG(Service, "called");
diff --git a/src/core/hle/service/apm/apm.cpp b/src/core/hle/service/apm/apm.cpp
index a005db8a4..c4b1723c5 100644
--- a/src/core/hle/service/apm/apm.cpp
+++ b/src/core/hle/service/apm/apm.cpp
@@ -30,7 +30,7 @@ private:
30 auto mode = static_cast<PerformanceMode>(rp.Pop<u32>()); 30 auto mode = static_cast<PerformanceMode>(rp.Pop<u32>());
31 u32 config = rp.Pop<u32>(); 31 u32 config = rp.Pop<u32>();
32 32
33 IPC::RequestBuilder rb{ctx, 2}; 33 IPC::ResponseBuilder rb{ctx, 2};
34 rb.Push(RESULT_SUCCESS); 34 rb.Push(RESULT_SUCCESS);
35 35
36 LOG_WARNING(Service, "(STUBBED) called mode=%u config=%u", static_cast<u32>(mode), config); 36 LOG_WARNING(Service, "(STUBBED) called mode=%u config=%u", static_cast<u32>(mode), config);
@@ -41,7 +41,7 @@ private:
41 41
42 auto mode = static_cast<PerformanceMode>(rp.Pop<u32>()); 42 auto mode = static_cast<PerformanceMode>(rp.Pop<u32>());
43 43
44 IPC::RequestBuilder rb{ctx, 3}; 44 IPC::ResponseBuilder rb{ctx, 3};
45 rb.Push(RESULT_SUCCESS); 45 rb.Push(RESULT_SUCCESS);
46 rb.Push<u32>(0); // Performance configuration 46 rb.Push<u32>(0); // Performance configuration
47 47
@@ -58,7 +58,7 @@ APM::APM() : ServiceFramework("apm") {
58} 58}
59 59
60void APM::OpenSession(Kernel::HLERequestContext& ctx) { 60void APM::OpenSession(Kernel::HLERequestContext& ctx) {
61 IPC::RequestBuilder rb{ctx, 2, 0, 1}; 61 IPC::ResponseBuilder rb{ctx, 2, 0, 1};
62 rb.Push(RESULT_SUCCESS); 62 rb.Push(RESULT_SUCCESS);
63 rb.PushIpcInterface<ISession>(); 63 rb.PushIpcInterface<ISession>();
64} 64}
diff --git a/src/core/hle/service/audio/audout_u.cpp b/src/core/hle/service/audio/audout_u.cpp
index 265c8e03c..3a0f8f362 100644
--- a/src/core/hle/service/audio/audout_u.cpp
+++ b/src/core/hle/service/audio/audout_u.cpp
@@ -61,7 +61,7 @@ private:
61 // start audio 61 // start audio
62 audio_out_state = Started; 62 audio_out_state = Started;
63 63
64 IPC::RequestBuilder rb{ctx, 2}; 64 IPC::ResponseBuilder rb{ctx, 2};
65 rb.Push(RESULT_SUCCESS); 65 rb.Push(RESULT_SUCCESS);
66 } 66 }
67 67
@@ -73,14 +73,14 @@ private:
73 73
74 queue_keys.clear(); 74 queue_keys.clear();
75 75
76 IPC::RequestBuilder rb{ctx, 2}; 76 IPC::ResponseBuilder rb{ctx, 2};
77 rb.Push(RESULT_SUCCESS); 77 rb.Push(RESULT_SUCCESS);
78 } 78 }
79 79
80 void RegisterBufferEvent(Kernel::HLERequestContext& ctx) { 80 void RegisterBufferEvent(Kernel::HLERequestContext& ctx) {
81 LOG_WARNING(Service_Audio, "(STUBBED) called"); 81 LOG_WARNING(Service_Audio, "(STUBBED) called");
82 82
83 IPC::RequestBuilder rb{ctx, 2, 1}; 83 IPC::ResponseBuilder rb{ctx, 2, 1};
84 rb.Push(RESULT_SUCCESS); 84 rb.Push(RESULT_SUCCESS);
85 rb.PushCopyObjects(buffer_event); 85 rb.PushCopyObjects(buffer_event);
86 } 86 }
@@ -93,7 +93,7 @@ private:
93 93
94 queue_keys.insert(queue_keys.begin(), key); 94 queue_keys.insert(queue_keys.begin(), key);
95 95
96 IPC::RequestBuilder rb{ctx, 2}; 96 IPC::ResponseBuilder rb{ctx, 2};
97 rb.Push(RESULT_SUCCESS); 97 rb.Push(RESULT_SUCCESS);
98 } 98 }
99 99
@@ -116,7 +116,7 @@ private:
116 116
117 Memory::WriteBlock(buffer.Address(), &key, sizeof(u64)); 117 Memory::WriteBlock(buffer.Address(), &key, sizeof(u64));
118 118
119 IPC::RequestBuilder rb{ctx, 3}; 119 IPC::ResponseBuilder rb{ctx, 3};
120 rb.Push(RESULT_SUCCESS); 120 rb.Push(RESULT_SUCCESS);
121 // TODO(st4rk): This might be the total of released buffers, needs to be verified on 121 // TODO(st4rk): This might be the total of released buffers, needs to be verified on
122 // hardware 122 // hardware
@@ -166,7 +166,7 @@ void AudOutU::ListAudioOuts(Kernel::HLERequestContext& ctx) {
166 166
167 Memory::WriteBlock(buffer.Address(), &audio_interface[0], audio_interface.size()); 167 Memory::WriteBlock(buffer.Address(), &audio_interface[0], audio_interface.size());
168 168
169 IPC::RequestBuilder rb = rp.MakeBuilder(3, 0, 0); 169 IPC::ResponseBuilder rb = rp.MakeBuilder(3, 0, 0);
170 170
171 rb.Push(RESULT_SUCCESS); 171 rb.Push(RESULT_SUCCESS);
172 // TODO(st4rk): we're currently returning only one audio interface 172 // TODO(st4rk): we're currently returning only one audio interface
@@ -189,7 +189,7 @@ void AudOutU::OpenAudioOut(Kernel::HLERequestContext& ctx) {
189 auto client = std::get<Kernel::SharedPtr<Kernel::ClientSession>>(sessions); 189 auto client = std::get<Kernel::SharedPtr<Kernel::ClientSession>>(sessions);
190 audio_out_interface->ClientConnected(server); 190 audio_out_interface->ClientConnected(server);
191 LOG_DEBUG(Service, "called, initialized IAudioOut -> session=%u", client->GetObjectId()); 191 LOG_DEBUG(Service, "called, initialized IAudioOut -> session=%u", client->GetObjectId());
192 IPC::RequestBuilder rb{ctx, 6, 0, 1}; 192 IPC::ResponseBuilder rb{ctx, 6, 0, 1};
193 193
194 rb.Push(RESULT_SUCCESS); 194 rb.Push(RESULT_SUCCESS);
195 rb.Push<u32>(sample_rate); 195 rb.Push<u32>(sample_rate);
diff --git a/src/core/hle/service/filesystem/fsp_srv.cpp b/src/core/hle/service/filesystem/fsp_srv.cpp
index c6b20199b..71b82393e 100644
--- a/src/core/hle/service/filesystem/fsp_srv.cpp
+++ b/src/core/hle/service/filesystem/fsp_srv.cpp
@@ -40,12 +40,12 @@ private:
40 // Error checking 40 // Error checking
41 ASSERT_MSG(length == descriptor.Size(), "unexpected size difference"); 41 ASSERT_MSG(length == descriptor.Size(), "unexpected size difference");
42 if (length < 0) { 42 if (length < 0) {
43 IPC::RequestBuilder rb{ctx, 2}; 43 IPC::ResponseBuilder rb{ctx, 2};
44 rb.Push(ResultCode(ErrorModule::FS, ErrorDescription::InvalidLength)); 44 rb.Push(ResultCode(ErrorModule::FS, ErrorDescription::InvalidLength));
45 return; 45 return;
46 } 46 }
47 if (offset < 0) { 47 if (offset < 0) {
48 IPC::RequestBuilder rb{ctx, 2}; 48 IPC::ResponseBuilder rb{ctx, 2};
49 rb.Push(ResultCode(ErrorModule::FS, ErrorDescription::InvalidOffset)); 49 rb.Push(ResultCode(ErrorModule::FS, ErrorDescription::InvalidOffset));
50 return; 50 return;
51 } 51 }
@@ -54,7 +54,7 @@ private:
54 std::vector<u8> output(length); 54 std::vector<u8> output(length);
55 ResultVal<size_t> res = backend->Read(offset, length, output.data()); 55 ResultVal<size_t> res = backend->Read(offset, length, output.data());
56 if (res.Failed()) { 56 if (res.Failed()) {
57 IPC::RequestBuilder rb{ctx, 2}; 57 IPC::ResponseBuilder rb{ctx, 2};
58 rb.Push(res.Code()); 58 rb.Push(res.Code());
59 return; 59 return;
60 } 60 }
@@ -62,7 +62,7 @@ private:
62 // Write the data to memory 62 // Write the data to memory
63 Memory::WriteBlock(descriptor.Address(), output.data(), descriptor.Size()); 63 Memory::WriteBlock(descriptor.Address(), output.data(), descriptor.Size());
64 64
65 IPC::RequestBuilder rb{ctx, 2}; 65 IPC::ResponseBuilder rb{ctx, 2};
66 rb.Push(RESULT_SUCCESS); 66 rb.Push(RESULT_SUCCESS);
67 } 67 }
68}; 68};
@@ -91,14 +91,14 @@ void FSP_SRV::TryLoadRomFS() {
91void FSP_SRV::Initalize(Kernel::HLERequestContext& ctx) { 91void FSP_SRV::Initalize(Kernel::HLERequestContext& ctx) {
92 LOG_WARNING(Service_FS, "(STUBBED) called"); 92 LOG_WARNING(Service_FS, "(STUBBED) called");
93 93
94 IPC::RequestBuilder rb{ctx, 2}; 94 IPC::ResponseBuilder rb{ctx, 2};
95 rb.Push(RESULT_SUCCESS); 95 rb.Push(RESULT_SUCCESS);
96} 96}
97 97
98void FSP_SRV::GetGlobalAccessLogMode(Kernel::HLERequestContext& ctx) { 98void FSP_SRV::GetGlobalAccessLogMode(Kernel::HLERequestContext& ctx) {
99 LOG_WARNING(Service_FS, "(STUBBED) called"); 99 LOG_WARNING(Service_FS, "(STUBBED) called");
100 100
101 IPC::RequestBuilder rb{ctx, 3}; 101 IPC::ResponseBuilder rb{ctx, 3};
102 rb.Push(RESULT_SUCCESS); 102 rb.Push(RESULT_SUCCESS);
103 rb.Push<u32>(5); 103 rb.Push<u32>(5);
104} 104}
@@ -110,7 +110,7 @@ void FSP_SRV::OpenDataStorageByCurrentProcess(Kernel::HLERequestContext& ctx) {
110 if (!romfs) { 110 if (!romfs) {
111 // TODO (bunnei): Find the right error code to use here 111 // TODO (bunnei): Find the right error code to use here
112 LOG_CRITICAL(Service_FS, "no file system interface available!"); 112 LOG_CRITICAL(Service_FS, "no file system interface available!");
113 IPC::RequestBuilder rb{ctx, 2}; 113 IPC::ResponseBuilder rb{ctx, 2};
114 rb.Push(ResultCode(-1)); 114 rb.Push(ResultCode(-1));
115 return; 115 return;
116 } 116 }
@@ -119,12 +119,12 @@ void FSP_SRV::OpenDataStorageByCurrentProcess(Kernel::HLERequestContext& ctx) {
119 auto storage = romfs->OpenFile({}, {}); 119 auto storage = romfs->OpenFile({}, {});
120 if (storage.Failed()) { 120 if (storage.Failed()) {
121 LOG_CRITICAL(Service_FS, "no storage interface available!"); 121 LOG_CRITICAL(Service_FS, "no storage interface available!");
122 IPC::RequestBuilder rb{ctx, 2}; 122 IPC::ResponseBuilder rb{ctx, 2};
123 rb.Push(storage.Code()); 123 rb.Push(storage.Code());
124 return; 124 return;
125 } 125 }
126 126
127 IPC::RequestBuilder rb{ctx, 2, 0, 1}; 127 IPC::ResponseBuilder rb{ctx, 2, 0, 1};
128 rb.Push(RESULT_SUCCESS); 128 rb.Push(RESULT_SUCCESS);
129 rb.PushIpcInterface<IStorage>(std::move(storage.Unwrap())); 129 rb.PushIpcInterface<IStorage>(std::move(storage.Unwrap()));
130} 130}
diff --git a/src/core/hle/service/hid/hid.cpp b/src/core/hle/service/hid/hid.cpp
index 4949fa1c9..326e0a4ab 100644
--- a/src/core/hle/service/hid/hid.cpp
+++ b/src/core/hle/service/hid/hid.cpp
@@ -46,7 +46,7 @@ public:
46 46
47private: 47private:
48 void GetSharedMemoryHandle(Kernel::HLERequestContext& ctx) { 48 void GetSharedMemoryHandle(Kernel::HLERequestContext& ctx) {
49 IPC::RequestBuilder rb{ctx, 2, 1}; 49 IPC::ResponseBuilder rb{ctx, 2, 1};
50 rb.Push(RESULT_SUCCESS); 50 rb.Push(RESULT_SUCCESS);
51 rb.PushCopyObjects(shared_mem); 51 rb.PushCopyObjects(shared_mem);
52 LOG_DEBUG(Service, "called"); 52 LOG_DEBUG(Service, "called");
@@ -169,7 +169,7 @@ private:
169 applet_resource = std::make_shared<IAppletResource>(); 169 applet_resource = std::make_shared<IAppletResource>();
170 } 170 }
171 171
172 IPC::RequestBuilder rb{ctx, 2, 0, 1}; 172 IPC::ResponseBuilder rb{ctx, 2, 0, 1};
173 rb.Push(RESULT_SUCCESS); 173 rb.Push(RESULT_SUCCESS);
174 rb.PushIpcInterface<IAppletResource>(applet_resource); 174 rb.PushIpcInterface<IAppletResource>(applet_resource);
175 LOG_DEBUG(Service, "called"); 175 LOG_DEBUG(Service, "called");
diff --git a/src/core/hle/service/lm/lm.cpp b/src/core/hle/service/lm/lm.cpp
index d5dcc8eaf..2843e0e40 100644
--- a/src/core/hle/service/lm/lm.cpp
+++ b/src/core/hle/service/lm/lm.cpp
@@ -65,7 +65,7 @@ private:
65 */ 65 */
66 void Log(Kernel::HLERequestContext& ctx) { 66 void Log(Kernel::HLERequestContext& ctx) {
67 // This function only succeeds - Get that out of the way 67 // This function only succeeds - Get that out of the way
68 IPC::RequestBuilder rb{ctx, 2}; 68 IPC::ResponseBuilder rb{ctx, 2};
69 rb.Push(RESULT_SUCCESS); 69 rb.Push(RESULT_SUCCESS);
70 70
71 // Read MessageHeader, despite not doing anything with it right now 71 // Read MessageHeader, despite not doing anything with it right now
@@ -146,7 +146,7 @@ void InstallInterfaces(SM::ServiceManager& service_manager) {
146 * 0: ResultCode 146 * 0: ResultCode
147 */ 147 */
148void LM::Initialize(Kernel::HLERequestContext& ctx) { 148void LM::Initialize(Kernel::HLERequestContext& ctx) {
149 IPC::RequestBuilder rb{ctx, 2, 0, 1}; 149 IPC::ResponseBuilder rb{ctx, 2, 0, 1};
150 rb.Push(RESULT_SUCCESS); 150 rb.Push(RESULT_SUCCESS);
151 rb.PushIpcInterface<Logger>(); 151 rb.PushIpcInterface<Logger>();
152 152
diff --git a/src/core/hle/service/nvdrv/interface.cpp b/src/core/hle/service/nvdrv/interface.cpp
index 0181d1b4f..85ecde6d2 100644
--- a/src/core/hle/service/nvdrv/interface.cpp
+++ b/src/core/hle/service/nvdrv/interface.cpp
@@ -18,7 +18,7 @@ void NVDRV::Open(Kernel::HLERequestContext& ctx) {
18 std::string device_name = Memory::ReadCString(buffer.Address(), buffer.Size()); 18 std::string device_name = Memory::ReadCString(buffer.Address(), buffer.Size());
19 19
20 u32 fd = nvdrv->Open(device_name); 20 u32 fd = nvdrv->Open(device_name);
21 IPC::RequestBuilder rb{ctx, 4}; 21 IPC::ResponseBuilder rb{ctx, 4};
22 rb.Push(RESULT_SUCCESS); 22 rb.Push(RESULT_SUCCESS);
23 rb.Push<u32>(fd); 23 rb.Push<u32>(fd);
24 rb.Push<u32>(0); 24 rb.Push<u32>(0);
@@ -43,7 +43,7 @@ void NVDRV::Ioctl(Kernel::HLERequestContext& ctx) {
43 43
44 Memory::WriteBlock(output_buffer.Address(), output.data(), output_buffer.Size()); 44 Memory::WriteBlock(output_buffer.Address(), output.data(), output_buffer.Size());
45 45
46 IPC::RequestBuilder rb{ctx, 3}; 46 IPC::ResponseBuilder rb{ctx, 3};
47 rb.Push(RESULT_SUCCESS); 47 rb.Push(RESULT_SUCCESS);
48 rb.Push(nv_result); 48 rb.Push(nv_result);
49} 49}
@@ -56,13 +56,13 @@ void NVDRV::Close(Kernel::HLERequestContext& ctx) {
56 56
57 auto result = nvdrv->Close(fd); 57 auto result = nvdrv->Close(fd);
58 58
59 IPC::RequestBuilder rb{ctx, 2}; 59 IPC::ResponseBuilder rb{ctx, 2};
60 rb.Push(result); 60 rb.Push(result);
61} 61}
62 62
63void NVDRV::Initialize(Kernel::HLERequestContext& ctx) { 63void NVDRV::Initialize(Kernel::HLERequestContext& ctx) {
64 LOG_WARNING(Service, "(STUBBED) called"); 64 LOG_WARNING(Service, "(STUBBED) called");
65 IPC::RequestBuilder rb{ctx, 3}; 65 IPC::ResponseBuilder rb{ctx, 3};
66 rb.Push(RESULT_SUCCESS); 66 rb.Push(RESULT_SUCCESS);
67 rb.Push<u32>(0); 67 rb.Push<u32>(0);
68} 68}
@@ -72,7 +72,7 @@ void NVDRV::SetClientPID(Kernel::HLERequestContext& ctx) {
72 pid = rp.Pop<u64>(); 72 pid = rp.Pop<u64>();
73 73
74 LOG_INFO(Service, "called, pid=0x%lx", pid); 74 LOG_INFO(Service, "called, pid=0x%lx", pid);
75 IPC::RequestBuilder rb{ctx, 3}; 75 IPC::ResponseBuilder rb{ctx, 3};
76 rb.Push(RESULT_SUCCESS); 76 rb.Push(RESULT_SUCCESS);
77 rb.Push<u32>(0); 77 rb.Push<u32>(0);
78} 78}
diff --git a/src/core/hle/service/pctl/pctl_a.cpp b/src/core/hle/service/pctl/pctl_a.cpp
index 61e2e19bd..c808b764b 100644
--- a/src/core/hle/service/pctl/pctl_a.cpp
+++ b/src/core/hle/service/pctl/pctl_a.cpp
@@ -15,7 +15,7 @@ public:
15}; 15};
16 16
17void PCTL_A::GetService(Kernel::HLERequestContext& ctx) { 17void PCTL_A::GetService(Kernel::HLERequestContext& ctx) {
18 IPC::RequestBuilder rb{ctx, 2, 0, 1}; 18 IPC::ResponseBuilder rb{ctx, 2, 0, 1};
19 rb.Push(RESULT_SUCCESS); 19 rb.Push(RESULT_SUCCESS);
20 rb.PushIpcInterface<IParentalControlService>(); 20 rb.PushIpcInterface<IParentalControlService>();
21 LOG_DEBUG(Service, "called"); 21 LOG_DEBUG(Service, "called");
diff --git a/src/core/hle/service/service.cpp b/src/core/hle/service/service.cpp
index 5fd2f1181..294351b76 100644
--- a/src/core/hle/service/service.cpp
+++ b/src/core/hle/service/service.cpp
@@ -132,7 +132,7 @@ void ServiceFrameworkBase::InvokeRequest(Kernel::HLERequestContext& ctx) {
132ResultCode ServiceFrameworkBase::HandleSyncRequest(Kernel::HLERequestContext& context) { 132ResultCode ServiceFrameworkBase::HandleSyncRequest(Kernel::HLERequestContext& context) {
133 switch (context.GetCommandType()) { 133 switch (context.GetCommandType()) {
134 case IPC::CommandType::Close: { 134 case IPC::CommandType::Close: {
135 IPC::RequestBuilder rb{context, 2}; 135 IPC::ResponseBuilder rb{context, 2};
136 rb.Push(RESULT_SUCCESS); 136 rb.Push(RESULT_SUCCESS);
137 return ResultCode(ErrorModule::HIPC, ErrorDescription::RemoteProcessDead); 137 return ResultCode(ErrorModule::HIPC, ErrorDescription::RemoteProcessDead);
138 } 138 }
diff --git a/src/core/hle/service/set/set.cpp b/src/core/hle/service/set/set.cpp
index 3715acd74..e0e157fe1 100644
--- a/src/core/hle/service/set/set.cpp
+++ b/src/core/hle/service/set/set.cpp
@@ -19,7 +19,7 @@ void SET::GetAvailableLanguageCodes(Kernel::HLERequestContext& ctx) {
19 19
20 Memory::WriteBlock(output_buffer.Address(), lang_codes.data(), lang_codes.size()); 20 Memory::WriteBlock(output_buffer.Address(), lang_codes.data(), lang_codes.size());
21 21
22 IPC::RequestBuilder rb{ctx, 4}; 22 IPC::ResponseBuilder rb{ctx, 4};
23 23
24 rb.Push(RESULT_SUCCESS); 24 rb.Push(RESULT_SUCCESS);
25 rb.Push(static_cast<u64>(lang_codes.size())); 25 rb.Push(static_cast<u64>(lang_codes.size()));
diff --git a/src/core/hle/service/sm/controller.cpp b/src/core/hle/service/sm/controller.cpp
index 1c1da9bbc..79700b7b2 100644
--- a/src/core/hle/service/sm/controller.cpp
+++ b/src/core/hle/service/sm/controller.cpp
@@ -13,7 +13,7 @@ void Controller::ConvertSessionToDomain(Kernel::HLERequestContext& ctx) {
13 ASSERT_MSG(!ctx.Session()->IsDomain(), "session is alread a domain"); 13 ASSERT_MSG(!ctx.Session()->IsDomain(), "session is alread a domain");
14 ctx.Session()->ConvertToDomain(); 14 ctx.Session()->ConvertToDomain();
15 15
16 IPC::RequestBuilder rb{ctx, 3}; 16 IPC::ResponseBuilder rb{ctx, 3};
17 rb.Push(RESULT_SUCCESS); 17 rb.Push(RESULT_SUCCESS);
18 rb.Push<u32>(1); // Converted sessions start with 1 request handler 18 rb.Push<u32>(1); // Converted sessions start with 1 request handler
19 19
@@ -21,7 +21,7 @@ void Controller::ConvertSessionToDomain(Kernel::HLERequestContext& ctx) {
21} 21}
22 22
23void Controller::DuplicateSession(Kernel::HLERequestContext& ctx) { 23void Controller::DuplicateSession(Kernel::HLERequestContext& ctx) {
24 IPC::RequestBuilder rb{ctx, 2, 0, 1, true}; 24 IPC::ResponseBuilder rb{ctx, 2, 0, 1, true};
25 rb.Push(RESULT_SUCCESS); 25 rb.Push(RESULT_SUCCESS);
26 rb.PushMoveObjects(ctx.Session()); 26 rb.PushMoveObjects(ctx.Session());
27 27
@@ -35,7 +35,7 @@ void Controller::DuplicateSessionEx(Kernel::HLERequestContext& ctx) {
35} 35}
36 36
37void Controller::QueryPointerBufferSize(Kernel::HLERequestContext& ctx) { 37void Controller::QueryPointerBufferSize(Kernel::HLERequestContext& ctx) {
38 IPC::RequestBuilder rb{ctx, 3}; 38 IPC::ResponseBuilder rb{ctx, 3};
39 rb.Push(RESULT_SUCCESS); 39 rb.Push(RESULT_SUCCESS);
40 rb.Push<u32>(0x500); 40 rb.Push<u32>(0x500);
41 41
diff --git a/src/core/hle/service/sm/sm.cpp b/src/core/hle/service/sm/sm.cpp
index 34ed93a80..eeee4a029 100644
--- a/src/core/hle/service/sm/sm.cpp
+++ b/src/core/hle/service/sm/sm.cpp
@@ -83,7 +83,7 @@ std::shared_ptr<ServiceManager> g_service_manager;
83 * 0: ResultCode 83 * 0: ResultCode
84 */ 84 */
85void SM::Initialize(Kernel::HLERequestContext& ctx) { 85void SM::Initialize(Kernel::HLERequestContext& ctx) {
86 IPC::RequestBuilder rb{ctx, 2}; 86 IPC::ResponseBuilder rb{ctx, 2};
87 rb.Push(RESULT_SUCCESS); 87 rb.Push(RESULT_SUCCESS);
88 LOG_DEBUG(Service_SM, "called"); 88 LOG_DEBUG(Service_SM, "called");
89} 89}
@@ -99,7 +99,7 @@ void SM::GetService(Kernel::HLERequestContext& ctx) {
99 99
100 auto client_port = service_manager->GetServicePort(name); 100 auto client_port = service_manager->GetServicePort(name);
101 if (client_port.Failed()) { 101 if (client_port.Failed()) {
102 IPC::RequestBuilder rb = rp.MakeBuilder(2, 0, 0); 102 IPC::ResponseBuilder rb = rp.MakeBuilder(2, 0, 0);
103 rb.Push(client_port.Code()); 103 rb.Push(client_port.Code());
104 LOG_ERROR(Service_SM, "called service=%s -> error 0x%08X", name.c_str(), 104 LOG_ERROR(Service_SM, "called service=%s -> error 0x%08X", name.c_str(),
105 client_port.Code().raw); 105 client_port.Code().raw);
@@ -112,7 +112,7 @@ void SM::GetService(Kernel::HLERequestContext& ctx) {
112 if (session.Succeeded()) { 112 if (session.Succeeded()) {
113 LOG_DEBUG(Service_SM, "called service=%s -> session=%u", name.c_str(), 113 LOG_DEBUG(Service_SM, "called service=%s -> session=%u", name.c_str(),
114 (*session)->GetObjectId()); 114 (*session)->GetObjectId());
115 IPC::RequestBuilder rb = rp.MakeBuilder(2, 0, 1, true); 115 IPC::ResponseBuilder rb = rp.MakeBuilder(2, 0, 1, true);
116 rb.Push(session.Code()); 116 rb.Push(session.Code());
117 rb.PushMoveObjects(std::move(session).Unwrap()); 117 rb.PushMoveObjects(std::move(session).Unwrap());
118 } 118 }
diff --git a/src/core/hle/service/sockets/bsd_u.cpp b/src/core/hle/service/sockets/bsd_u.cpp
index a819acc96..4fd960bd8 100644
--- a/src/core/hle/service/sockets/bsd_u.cpp
+++ b/src/core/hle/service/sockets/bsd_u.cpp
@@ -11,7 +11,7 @@ namespace Sockets {
11void BSD_U::RegisterClient(Kernel::HLERequestContext& ctx) { 11void BSD_U::RegisterClient(Kernel::HLERequestContext& ctx) {
12 LOG_WARNING(Service, "(STUBBED) called"); 12 LOG_WARNING(Service, "(STUBBED) called");
13 13
14 IPC::RequestBuilder rb{ctx, 3}; 14 IPC::ResponseBuilder rb{ctx, 3};
15 15
16 rb.Push(RESULT_SUCCESS); 16 rb.Push(RESULT_SUCCESS);
17 rb.Push<u32>(0); // bsd errno 17 rb.Push<u32>(0); // bsd errno
@@ -28,7 +28,7 @@ void BSD_U::Socket(Kernel::HLERequestContext& ctx) {
28 28
29 u32 fd = next_fd++; 29 u32 fd = next_fd++;
30 30
31 IPC::RequestBuilder rb{ctx, 4}; 31 IPC::ResponseBuilder rb{ctx, 4};
32 32
33 rb.Push(RESULT_SUCCESS); 33 rb.Push(RESULT_SUCCESS);
34 rb.Push<u32>(fd); 34 rb.Push<u32>(fd);
@@ -38,7 +38,7 @@ void BSD_U::Socket(Kernel::HLERequestContext& ctx) {
38void BSD_U::Connect(Kernel::HLERequestContext& ctx) { 38void BSD_U::Connect(Kernel::HLERequestContext& ctx) {
39 LOG_WARNING(Service, "(STUBBED) called"); 39 LOG_WARNING(Service, "(STUBBED) called");
40 40
41 IPC::RequestBuilder rb{ctx, 4}; 41 IPC::ResponseBuilder rb{ctx, 4};
42 42
43 rb.Push(RESULT_SUCCESS); 43 rb.Push(RESULT_SUCCESS);
44 rb.Push<u32>(0); // ret 44 rb.Push<u32>(0); // ret
@@ -48,7 +48,7 @@ void BSD_U::Connect(Kernel::HLERequestContext& ctx) {
48void BSD_U::SendTo(Kernel::HLERequestContext& ctx) { 48void BSD_U::SendTo(Kernel::HLERequestContext& ctx) {
49 LOG_WARNING(Service, "(STUBBED) called"); 49 LOG_WARNING(Service, "(STUBBED) called");
50 50
51 IPC::RequestBuilder rb{ctx, 4}; 51 IPC::ResponseBuilder rb{ctx, 4};
52 52
53 rb.Push(RESULT_SUCCESS); 53 rb.Push(RESULT_SUCCESS);
54 rb.Push<u32>(0); // ret 54 rb.Push<u32>(0); // ret
diff --git a/src/core/hle/service/time/time.cpp b/src/core/hle/service/time/time.cpp
index 9816a33d0..d6f3ae043 100644
--- a/src/core/hle/service/time/time.cpp
+++ b/src/core/hle/service/time/time.cpp
@@ -28,7 +28,7 @@ private:
28 const s64 time_since_epoch{std::chrono::duration_cast<std::chrono::seconds>( 28 const s64 time_since_epoch{std::chrono::duration_cast<std::chrono::seconds>(
29 std::chrono::system_clock::now().time_since_epoch()) 29 std::chrono::system_clock::now().time_since_epoch())
30 .count()}; 30 .count()};
31 IPC::RequestBuilder rb{ctx, 4}; 31 IPC::ResponseBuilder rb{ctx, 4};
32 rb.Push(RESULT_SUCCESS); 32 rb.Push(RESULT_SUCCESS);
33 rb.Push<u64>(time_since_epoch); 33 rb.Push<u64>(time_since_epoch);
34 LOG_DEBUG(Service, "called"); 34 LOG_DEBUG(Service, "called");
@@ -55,14 +55,14 @@ private:
55 void GetDeviceLocationName(Kernel::HLERequestContext& ctx) { 55 void GetDeviceLocationName(Kernel::HLERequestContext& ctx) {
56 LOG_WARNING(Service, "(STUBBED) called"); 56 LOG_WARNING(Service, "(STUBBED) called");
57 LocationName location_name{}; 57 LocationName location_name{};
58 IPC::RequestBuilder rb{ctx, (sizeof(LocationName) / 4) + 2}; 58 IPC::ResponseBuilder rb{ctx, (sizeof(LocationName) / 4) + 2};
59 rb.Push(RESULT_SUCCESS); 59 rb.Push(RESULT_SUCCESS);
60 rb.PushRaw(location_name); 60 rb.PushRaw(location_name);
61 } 61 }
62 62
63 void GetTotalLocationNameCount(Kernel::HLERequestContext& ctx) { 63 void GetTotalLocationNameCount(Kernel::HLERequestContext& ctx) {
64 LOG_WARNING(Service, "(STUBBED) called"); 64 LOG_WARNING(Service, "(STUBBED) called");
65 IPC::RequestBuilder rb{ctx, 3}; 65 IPC::ResponseBuilder rb{ctx, 3};
66 rb.Push(RESULT_SUCCESS); 66 rb.Push(RESULT_SUCCESS);
67 rb.Push<u32>(0); 67 rb.Push<u32>(0);
68 } 68 }
@@ -75,7 +75,7 @@ private:
75 75
76 CalendarTime calendar_time{2018, 1, 1, 0, 0, 0}; 76 CalendarTime calendar_time{2018, 1, 1, 0, 0, 0};
77 CalendarAdditionalInfo additional_info{}; 77 CalendarAdditionalInfo additional_info{};
78 IPC::RequestBuilder rb{ctx, 10}; 78 IPC::ResponseBuilder rb{ctx, 10};
79 rb.Push(RESULT_SUCCESS); 79 rb.Push(RESULT_SUCCESS);
80 rb.PushRaw(calendar_time); 80 rb.PushRaw(calendar_time);
81 rb.PushRaw(additional_info); 81 rb.PushRaw(additional_info);
@@ -83,28 +83,28 @@ private:
83}; 83};
84 84
85void Module::Interface::GetStandardUserSystemClock(Kernel::HLERequestContext& ctx) { 85void Module::Interface::GetStandardUserSystemClock(Kernel::HLERequestContext& ctx) {
86 IPC::RequestBuilder rb{ctx, 2, 0, 1}; 86 IPC::ResponseBuilder rb{ctx, 2, 0, 1};
87 rb.Push(RESULT_SUCCESS); 87 rb.Push(RESULT_SUCCESS);
88 rb.PushIpcInterface<ISystemClock>(); 88 rb.PushIpcInterface<ISystemClock>();
89 LOG_DEBUG(Service, "called"); 89 LOG_DEBUG(Service, "called");
90} 90}
91 91
92void Module::Interface::GetStandardNetworkSystemClock(Kernel::HLERequestContext& ctx) { 92void Module::Interface::GetStandardNetworkSystemClock(Kernel::HLERequestContext& ctx) {
93 IPC::RequestBuilder rb{ctx, 2, 0, 1}; 93 IPC::ResponseBuilder rb{ctx, 2, 0, 1};
94 rb.Push(RESULT_SUCCESS); 94 rb.Push(RESULT_SUCCESS);
95 rb.PushIpcInterface<ISystemClock>(); 95 rb.PushIpcInterface<ISystemClock>();
96 LOG_DEBUG(Service, "called"); 96 LOG_DEBUG(Service, "called");
97} 97}
98 98
99void Module::Interface::GetStandardSteadyClock(Kernel::HLERequestContext& ctx) { 99void Module::Interface::GetStandardSteadyClock(Kernel::HLERequestContext& ctx) {
100 IPC::RequestBuilder rb{ctx, 2, 0, 1}; 100 IPC::ResponseBuilder rb{ctx, 2, 0, 1};
101 rb.Push(RESULT_SUCCESS); 101 rb.Push(RESULT_SUCCESS);
102 rb.PushIpcInterface<ISteadyClock>(); 102 rb.PushIpcInterface<ISteadyClock>();
103 LOG_DEBUG(Service, "called"); 103 LOG_DEBUG(Service, "called");
104} 104}
105 105
106void Module::Interface::GetTimeZoneService(Kernel::HLERequestContext& ctx) { 106void Module::Interface::GetTimeZoneService(Kernel::HLERequestContext& ctx) {
107 IPC::RequestBuilder rb{ctx, 2, 0, 1}; 107 IPC::ResponseBuilder rb{ctx, 2, 0, 1};
108 rb.Push(RESULT_SUCCESS); 108 rb.Push(RESULT_SUCCESS);
109 rb.PushIpcInterface<ITimeZoneService>(); 109 rb.PushIpcInterface<ITimeZoneService>();
110 LOG_DEBUG(Service, "called"); 110 LOG_DEBUG(Service, "called");
diff --git a/src/core/hle/service/vi/vi.cpp b/src/core/hle/service/vi/vi.cpp
index 3fcfa1013..3b993f36c 100644
--- a/src/core/hle/service/vi/vi.cpp
+++ b/src/core/hle/service/vi/vi.cpp
@@ -486,7 +486,7 @@ private:
486 } 486 }
487 487
488 LOG_WARNING(Service, "(STUBBED) called"); 488 LOG_WARNING(Service, "(STUBBED) called");
489 IPC::RequestBuilder rb{ctx, 2}; 489 IPC::ResponseBuilder rb{ctx, 2};
490 rb.Push(RESULT_SUCCESS); 490 rb.Push(RESULT_SUCCESS);
491 } 491 }
492 492
@@ -497,7 +497,7 @@ private:
497 u32 type = rp.Pop<u32>(); 497 u32 type = rp.Pop<u32>();
498 498
499 LOG_WARNING(Service, "(STUBBED) called id=%u, addval=%08X, type=%08X", id, addval, type); 499 LOG_WARNING(Service, "(STUBBED) called id=%u, addval=%08X, type=%08X", id, addval, type);
500 IPC::RequestBuilder rb{ctx, 2}; 500 IPC::ResponseBuilder rb{ctx, 2};
501 rb.Push(RESULT_SUCCESS); 501 rb.Push(RESULT_SUCCESS);
502 } 502 }
503 503
@@ -511,7 +511,7 @@ private:
511 // TODO(Subv): Find out what this actually is. 511 // TODO(Subv): Find out what this actually is.
512 512
513 LOG_WARNING(Service, "(STUBBED) called id=%u, unknown=%08X", id, unknown); 513 LOG_WARNING(Service, "(STUBBED) called id=%u, unknown=%08X", id, unknown);
514 IPC::RequestBuilder rb{ctx, 2, 1}; 514 IPC::ResponseBuilder rb{ctx, 2, 1};
515 rb.Push(RESULT_SUCCESS); 515 rb.Push(RESULT_SUCCESS);
516 rb.PushCopyObjects(buffer_queue->GetNativeHandle()); 516 rb.PushCopyObjects(buffer_queue->GetNativeHandle());
517 } 517 }
@@ -537,7 +537,7 @@ private:
537 u64 layer_id = rp.Pop<u64>(); 537 u64 layer_id = rp.Pop<u64>();
538 u64 z_value = rp.Pop<u64>(); 538 u64 z_value = rp.Pop<u64>();
539 539
540 IPC::RequestBuilder rb = rp.MakeBuilder(2, 0, 0, 0); 540 IPC::ResponseBuilder rb = rp.MakeBuilder(2, 0, 0);
541 rb.Push(RESULT_SUCCESS); 541 rb.Push(RESULT_SUCCESS);
542 } 542 }
543}; 543};
@@ -562,7 +562,7 @@ private:
562 IPC::RequestParser rp{ctx}; 562 IPC::RequestParser rp{ctx};
563 u64 display = rp.Pop<u64>(); 563 u64 display = rp.Pop<u64>();
564 564
565 IPC::RequestBuilder rb = rp.MakeBuilder(2, 0, 0, 0); 565 IPC::ResponseBuilder rb = rp.MakeBuilder(2, 0, 0);
566 rb.Push(RESULT_SUCCESS); 566 rb.Push(RESULT_SUCCESS);
567 } 567 }
568 568
@@ -576,7 +576,7 @@ private:
576 576
577 u64 layer_id = nv_flinger->CreateLayer(display); 577 u64 layer_id = nv_flinger->CreateLayer(display);
578 578
579 IPC::RequestBuilder rb = rp.MakeBuilder(4, 0, 0, 0); 579 IPC::ResponseBuilder rb = rp.MakeBuilder(4, 0, 0);
580 rb.Push(RESULT_SUCCESS); 580 rb.Push(RESULT_SUCCESS);
581 rb.Push(layer_id); 581 rb.Push(layer_id);
582 } 582 }
@@ -587,7 +587,7 @@ private:
587 u32 stack = rp.Pop<u32>(); 587 u32 stack = rp.Pop<u32>();
588 u64 layer_id = rp.Pop<u64>(); 588 u64 layer_id = rp.Pop<u64>();
589 589
590 IPC::RequestBuilder rb = rp.MakeBuilder(2, 0, 0, 0); 590 IPC::ResponseBuilder rb = rp.MakeBuilder(2, 0, 0);
591 rb.Push(RESULT_SUCCESS); 591 rb.Push(RESULT_SUCCESS);
592 } 592 }
593 593
@@ -597,7 +597,7 @@ private:
597void IApplicationDisplayService::GetRelayService(Kernel::HLERequestContext& ctx) { 597void IApplicationDisplayService::GetRelayService(Kernel::HLERequestContext& ctx) {
598 LOG_WARNING(Service, "(STUBBED) called"); 598 LOG_WARNING(Service, "(STUBBED) called");
599 599
600 IPC::RequestBuilder rb{ctx, 2, 0, 1}; 600 IPC::ResponseBuilder rb{ctx, 2, 0, 1};
601 rb.Push(RESULT_SUCCESS); 601 rb.Push(RESULT_SUCCESS);
602 rb.PushIpcInterface<IHOSBinderDriver>(nv_flinger); 602 rb.PushIpcInterface<IHOSBinderDriver>(nv_flinger);
603} 603}
@@ -605,7 +605,7 @@ void IApplicationDisplayService::GetRelayService(Kernel::HLERequestContext& ctx)
605void IApplicationDisplayService::GetSystemDisplayService(Kernel::HLERequestContext& ctx) { 605void IApplicationDisplayService::GetSystemDisplayService(Kernel::HLERequestContext& ctx) {
606 LOG_WARNING(Service, "(STUBBED) called"); 606 LOG_WARNING(Service, "(STUBBED) called");
607 607
608 IPC::RequestBuilder rb{ctx, 2, 0, 1}; 608 IPC::ResponseBuilder rb{ctx, 2, 0, 1};
609 rb.Push(RESULT_SUCCESS); 609 rb.Push(RESULT_SUCCESS);
610 rb.PushIpcInterface<ISystemDisplayService>(); 610 rb.PushIpcInterface<ISystemDisplayService>();
611} 611}
@@ -613,7 +613,7 @@ void IApplicationDisplayService::GetSystemDisplayService(Kernel::HLERequestConte
613void IApplicationDisplayService::GetManagerDisplayService(Kernel::HLERequestContext& ctx) { 613void IApplicationDisplayService::GetManagerDisplayService(Kernel::HLERequestContext& ctx) {
614 LOG_WARNING(Service, "(STUBBED) called"); 614 LOG_WARNING(Service, "(STUBBED) called");
615 615
616 IPC::RequestBuilder rb{ctx, 2, 0, 1}; 616 IPC::ResponseBuilder rb{ctx, 2, 0, 1};
617 rb.Push(RESULT_SUCCESS); 617 rb.Push(RESULT_SUCCESS);
618 rb.PushIpcInterface<IManagerDisplayService>(nv_flinger); 618 rb.PushIpcInterface<IManagerDisplayService>(nv_flinger);
619} 619}
@@ -622,7 +622,7 @@ void IApplicationDisplayService::GetIndirectDisplayTransactionService(
622 Kernel::HLERequestContext& ctx) { 622 Kernel::HLERequestContext& ctx) {
623 LOG_WARNING(Service, "(STUBBED) called"); 623 LOG_WARNING(Service, "(STUBBED) called");
624 624
625 IPC::RequestBuilder rb{ctx, 2, 0, 1}; 625 IPC::ResponseBuilder rb{ctx, 2, 0, 1};
626 rb.Push(RESULT_SUCCESS); 626 rb.Push(RESULT_SUCCESS);
627 rb.PushIpcInterface<IHOSBinderDriver>(nv_flinger); 627 rb.PushIpcInterface<IHOSBinderDriver>(nv_flinger);
628} 628}
@@ -637,7 +637,7 @@ void IApplicationDisplayService::OpenDisplay(Kernel::HLERequestContext& ctx) {
637 637
638 ASSERT_MSG(name == "Default", "Non-default displays aren't supported yet"); 638 ASSERT_MSG(name == "Default", "Non-default displays aren't supported yet");
639 639
640 IPC::RequestBuilder rb = rp.MakeBuilder(4, 0, 0, 0); 640 IPC::ResponseBuilder rb = rp.MakeBuilder(4, 0, 0);
641 rb.Push(RESULT_SUCCESS); 641 rb.Push(RESULT_SUCCESS);
642 rb.Push<u64>(nv_flinger->OpenDisplay(name)); 642 rb.Push<u64>(nv_flinger->OpenDisplay(name));
643} 643}
@@ -647,7 +647,7 @@ void IApplicationDisplayService::CloseDisplay(Kernel::HLERequestContext& ctx) {
647 IPC::RequestParser rp{ctx}; 647 IPC::RequestParser rp{ctx};
648 u64 display_id = rp.Pop<u64>(); 648 u64 display_id = rp.Pop<u64>();
649 649
650 IPC::RequestBuilder rb = rp.MakeBuilder(4, 0, 0, 0); 650 IPC::ResponseBuilder rb = rp.MakeBuilder(4, 0, 0);
651 rb.Push(RESULT_SUCCESS); 651 rb.Push(RESULT_SUCCESS);
652} 652}
653 653
@@ -671,7 +671,7 @@ void IApplicationDisplayService::OpenLayer(Kernel::HLERequestContext& ctx) {
671 auto data = native_window.Serialize(); 671 auto data = native_window.Serialize();
672 Memory::WriteBlock(buffer.Address(), data.data(), data.size()); 672 Memory::WriteBlock(buffer.Address(), data.data(), data.size());
673 673
674 IPC::RequestBuilder rb = rp.MakeBuilder(4, 0, 0, 0); 674 IPC::ResponseBuilder rb = rp.MakeBuilder(4, 0, 0);
675 rb.Push(RESULT_SUCCESS); 675 rb.Push(RESULT_SUCCESS);
676 rb.Push<u64>(data.size()); 676 rb.Push<u64>(data.size());
677} 677}
@@ -694,7 +694,7 @@ void IApplicationDisplayService::CreateStrayLayer(Kernel::HLERequestContext& ctx
694 auto data = native_window.Serialize(); 694 auto data = native_window.Serialize();
695 Memory::WriteBlock(buffer.Address(), data.data(), data.size()); 695 Memory::WriteBlock(buffer.Address(), data.data(), data.size());
696 696
697 IPC::RequestBuilder rb = rp.MakeBuilder(6, 0, 0, 0); 697 IPC::ResponseBuilder rb = rp.MakeBuilder(6, 0, 0);
698 rb.Push(RESULT_SUCCESS); 698 rb.Push(RESULT_SUCCESS);
699 rb.Push(layer_id); 699 rb.Push(layer_id);
700 rb.Push<u64>(data.size()); 700 rb.Push<u64>(data.size());
@@ -706,7 +706,7 @@ void IApplicationDisplayService::DestroyStrayLayer(Kernel::HLERequestContext& ct
706 IPC::RequestParser rp{ctx}; 706 IPC::RequestParser rp{ctx};
707 u64 layer_id = rp.Pop<u64>(); 707 u64 layer_id = rp.Pop<u64>();
708 708
709 IPC::RequestBuilder rb = rp.MakeBuilder(2, 0, 0, 0); 709 IPC::ResponseBuilder rb = rp.MakeBuilder(2, 0, 0);
710 rb.Push(RESULT_SUCCESS); 710 rb.Push(RESULT_SUCCESS);
711} 711}
712 712
@@ -716,7 +716,7 @@ void IApplicationDisplayService::SetLayerScalingMode(Kernel::HLERequestContext&
716 u32 scaling_mode = rp.Pop<u32>(); 716 u32 scaling_mode = rp.Pop<u32>();
717 u64 unknown = rp.Pop<u64>(); 717 u64 unknown = rp.Pop<u64>();
718 718
719 IPC::RequestBuilder rb = rp.MakeBuilder(2, 0, 0, 0); 719 IPC::ResponseBuilder rb = rp.MakeBuilder(2, 0, 0);
720 rb.Push(RESULT_SUCCESS); 720 rb.Push(RESULT_SUCCESS);
721} 721}
722 722
@@ -727,7 +727,7 @@ void IApplicationDisplayService::GetDisplayVsyncEvent(Kernel::HLERequestContext&
727 727
728 auto vsync_event = nv_flinger->GetVsyncEvent(display_id); 728 auto vsync_event = nv_flinger->GetVsyncEvent(display_id);
729 729
730 IPC::RequestBuilder rb = rp.MakeBuilder(2, 1, 0, 0); 730 IPC::ResponseBuilder rb = rp.MakeBuilder(2, 1, 0);
731 rb.Push(RESULT_SUCCESS); 731 rb.Push(RESULT_SUCCESS);
732 rb.PushCopyObjects(vsync_event); 732 rb.PushCopyObjects(vsync_event);
733} 733}
diff --git a/src/core/hle/service/vi/vi_m.cpp b/src/core/hle/service/vi/vi_m.cpp
index cba7cde1c..bb440cadb 100644
--- a/src/core/hle/service/vi/vi_m.cpp
+++ b/src/core/hle/service/vi/vi_m.cpp
@@ -13,7 +13,7 @@ namespace VI {
13void VI_M::GetDisplayService(Kernel::HLERequestContext& ctx) { 13void VI_M::GetDisplayService(Kernel::HLERequestContext& ctx) {
14 LOG_WARNING(Service, "(STUBBED) called"); 14 LOG_WARNING(Service, "(STUBBED) called");
15 15
16 IPC::RequestBuilder rb{ctx, 2, 0, 1}; 16 IPC::ResponseBuilder rb{ctx, 2, 0, 1};
17 rb.Push(RESULT_SUCCESS); 17 rb.Push(RESULT_SUCCESS);
18 rb.PushIpcInterface<IApplicationDisplayService>(nv_flinger); 18 rb.PushIpcInterface<IApplicationDisplayService>(nv_flinger);
19} 19}