diff options
| author | 2022-12-09 13:41:04 +0100 | |
|---|---|---|
| committer | 2022-12-09 16:39:59 +0100 | |
| commit | c586ac9be2edea86889b44d44cede599a0c4dba5 (patch) | |
| tree | 1f6426d0fa21acd1eaacd42ecbc130d002591b6a /src | |
| parent | Merge pull request #9401 from vonchenplus/draw_manager (diff) | |
| download | yuzu-c586ac9be2edea86889b44d44cede599a0c4dba5.tar.gz yuzu-c586ac9be2edea86889b44d44cede599a0c4dba5.tar.xz yuzu-c586ac9be2edea86889b44d44cede599a0c4dba5.zip | |
Remove the lock entirely as per PR discussion
Correctly unlock mutex before its destruction
As per https://en.cppreference.com/w/cpp/thread/mutex/~mutex destroying a locked mutex is undefined behavior and MSVC++ decides to throw in this case
Swap out unique for scoped lock and readd comment
Diffstat (limited to '')
| -rw-r--r-- | src/core/hle/kernel/service_thread.cpp | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/src/core/hle/kernel/service_thread.cpp b/src/core/hle/kernel/service_thread.cpp index e72c3d35d..38afa720b 100644 --- a/src/core/hle/kernel/service_thread.cpp +++ b/src/core/hle/kernel/service_thread.cpp | |||
| @@ -163,9 +163,6 @@ ServiceThread::Impl::~Impl() { | |||
| 163 | m_wakeup_event->Signal(); | 163 | m_wakeup_event->Signal(); |
| 164 | m_host_thread.join(); | 164 | m_host_thread.join(); |
| 165 | 165 | ||
| 166 | // Lock mutex. | ||
| 167 | m_session_mutex.lock(); | ||
| 168 | |||
| 169 | // Close all remaining sessions. | 166 | // Close all remaining sessions. |
| 170 | for (const auto& [server_session, manager] : m_sessions) { | 167 | for (const auto& [server_session, manager] : m_sessions) { |
| 171 | server_session->Close(); | 168 | server_session->Close(); |