diff options
| author | 2018-06-20 16:46:14 -0400 | |
|---|---|---|
| committer | 2018-06-20 16:46:14 -0400 | |
| commit | c3e95086b66dfa4214892dcddb9fd6f865037c1e (patch) | |
| tree | 859f41acecbdcfcbdf19df80903a045d6e2b0bcb /src/video_core | |
| parent | Implement GetAvailableLanguageCodes2 (#575) (diff) | |
| parent | Build: Fixed some MSVC warnings in various parts of the code. (diff) | |
| download | yuzu-c3e95086b66dfa4214892dcddb9fd6f865037c1e.tar.gz yuzu-c3e95086b66dfa4214892dcddb9fd6f865037c1e.tar.xz yuzu-c3e95086b66dfa4214892dcddb9fd6f865037c1e.zip | |
Merge pull request #576 from Subv/warnings1
Build: Fixed some MSVC warnings in various parts of the code.
Diffstat (limited to 'src/video_core')
| -rw-r--r-- | src/video_core/engines/maxwell_3d.cpp | 5 | ||||
| -rw-r--r-- | src/video_core/engines/shader_bytecode.h | 4 | ||||
| -rw-r--r-- | src/video_core/renderer_opengl/gl_rasterizer.cpp | 4 | ||||
| -rw-r--r-- | src/video_core/renderer_opengl/gl_rasterizer_cache.cpp | 2 | ||||
| -rw-r--r-- | src/video_core/renderer_opengl/gl_shader_decompiler.cpp | 2 | ||||
| -rw-r--r-- | src/video_core/renderer_opengl/gl_shader_manager.cpp | 4 | ||||
| -rw-r--r-- | src/video_core/renderer_opengl/gl_state.cpp | 4 |
7 files changed, 13 insertions, 12 deletions
diff --git a/src/video_core/engines/maxwell_3d.cpp b/src/video_core/engines/maxwell_3d.cpp index 86e9dc998..93c43c8cb 100644 --- a/src/video_core/engines/maxwell_3d.cpp +++ b/src/video_core/engines/maxwell_3d.cpp | |||
| @@ -328,8 +328,9 @@ std::vector<Texture::FullTextureInfo> Maxwell3D::GetStageTextures(Regs::ShaderSt | |||
| 328 | 328 | ||
| 329 | Texture::FullTextureInfo tex_info{}; | 329 | Texture::FullTextureInfo tex_info{}; |
| 330 | // TODO(Subv): Use the shader to determine which textures are actually accessed. | 330 | // TODO(Subv): Use the shader to determine which textures are actually accessed. |
| 331 | tex_info.index = (current_texture - tex_info_buffer.address - TextureInfoOffset) / | 331 | tex_info.index = |
| 332 | sizeof(Texture::TextureHandle); | 332 | static_cast<u32>(current_texture - tex_info_buffer.address - TextureInfoOffset) / |
| 333 | sizeof(Texture::TextureHandle); | ||
| 333 | 334 | ||
| 334 | // Load the TIC data. | 335 | // Load the TIC data. |
| 335 | if (tex_handle.tic_id != 0) { | 336 | if (tex_handle.tic_id != 0) { |
diff --git a/src/video_core/engines/shader_bytecode.h b/src/video_core/engines/shader_bytecode.h index 5ff861b04..cb4db0679 100644 --- a/src/video_core/engines/shader_bytecode.h +++ b/src/video_core/engines/shader_bytecode.h | |||
| @@ -372,7 +372,7 @@ union Instruction { | |||
| 372 | BitField<31, 4, u64> component_mask; | 372 | BitField<31, 4, u64> component_mask; |
| 373 | 373 | ||
| 374 | bool IsComponentEnabled(size_t component) const { | 374 | bool IsComponentEnabled(size_t component) const { |
| 375 | return ((1 << component) & component_mask) != 0; | 375 | return ((1ull << component) & component_mask) != 0; |
| 376 | } | 376 | } |
| 377 | } tex; | 377 | } tex; |
| 378 | 378 | ||
| @@ -391,7 +391,7 @@ union Instruction { | |||
| 391 | 391 | ||
| 392 | ASSERT(component_mask_selector < mask.size()); | 392 | ASSERT(component_mask_selector < mask.size()); |
| 393 | 393 | ||
| 394 | return ((1 << component) & mask[component_mask_selector]) != 0; | 394 | return ((1ull << component) & mask[component_mask_selector]) != 0; |
| 395 | } | 395 | } |
| 396 | } texs; | 396 | } texs; |
| 397 | 397 | ||
diff --git a/src/video_core/renderer_opengl/gl_rasterizer.cpp b/src/video_core/renderer_opengl/gl_rasterizer.cpp index 833ff8273..3ba20f978 100644 --- a/src/video_core/renderer_opengl/gl_rasterizer.cpp +++ b/src/video_core/renderer_opengl/gl_rasterizer.cpp | |||
| @@ -633,7 +633,7 @@ u32 RasterizerOpenGL::SetupConstBuffers(Maxwell::ShaderStage stage, GLuint progr | |||
| 633 | 633 | ||
| 634 | state.Apply(); | 634 | state.Apply(); |
| 635 | 635 | ||
| 636 | return current_bindpoint + entries.size(); | 636 | return current_bindpoint + static_cast<u32>(entries.size()); |
| 637 | } | 637 | } |
| 638 | 638 | ||
| 639 | u32 RasterizerOpenGL::SetupTextures(Maxwell::ShaderStage stage, GLuint program, u32 current_unit, | 639 | u32 RasterizerOpenGL::SetupTextures(Maxwell::ShaderStage stage, GLuint program, u32 current_unit, |
| @@ -679,7 +679,7 @@ u32 RasterizerOpenGL::SetupTextures(Maxwell::ShaderStage stage, GLuint program, | |||
| 679 | 679 | ||
| 680 | state.Apply(); | 680 | state.Apply(); |
| 681 | 681 | ||
| 682 | return current_unit + entries.size(); | 682 | return current_unit + static_cast<u32>(entries.size()); |
| 683 | } | 683 | } |
| 684 | 684 | ||
| 685 | void RasterizerOpenGL::BindFramebufferSurfaces(const Surface& color_surface, | 685 | void RasterizerOpenGL::BindFramebufferSurfaces(const Surface& color_surface, |
diff --git a/src/video_core/renderer_opengl/gl_rasterizer_cache.cpp b/src/video_core/renderer_opengl/gl_rasterizer_cache.cpp index b2a61024e..61d670dcb 100644 --- a/src/video_core/renderer_opengl/gl_rasterizer_cache.cpp +++ b/src/video_core/renderer_opengl/gl_rasterizer_cache.cpp | |||
| @@ -575,7 +575,7 @@ void CachedSurface::UploadGLTexture(const MathUtil::Rectangle<u32>& rect, GLuint | |||
| 575 | glCompressedTexImage2D(GL_TEXTURE_2D, 0, tuple.internal_format, | 575 | glCompressedTexImage2D(GL_TEXTURE_2D, 0, tuple.internal_format, |
| 576 | static_cast<GLsizei>(rect.GetWidth() * GetCompresssionFactor()), | 576 | static_cast<GLsizei>(rect.GetWidth() * GetCompresssionFactor()), |
| 577 | static_cast<GLsizei>(rect.GetHeight() * GetCompresssionFactor()), 0, | 577 | static_cast<GLsizei>(rect.GetHeight() * GetCompresssionFactor()), 0, |
| 578 | size, &gl_buffer[buffer_offset]); | 578 | static_cast<GLsizei>(size), &gl_buffer[buffer_offset]); |
| 579 | } else { | 579 | } else { |
| 580 | glTexSubImage2D(GL_TEXTURE_2D, 0, x0, y0, static_cast<GLsizei>(rect.GetWidth()), | 580 | glTexSubImage2D(GL_TEXTURE_2D, 0, x0, y0, static_cast<GLsizei>(rect.GetWidth()), |
| 581 | static_cast<GLsizei>(rect.GetHeight()), tuple.format, tuple.type, | 581 | static_cast<GLsizei>(rect.GetHeight()), tuple.format, tuple.type, |
diff --git a/src/video_core/renderer_opengl/gl_shader_decompiler.cpp b/src/video_core/renderer_opengl/gl_shader_decompiler.cpp index fc80d4b29..65fed77ef 100644 --- a/src/video_core/renderer_opengl/gl_shader_decompiler.cpp +++ b/src/video_core/renderer_opengl/gl_shader_decompiler.cpp | |||
| @@ -535,7 +535,7 @@ private: | |||
| 535 | */ | 535 | */ |
| 536 | void SetRegister(const Register& reg, u64 elem, const std::string& value, | 536 | void SetRegister(const Register& reg, u64 elem, const std::string& value, |
| 537 | u64 dest_num_components, u64 value_num_components, u64 dest_elem) { | 537 | u64 dest_num_components, u64 value_num_components, u64 dest_elem) { |
| 538 | std::string dest = GetRegister(reg, dest_elem); | 538 | std::string dest = GetRegister(reg, static_cast<u32>(dest_elem)); |
| 539 | if (dest_num_components > 1) { | 539 | if (dest_num_components > 1) { |
| 540 | dest += GetSwizzle(elem); | 540 | dest += GetSwizzle(elem); |
| 541 | } | 541 | } |
diff --git a/src/video_core/renderer_opengl/gl_shader_manager.cpp b/src/video_core/renderer_opengl/gl_shader_manager.cpp index 7c00beb33..d7167b298 100644 --- a/src/video_core/renderer_opengl/gl_shader_manager.cpp +++ b/src/video_core/renderer_opengl/gl_shader_manager.cpp | |||
| @@ -38,8 +38,8 @@ void MaxwellUniformData::SetFromRegs(const Maxwell3D::State::ShaderStageInfo& sh | |||
| 38 | const auto& regs = Core::System().GetInstance().GPU().Maxwell3D().regs; | 38 | const auto& regs = Core::System().GetInstance().GPU().Maxwell3D().regs; |
| 39 | 39 | ||
| 40 | // TODO(bunnei): Support more than one viewport | 40 | // TODO(bunnei): Support more than one viewport |
| 41 | viewport_flip[0] = regs.viewport_transform[0].scale_x < 0.0 ? -1.0 : 1.0; | 41 | viewport_flip[0] = regs.viewport_transform[0].scale_x < 0.0 ? -1.0f : 1.0f; |
| 42 | viewport_flip[1] = regs.viewport_transform[0].scale_y < 0.0 ? -1.0 : 1.0; | 42 | viewport_flip[1] = regs.viewport_transform[0].scale_y < 0.0 ? -1.0f : 1.0f; |
| 43 | } | 43 | } |
| 44 | 44 | ||
| 45 | } // namespace GLShader | 45 | } // namespace GLShader |
diff --git a/src/video_core/renderer_opengl/gl_state.cpp b/src/video_core/renderer_opengl/gl_state.cpp index 44f0c8a01..1f1e48425 100644 --- a/src/video_core/renderer_opengl/gl_state.cpp +++ b/src/video_core/renderer_opengl/gl_state.cpp | |||
| @@ -196,13 +196,13 @@ void OpenGLState::Apply() const { | |||
| 196 | } | 196 | } |
| 197 | 197 | ||
| 198 | // Textures | 198 | // Textures |
| 199 | for (size_t i = 0; i < std::size(texture_units); ++i) { | 199 | for (int i = 0; i < std::size(texture_units); ++i) { |
| 200 | if (texture_units[i].texture_2d != cur_state.texture_units[i].texture_2d) { | 200 | if (texture_units[i].texture_2d != cur_state.texture_units[i].texture_2d) { |
| 201 | glActiveTexture(TextureUnits::MaxwellTexture(i).Enum()); | 201 | glActiveTexture(TextureUnits::MaxwellTexture(i).Enum()); |
| 202 | glBindTexture(GL_TEXTURE_2D, texture_units[i].texture_2d); | 202 | glBindTexture(GL_TEXTURE_2D, texture_units[i].texture_2d); |
| 203 | } | 203 | } |
| 204 | if (texture_units[i].sampler != cur_state.texture_units[i].sampler) { | 204 | if (texture_units[i].sampler != cur_state.texture_units[i].sampler) { |
| 205 | glBindSampler(i, texture_units[i].sampler); | 205 | glBindSampler(static_cast<GLuint>(i), texture_units[i].sampler); |
| 206 | } | 206 | } |
| 207 | // Update the texture swizzle | 207 | // Update the texture swizzle |
| 208 | if (texture_units[i].swizzle.r != cur_state.texture_units[i].swizzle.r || | 208 | if (texture_units[i].swizzle.r != cur_state.texture_units[i].swizzle.r || |