diff options
| author | 2019-11-26 14:10:49 -0500 | |
|---|---|---|
| committer | 2019-11-26 21:55:37 -0500 | |
| commit | 536fc7f0ea77e08d68c760f387c307d258804e3b (patch) | |
| tree | e979df531bf1222788cc26144531c6e6f5cca1d1 /src/video_core | |
| parent | core/memory: Move memory read/write implementation functions into an anonymou... (diff) | |
| download | yuzu-536fc7f0ea77e08d68c760f387c307d258804e3b.tar.gz yuzu-536fc7f0ea77e08d68c760f387c307d258804e3b.tar.xz yuzu-536fc7f0ea77e08d68c760f387c307d258804e3b.zip | |
core: Prepare various classes for memory read/write migration
Amends a few interfaces to be able to handle the migration over to the
new Memory class by passing the class by reference as a function
parameter where necessary.
Notably, within the filesystem services, this eliminates two ReadBlock()
calls by using the helper functions of HLERequestContext to do that for
us.
Diffstat (limited to 'src/video_core')
| -rw-r--r-- | src/video_core/rasterizer_accelerated.cpp | 3 | ||||
| -rw-r--r-- | src/video_core/rasterizer_accelerated.h | 9 | ||||
| -rw-r--r-- | src/video_core/renderer_opengl/gl_rasterizer.cpp | 5 | ||||
| -rw-r--r-- | src/video_core/renderer_vulkan/vk_buffer_cache.cpp | 4 | ||||
| -rw-r--r-- | src/video_core/renderer_vulkan/vk_buffer_cache.h | 7 |
5 files changed, 21 insertions, 7 deletions
diff --git a/src/video_core/rasterizer_accelerated.cpp b/src/video_core/rasterizer_accelerated.cpp index b230dcc18..f3dbadebc 100644 --- a/src/video_core/rasterizer_accelerated.cpp +++ b/src/video_core/rasterizer_accelerated.cpp | |||
| @@ -22,7 +22,8 @@ constexpr auto RangeFromInterval(Map& map, const Interval& interval) { | |||
| 22 | 22 | ||
| 23 | } // Anonymous namespace | 23 | } // Anonymous namespace |
| 24 | 24 | ||
| 25 | RasterizerAccelerated::RasterizerAccelerated() = default; | 25 | RasterizerAccelerated::RasterizerAccelerated(Memory::Memory& cpu_memory_) |
| 26 | : cpu_memory{cpu_memory_} {} | ||
| 26 | 27 | ||
| 27 | RasterizerAccelerated::~RasterizerAccelerated() = default; | 28 | RasterizerAccelerated::~RasterizerAccelerated() = default; |
| 28 | 29 | ||
diff --git a/src/video_core/rasterizer_accelerated.h b/src/video_core/rasterizer_accelerated.h index 8f7e3547e..315798e7c 100644 --- a/src/video_core/rasterizer_accelerated.h +++ b/src/video_core/rasterizer_accelerated.h | |||
| @@ -11,12 +11,16 @@ | |||
| 11 | #include "common/common_types.h" | 11 | #include "common/common_types.h" |
| 12 | #include "video_core/rasterizer_interface.h" | 12 | #include "video_core/rasterizer_interface.h" |
| 13 | 13 | ||
| 14 | namespace Memory { | ||
| 15 | class Memory; | ||
| 16 | } | ||
| 17 | |||
| 14 | namespace VideoCore { | 18 | namespace VideoCore { |
| 15 | 19 | ||
| 16 | /// Implements the shared part in GPU accelerated rasterizers in RasterizerInterface. | 20 | /// Implements the shared part in GPU accelerated rasterizers in RasterizerInterface. |
| 17 | class RasterizerAccelerated : public RasterizerInterface { | 21 | class RasterizerAccelerated : public RasterizerInterface { |
| 18 | public: | 22 | public: |
| 19 | explicit RasterizerAccelerated(); | 23 | explicit RasterizerAccelerated(Memory::Memory& cpu_memory_); |
| 20 | ~RasterizerAccelerated() override; | 24 | ~RasterizerAccelerated() override; |
| 21 | 25 | ||
| 22 | void UpdatePagesCachedCount(VAddr addr, u64 size, int delta) override; | 26 | void UpdatePagesCachedCount(VAddr addr, u64 size, int delta) override; |
| @@ -24,8 +28,9 @@ public: | |||
| 24 | private: | 28 | private: |
| 25 | using CachedPageMap = boost::icl::interval_map<u64, int>; | 29 | using CachedPageMap = boost::icl::interval_map<u64, int>; |
| 26 | CachedPageMap cached_pages; | 30 | CachedPageMap cached_pages; |
| 27 | |||
| 28 | std::mutex pages_mutex; | 31 | std::mutex pages_mutex; |
| 32 | |||
| 33 | Memory::Memory& cpu_memory; | ||
| 29 | }; | 34 | }; |
| 30 | 35 | ||
| 31 | } // namespace VideoCore | 36 | } // namespace VideoCore |
diff --git a/src/video_core/renderer_opengl/gl_rasterizer.cpp b/src/video_core/renderer_opengl/gl_rasterizer.cpp index f97ec06f0..85f05544c 100644 --- a/src/video_core/renderer_opengl/gl_rasterizer.cpp +++ b/src/video_core/renderer_opengl/gl_rasterizer.cpp | |||
| @@ -86,8 +86,9 @@ std::size_t GetConstBufferSize(const Tegra::Engines::ConstBufferInfo& buffer, | |||
| 86 | 86 | ||
| 87 | RasterizerOpenGL::RasterizerOpenGL(Core::System& system, Core::Frontend::EmuWindow& emu_window, | 87 | RasterizerOpenGL::RasterizerOpenGL(Core::System& system, Core::Frontend::EmuWindow& emu_window, |
| 88 | ScreenInfo& info) | 88 | ScreenInfo& info) |
| 89 | : texture_cache{system, *this, device}, shader_cache{*this, system, emu_window, device}, | 89 | : RasterizerAccelerated{system.Memory()}, texture_cache{system, *this, device}, |
| 90 | system{system}, screen_info{info}, buffer_cache{*this, system, device, STREAM_BUFFER_SIZE} { | 90 | shader_cache{*this, system, emu_window, device}, system{system}, screen_info{info}, |
| 91 | buffer_cache{*this, system, device, STREAM_BUFFER_SIZE} { | ||
| 91 | shader_program_manager = std::make_unique<GLShader::ProgramManager>(); | 92 | shader_program_manager = std::make_unique<GLShader::ProgramManager>(); |
| 92 | state.draw.shader_program = 0; | 93 | state.draw.shader_program = 0; |
| 93 | state.Apply(); | 94 | state.Apply(); |
diff --git a/src/video_core/renderer_vulkan/vk_buffer_cache.cpp b/src/video_core/renderer_vulkan/vk_buffer_cache.cpp index d2e9f4031..959638747 100644 --- a/src/video_core/renderer_vulkan/vk_buffer_cache.cpp +++ b/src/video_core/renderer_vulkan/vk_buffer_cache.cpp | |||
| @@ -24,9 +24,11 @@ CachedBufferEntry::CachedBufferEntry(VAddr cpu_addr, std::size_t size, u64 offse | |||
| 24 | alignment{alignment} {} | 24 | alignment{alignment} {} |
| 25 | 25 | ||
| 26 | VKBufferCache::VKBufferCache(Tegra::MemoryManager& tegra_memory_manager, | 26 | VKBufferCache::VKBufferCache(Tegra::MemoryManager& tegra_memory_manager, |
| 27 | Memory::Memory& cpu_memory_, | ||
| 27 | VideoCore::RasterizerInterface& rasterizer, const VKDevice& device, | 28 | VideoCore::RasterizerInterface& rasterizer, const VKDevice& device, |
| 28 | VKMemoryManager& memory_manager, VKScheduler& scheduler, u64 size) | 29 | VKMemoryManager& memory_manager, VKScheduler& scheduler, u64 size) |
| 29 | : RasterizerCache{rasterizer}, tegra_memory_manager{tegra_memory_manager} { | 30 | : RasterizerCache{rasterizer}, tegra_memory_manager{tegra_memory_manager}, cpu_memory{ |
| 31 | cpu_memory_} { | ||
| 30 | const auto usage = vk::BufferUsageFlagBits::eVertexBuffer | | 32 | const auto usage = vk::BufferUsageFlagBits::eVertexBuffer | |
| 31 | vk::BufferUsageFlagBits::eIndexBuffer | | 33 | vk::BufferUsageFlagBits::eIndexBuffer | |
| 32 | vk::BufferUsageFlagBits::eUniformBuffer; | 34 | vk::BufferUsageFlagBits::eUniformBuffer; |
diff --git a/src/video_core/renderer_vulkan/vk_buffer_cache.h b/src/video_core/renderer_vulkan/vk_buffer_cache.h index 49f13bcdc..daa8ccf66 100644 --- a/src/video_core/renderer_vulkan/vk_buffer_cache.h +++ b/src/video_core/renderer_vulkan/vk_buffer_cache.h | |||
| @@ -13,6 +13,10 @@ | |||
| 13 | #include "video_core/renderer_vulkan/declarations.h" | 13 | #include "video_core/renderer_vulkan/declarations.h" |
| 14 | #include "video_core/renderer_vulkan/vk_scheduler.h" | 14 | #include "video_core/renderer_vulkan/vk_scheduler.h" |
| 15 | 15 | ||
| 16 | namespace Memory { | ||
| 17 | class Memory; | ||
| 18 | } | ||
| 19 | |||
| 16 | namespace Tegra { | 20 | namespace Tegra { |
| 17 | class MemoryManager; | 21 | class MemoryManager; |
| 18 | } | 22 | } |
| @@ -58,7 +62,7 @@ private: | |||
| 58 | 62 | ||
| 59 | class VKBufferCache final : public RasterizerCache<std::shared_ptr<CachedBufferEntry>> { | 63 | class VKBufferCache final : public RasterizerCache<std::shared_ptr<CachedBufferEntry>> { |
| 60 | public: | 64 | public: |
| 61 | explicit VKBufferCache(Tegra::MemoryManager& tegra_memory_manager, | 65 | explicit VKBufferCache(Tegra::MemoryManager& tegra_memory_manager, Memory::Memory& cpu_memory_, |
| 62 | VideoCore::RasterizerInterface& rasterizer, const VKDevice& device, | 66 | VideoCore::RasterizerInterface& rasterizer, const VKDevice& device, |
| 63 | VKMemoryManager& memory_manager, VKScheduler& scheduler, u64 size); | 67 | VKMemoryManager& memory_manager, VKScheduler& scheduler, u64 size); |
| 64 | ~VKBufferCache(); | 68 | ~VKBufferCache(); |
| @@ -92,6 +96,7 @@ private: | |||
| 92 | void AlignBuffer(std::size_t alignment); | 96 | void AlignBuffer(std::size_t alignment); |
| 93 | 97 | ||
| 94 | Tegra::MemoryManager& tegra_memory_manager; | 98 | Tegra::MemoryManager& tegra_memory_manager; |
| 99 | Memory::Memory& cpu_memory; | ||
| 95 | 100 | ||
| 96 | std::unique_ptr<VKStreamBuffer> stream_buffer; | 101 | std::unique_ptr<VKStreamBuffer> stream_buffer; |
| 97 | vk::Buffer buffer_handle; | 102 | vk::Buffer buffer_handle; |