summaryrefslogtreecommitdiff
path: root/src/video_core
diff options
context:
space:
mode:
authorGravatar bunnei2018-07-03 00:26:45 -0400
committerGravatar GitHub2018-07-03 00:26:45 -0400
commit15e68cdbaac38bbf13cd4eb0d70d1e34b2fd4256 (patch)
tree9d072a572c0037a44e1e35aeffc242d3772a383c /src/video_core
parentMerge pull request #612 from bunnei/fix-cull (diff)
parentFix build and address review feedback (diff)
downloadyuzu-15e68cdbaac38bbf13cd4eb0d70d1e34b2fd4256.tar.gz
yuzu-15e68cdbaac38bbf13cd4eb0d70d1e34b2fd4256.tar.xz
yuzu-15e68cdbaac38bbf13cd4eb0d70d1e34b2fd4256.zip
Merge pull request #607 from jroweboy/logging
Logging - Customizable backends
Diffstat (limited to 'src/video_core')
-rw-r--r--src/video_core/command_processor.cpp12
-rw-r--r--src/video_core/engines/fermi_2d.cpp4
-rw-r--r--src/video_core/engines/maxwell_3d.cpp4
-rw-r--r--src/video_core/engines/maxwell_dma.cpp2
-rw-r--r--src/video_core/renderer_opengl/gl_rasterizer.cpp16
-rw-r--r--src/video_core/renderer_opengl/gl_rasterizer_cache.cpp6
-rw-r--r--src/video_core/renderer_opengl/gl_rasterizer_cache.h14
-rw-r--r--src/video_core/renderer_opengl/gl_shader_decompiler.cpp52
-rw-r--r--src/video_core/renderer_opengl/gl_shader_util.cpp6
-rw-r--r--src/video_core/renderer_opengl/gl_shader_util.h8
-rw-r--r--src/video_core/renderer_opengl/maxwell_to_gl.h29
-rw-r--r--src/video_core/renderer_opengl/renderer_opengl.cpp16
-rw-r--r--src/video_core/video_core.cpp6
13 files changed, 87 insertions, 88 deletions
diff --git a/src/video_core/command_processor.cpp b/src/video_core/command_processor.cpp
index cec9cb9f3..31ea3adad 100644
--- a/src/video_core/command_processor.cpp
+++ b/src/video_core/command_processor.cpp
@@ -29,21 +29,21 @@ enum class BufferMethods {
29}; 29};
30 30
31void GPU::WriteReg(u32 method, u32 subchannel, u32 value, u32 remaining_params) { 31void GPU::WriteReg(u32 method, u32 subchannel, u32 value, u32 remaining_params) {
32 NGLOG_WARNING(HW_GPU, 32 LOG_WARNING(HW_GPU,
33 "Processing method {:08X} on subchannel {} value " 33 "Processing method {:08X} on subchannel {} value "
34 "{:08X} remaining params {}", 34 "{:08X} remaining params {}",
35 method, subchannel, value, remaining_params); 35 method, subchannel, value, remaining_params);
36 36
37 if (method == static_cast<u32>(BufferMethods::BindObject)) { 37 if (method == static_cast<u32>(BufferMethods::BindObject)) {
38 // Bind the current subchannel to the desired engine id. 38 // Bind the current subchannel to the desired engine id.
39 NGLOG_DEBUG(HW_GPU, "Binding subchannel {} to engine {}", subchannel, value); 39 LOG_DEBUG(HW_GPU, "Binding subchannel {} to engine {}", subchannel, value);
40 bound_engines[subchannel] = static_cast<EngineID>(value); 40 bound_engines[subchannel] = static_cast<EngineID>(value);
41 return; 41 return;
42 } 42 }
43 43
44 if (method < static_cast<u32>(BufferMethods::CountBufferMethods)) { 44 if (method < static_cast<u32>(BufferMethods::CountBufferMethods)) {
45 // TODO(Subv): Research and implement these methods. 45 // TODO(Subv): Research and implement these methods.
46 NGLOG_ERROR(HW_GPU, "Special buffer methods other than Bind are not implemented"); 46 LOG_ERROR(HW_GPU, "Special buffer methods other than Bind are not implemented");
47 return; 47 return;
48 } 48 }
49 49
diff --git a/src/video_core/engines/fermi_2d.cpp b/src/video_core/engines/fermi_2d.cpp
index 998b7c843..34053e393 100644
--- a/src/video_core/engines/fermi_2d.cpp
+++ b/src/video_core/engines/fermi_2d.cpp
@@ -26,8 +26,8 @@ void Fermi2D::WriteReg(u32 method, u32 value) {
26} 26}
27 27
28void Fermi2D::HandleSurfaceCopy() { 28void Fermi2D::HandleSurfaceCopy() {
29 NGLOG_WARNING(HW_GPU, "Requested a surface copy with operation {}", 29 LOG_WARNING(HW_GPU, "Requested a surface copy with operation {}",
30 static_cast<u32>(regs.operation)); 30 static_cast<u32>(regs.operation));
31 31
32 const GPUVAddr source = regs.src.Address(); 32 const GPUVAddr source = regs.src.Address();
33 const GPUVAddr dest = regs.dst.Address(); 33 const GPUVAddr dest = regs.dst.Address();
diff --git a/src/video_core/engines/maxwell_3d.cpp b/src/video_core/engines/maxwell_3d.cpp
index 93c43c8cb..9b209a49e 100644
--- a/src/video_core/engines/maxwell_3d.cpp
+++ b/src/video_core/engines/maxwell_3d.cpp
@@ -207,8 +207,8 @@ void Maxwell3D::ProcessQueryGet() {
207} 207}
208 208
209void Maxwell3D::DrawArrays() { 209void Maxwell3D::DrawArrays() {
210 NGLOG_DEBUG(HW_GPU, "called, topology={}, count={}", 210 LOG_DEBUG(HW_GPU, "called, topology={}, count={}", static_cast<u32>(regs.draw.topology.Value()),
211 static_cast<u32>(regs.draw.topology.Value()), regs.vertex_buffer.count); 211 regs.vertex_buffer.count);
212 ASSERT_MSG(!(regs.index_array.count && regs.vertex_buffer.count), "Both indexed and direct?"); 212 ASSERT_MSG(!(regs.index_array.count && regs.vertex_buffer.count), "Both indexed and direct?");
213 213
214 auto debug_context = Core::System::GetInstance().GetGPUDebugContext(); 214 auto debug_context = Core::System::GetInstance().GetGPUDebugContext();
diff --git a/src/video_core/engines/maxwell_dma.cpp b/src/video_core/engines/maxwell_dma.cpp
index c298f0bfb..6e740713f 100644
--- a/src/video_core/engines/maxwell_dma.cpp
+++ b/src/video_core/engines/maxwell_dma.cpp
@@ -31,7 +31,7 @@ void MaxwellDMA::WriteReg(u32 method, u32 value) {
31} 31}
32 32
33void MaxwellDMA::HandleCopy() { 33void MaxwellDMA::HandleCopy() {
34 NGLOG_WARNING(HW_GPU, "Requested a DMA copy"); 34 LOG_WARNING(HW_GPU, "Requested a DMA copy");
35 35
36 const GPUVAddr source = regs.src_address.Address(); 36 const GPUVAddr source = regs.src_address.Address();
37 const GPUVAddr dest = regs.dst_address.Address(); 37 const GPUVAddr dest = regs.dst_address.Address();
diff --git a/src/video_core/renderer_opengl/gl_rasterizer.cpp b/src/video_core/renderer_opengl/gl_rasterizer.cpp
index dea88dfce..c7b7a5817 100644
--- a/src/video_core/renderer_opengl/gl_rasterizer.cpp
+++ b/src/video_core/renderer_opengl/gl_rasterizer.cpp
@@ -112,7 +112,7 @@ RasterizerOpenGL::RasterizerOpenGL() {
112 112
113 glEnable(GL_BLEND); 113 glEnable(GL_BLEND);
114 114
115 NGLOG_CRITICAL(Render_OpenGL, "Sync fixed function OpenGL state here!"); 115 LOG_CRITICAL(Render_OpenGL, "Sync fixed function OpenGL state here!");
116} 116}
117 117
118RasterizerOpenGL::~RasterizerOpenGL() { 118RasterizerOpenGL::~RasterizerOpenGL() {
@@ -165,9 +165,9 @@ std::pair<u8*, GLintptr> RasterizerOpenGL::SetupVertexArrays(u8* array_ptr,
165 // assume every shader uses them all. 165 // assume every shader uses them all.
166 for (unsigned index = 0; index < 16; ++index) { 166 for (unsigned index = 0; index < 16; ++index) {
167 auto& attrib = regs.vertex_attrib_format[index]; 167 auto& attrib = regs.vertex_attrib_format[index];
168 NGLOG_DEBUG(HW_GPU, "vertex attrib {}, count={}, size={}, type={}, offset={}, normalize={}", 168 LOG_DEBUG(HW_GPU, "vertex attrib {}, count={}, size={}, type={}, offset={}, normalize={}",
169 index, attrib.ComponentCount(), attrib.SizeString(), attrib.TypeString(), 169 index, attrib.ComponentCount(), attrib.SizeString(), attrib.TypeString(),
170 attrib.offset.Value(), attrib.IsNormalized()); 170 attrib.offset.Value(), attrib.IsNormalized());
171 171
172 auto& buffer = regs.vertex_array[attrib.buffer]; 172 auto& buffer = regs.vertex_array[attrib.buffer];
173 ASSERT(buffer.IsEnabled()); 173 ASSERT(buffer.IsEnabled());
@@ -251,8 +251,8 @@ void RasterizerOpenGL::SetupShaders(u8* buffer_ptr, GLintptr buffer_offset) {
251 break; 251 break;
252 } 252 }
253 default: 253 default:
254 NGLOG_CRITICAL(HW_GPU, "Unimplemented shader index={}, enable={}, offset=0x{:08X}", 254 LOG_CRITICAL(HW_GPU, "Unimplemented shader index={}, enable={}, offset=0x{:08X}", index,
255 index, shader_config.enable.Value(), shader_config.offset); 255 shader_config.enable.Value(), shader_config.offset);
256 UNREACHABLE(); 256 UNREACHABLE();
257 } 257 }
258 258
@@ -587,8 +587,8 @@ u32 RasterizerOpenGL::SetupConstBuffers(Maxwell::ShaderStage stage, GLuint progr
587 size = buffer.size * sizeof(float); 587 size = buffer.size * sizeof(float);
588 588
589 if (size > MaxConstbufferSize) { 589 if (size > MaxConstbufferSize) {
590 NGLOG_ERROR(HW_GPU, "indirect constbuffer size {} exceeds maximum {}", size, 590 LOG_ERROR(HW_GPU, "indirect constbuffer size {} exceeds maximum {}", size,
591 MaxConstbufferSize); 591 MaxConstbufferSize);
592 size = MaxConstbufferSize; 592 size = MaxConstbufferSize;
593 } 593 }
594 } else { 594 } else {
diff --git a/src/video_core/renderer_opengl/gl_rasterizer_cache.cpp b/src/video_core/renderer_opengl/gl_rasterizer_cache.cpp
index 851ebc263..f9b4a4b87 100644
--- a/src/video_core/renderer_opengl/gl_rasterizer_cache.cpp
+++ b/src/video_core/renderer_opengl/gl_rasterizer_cache.cpp
@@ -117,7 +117,7 @@ static std::pair<u32, u32> GetASTCBlockSize(PixelFormat format) {
117 case PixelFormat::ASTC_2D_4X4: 117 case PixelFormat::ASTC_2D_4X4:
118 return {4, 4}; 118 return {4, 4};
119 default: 119 default:
120 NGLOG_CRITICAL(HW_GPU, "Unhandled format: {}", static_cast<u32>(format)); 120 LOG_CRITICAL(HW_GPU, "Unhandled format: {}", static_cast<u32>(format));
121 UNREACHABLE(); 121 UNREACHABLE();
122 } 122 }
123} 123}
@@ -159,7 +159,7 @@ void MortonCopy(u32 stride, u32 block_height, u32 height, u8* gl_buffer, Tegra::
159 } else { 159 } else {
160 // TODO(bunnei): Assumes the default rendering GOB size of 16 (128 lines). We should 160 // TODO(bunnei): Assumes the default rendering GOB size of 16 (128 lines). We should
161 // check the configuration for this and perform more generic un/swizzle 161 // check the configuration for this and perform more generic un/swizzle
162 NGLOG_WARNING(Render_OpenGL, "need to use correct swizzle/GOB parameters!"); 162 LOG_WARNING(Render_OpenGL, "need to use correct swizzle/GOB parameters!");
163 VideoCore::MortonCopyPixels128( 163 VideoCore::MortonCopyPixels128(
164 stride, height, bytes_per_pixel, gl_bytes_per_pixel, 164 stride, height, bytes_per_pixel, gl_bytes_per_pixel,
165 Memory::GetPointer(*gpu.memory_manager->GpuToCpuAddress(addr)), gl_buffer, 165 Memory::GetPointer(*gpu.memory_manager->GpuToCpuAddress(addr)), gl_buffer,
@@ -396,7 +396,7 @@ SurfaceSurfaceRect_Tuple RasterizerCacheOpenGL::GetFramebufferSurfaces(
396 const auto& regs = Core::System().GetInstance().GPU().Maxwell3D().regs; 396 const auto& regs = Core::System().GetInstance().GPU().Maxwell3D().regs;
397 397
398 // TODO(bunnei): This is hard corded to use just the first render buffer 398 // TODO(bunnei): This is hard corded to use just the first render buffer
399 NGLOG_WARNING(Render_OpenGL, "hard-coded for render target 0!"); 399 LOG_WARNING(Render_OpenGL, "hard-coded for render target 0!");
400 400
401 // get color and depth surfaces 401 // get color and depth surfaces
402 const SurfaceParams color_params{SurfaceParams::CreateForFramebuffer(regs.rt[0])}; 402 const SurfaceParams color_params{SurfaceParams::CreateForFramebuffer(regs.rt[0])};
diff --git a/src/video_core/renderer_opengl/gl_rasterizer_cache.h b/src/video_core/renderer_opengl/gl_rasterizer_cache.h
index eea432b0b..459abbdc2 100644
--- a/src/video_core/renderer_opengl/gl_rasterizer_cache.h
+++ b/src/video_core/renderer_opengl/gl_rasterizer_cache.h
@@ -131,7 +131,7 @@ struct SurfaceParams {
131 case Tegra::DepthFormat::Z24_S8_UNORM: 131 case Tegra::DepthFormat::Z24_S8_UNORM:
132 return PixelFormat::Z24S8; 132 return PixelFormat::Z24S8;
133 default: 133 default:
134 NGLOG_CRITICAL(HW_GPU, "Unimplemented format={}", static_cast<u32>(format)); 134 LOG_CRITICAL(HW_GPU, "Unimplemented format={}", static_cast<u32>(format));
135 UNREACHABLE(); 135 UNREACHABLE();
136 } 136 }
137 } 137 }
@@ -150,7 +150,7 @@ struct SurfaceParams {
150 case Tegra::RenderTargetFormat::RGBA32_UINT: 150 case Tegra::RenderTargetFormat::RGBA32_UINT:
151 return PixelFormat::RGBA32UI; 151 return PixelFormat::RGBA32UI;
152 default: 152 default:
153 NGLOG_CRITICAL(HW_GPU, "Unimplemented format={}", static_cast<u32>(format)); 153 LOG_CRITICAL(HW_GPU, "Unimplemented format={}", static_cast<u32>(format));
154 UNREACHABLE(); 154 UNREACHABLE();
155 } 155 }
156 } 156 }
@@ -185,7 +185,7 @@ struct SurfaceParams {
185 case Tegra::Texture::TextureFormat::ASTC_2D_4X4: 185 case Tegra::Texture::TextureFormat::ASTC_2D_4X4:
186 return PixelFormat::ASTC_2D_4X4; 186 return PixelFormat::ASTC_2D_4X4;
187 default: 187 default:
188 NGLOG_CRITICAL(HW_GPU, "Unimplemented format={}", static_cast<u32>(format)); 188 LOG_CRITICAL(HW_GPU, "Unimplemented format={}", static_cast<u32>(format));
189 UNREACHABLE(); 189 UNREACHABLE();
190 } 190 }
191 } 191 }
@@ -239,7 +239,7 @@ struct SurfaceParams {
239 case Tegra::Texture::ComponentType::UNORM: 239 case Tegra::Texture::ComponentType::UNORM:
240 return ComponentType::UNorm; 240 return ComponentType::UNorm;
241 default: 241 default:
242 NGLOG_CRITICAL(HW_GPU, "Unimplemented component type={}", static_cast<u32>(type)); 242 LOG_CRITICAL(HW_GPU, "Unimplemented component type={}", static_cast<u32>(type));
243 UNREACHABLE(); 243 UNREACHABLE();
244 } 244 }
245 } 245 }
@@ -257,7 +257,7 @@ struct SurfaceParams {
257 case Tegra::RenderTargetFormat::RGBA32_UINT: 257 case Tegra::RenderTargetFormat::RGBA32_UINT:
258 return ComponentType::UInt; 258 return ComponentType::UInt;
259 default: 259 default:
260 NGLOG_CRITICAL(HW_GPU, "Unimplemented format={}", static_cast<u32>(format)); 260 LOG_CRITICAL(HW_GPU, "Unimplemented format={}", static_cast<u32>(format));
261 UNREACHABLE(); 261 UNREACHABLE();
262 } 262 }
263 } 263 }
@@ -267,7 +267,7 @@ struct SurfaceParams {
267 case Tegra::FramebufferConfig::PixelFormat::ABGR8: 267 case Tegra::FramebufferConfig::PixelFormat::ABGR8:
268 return PixelFormat::ABGR8; 268 return PixelFormat::ABGR8;
269 default: 269 default:
270 NGLOG_CRITICAL(HW_GPU, "Unimplemented format={}", static_cast<u32>(format)); 270 LOG_CRITICAL(HW_GPU, "Unimplemented format={}", static_cast<u32>(format));
271 UNREACHABLE(); 271 UNREACHABLE();
272 } 272 }
273 } 273 }
@@ -277,7 +277,7 @@ struct SurfaceParams {
277 case Tegra::DepthFormat::Z24_S8_UNORM: 277 case Tegra::DepthFormat::Z24_S8_UNORM:
278 return ComponentType::UNorm; 278 return ComponentType::UNorm;
279 default: 279 default:
280 NGLOG_CRITICAL(HW_GPU, "Unimplemented format={}", static_cast<u32>(format)); 280 LOG_CRITICAL(HW_GPU, "Unimplemented format={}", static_cast<u32>(format));
281 UNREACHABLE(); 281 UNREACHABLE();
282 } 282 }
283 } 283 }
diff --git a/src/video_core/renderer_opengl/gl_shader_decompiler.cpp b/src/video_core/renderer_opengl/gl_shader_decompiler.cpp
index 8e5465f40..ec9956edb 100644
--- a/src/video_core/renderer_opengl/gl_shader_decompiler.cpp
+++ b/src/video_core/renderer_opengl/gl_shader_decompiler.cpp
@@ -283,7 +283,7 @@ public:
283 // Default - do nothing 283 // Default - do nothing
284 return value; 284 return value;
285 default: 285 default:
286 NGLOG_CRITICAL(HW_GPU, "Unimplemented conversion size {}", static_cast<u32>(size)); 286 LOG_CRITICAL(HW_GPU, "Unimplemented conversion size {}", static_cast<u32>(size));
287 UNREACHABLE(); 287 UNREACHABLE();
288 } 288 }
289 } 289 }
@@ -581,7 +581,7 @@ private:
581 return "input_attribute_" + std::to_string(index); 581 return "input_attribute_" + std::to_string(index);
582 } 582 }
583 583
584 NGLOG_CRITICAL(HW_GPU, "Unhandled input attribute: {}", index); 584 LOG_CRITICAL(HW_GPU, "Unhandled input attribute: {}", index);
585 UNREACHABLE(); 585 UNREACHABLE();
586 } 586 }
587 } 587 }
@@ -599,7 +599,7 @@ private:
599 return "output_attribute_" + std::to_string(index); 599 return "output_attribute_" + std::to_string(index);
600 } 600 }
601 601
602 NGLOG_CRITICAL(HW_GPU, "Unhandled output attribute: {}", index); 602 LOG_CRITICAL(HW_GPU, "Unhandled output attribute: {}", index);
603 UNREACHABLE(); 603 UNREACHABLE();
604 } 604 }
605 } 605 }
@@ -797,7 +797,7 @@ private:
797 break; 797 break;
798 } 798 }
799 default: 799 default:
800 NGLOG_CRITICAL(HW_GPU, "Unimplemented logic operation: {}", static_cast<u32>(logic_op)); 800 LOG_CRITICAL(HW_GPU, "Unimplemented logic operation: {}", static_cast<u32>(logic_op));
801 UNREACHABLE(); 801 UNREACHABLE();
802 } 802 }
803 } 803 }
@@ -819,7 +819,7 @@ private:
819 819
820 // Decoding failure 820 // Decoding failure
821 if (!opcode) { 821 if (!opcode) {
822 NGLOG_CRITICAL(HW_GPU, "Unhandled instruction: {0:x}", instr.value); 822 LOG_CRITICAL(HW_GPU, "Unhandled instruction: {0:x}", instr.value);
823 UNREACHABLE(); 823 UNREACHABLE();
824 return offset + 1; 824 return offset + 1;
825 } 825 }
@@ -922,8 +922,8 @@ private:
922 instr.alu.saturate_d); 922 instr.alu.saturate_d);
923 break; 923 break;
924 default: 924 default:
925 NGLOG_CRITICAL(HW_GPU, "Unhandled MUFU sub op: {0:x}", 925 LOG_CRITICAL(HW_GPU, "Unhandled MUFU sub op: {0:x}",
926 static_cast<unsigned>(instr.sub_op.Value())); 926 static_cast<unsigned>(instr.sub_op.Value()));
927 UNREACHABLE(); 927 UNREACHABLE();
928 } 928 }
929 break; 929 break;
@@ -946,11 +946,11 @@ private:
946 // Currently RRO is only implemented as a register move. 946 // Currently RRO is only implemented as a register move.
947 // Usage of `abs_b` and `negate_b` here should also be correct. 947 // Usage of `abs_b` and `negate_b` here should also be correct.
948 regs.SetRegisterToFloat(instr.gpr0, 0, op_b, 1, 1); 948 regs.SetRegisterToFloat(instr.gpr0, 0, op_b, 1, 1);
949 NGLOG_WARNING(HW_GPU, "RRO instruction is incomplete"); 949 LOG_WARNING(HW_GPU, "RRO instruction is incomplete");
950 break; 950 break;
951 } 951 }
952 default: { 952 default: {
953 NGLOG_CRITICAL(HW_GPU, "Unhandled arithmetic instruction: {}", opcode->GetName()); 953 LOG_CRITICAL(HW_GPU, "Unhandled arithmetic instruction: {}", opcode->GetName());
954 UNREACHABLE(); 954 UNREACHABLE();
955 } 955 }
956 } 956 }
@@ -989,7 +989,7 @@ private:
989 break; 989 break;
990 } 990 }
991 default: { 991 default: {
992 NGLOG_CRITICAL(HW_GPU, "Unhandled BFE instruction: {}", opcode->GetName()); 992 LOG_CRITICAL(HW_GPU, "Unhandled BFE instruction: {}", opcode->GetName());
993 UNREACHABLE(); 993 UNREACHABLE();
994 } 994 }
995 } 995 }
@@ -1032,7 +1032,7 @@ private:
1032 regs.SetRegisterToInteger(instr.gpr0, true, 0, op_a + " << " + op_b, 1, 1); 1032 regs.SetRegisterToInteger(instr.gpr0, true, 0, op_a + " << " + op_b, 1, 1);
1033 break; 1033 break;
1034 default: { 1034 default: {
1035 NGLOG_CRITICAL(HW_GPU, "Unhandled shift instruction: {}", opcode->GetName()); 1035 LOG_CRITICAL(HW_GPU, "Unhandled shift instruction: {}", opcode->GetName());
1036 UNREACHABLE(); 1036 UNREACHABLE();
1037 } 1037 }
1038 } 1038 }
@@ -1062,8 +1062,8 @@ private:
1062 break; 1062 break;
1063 } 1063 }
1064 default: { 1064 default: {
1065 NGLOG_CRITICAL(HW_GPU, "Unhandled ArithmeticIntegerImmediate instruction: {}", 1065 LOG_CRITICAL(HW_GPU, "Unhandled ArithmeticIntegerImmediate instruction: {}",
1066 opcode->GetName()); 1066 opcode->GetName());
1067 UNREACHABLE(); 1067 UNREACHABLE();
1068 } 1068 }
1069 } 1069 }
@@ -1128,8 +1128,8 @@ private:
1128 break; 1128 break;
1129 } 1129 }
1130 default: { 1130 default: {
1131 NGLOG_CRITICAL(HW_GPU, "Unhandled ArithmeticInteger instruction: {}", 1131 LOG_CRITICAL(HW_GPU, "Unhandled ArithmeticInteger instruction: {}",
1132 opcode->GetName()); 1132 opcode->GetName());
1133 UNREACHABLE(); 1133 UNREACHABLE();
1134 } 1134 }
1135 } 1135 }
@@ -1165,7 +1165,7 @@ private:
1165 break; 1165 break;
1166 } 1166 }
1167 default: { 1167 default: {
1168 NGLOG_CRITICAL(HW_GPU, "Unhandled FFMA instruction: {}", opcode->GetName()); 1168 LOG_CRITICAL(HW_GPU, "Unhandled FFMA instruction: {}", opcode->GetName());
1169 UNREACHABLE(); 1169 UNREACHABLE();
1170 } 1170 }
1171 } 1171 }
@@ -1223,8 +1223,8 @@ private:
1223 op_a = "trunc(" + op_a + ')'; 1223 op_a = "trunc(" + op_a + ')';
1224 break; 1224 break;
1225 default: 1225 default:
1226 NGLOG_CRITICAL(HW_GPU, "Unimplemented f2f rounding mode {}", 1226 LOG_CRITICAL(HW_GPU, "Unimplemented f2f rounding mode {}",
1227 static_cast<u32>(instr.conversion.f2f.rounding.Value())); 1227 static_cast<u32>(instr.conversion.f2f.rounding.Value()));
1228 UNREACHABLE(); 1228 UNREACHABLE();
1229 break; 1229 break;
1230 } 1230 }
@@ -1257,8 +1257,8 @@ private:
1257 op_a = "trunc(" + op_a + ')'; 1257 op_a = "trunc(" + op_a + ')';
1258 break; 1258 break;
1259 default: 1259 default:
1260 NGLOG_CRITICAL(HW_GPU, "Unimplemented f2i rounding mode {}", 1260 LOG_CRITICAL(HW_GPU, "Unimplemented f2i rounding mode {}",
1261 static_cast<u32>(instr.conversion.f2i.rounding.Value())); 1261 static_cast<u32>(instr.conversion.f2i.rounding.Value()));
1262 UNREACHABLE(); 1262 UNREACHABLE();
1263 break; 1263 break;
1264 } 1264 }
@@ -1274,7 +1274,7 @@ private:
1274 break; 1274 break;
1275 } 1275 }
1276 default: { 1276 default: {
1277 NGLOG_CRITICAL(HW_GPU, "Unhandled conversion instruction: {}", opcode->GetName()); 1277 LOG_CRITICAL(HW_GPU, "Unhandled conversion instruction: {}", opcode->GetName());
1278 UNREACHABLE(); 1278 UNREACHABLE();
1279 } 1279 }
1280 } 1280 }
@@ -1309,8 +1309,8 @@ private:
1309 break; 1309 break;
1310 1310
1311 default: 1311 default:
1312 NGLOG_CRITICAL(HW_GPU, "Unhandled type: {}", 1312 LOG_CRITICAL(HW_GPU, "Unhandled type: {}",
1313 static_cast<unsigned>(instr.ld_c.type.Value())); 1313 static_cast<unsigned>(instr.ld_c.type.Value()));
1314 UNREACHABLE(); 1314 UNREACHABLE();
1315 } 1315 }
1316 break; 1316 break;
@@ -1383,7 +1383,7 @@ private:
1383 break; 1383 break;
1384 } 1384 }
1385 default: { 1385 default: {
1386 NGLOG_CRITICAL(HW_GPU, "Unhandled memory instruction: {}", opcode->GetName()); 1386 LOG_CRITICAL(HW_GPU, "Unhandled memory instruction: {}", opcode->GetName());
1387 UNREACHABLE(); 1387 UNREACHABLE();
1388 } 1388 }
1389 } 1389 }
@@ -1600,7 +1600,7 @@ private:
1600 break; 1600 break;
1601 } 1601 }
1602 default: { 1602 default: {
1603 NGLOG_CRITICAL(HW_GPU, "Unhandled instruction: {}", opcode->GetName()); 1603 LOG_CRITICAL(HW_GPU, "Unhandled instruction: {}", opcode->GetName());
1604 UNREACHABLE(); 1604 UNREACHABLE();
1605 } 1605 }
1606 } 1606 }
@@ -1740,7 +1740,7 @@ boost::optional<ProgramResult> DecompileProgram(const ProgramCode& program_code,
1740 GLSLGenerator generator(subroutines, program_code, main_offset, stage); 1740 GLSLGenerator generator(subroutines, program_code, main_offset, stage);
1741 return ProgramResult{generator.GetShaderCode(), generator.GetEntries()}; 1741 return ProgramResult{generator.GetShaderCode(), generator.GetEntries()};
1742 } catch (const DecompileFail& exception) { 1742 } catch (const DecompileFail& exception) {
1743 NGLOG_ERROR(HW_GPU, "Shader decompilation failed: {}", exception.what()); 1743 LOG_ERROR(HW_GPU, "Shader decompilation failed: {}", exception.what());
1744 } 1744 }
1745 return boost::none; 1745 return boost::none;
1746} 1746}
diff --git a/src/video_core/renderer_opengl/gl_shader_util.cpp b/src/video_core/renderer_opengl/gl_shader_util.cpp
index 8568fface..3c087d638 100644
--- a/src/video_core/renderer_opengl/gl_shader_util.cpp
+++ b/src/video_core/renderer_opengl/gl_shader_util.cpp
@@ -27,7 +27,7 @@ GLuint LoadShader(const char* source, GLenum type) {
27 } 27 }
28 GLuint shader_id = glCreateShader(type); 28 GLuint shader_id = glCreateShader(type);
29 glShaderSource(shader_id, 1, &source, nullptr); 29 glShaderSource(shader_id, 1, &source, nullptr);
30 NGLOG_DEBUG(Render_OpenGL, "Compiling {} shader...", debug_type); 30 LOG_DEBUG(Render_OpenGL, "Compiling {} shader...", debug_type);
31 glCompileShader(shader_id); 31 glCompileShader(shader_id);
32 32
33 GLint result = GL_FALSE; 33 GLint result = GL_FALSE;
@@ -39,9 +39,9 @@ GLuint LoadShader(const char* source, GLenum type) {
39 std::string shader_error(info_log_length, ' '); 39 std::string shader_error(info_log_length, ' ');
40 glGetShaderInfoLog(shader_id, info_log_length, nullptr, &shader_error[0]); 40 glGetShaderInfoLog(shader_id, info_log_length, nullptr, &shader_error[0]);
41 if (result == GL_TRUE) { 41 if (result == GL_TRUE) {
42 NGLOG_DEBUG(Render_OpenGL, "{}", shader_error); 42 LOG_DEBUG(Render_OpenGL, "{}", shader_error);
43 } else { 43 } else {
44 NGLOG_ERROR(Render_OpenGL, "Error compiling {} shader:\n{}", debug_type, shader_error); 44 LOG_ERROR(Render_OpenGL, "Error compiling {} shader:\n{}", debug_type, shader_error);
45 } 45 }
46 } 46 }
47 return shader_id; 47 return shader_id;
diff --git a/src/video_core/renderer_opengl/gl_shader_util.h b/src/video_core/renderer_opengl/gl_shader_util.h
index 2036a06a9..0e4d782e2 100644
--- a/src/video_core/renderer_opengl/gl_shader_util.h
+++ b/src/video_core/renderer_opengl/gl_shader_util.h
@@ -29,7 +29,7 @@ void LogShaderSource(T... shaders) {
29 29
30 std::string source(source_length, ' '); 30 std::string source(source_length, ' ');
31 glGetShaderSource(shader, source_length, nullptr, &source[0]); 31 glGetShaderSource(shader, source_length, nullptr, &source[0]);
32 NGLOG_INFO(Render_OpenGL, "Shader source {}", source); 32 LOG_INFO(Render_OpenGL, "Shader source {}", source);
33 } 33 }
34} 34}
35 35
@@ -49,7 +49,7 @@ GLuint LoadShader(const char* source, GLenum type);
49template <typename... T> 49template <typename... T>
50GLuint LoadProgram(bool separable_program, T... shaders) { 50GLuint LoadProgram(bool separable_program, T... shaders) {
51 // Link the program 51 // Link the program
52 NGLOG_DEBUG(Render_OpenGL, "Linking program..."); 52 LOG_DEBUG(Render_OpenGL, "Linking program...");
53 53
54 GLuint program_id = glCreateProgram(); 54 GLuint program_id = glCreateProgram();
55 55
@@ -71,9 +71,9 @@ GLuint LoadProgram(bool separable_program, T... shaders) {
71 std::string program_error(info_log_length, ' '); 71 std::string program_error(info_log_length, ' ');
72 glGetProgramInfoLog(program_id, info_log_length, nullptr, &program_error[0]); 72 glGetProgramInfoLog(program_id, info_log_length, nullptr, &program_error[0]);
73 if (result == GL_TRUE) { 73 if (result == GL_TRUE) {
74 NGLOG_DEBUG(Render_OpenGL, "{}", program_error); 74 LOG_DEBUG(Render_OpenGL, "{}", program_error);
75 } else { 75 } else {
76 NGLOG_ERROR(Render_OpenGL, "Error linking shader:\n{}", program_error); 76 LOG_ERROR(Render_OpenGL, "Error linking shader:\n{}", program_error);
77 } 77 }
78 } 78 }
79 79
diff --git a/src/video_core/renderer_opengl/maxwell_to_gl.h b/src/video_core/renderer_opengl/maxwell_to_gl.h
index 392041a1c..6b9bb3df1 100644
--- a/src/video_core/renderer_opengl/maxwell_to_gl.h
+++ b/src/video_core/renderer_opengl/maxwell_to_gl.h
@@ -31,7 +31,7 @@ inline GLenum VertexType(Maxwell::VertexAttribute attrib) {
31 return GL_UNSIGNED_BYTE; 31 return GL_UNSIGNED_BYTE;
32 } 32 }
33 33
34 NGLOG_CRITICAL(Render_OpenGL, "Unimplemented vertex size={}", attrib.SizeString()); 34 LOG_CRITICAL(Render_OpenGL, "Unimplemented vertex size={}", attrib.SizeString());
35 UNREACHABLE(); 35 UNREACHABLE();
36 return {}; 36 return {};
37 } 37 }
@@ -43,7 +43,7 @@ inline GLenum VertexType(Maxwell::VertexAttribute attrib) {
43 return GL_BYTE; 43 return GL_BYTE;
44 } 44 }
45 45
46 NGLOG_CRITICAL(Render_OpenGL, "Unimplemented vertex size={}", attrib.SizeString()); 46 LOG_CRITICAL(Render_OpenGL, "Unimplemented vertex size={}", attrib.SizeString());
47 UNREACHABLE(); 47 UNREACHABLE();
48 return {}; 48 return {};
49 } 49 }
@@ -52,7 +52,7 @@ inline GLenum VertexType(Maxwell::VertexAttribute attrib) {
52 return GL_FLOAT; 52 return GL_FLOAT;
53 } 53 }
54 54
55 NGLOG_CRITICAL(Render_OpenGL, "Unimplemented vertex type={}", attrib.TypeString()); 55 LOG_CRITICAL(Render_OpenGL, "Unimplemented vertex type={}", attrib.TypeString());
56 UNREACHABLE(); 56 UNREACHABLE();
57 return {}; 57 return {};
58} 58}
@@ -66,7 +66,7 @@ inline GLenum IndexFormat(Maxwell::IndexFormat index_format) {
66 case Maxwell::IndexFormat::UnsignedInt: 66 case Maxwell::IndexFormat::UnsignedInt:
67 return GL_UNSIGNED_INT; 67 return GL_UNSIGNED_INT;
68 } 68 }
69 NGLOG_CRITICAL(Render_OpenGL, "Unimplemented index_format={}", static_cast<u32>(index_format)); 69 LOG_CRITICAL(Render_OpenGL, "Unimplemented index_format={}", static_cast<u32>(index_format));
70 UNREACHABLE(); 70 UNREACHABLE();
71 return {}; 71 return {};
72} 72}
@@ -78,7 +78,7 @@ inline GLenum PrimitiveTopology(Maxwell::PrimitiveTopology topology) {
78 case Maxwell::PrimitiveTopology::TriangleStrip: 78 case Maxwell::PrimitiveTopology::TriangleStrip:
79 return GL_TRIANGLE_STRIP; 79 return GL_TRIANGLE_STRIP;
80 } 80 }
81 NGLOG_CRITICAL(Render_OpenGL, "Unimplemented topology={}", static_cast<u32>(topology)); 81 LOG_CRITICAL(Render_OpenGL, "Unimplemented topology={}", static_cast<u32>(topology));
82 UNREACHABLE(); 82 UNREACHABLE();
83 return {}; 83 return {};
84} 84}
@@ -90,8 +90,8 @@ inline GLenum TextureFilterMode(Tegra::Texture::TextureFilter filter_mode) {
90 case Tegra::Texture::TextureFilter::Nearest: 90 case Tegra::Texture::TextureFilter::Nearest:
91 return GL_NEAREST; 91 return GL_NEAREST;
92 } 92 }
93 NGLOG_CRITICAL(Render_OpenGL, "Unimplemented texture filter mode={}", 93 LOG_CRITICAL(Render_OpenGL, "Unimplemented texture filter mode={}",
94 static_cast<u32>(filter_mode)); 94 static_cast<u32>(filter_mode));
95 UNREACHABLE(); 95 UNREACHABLE();
96 return {}; 96 return {};
97} 97}
@@ -110,8 +110,7 @@ inline GLenum WrapMode(Tegra::Texture::WrapMode wrap_mode) {
110 // manually mix them. However the shader part of this is not yet implemented. 110 // manually mix them. However the shader part of this is not yet implemented.
111 return GL_CLAMP_TO_BORDER; 111 return GL_CLAMP_TO_BORDER;
112 } 112 }
113 NGLOG_CRITICAL(Render_OpenGL, "Unimplemented texture wrap mode={}", 113 LOG_CRITICAL(Render_OpenGL, "Unimplemented texture wrap mode={}", static_cast<u32>(wrap_mode));
114 static_cast<u32>(wrap_mode));
115 UNREACHABLE(); 114 UNREACHABLE();
116 return {}; 115 return {};
117} 116}
@@ -129,7 +128,7 @@ inline GLenum BlendEquation(Maxwell::Blend::Equation equation) {
129 case Maxwell::Blend::Equation::Max: 128 case Maxwell::Blend::Equation::Max:
130 return GL_MAX; 129 return GL_MAX;
131 } 130 }
132 NGLOG_CRITICAL(Render_OpenGL, "Unimplemented blend equation={}", static_cast<u32>(equation)); 131 LOG_CRITICAL(Render_OpenGL, "Unimplemented blend equation={}", static_cast<u32>(equation));
133 UNREACHABLE(); 132 UNREACHABLE();
134 return {}; 133 return {};
135} 134}
@@ -175,7 +174,7 @@ inline GLenum BlendFunc(Maxwell::Blend::Factor factor) {
175 case Maxwell::Blend::Factor::OneMinusConstantAlpha: 174 case Maxwell::Blend::Factor::OneMinusConstantAlpha:
176 return GL_ONE_MINUS_CONSTANT_ALPHA; 175 return GL_ONE_MINUS_CONSTANT_ALPHA;
177 } 176 }
178 NGLOG_CRITICAL(Render_OpenGL, "Unimplemented blend factor={}", static_cast<u32>(factor)); 177 LOG_CRITICAL(Render_OpenGL, "Unimplemented blend factor={}", static_cast<u32>(factor));
179 UNREACHABLE(); 178 UNREACHABLE();
180 return {}; 179 return {};
181} 180}
@@ -196,7 +195,7 @@ inline GLenum SwizzleSource(Tegra::Texture::SwizzleSource source) {
196 case Tegra::Texture::SwizzleSource::OneFloat: 195 case Tegra::Texture::SwizzleSource::OneFloat:
197 return GL_ONE; 196 return GL_ONE;
198 } 197 }
199 NGLOG_CRITICAL(Render_OpenGL, "Unimplemented swizzle source={}", static_cast<u32>(source)); 198 LOG_CRITICAL(Render_OpenGL, "Unimplemented swizzle source={}", static_cast<u32>(source));
200 UNREACHABLE(); 199 UNREACHABLE();
201 return {}; 200 return {};
202} 201}
@@ -220,7 +219,7 @@ inline GLenum ComparisonOp(Maxwell::ComparisonOp comparison) {
220 case Maxwell::ComparisonOp::Always: 219 case Maxwell::ComparisonOp::Always:
221 return GL_ALWAYS; 220 return GL_ALWAYS;
222 } 221 }
223 NGLOG_CRITICAL(Render_OpenGL, "Unimplemented comparison op={}", static_cast<u32>(comparison)); 222 LOG_CRITICAL(Render_OpenGL, "Unimplemented comparison op={}", static_cast<u32>(comparison));
224 UNREACHABLE(); 223 UNREACHABLE();
225 return {}; 224 return {};
226} 225}
@@ -232,7 +231,7 @@ inline GLenum FrontFace(Maxwell::Cull::FrontFace front_face) {
232 case Maxwell::Cull::FrontFace::CounterClockWise: 231 case Maxwell::Cull::FrontFace::CounterClockWise:
233 return GL_CCW; 232 return GL_CCW;
234 } 233 }
235 NGLOG_CRITICAL(Render_OpenGL, "Unimplemented front face cull={}", static_cast<u32>(front_face)); 234 LOG_CRITICAL(Render_OpenGL, "Unimplemented front face cull={}", static_cast<u32>(front_face));
236 UNREACHABLE(); 235 UNREACHABLE();
237 return {}; 236 return {};
238} 237}
@@ -246,7 +245,7 @@ inline GLenum CullFace(Maxwell::Cull::CullFace cull_face) {
246 case Maxwell::Cull::CullFace::FrontAndBack: 245 case Maxwell::Cull::CullFace::FrontAndBack:
247 return GL_FRONT_AND_BACK; 246 return GL_FRONT_AND_BACK;
248 } 247 }
249 NGLOG_CRITICAL(Render_OpenGL, "Unimplemented cull face={}", static_cast<u32>(cull_face)); 248 LOG_CRITICAL(Render_OpenGL, "Unimplemented cull face={}", static_cast<u32>(cull_face));
250 UNREACHABLE(); 249 UNREACHABLE();
251 return {}; 250 return {};
252} 251}
diff --git a/src/video_core/renderer_opengl/renderer_opengl.cpp b/src/video_core/renderer_opengl/renderer_opengl.cpp
index e3bb2cbb8..00841e937 100644
--- a/src/video_core/renderer_opengl/renderer_opengl.cpp
+++ b/src/video_core/renderer_opengl/renderer_opengl.cpp
@@ -301,8 +301,8 @@ void RendererOpenGL::DrawScreenTriangles(const ScreenInfo& screen_info, float x,
301 right = texcoords.left; 301 right = texcoords.left;
302 } else { 302 } else {
303 // Other transformations are unsupported 303 // Other transformations are unsupported
304 NGLOG_CRITICAL(Render_OpenGL, "Unsupported framebuffer_transform_flags={}", 304 LOG_CRITICAL(Render_OpenGL, "Unsupported framebuffer_transform_flags={}",
305 static_cast<u32>(framebuffer_transform_flags)); 305 static_cast<u32>(framebuffer_transform_flags));
306 UNIMPLEMENTED(); 306 UNIMPLEMENTED();
307 } 307 }
308 } 308 }
@@ -404,14 +404,14 @@ static void APIENTRY DebugHandler(GLenum source, GLenum type, GLuint id, GLenum
404 404
405 switch (severity) { 405 switch (severity) {
406 case GL_DEBUG_SEVERITY_HIGH: 406 case GL_DEBUG_SEVERITY_HIGH:
407 NGLOG_ERROR(Render_OpenGL, format, str_source, str_type, id, message); 407 LOG_ERROR(Render_OpenGL, format, str_source, str_type, id, message);
408 break; 408 break;
409 case GL_DEBUG_SEVERITY_MEDIUM: 409 case GL_DEBUG_SEVERITY_MEDIUM:
410 NGLOG_WARNING(Render_OpenGL, format, str_source, str_type, id, message); 410 LOG_WARNING(Render_OpenGL, format, str_source, str_type, id, message);
411 break; 411 break;
412 case GL_DEBUG_SEVERITY_NOTIFICATION: 412 case GL_DEBUG_SEVERITY_NOTIFICATION:
413 case GL_DEBUG_SEVERITY_LOW: 413 case GL_DEBUG_SEVERITY_LOW:
414 NGLOG_DEBUG(Render_OpenGL, format, str_source, str_type, id, message); 414 LOG_DEBUG(Render_OpenGL, format, str_source, str_type, id, message);
415 break; 415 break;
416 } 416 }
417} 417}
@@ -429,9 +429,9 @@ bool RendererOpenGL::Init() {
429 const char* gpu_vendor{reinterpret_cast<char const*>(glGetString(GL_VENDOR))}; 429 const char* gpu_vendor{reinterpret_cast<char const*>(glGetString(GL_VENDOR))};
430 const char* gpu_model{reinterpret_cast<char const*>(glGetString(GL_RENDERER))}; 430 const char* gpu_model{reinterpret_cast<char const*>(glGetString(GL_RENDERER))};
431 431
432 NGLOG_INFO(Render_OpenGL, "GL_VERSION: {}", gl_version); 432 LOG_INFO(Render_OpenGL, "GL_VERSION: {}", gl_version);
433 NGLOG_INFO(Render_OpenGL, "GL_VENDOR: {}", gpu_vendor); 433 LOG_INFO(Render_OpenGL, "GL_VENDOR: {}", gpu_vendor);
434 NGLOG_INFO(Render_OpenGL, "GL_RENDERER: {}", gpu_model); 434 LOG_INFO(Render_OpenGL, "GL_RENDERER: {}", gpu_model);
435 435
436 Core::Telemetry().AddField(Telemetry::FieldType::UserSystem, "GPU_Vendor", gpu_vendor); 436 Core::Telemetry().AddField(Telemetry::FieldType::UserSystem, "GPU_Vendor", gpu_vendor);
437 Core::Telemetry().AddField(Telemetry::FieldType::UserSystem, "GPU_Model", gpu_model); 437 Core::Telemetry().AddField(Telemetry::FieldType::UserSystem, "GPU_Model", gpu_model);
diff --git a/src/video_core/video_core.cpp b/src/video_core/video_core.cpp
index 89dc8ed1e..289140f31 100644
--- a/src/video_core/video_core.cpp
+++ b/src/video_core/video_core.cpp
@@ -24,9 +24,9 @@ bool Init(EmuWindow* emu_window) {
24 g_renderer = std::make_unique<RendererOpenGL>(); 24 g_renderer = std::make_unique<RendererOpenGL>();
25 g_renderer->SetWindow(g_emu_window); 25 g_renderer->SetWindow(g_emu_window);
26 if (g_renderer->Init()) { 26 if (g_renderer->Init()) {
27 NGLOG_DEBUG(Render, "initialized OK"); 27 LOG_DEBUG(Render, "initialized OK");
28 } else { 28 } else {
29 NGLOG_CRITICAL(Render, "initialization failed !"); 29 LOG_CRITICAL(Render, "initialization failed !");
30 return false; 30 return false;
31 } 31 }
32 return true; 32 return true;
@@ -36,7 +36,7 @@ bool Init(EmuWindow* emu_window) {
36void Shutdown() { 36void Shutdown() {
37 g_renderer.reset(); 37 g_renderer.reset();
38 38
39 NGLOG_DEBUG(Render, "shutdown OK"); 39 LOG_DEBUG(Render, "shutdown OK");
40} 40}
41 41
42} // namespace VideoCore 42} // namespace VideoCore