diff options
| author | 2023-03-02 23:03:07 +0000 | |
|---|---|---|
| committer | 2023-03-04 02:33:50 +0000 | |
| commit | a7fb80e6127645dd42fcd41ab57666c68da8a442 (patch) | |
| tree | fac8ec3731a66f68abcea8c966e3a146c4ed61d1 /src/video_core/renderer_vulkan | |
| parent | Merge pull request #9832 from liamwhite/hle-mp (diff) | |
| download | yuzu-a7fb80e6127645dd42fcd41ab57666c68da8a442.tar.gz yuzu-a7fb80e6127645dd42fcd41ab57666c68da8a442.tar.xz yuzu-a7fb80e6127645dd42fcd41ab57666c68da8a442.zip | |
Check all swizzle components for red, not just [0], pass float border color rather than int
Diffstat (limited to 'src/video_core/renderer_vulkan')
| -rw-r--r-- | src/video_core/renderer_vulkan/vk_rasterizer.cpp | 2 | ||||
| -rw-r--r-- | src/video_core/renderer_vulkan/vk_texture_cache.cpp | 11 |
2 files changed, 8 insertions, 5 deletions
diff --git a/src/video_core/renderer_vulkan/vk_rasterizer.cpp b/src/video_core/renderer_vulkan/vk_rasterizer.cpp index 719edbcfb..4ed0aebf7 100644 --- a/src/video_core/renderer_vulkan/vk_rasterizer.cpp +++ b/src/video_core/renderer_vulkan/vk_rasterizer.cpp | |||
| @@ -1064,7 +1064,7 @@ void RasterizerVulkan::UpdateDepthBoundsTestEnable(Tegra::Engines::Maxwell3D::Re | |||
| 1064 | LOG_WARNING(Render_Vulkan, "Depth bounds is enabled but not supported"); | 1064 | LOG_WARNING(Render_Vulkan, "Depth bounds is enabled but not supported"); |
| 1065 | enabled = false; | 1065 | enabled = false; |
| 1066 | } | 1066 | } |
| 1067 | scheduler.Record([enable = regs.depth_bounds_enable](vk::CommandBuffer cmdbuf) { | 1067 | scheduler.Record([enable = enabled](vk::CommandBuffer cmdbuf) { |
| 1068 | cmdbuf.SetDepthBoundsTestEnableEXT(enable); | 1068 | cmdbuf.SetDepthBoundsTestEnableEXT(enable); |
| 1069 | }); | 1069 | }); |
| 1070 | } | 1070 | } |
diff --git a/src/video_core/renderer_vulkan/vk_texture_cache.cpp b/src/video_core/renderer_vulkan/vk_texture_cache.cpp index 80adb70eb..69b654994 100644 --- a/src/video_core/renderer_vulkan/vk_texture_cache.cpp +++ b/src/video_core/renderer_vulkan/vk_texture_cache.cpp | |||
| @@ -189,13 +189,16 @@ constexpr VkBorderColor ConvertBorderColor(const std::array<float, 4>& color) { | |||
| 189 | if (info.IsRenderTarget()) { | 189 | if (info.IsRenderTarget()) { |
| 190 | return ImageAspectMask(info.format); | 190 | return ImageAspectMask(info.format); |
| 191 | } | 191 | } |
| 192 | const bool is_first = info.Swizzle()[0] == SwizzleSource::R; | 192 | bool any_r = |
| 193 | std::ranges::any_of(info.Swizzle(), [](SwizzleSource s) { return s == SwizzleSource::R; }); | ||
| 193 | switch (info.format) { | 194 | switch (info.format) { |
| 194 | case PixelFormat::D24_UNORM_S8_UINT: | 195 | case PixelFormat::D24_UNORM_S8_UINT: |
| 195 | case PixelFormat::D32_FLOAT_S8_UINT: | 196 | case PixelFormat::D32_FLOAT_S8_UINT: |
| 196 | return is_first ? VK_IMAGE_ASPECT_DEPTH_BIT : VK_IMAGE_ASPECT_STENCIL_BIT; | 197 | // R = depth, G = stencil |
| 198 | return any_r ? VK_IMAGE_ASPECT_DEPTH_BIT : VK_IMAGE_ASPECT_STENCIL_BIT; | ||
| 197 | case PixelFormat::S8_UINT_D24_UNORM: | 199 | case PixelFormat::S8_UINT_D24_UNORM: |
| 198 | return is_first ? VK_IMAGE_ASPECT_STENCIL_BIT : VK_IMAGE_ASPECT_DEPTH_BIT; | 200 | // R = stencil, G = depth |
| 201 | return any_r ? VK_IMAGE_ASPECT_STENCIL_BIT : VK_IMAGE_ASPECT_DEPTH_BIT; | ||
| 199 | case PixelFormat::D16_UNORM: | 202 | case PixelFormat::D16_UNORM: |
| 200 | case PixelFormat::D32_FLOAT: | 203 | case PixelFormat::D32_FLOAT: |
| 201 | return VK_IMAGE_ASPECT_DEPTH_BIT; | 204 | return VK_IMAGE_ASPECT_DEPTH_BIT; |
| @@ -1763,7 +1766,7 @@ Sampler::Sampler(TextureCacheRuntime& runtime, const Tegra::Texture::TSCEntry& t | |||
| 1763 | .minLod = tsc.mipmap_filter == TextureMipmapFilter::None ? 0.0f : tsc.MinLod(), | 1766 | .minLod = tsc.mipmap_filter == TextureMipmapFilter::None ? 0.0f : tsc.MinLod(), |
| 1764 | .maxLod = tsc.mipmap_filter == TextureMipmapFilter::None ? 0.25f : tsc.MaxLod(), | 1767 | .maxLod = tsc.mipmap_filter == TextureMipmapFilter::None ? 0.25f : tsc.MaxLod(), |
| 1765 | .borderColor = | 1768 | .borderColor = |
| 1766 | arbitrary_borders ? VK_BORDER_COLOR_INT_CUSTOM_EXT : ConvertBorderColor(color), | 1769 | arbitrary_borders ? VK_BORDER_COLOR_FLOAT_CUSTOM_EXT : ConvertBorderColor(color), |
| 1767 | .unnormalizedCoordinates = VK_FALSE, | 1770 | .unnormalizedCoordinates = VK_FALSE, |
| 1768 | }); | 1771 | }); |
| 1769 | } | 1772 | } |