diff options
| author | 2020-03-18 20:09:32 -0400 | |
|---|---|---|
| committer | 2020-03-18 20:09:32 -0400 | |
| commit | 9418b983bd400aa8d1cd149655edccd488426f0e (patch) | |
| tree | a3eaa1d90557b089128b2e7c58624434decbc9f9 /src/video_core/renderer_vulkan | |
| parent | Merge pull request #3534 from ReinUsesLisp/oob-time-zone (diff) | |
| parent | vk_texture_cache: Silence misc warnings (diff) | |
| download | yuzu-9418b983bd400aa8d1cd149655edccd488426f0e.tar.gz yuzu-9418b983bd400aa8d1cd149655edccd488426f0e.tar.xz yuzu-9418b983bd400aa8d1cd149655edccd488426f0e.zip | |
Merge pull request #3535 from ReinUsesLisp/gcc-warnings
video_core: Silence misc warnings
Diffstat (limited to 'src/video_core/renderer_vulkan')
5 files changed, 6 insertions, 7 deletions
diff --git a/src/video_core/renderer_vulkan/maxwell_to_vk.cpp b/src/video_core/renderer_vulkan/maxwell_to_vk.cpp index 0e2e5e6c7..f93447610 100644 --- a/src/video_core/renderer_vulkan/maxwell_to_vk.cpp +++ b/src/video_core/renderer_vulkan/maxwell_to_vk.cpp | |||
| @@ -257,6 +257,8 @@ vk::ShaderStageFlagBits ShaderStage(Tegra::Engines::ShaderType stage) { | |||
| 257 | return vk::ShaderStageFlagBits::eGeometry; | 257 | return vk::ShaderStageFlagBits::eGeometry; |
| 258 | case Tegra::Engines::ShaderType::Fragment: | 258 | case Tegra::Engines::ShaderType::Fragment: |
| 259 | return vk::ShaderStageFlagBits::eFragment; | 259 | return vk::ShaderStageFlagBits::eFragment; |
| 260 | case Tegra::Engines::ShaderType::Compute: | ||
| 261 | return vk::ShaderStageFlagBits::eCompute; | ||
| 260 | } | 262 | } |
| 261 | UNIMPLEMENTED_MSG("Unimplemented shader stage={}", static_cast<u32>(stage)); | 263 | UNIMPLEMENTED_MSG("Unimplemented shader stage={}", static_cast<u32>(stage)); |
| 262 | return {}; | 264 | return {}; |
diff --git a/src/video_core/renderer_vulkan/vk_pipeline_cache.cpp b/src/video_core/renderer_vulkan/vk_pipeline_cache.cpp index 91e7b7791..557b9d662 100644 --- a/src/video_core/renderer_vulkan/vk_pipeline_cache.cpp +++ b/src/video_core/renderer_vulkan/vk_pipeline_cache.cpp | |||
| @@ -192,7 +192,6 @@ std::array<Shader, Maxwell::MaxShaderProgram> VKPipelineCache::GetShaders() { | |||
| 192 | 192 | ||
| 193 | std::array<Shader, Maxwell::MaxShaderProgram> shaders; | 193 | std::array<Shader, Maxwell::MaxShaderProgram> shaders; |
| 194 | for (std::size_t index = 0; index < Maxwell::MaxShaderProgram; ++index) { | 194 | for (std::size_t index = 0; index < Maxwell::MaxShaderProgram; ++index) { |
| 195 | const auto& shader_config = gpu.regs.shader_config[index]; | ||
| 196 | const auto program{static_cast<Maxwell::ShaderProgram>(index)}; | 195 | const auto program{static_cast<Maxwell::ShaderProgram>(index)}; |
| 197 | 196 | ||
| 198 | // Skip stages that are not enabled | 197 | // Skip stages that are not enabled |
diff --git a/src/video_core/renderer_vulkan/vk_rasterizer.cpp b/src/video_core/renderer_vulkan/vk_rasterizer.cpp index 755aad643..58c69b786 100644 --- a/src/video_core/renderer_vulkan/vk_rasterizer.cpp +++ b/src/video_core/renderer_vulkan/vk_rasterizer.cpp | |||
| @@ -548,8 +548,6 @@ bool RasterizerVulkan::AccelerateDisplay(const Tegra::FramebufferConfig& config, | |||
| 548 | 548 | ||
| 549 | // Verify that the cached surface is the same size and format as the requested framebuffer | 549 | // Verify that the cached surface is the same size and format as the requested framebuffer |
| 550 | const auto& params{surface->GetSurfaceParams()}; | 550 | const auto& params{surface->GetSurfaceParams()}; |
| 551 | const auto& pixel_format{ | ||
| 552 | VideoCore::Surface::PixelFormatFromGPUPixelFormat(config.pixel_format)}; | ||
| 553 | ASSERT_MSG(params.width == config.width, "Framebuffer width is different"); | 551 | ASSERT_MSG(params.width == config.width, "Framebuffer width is different"); |
| 554 | ASSERT_MSG(params.height == config.height, "Framebuffer height is different"); | 552 | ASSERT_MSG(params.height == config.height, "Framebuffer height is different"); |
| 555 | 553 | ||
diff --git a/src/video_core/renderer_vulkan/vk_staging_buffer_pool.cpp b/src/video_core/renderer_vulkan/vk_staging_buffer_pool.cpp index d9ea3cc21..374959f82 100644 --- a/src/video_core/renderer_vulkan/vk_staging_buffer_pool.cpp +++ b/src/video_core/renderer_vulkan/vk_staging_buffer_pool.cpp | |||
| @@ -100,7 +100,6 @@ void VKStagingBufferPool::ReleaseCache(bool host_visible) { | |||
| 100 | } | 100 | } |
| 101 | 101 | ||
| 102 | u64 VKStagingBufferPool::ReleaseLevel(StagingBuffersCache& cache, std::size_t log2) { | 102 | u64 VKStagingBufferPool::ReleaseLevel(StagingBuffersCache& cache, std::size_t log2) { |
| 103 | static constexpr u64 epochs_to_destroy = 180; | ||
| 104 | static constexpr std::size_t deletions_per_tick = 16; | 103 | static constexpr std::size_t deletions_per_tick = 16; |
| 105 | 104 | ||
| 106 | auto& staging = cache[log2]; | 105 | auto& staging = cache[log2]; |
| @@ -108,6 +107,7 @@ u64 VKStagingBufferPool::ReleaseLevel(StagingBuffersCache& cache, std::size_t lo | |||
| 108 | const std::size_t old_size = entries.size(); | 107 | const std::size_t old_size = entries.size(); |
| 109 | 108 | ||
| 110 | const auto is_deleteable = [this](const auto& entry) { | 109 | const auto is_deleteable = [this](const auto& entry) { |
| 110 | static constexpr u64 epochs_to_destroy = 180; | ||
| 111 | return entry.last_epoch + epochs_to_destroy < epoch && !entry.watch.IsUsed(); | 111 | return entry.last_epoch + epochs_to_destroy < epoch && !entry.watch.IsUsed(); |
| 112 | }; | 112 | }; |
| 113 | const std::size_t begin_offset = staging.delete_index; | 113 | const std::size_t begin_offset = staging.delete_index; |
diff --git a/src/video_core/renderer_vulkan/vk_texture_cache.cpp b/src/video_core/renderer_vulkan/vk_texture_cache.cpp index 73d92a5ae..26175921b 100644 --- a/src/video_core/renderer_vulkan/vk_texture_cache.cpp +++ b/src/video_core/renderer_vulkan/vk_texture_cache.cpp | |||
| @@ -52,6 +52,9 @@ vk::ImageType SurfaceTargetToImage(SurfaceTarget target) { | |||
| 52 | return vk::ImageType::e2D; | 52 | return vk::ImageType::e2D; |
| 53 | case SurfaceTarget::Texture3D: | 53 | case SurfaceTarget::Texture3D: |
| 54 | return vk::ImageType::e3D; | 54 | return vk::ImageType::e3D; |
| 55 | case SurfaceTarget::TextureBuffer: | ||
| 56 | UNREACHABLE(); | ||
| 57 | return {}; | ||
| 55 | } | 58 | } |
| 56 | UNREACHABLE_MSG("Unknown texture target={}", static_cast<u32>(target)); | 59 | UNREACHABLE_MSG("Unknown texture target={}", static_cast<u32>(target)); |
| 57 | return {}; | 60 | return {}; |
| @@ -273,7 +276,6 @@ void CachedSurface::UploadImage(const std::vector<u8>& staging_buffer) { | |||
| 273 | 276 | ||
| 274 | for (u32 level = 0; level < params.num_levels; ++level) { | 277 | for (u32 level = 0; level < params.num_levels; ++level) { |
| 275 | vk::BufferImageCopy copy = GetBufferImageCopy(level); | 278 | vk::BufferImageCopy copy = GetBufferImageCopy(level); |
| 276 | const auto& dld = device.GetDispatchLoader(); | ||
| 277 | if (image->GetAspectMask() == | 279 | if (image->GetAspectMask() == |
| 278 | (vk::ImageAspectFlagBits::eDepth | vk::ImageAspectFlagBits::eStencil)) { | 280 | (vk::ImageAspectFlagBits::eDepth | vk::ImageAspectFlagBits::eStencil)) { |
| 279 | vk::BufferImageCopy depth = copy; | 281 | vk::BufferImageCopy depth = copy; |
| @@ -422,7 +424,6 @@ void VKTextureCache::ImageCopy(Surface& src_surface, Surface& dst_surface, | |||
| 422 | dst_base_layer, num_layers, copy_params.dest_level, 1, vk::PipelineStageFlagBits::eTransfer, | 424 | dst_base_layer, num_layers, copy_params.dest_level, 1, vk::PipelineStageFlagBits::eTransfer, |
| 423 | vk::AccessFlagBits::eTransferWrite, vk::ImageLayout::eTransferDstOptimal); | 425 | vk::AccessFlagBits::eTransferWrite, vk::ImageLayout::eTransferDstOptimal); |
| 424 | 426 | ||
| 425 | const auto& dld{device.GetDispatchLoader()}; | ||
| 426 | const vk::ImageSubresourceLayers src_subresource( | 427 | const vk::ImageSubresourceLayers src_subresource( |
| 427 | src_surface->GetAspectMask(), copy_params.source_level, copy_params.source_z, num_layers); | 428 | src_surface->GetAspectMask(), copy_params.source_level, copy_params.source_z, num_layers); |
| 428 | const vk::ImageSubresourceLayers dst_subresource( | 429 | const vk::ImageSubresourceLayers dst_subresource( |
| @@ -458,7 +459,6 @@ void VKTextureCache::ImageBlit(View& src_view, View& dst_view, | |||
| 458 | dst_view->GetImageSubresourceLayers(), {dst_top_left, dst_bot_right}); | 459 | dst_view->GetImageSubresourceLayers(), {dst_top_left, dst_bot_right}); |
| 459 | const bool is_linear = copy_config.filter == Tegra::Engines::Fermi2D::Filter::Linear; | 460 | const bool is_linear = copy_config.filter == Tegra::Engines::Fermi2D::Filter::Linear; |
| 460 | 461 | ||
| 461 | const auto& dld{device.GetDispatchLoader()}; | ||
| 462 | scheduler.Record([src_image = src_view->GetImage(), dst_image = dst_view->GetImage(), blit, | 462 | scheduler.Record([src_image = src_view->GetImage(), dst_image = dst_view->GetImage(), blit, |
| 463 | is_linear](auto cmdbuf, auto& dld) { | 463 | is_linear](auto cmdbuf, auto& dld) { |
| 464 | cmdbuf.blitImage(src_image, vk::ImageLayout::eTransferSrcOptimal, dst_image, | 464 | cmdbuf.blitImage(src_image, vk::ImageLayout::eTransferSrcOptimal, dst_image, |