summaryrefslogtreecommitdiff
path: root/src/video_core/renderer_opengl
diff options
context:
space:
mode:
authorGravatar Yuri Kunde Schlesner2014-12-05 23:53:49 -0200
committerGravatar Yuri Kunde Schlesner2014-12-13 02:08:02 -0200
commit0600e2d8b5b30bd68c8b19cb1f2051e096e7caa9 (patch)
tree40fee084c551bfb497e68181447298f862ea68ca /src/video_core/renderer_opengl
parentImplement text path trimming for shorter paths. (diff)
downloadyuzu-0600e2d8b5b30bd68c8b19cb1f2051e096e7caa9.tar.gz
yuzu-0600e2d8b5b30bd68c8b19cb1f2051e096e7caa9.tar.xz
yuzu-0600e2d8b5b30bd68c8b19cb1f2051e096e7caa9.zip
Convert old logging calls to new logging macros
Diffstat (limited to 'src/video_core/renderer_opengl')
-rw-r--r--src/video_core/renderer_opengl/gl_shader_util.cpp24
-rw-r--r--src/video_core/renderer_opengl/renderer_opengl.cpp12
2 files changed, 24 insertions, 12 deletions
diff --git a/src/video_core/renderer_opengl/gl_shader_util.cpp b/src/video_core/renderer_opengl/gl_shader_util.cpp
index fdac9ae1a..d0f82e6cd 100644
--- a/src/video_core/renderer_opengl/gl_shader_util.cpp
+++ b/src/video_core/renderer_opengl/gl_shader_util.cpp
@@ -20,7 +20,7 @@ GLuint LoadShaders(const char* vertex_shader, const char* fragment_shader) {
20 int info_log_length; 20 int info_log_length;
21 21
22 // Compile Vertex Shader 22 // Compile Vertex Shader
23 DEBUG_LOG(GPU, "Compiling vertex shader."); 23 LOG_DEBUG(Render_OpenGL, "Compiling vertex shader...");
24 24
25 glShaderSource(vertex_shader_id, 1, &vertex_shader, nullptr); 25 glShaderSource(vertex_shader_id, 1, &vertex_shader, nullptr);
26 glCompileShader(vertex_shader_id); 26 glCompileShader(vertex_shader_id);
@@ -32,11 +32,15 @@ GLuint LoadShaders(const char* vertex_shader, const char* fragment_shader) {
32 if (info_log_length > 1) { 32 if (info_log_length > 1) {
33 std::vector<char> vertex_shader_error(info_log_length); 33 std::vector<char> vertex_shader_error(info_log_length);
34 glGetShaderInfoLog(vertex_shader_id, info_log_length, nullptr, &vertex_shader_error[0]); 34 glGetShaderInfoLog(vertex_shader_id, info_log_length, nullptr, &vertex_shader_error[0]);
35 DEBUG_LOG(GPU, "%s", &vertex_shader_error[0]); 35 if (result) {
36 LOG_DEBUG(Render_OpenGL, "%s", &vertex_shader_error[0]);
37 } else {
38 LOG_ERROR(Render_OpenGL, "Error compiling vertex shader:\n%s", &vertex_shader_error[0]);
39 }
36 } 40 }
37 41
38 // Compile Fragment Shader 42 // Compile Fragment Shader
39 DEBUG_LOG(GPU, "Compiling fragment shader."); 43 LOG_DEBUG(Render_OpenGL, "Compiling fragment shader...");
40 44
41 glShaderSource(fragment_shader_id, 1, &fragment_shader, nullptr); 45 glShaderSource(fragment_shader_id, 1, &fragment_shader, nullptr);
42 glCompileShader(fragment_shader_id); 46 glCompileShader(fragment_shader_id);
@@ -48,11 +52,15 @@ GLuint LoadShaders(const char* vertex_shader, const char* fragment_shader) {
48 if (info_log_length > 1) { 52 if (info_log_length > 1) {
49 std::vector<char> fragment_shader_error(info_log_length); 53 std::vector<char> fragment_shader_error(info_log_length);
50 glGetShaderInfoLog(fragment_shader_id, info_log_length, nullptr, &fragment_shader_error[0]); 54 glGetShaderInfoLog(fragment_shader_id, info_log_length, nullptr, &fragment_shader_error[0]);
51 DEBUG_LOG(GPU, "%s", &fragment_shader_error[0]); 55 if (result) {
56 LOG_DEBUG(Render_OpenGL, "%s", &fragment_shader_error[0]);
57 } else {
58 LOG_ERROR(Render_OpenGL, "Error compiling fragment shader:\n%s", &fragment_shader_error[0]);
59 }
52 } 60 }
53 61
54 // Link the program 62 // Link the program
55 DEBUG_LOG(GPU, "Linking program."); 63 LOG_DEBUG(Render_OpenGL, "Linking program...");
56 64
57 GLuint program_id = glCreateProgram(); 65 GLuint program_id = glCreateProgram();
58 glAttachShader(program_id, vertex_shader_id); 66 glAttachShader(program_id, vertex_shader_id);
@@ -66,7 +74,11 @@ GLuint LoadShaders(const char* vertex_shader, const char* fragment_shader) {
66 if (info_log_length > 1) { 74 if (info_log_length > 1) {
67 std::vector<char> program_error(info_log_length); 75 std::vector<char> program_error(info_log_length);
68 glGetProgramInfoLog(program_id, info_log_length, nullptr, &program_error[0]); 76 glGetProgramInfoLog(program_id, info_log_length, nullptr, &program_error[0]);
69 DEBUG_LOG(GPU, "%s", &program_error[0]); 77 if (result) {
78 LOG_DEBUG(Render_OpenGL, "%s", &program_error[0]);
79 } else {
80 LOG_ERROR(Render_OpenGL, "Error linking shader:\n%s", &program_error[0]);
81 }
70 } 82 }
71 83
72 glDeleteShader(vertex_shader_id); 84 glDeleteShader(vertex_shader_id);
diff --git a/src/video_core/renderer_opengl/renderer_opengl.cpp b/src/video_core/renderer_opengl/renderer_opengl.cpp
index 06de6afbd..e2caeeb8f 100644
--- a/src/video_core/renderer_opengl/renderer_opengl.cpp
+++ b/src/video_core/renderer_opengl/renderer_opengl.cpp
@@ -90,7 +90,7 @@ void RendererOpenGL::LoadFBToActiveGLTexture(const GPU::Regs::FramebufferConfig&
90 const VAddr framebuffer_vaddr = Memory::PhysicalToVirtualAddress( 90 const VAddr framebuffer_vaddr = Memory::PhysicalToVirtualAddress(
91 framebuffer.active_fb == 1 ? framebuffer.address_left2 : framebuffer.address_left1); 91 framebuffer.active_fb == 1 ? framebuffer.address_left2 : framebuffer.address_left1);
92 92
93 DEBUG_LOG(GPU, "0x%08x bytes from 0x%08x(%dx%d), fmt %x", 93 LOG_TRACE(Render_OpenGL, "0x%08x bytes from 0x%08x(%dx%d), fmt %x",
94 framebuffer.stride * framebuffer.height, 94 framebuffer.stride * framebuffer.height,
95 framebuffer_vaddr, (int)framebuffer.width, 95 framebuffer_vaddr, (int)framebuffer.width,
96 (int)framebuffer.height, (int)framebuffer.format); 96 (int)framebuffer.height, (int)framebuffer.format);
@@ -98,15 +98,15 @@ void RendererOpenGL::LoadFBToActiveGLTexture(const GPU::Regs::FramebufferConfig&
98 const u8* framebuffer_data = Memory::GetPointer(framebuffer_vaddr); 98 const u8* framebuffer_data = Memory::GetPointer(framebuffer_vaddr);
99 99
100 // TODO: Handle other pixel formats 100 // TODO: Handle other pixel formats
101 _dbg_assert_msg_(RENDER, framebuffer.color_format == GPU::Regs::PixelFormat::RGB8, 101 _dbg_assert_msg_(Render_OpenGL, framebuffer.color_format == GPU::Regs::PixelFormat::RGB8,
102 "Unsupported 3DS pixel format."); 102 "Unsupported 3DS pixel format.");
103 103
104 size_t pixel_stride = framebuffer.stride / 3; 104 size_t pixel_stride = framebuffer.stride / 3;
105 // OpenGL only supports specifying a stride in units of pixels, not bytes, unfortunately 105 // OpenGL only supports specifying a stride in units of pixels, not bytes, unfortunately
106 _dbg_assert_(RENDER, pixel_stride * 3 == framebuffer.stride); 106 _dbg_assert_(Render_OpenGL, pixel_stride * 3 == framebuffer.stride);
107 // Ensure no bad interactions with GL_UNPACK_ALIGNMENT, which by default 107 // Ensure no bad interactions with GL_UNPACK_ALIGNMENT, which by default
108 // only allows rows to have a memory alignement of 4. 108 // only allows rows to have a memory alignement of 4.
109 _dbg_assert_(RENDER, pixel_stride % 4 == 0); 109 _dbg_assert_(Render_OpenGL, pixel_stride % 4 == 0);
110 110
111 glBindTexture(GL_TEXTURE_2D, texture.handle); 111 glBindTexture(GL_TEXTURE_2D, texture.handle);
112 glPixelStorei(GL_UNPACK_ROW_LENGTH, (GLint)pixel_stride); 112 glPixelStorei(GL_UNPACK_ROW_LENGTH, (GLint)pixel_stride);
@@ -263,11 +263,11 @@ void RendererOpenGL::Init() {
263 263
264 int err = ogl_LoadFunctions(); 264 int err = ogl_LoadFunctions();
265 if (ogl_LOAD_SUCCEEDED != err) { 265 if (ogl_LOAD_SUCCEEDED != err) {
266 ERROR_LOG(RENDER, "Failed to initialize GL functions! Exiting..."); 266 LOG_CRITICAL(Render_OpenGL, "Failed to initialize GL functions! Exiting...");
267 exit(-1); 267 exit(-1);
268 } 268 }
269 269
270 NOTICE_LOG(RENDER, "GL_VERSION: %s\n", glGetString(GL_VERSION)); 270 LOG_INFO(Render_OpenGL, "GL_VERSION: %s", glGetString(GL_VERSION));
271 InitOpenGLObjects(); 271 InitOpenGLObjects();
272} 272}
273 273