summaryrefslogtreecommitdiff
path: root/src/video_core/engines
diff options
context:
space:
mode:
authorGravatar Fernando Sahmkow2019-07-17 19:37:01 -0400
committerGravatar FernandoS272019-07-20 10:18:35 -0400
commit7a35178ee2c8ce60c87654ed2d80cc76abb0380b (patch)
tree514fdc12910bb3b00d7c2df89b9e1882a8586320 /src/video_core/engines
parentGL_State: Feedback and fixes (diff)
downloadyuzu-7a35178ee2c8ce60c87654ed2d80cc76abb0380b.tar.gz
yuzu-7a35178ee2c8ce60c87654ed2d80cc76abb0380b.tar.xz
yuzu-7a35178ee2c8ce60c87654ed2d80cc76abb0380b.zip
Maxwell3D: Reorganize and address feedback
Diffstat (limited to 'src/video_core/engines')
-rw-r--r--src/video_core/engines/maxwell_3d.cpp4
-rw-r--r--src/video_core/engines/maxwell_3d.h4
2 files changed, 6 insertions, 2 deletions
diff --git a/src/video_core/engines/maxwell_3d.cpp b/src/video_core/engines/maxwell_3d.cpp
index 87777e265..fe9fc0278 100644
--- a/src/video_core/engines/maxwell_3d.cpp
+++ b/src/video_core/engines/maxwell_3d.cpp
@@ -70,6 +70,10 @@ void Maxwell3D::InitializeRegisterDefaults() {
70 regs.stencil_back_func_mask = 0xFFFFFFFF; 70 regs.stencil_back_func_mask = 0xFFFFFFFF;
71 regs.stencil_back_mask = 0xFFFFFFFF; 71 regs.stencil_back_mask = 0xFFFFFFFF;
72 72
73 regs.depth_test_func = Regs::ComparisonOp::Always;
74 regs.cull.front_face = Regs::Cull::FrontFace::CounterClockWise;
75 regs.cull.cull_face = Regs::Cull::CullFace::Back;
76
73 // TODO(Rodrigo): Most games do not set a point size. I think this is a case of a 77 // TODO(Rodrigo): Most games do not set a point size. I think this is a case of a
74 // register carrying a default value. Assume it's OpenGL's default (1). 78 // register carrying a default value. Assume it's OpenGL's default (1).
75 regs.point_size = 1.0f; 79 regs.point_size = 1.0f;
diff --git a/src/video_core/engines/maxwell_3d.h b/src/video_core/engines/maxwell_3d.h
index 42feb0345..ac300bf76 100644
--- a/src/video_core/engines/maxwell_3d.h
+++ b/src/video_core/engines/maxwell_3d.h
@@ -1246,8 +1246,6 @@ private:
1246 /// Interpreter for the macro codes uploaded to the GPU. 1246 /// Interpreter for the macro codes uploaded to the GPU.
1247 MacroInterpreter macro_interpreter; 1247 MacroInterpreter macro_interpreter;
1248 1248
1249 Upload::State upload_state;
1250
1251 static constexpr u32 null_cb_data = 0xFFFFFFFF; 1249 static constexpr u32 null_cb_data = 0xFFFFFFFF;
1252 struct { 1250 struct {
1253 std::array<std::array<u32, 0x4000>, 16> buffer; 1251 std::array<std::array<u32, 0x4000>, 16> buffer;
@@ -1257,6 +1255,8 @@ private:
1257 u32 counter{}; 1255 u32 counter{};
1258 } cb_data_state; 1256 } cb_data_state;
1259 1257
1258 Upload::State upload_state;
1259
1260 /// Retrieves information about a specific TIC entry from the TIC buffer. 1260 /// Retrieves information about a specific TIC entry from the TIC buffer.
1261 Texture::TICEntry GetTICEntry(u32 tic_index) const; 1261 Texture::TICEntry GetTICEntry(u32 tic_index) const;
1262 1262