diff options
| author | 2020-06-19 20:47:48 -0300 | |
|---|---|---|
| committer | 2020-06-24 02:36:14 -0300 | |
| commit | 32a2dcd4153f4e2aea7b5f88c85d8a352f647f12 (patch) | |
| tree | 3422389a0dcf71fe8df676bc00222a77ac963825 /src/video_core/buffer_cache | |
| parent | gl_stream_buffer: Use InvalidateBufferData instead unmap and map (diff) | |
| download | yuzu-32a2dcd4153f4e2aea7b5f88c85d8a352f647f12.tar.gz yuzu-32a2dcd4153f4e2aea7b5f88c85d8a352f647f12.tar.xz yuzu-32a2dcd4153f4e2aea7b5f88c85d8a352f647f12.zip | |
buffer_cache: Use buffer methods instead of cache virtual methods
Diffstat (limited to 'src/video_core/buffer_cache')
| -rw-r--r-- | src/video_core/buffer_cache/buffer_cache.h | 23 |
1 files changed, 7 insertions, 16 deletions
diff --git a/src/video_core/buffer_cache/buffer_cache.h b/src/video_core/buffer_cache/buffer_cache.h index 6ea59253a..cf8bdd021 100644 --- a/src/video_core/buffer_cache/buffer_cache.h +++ b/src/video_core/buffer_cache/buffer_cache.h | |||
| @@ -269,15 +269,6 @@ protected: | |||
| 269 | 269 | ||
| 270 | virtual std::shared_ptr<Buffer> CreateBlock(VAddr cpu_addr, std::size_t size) = 0; | 270 | virtual std::shared_ptr<Buffer> CreateBlock(VAddr cpu_addr, std::size_t size) = 0; |
| 271 | 271 | ||
| 272 | virtual void UploadBlockData(const Buffer& buffer, std::size_t offset, std::size_t size, | ||
| 273 | const u8* data) = 0; | ||
| 274 | |||
| 275 | virtual void DownloadBlockData(const Buffer& buffer, std::size_t offset, std::size_t size, | ||
| 276 | u8* data) = 0; | ||
| 277 | |||
| 278 | virtual void CopyBlock(const Buffer& src, const Buffer& dst, std::size_t src_offset, | ||
| 279 | std::size_t dst_offset, std::size_t size) = 0; | ||
| 280 | |||
| 281 | virtual BufferInfo ConstBufferUpload(const void* raw_pointer, std::size_t size) { | 272 | virtual BufferInfo ConstBufferUpload(const void* raw_pointer, std::size_t size) { |
| 282 | return {}; | 273 | return {}; |
| 283 | } | 274 | } |
| @@ -339,11 +330,11 @@ private: | |||
| 339 | const VAddr cpu_addr_end = cpu_addr + size; | 330 | const VAddr cpu_addr_end = cpu_addr + size; |
| 340 | if (memory_manager.IsGranularRange(gpu_addr, size)) { | 331 | if (memory_manager.IsGranularRange(gpu_addr, size)) { |
| 341 | u8* host_ptr = memory_manager.GetPointer(gpu_addr); | 332 | u8* host_ptr = memory_manager.GetPointer(gpu_addr); |
| 342 | UploadBlockData(*block, block->Offset(cpu_addr), size, host_ptr); | 333 | block->Upload(block->Offset(cpu_addr), size, host_ptr); |
| 343 | } else { | 334 | } else { |
| 344 | staging_buffer.resize(size); | 335 | staging_buffer.resize(size); |
| 345 | memory_manager.ReadBlockUnsafe(gpu_addr, staging_buffer.data(), size); | 336 | memory_manager.ReadBlockUnsafe(gpu_addr, staging_buffer.data(), size); |
| 346 | UploadBlockData(*block, block->Offset(cpu_addr), size, staging_buffer.data()); | 337 | block->Upload(block->Offset(cpu_addr), size, staging_buffer.data()); |
| 347 | } | 338 | } |
| 348 | return Register(MapInterval(cpu_addr, cpu_addr_end, gpu_addr)); | 339 | return Register(MapInterval(cpu_addr, cpu_addr_end, gpu_addr)); |
| 349 | } | 340 | } |
| @@ -402,7 +393,7 @@ private: | |||
| 402 | } | 393 | } |
| 403 | staging_buffer.resize(size); | 394 | staging_buffer.resize(size); |
| 404 | system.Memory().ReadBlockUnsafe(interval.lower(), staging_buffer.data(), size); | 395 | system.Memory().ReadBlockUnsafe(interval.lower(), staging_buffer.data(), size); |
| 405 | UploadBlockData(*block, block->Offset(interval.lower()), size, staging_buffer.data()); | 396 | block->Upload(block->Offset(interval.lower()), size, staging_buffer.data()); |
| 406 | } | 397 | } |
| 407 | } | 398 | } |
| 408 | 399 | ||
| @@ -439,7 +430,7 @@ private: | |||
| 439 | 430 | ||
| 440 | const std::size_t size = map->end - map->start; | 431 | const std::size_t size = map->end - map->start; |
| 441 | staging_buffer.resize(size); | 432 | staging_buffer.resize(size); |
| 442 | DownloadBlockData(*block, block->Offset(map->start), size, staging_buffer.data()); | 433 | block->Download(block->Offset(map->start), size, staging_buffer.data()); |
| 443 | system.Memory().WriteBlockUnsafe(map->start, staging_buffer.data(), size); | 434 | system.Memory().WriteBlockUnsafe(map->start, staging_buffer.data(), size); |
| 444 | map->MarkAsModified(false, 0); | 435 | map->MarkAsModified(false, 0); |
| 445 | } | 436 | } |
| @@ -467,7 +458,7 @@ private: | |||
| 467 | const std::size_t new_size = old_size + BLOCK_PAGE_SIZE; | 458 | const std::size_t new_size = old_size + BLOCK_PAGE_SIZE; |
| 468 | const VAddr cpu_addr = buffer->CpuAddr(); | 459 | const VAddr cpu_addr = buffer->CpuAddr(); |
| 469 | std::shared_ptr<Buffer> new_buffer = CreateBlock(cpu_addr, new_size); | 460 | std::shared_ptr<Buffer> new_buffer = CreateBlock(cpu_addr, new_size); |
| 470 | CopyBlock(*buffer, *new_buffer, 0, 0, old_size); | 461 | new_buffer->CopyFrom(*buffer, 0, 0, old_size); |
| 471 | QueueDestruction(std::move(buffer)); | 462 | QueueDestruction(std::move(buffer)); |
| 472 | 463 | ||
| 473 | const VAddr cpu_addr_end = cpu_addr + new_size - 1; | 464 | const VAddr cpu_addr_end = cpu_addr + new_size - 1; |
| @@ -489,8 +480,8 @@ private: | |||
| 489 | const std::size_t new_size = size_1 + size_2; | 480 | const std::size_t new_size = size_1 + size_2; |
| 490 | 481 | ||
| 491 | std::shared_ptr<Buffer> new_buffer = CreateBlock(new_addr, new_size); | 482 | std::shared_ptr<Buffer> new_buffer = CreateBlock(new_addr, new_size); |
| 492 | CopyBlock(*first, *new_buffer, 0, new_buffer->Offset(first_addr), size_1); | 483 | new_buffer->CopyFrom(*first, 0, new_buffer->Offset(first_addr), size_1); |
| 493 | CopyBlock(*second, *new_buffer, 0, new_buffer->Offset(second_addr), size_2); | 484 | new_buffer->CopyFrom(*second, 0, new_buffer->Offset(second_addr), size_2); |
| 494 | QueueDestruction(std::move(first)); | 485 | QueueDestruction(std::move(first)); |
| 495 | QueueDestruction(std::move(second)); | 486 | QueueDestruction(std::move(second)); |
| 496 | 487 | ||