diff options
| author | 2021-01-24 15:17:02 -0500 | |
|---|---|---|
| committer | 2021-02-28 17:25:31 -0500 | |
| commit | 2910aa77b2feea39fc0618598e275b138a346e71 (patch) | |
| tree | 2760d0c2914c672ae2cd2450851e4feda3b053e5 /src/tests/CMakeLists.txt | |
| parent | Merge pull request #6007 from bunnei/ldn-error (diff) | |
| download | yuzu-2910aa77b2feea39fc0618598e275b138a346e71.tar.gz yuzu-2910aa77b2feea39fc0618598e275b138a346e71.tar.xz yuzu-2910aa77b2feea39fc0618598e275b138a346e71.zip | |
[network] Error handling reform
`network.cpp` has several error paths which either:
- report "Unhandled host socket error=n" and return `SUCCESS`, or
- switch on a few possible errors, log them, and translate them to
Errno; the same switch statement is copied and pasted in multiple
places in the code
Convert these paths to use a helper function `GetAndLogLastError`, which
is roughly the equivalent of one of the switch statements, but:
- handling more cases (both ones that were already in `Errno`, and a few
more I added), and
- using OS functions to convert the error to a string when logging, so
it'll describe the error even if it's not one of the ones in the
switch statement.
- To handle this, refactor the logic in `GetLastErrorMsg` to expose a
new function `NativeErrorToString` which takes the error number
explicitly as an argument. And improve the Windows version a bit.
Also, add a test which exercises two random error paths.
Diffstat (limited to 'src/tests/CMakeLists.txt')
| -rw-r--r-- | src/tests/CMakeLists.txt | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/src/tests/CMakeLists.txt b/src/tests/CMakeLists.txt index 4ea0076e9..d875c4fee 100644 --- a/src/tests/CMakeLists.txt +++ b/src/tests/CMakeLists.txt | |||
| @@ -5,6 +5,7 @@ add_executable(tests | |||
| 5 | common/param_package.cpp | 5 | common/param_package.cpp |
| 6 | common/ring_buffer.cpp | 6 | common/ring_buffer.cpp |
| 7 | core/core_timing.cpp | 7 | core/core_timing.cpp |
| 8 | core/network/network.cpp | ||
| 8 | tests.cpp | 9 | tests.cpp |
| 9 | video_core/buffer_base.cpp | 10 | video_core/buffer_base.cpp |
| 10 | ) | 11 | ) |