diff options
| author | 2022-11-23 21:30:23 +0000 | |
|---|---|---|
| committer | 2023-01-05 22:13:07 +0000 | |
| commit | 8804a4eb23e0c4f3e4bab03dee7c204bd38bf21e (patch) | |
| tree | a250fb7a6485109609c5f89fee55fd73549b3a19 /src/shader_recompiler/ir_opt | |
| parent | shader_recompiler: SPIRV: Only enable int64 feature when supported (diff) | |
| download | yuzu-8804a4eb23e0c4f3e4bab03dee7c204bd38bf21e.tar.gz yuzu-8804a4eb23e0c4f3e4bab03dee7c204bd38bf21e.tar.xz yuzu-8804a4eb23e0c4f3e4bab03dee7c204bd38bf21e.zip | |
shader_recompiler: Align SSBO offsets to meet host requirements
We can take advantage of SSBO addresses being passed in a constant bufer to account for the extra alignment requirements in the shader itself.
Diffstat (limited to 'src/shader_recompiler/ir_opt')
| -rw-r--r-- | src/shader_recompiler/ir_opt/global_memory_to_storage_buffer_pass.cpp | 12 | ||||
| -rw-r--r-- | src/shader_recompiler/ir_opt/passes.h | 2 |
2 files changed, 9 insertions, 5 deletions
diff --git a/src/shader_recompiler/ir_opt/global_memory_to_storage_buffer_pass.cpp b/src/shader_recompiler/ir_opt/global_memory_to_storage_buffer_pass.cpp index 336338e62..f8d20af3c 100644 --- a/src/shader_recompiler/ir_opt/global_memory_to_storage_buffer_pass.cpp +++ b/src/shader_recompiler/ir_opt/global_memory_to_storage_buffer_pass.cpp | |||
| @@ -11,6 +11,7 @@ | |||
| 11 | #include "shader_recompiler/frontend/ir/breadth_first_search.h" | 11 | #include "shader_recompiler/frontend/ir/breadth_first_search.h" |
| 12 | #include "shader_recompiler/frontend/ir/ir_emitter.h" | 12 | #include "shader_recompiler/frontend/ir/ir_emitter.h" |
| 13 | #include "shader_recompiler/frontend/ir/value.h" | 13 | #include "shader_recompiler/frontend/ir/value.h" |
| 14 | #include "shader_recompiler/host_translate_info.h" | ||
| 14 | #include "shader_recompiler/ir_opt/passes.h" | 15 | #include "shader_recompiler/ir_opt/passes.h" |
| 15 | 16 | ||
| 16 | namespace Shader::Optimization { | 17 | namespace Shader::Optimization { |
| @@ -402,7 +403,7 @@ void CollectStorageBuffers(IR::Block& block, IR::Inst& inst, StorageInfo& info) | |||
| 402 | } | 403 | } |
| 403 | 404 | ||
| 404 | /// Returns the offset in indices (not bytes) for an equivalent storage instruction | 405 | /// Returns the offset in indices (not bytes) for an equivalent storage instruction |
| 405 | IR::U32 StorageOffset(IR::Block& block, IR::Inst& inst, StorageBufferAddr buffer) { | 406 | IR::U32 StorageOffset(IR::Block& block, IR::Inst& inst, StorageBufferAddr buffer, u32 alignment) { |
| 406 | IR::IREmitter ir{block, IR::Block::InstructionList::s_iterator_to(inst)}; | 407 | IR::IREmitter ir{block, IR::Block::InstructionList::s_iterator_to(inst)}; |
| 407 | IR::U32 offset; | 408 | IR::U32 offset; |
| 408 | if (const std::optional<LowAddrInfo> low_addr{TrackLowAddress(&inst)}) { | 409 | if (const std::optional<LowAddrInfo> low_addr{TrackLowAddress(&inst)}) { |
| @@ -415,7 +416,10 @@ IR::U32 StorageOffset(IR::Block& block, IR::Inst& inst, StorageBufferAddr buffer | |||
| 415 | } | 416 | } |
| 416 | // Subtract the least significant 32 bits from the guest offset. The result is the storage | 417 | // Subtract the least significant 32 bits from the guest offset. The result is the storage |
| 417 | // buffer offset in bytes. | 418 | // buffer offset in bytes. |
| 418 | const IR::U32 low_cbuf{ir.GetCbuf(ir.Imm32(buffer.index), ir.Imm32(buffer.offset))}; | 419 | IR::U32 low_cbuf{ir.GetCbuf(ir.Imm32(buffer.index), ir.Imm32(buffer.offset))}; |
| 420 | |||
| 421 | // Align the offset base to match the host alignment requirements | ||
| 422 | low_cbuf = ir.BitwiseAnd(low_cbuf, ir.Imm32(~(alignment - 1U))); | ||
| 419 | return ir.ISub(offset, low_cbuf); | 423 | return ir.ISub(offset, low_cbuf); |
| 420 | } | 424 | } |
| 421 | 425 | ||
| @@ -510,7 +514,7 @@ void Replace(IR::Block& block, IR::Inst& inst, const IR::U32& storage_index, | |||
| 510 | } | 514 | } |
| 511 | } // Anonymous namespace | 515 | } // Anonymous namespace |
| 512 | 516 | ||
| 513 | void GlobalMemoryToStorageBufferPass(IR::Program& program) { | 517 | void GlobalMemoryToStorageBufferPass(IR::Program& program, const HostTranslateInfo& host_info) { |
| 514 | StorageInfo info; | 518 | StorageInfo info; |
| 515 | for (IR::Block* const block : program.post_order_blocks) { | 519 | for (IR::Block* const block : program.post_order_blocks) { |
| 516 | for (IR::Inst& inst : block->Instructions()) { | 520 | for (IR::Inst& inst : block->Instructions()) { |
| @@ -534,7 +538,7 @@ void GlobalMemoryToStorageBufferPass(IR::Program& program) { | |||
| 534 | const IR::U32 index{IR::Value{static_cast<u32>(info.set.index_of(it))}}; | 538 | const IR::U32 index{IR::Value{static_cast<u32>(info.set.index_of(it))}}; |
| 535 | IR::Block* const block{storage_inst.block}; | 539 | IR::Block* const block{storage_inst.block}; |
| 536 | IR::Inst* const inst{storage_inst.inst}; | 540 | IR::Inst* const inst{storage_inst.inst}; |
| 537 | const IR::U32 offset{StorageOffset(*block, *inst, storage_buffer)}; | 541 | const IR::U32 offset{StorageOffset(*block, *inst, storage_buffer, host_info.min_ssbo_alignment)}; |
| 538 | Replace(*block, *inst, index, offset); | 542 | Replace(*block, *inst, index, offset); |
| 539 | } | 543 | } |
| 540 | } | 544 | } |
diff --git a/src/shader_recompiler/ir_opt/passes.h b/src/shader_recompiler/ir_opt/passes.h index 1f8f2ba95..4ffad1172 100644 --- a/src/shader_recompiler/ir_opt/passes.h +++ b/src/shader_recompiler/ir_opt/passes.h | |||
| @@ -15,7 +15,7 @@ namespace Shader::Optimization { | |||
| 15 | void CollectShaderInfoPass(Environment& env, IR::Program& program); | 15 | void CollectShaderInfoPass(Environment& env, IR::Program& program); |
| 16 | void ConstantPropagationPass(Environment& env, IR::Program& program); | 16 | void ConstantPropagationPass(Environment& env, IR::Program& program); |
| 17 | void DeadCodeEliminationPass(IR::Program& program); | 17 | void DeadCodeEliminationPass(IR::Program& program); |
| 18 | void GlobalMemoryToStorageBufferPass(IR::Program& program); | 18 | void GlobalMemoryToStorageBufferPass(IR::Program& program, const HostTranslateInfo& host_info); |
| 19 | void IdentityRemovalPass(IR::Program& program); | 19 | void IdentityRemovalPass(IR::Program& program); |
| 20 | void LowerFp16ToFp32(IR::Program& program); | 20 | void LowerFp16ToFp32(IR::Program& program); |
| 21 | void LowerInt64ToInt32(IR::Program& program); | 21 | void LowerInt64ToInt32(IR::Program& program); |