summaryrefslogtreecommitdiff
path: root/src/shader_recompiler/backend
diff options
context:
space:
mode:
authorGravatar arades792023-02-11 13:28:03 -0500
committerGravatar arades792023-02-14 12:33:11 -0500
commit45e13b03f372230dbf780f3fa87dd88f388af605 (patch)
tree555593e7e5016b6ba2a777d7417ada244abce458 /src/shader_recompiler/backend
parentMerge pull request #9795 from Kelebek1/biquad_fix (diff)
downloadyuzu-45e13b03f372230dbf780f3fa87dd88f388af605.tar.gz
yuzu-45e13b03f372230dbf780f3fa87dd88f388af605.tar.xz
yuzu-45e13b03f372230dbf780f3fa87dd88f388af605.zip
add static lifetime to constexpr values to force compile time evaluation where possible
Signed-off-by: arades79 <scravers@protonmail.com>
Diffstat (limited to 'src/shader_recompiler/backend')
-rw-r--r--src/shader_recompiler/backend/glsl/emit_glsl_integer.cpp2
-rw-r--r--src/shader_recompiler/backend/spirv/emit_spirv_integer.cpp2
2 files changed, 2 insertions, 2 deletions
diff --git a/src/shader_recompiler/backend/glsl/emit_glsl_integer.cpp b/src/shader_recompiler/backend/glsl/emit_glsl_integer.cpp
index 49397c9b2..06599c1b0 100644
--- a/src/shader_recompiler/backend/glsl/emit_glsl_integer.cpp
+++ b/src/shader_recompiler/backend/glsl/emit_glsl_integer.cpp
@@ -39,7 +39,7 @@ void EmitIAdd32(EmitContext& ctx, IR::Inst& inst, std::string_view a, std::strin
39 // which may be overwritten by the result of the addition 39 // which may be overwritten by the result of the addition
40 if (IR::Inst * overflow{inst.GetAssociatedPseudoOperation(IR::Opcode::GetOverflowFromOp)}) { 40 if (IR::Inst * overflow{inst.GetAssociatedPseudoOperation(IR::Opcode::GetOverflowFromOp)}) {
41 // https://stackoverflow.com/questions/55468823/how-to-detect-integer-overflow-in-c 41 // https://stackoverflow.com/questions/55468823/how-to-detect-integer-overflow-in-c
42 constexpr u32 s32_max{static_cast<u32>(std::numeric_limits<s32>::max())}; 42 constexpr static u32 s32_max{static_cast<u32>(std::numeric_limits<s32>::max())};
43 const auto sub_a{fmt::format("{}u-{}", s32_max, a)}; 43 const auto sub_a{fmt::format("{}u-{}", s32_max, a)};
44 const auto positive_result{fmt::format("int({})>int({})", b, sub_a)}; 44 const auto positive_result{fmt::format("int({})>int({})", b, sub_a)};
45 const auto negative_result{fmt::format("int({})<int({})", b, sub_a)}; 45 const auto negative_result{fmt::format("int({})<int({})", b, sub_a)};
diff --git a/src/shader_recompiler/backend/spirv/emit_spirv_integer.cpp b/src/shader_recompiler/backend/spirv/emit_spirv_integer.cpp
index 960bdea6f..f6492dffd 100644
--- a/src/shader_recompiler/backend/spirv/emit_spirv_integer.cpp
+++ b/src/shader_recompiler/backend/spirv/emit_spirv_integer.cpp
@@ -42,7 +42,7 @@ Id EmitIAdd32(EmitContext& ctx, IR::Inst* inst, Id a, Id b) {
42 SetSignFlag(ctx, inst, result); 42 SetSignFlag(ctx, inst, result);
43 if (IR::Inst * overflow{inst->GetAssociatedPseudoOperation(IR::Opcode::GetOverflowFromOp)}) { 43 if (IR::Inst * overflow{inst->GetAssociatedPseudoOperation(IR::Opcode::GetOverflowFromOp)}) {
44 // https://stackoverflow.com/questions/55468823/how-to-detect-integer-overflow-in-c 44 // https://stackoverflow.com/questions/55468823/how-to-detect-integer-overflow-in-c
45 constexpr u32 s32_max{static_cast<u32>(std::numeric_limits<s32>::max())}; 45 constexpr static u32 s32_max{static_cast<u32>(std::numeric_limits<s32>::max())};
46 const Id is_positive{ctx.OpSGreaterThanEqual(ctx.U1, a, ctx.u32_zero_value)}; 46 const Id is_positive{ctx.OpSGreaterThanEqual(ctx.U1, a, ctx.u32_zero_value)};
47 const Id sub_a{ctx.OpISub(ctx.U32[1], ctx.Const(s32_max), a)}; 47 const Id sub_a{ctx.OpISub(ctx.U32[1], ctx.Const(s32_max), a)};
48 48