summaryrefslogtreecommitdiff
path: root/src/input_common/helpers/joycon_protocol/calibration.cpp
diff options
context:
space:
mode:
authorGravatar german772022-12-23 08:32:02 -0600
committerGravatar Narr the Reg2023-01-19 18:05:22 -0600
commite1a3bda4d9881cb99c36b64733b814a3bb437f13 (patch)
treea9c0d864b023a810f48c129bb8bd6e84afb2ed2b /src/input_common/helpers/joycon_protocol/calibration.cpp
parentcore: hid: Fix input regressions (diff)
downloadyuzu-e1a3bda4d9881cb99c36b64733b814a3bb437f13.tar.gz
yuzu-e1a3bda4d9881cb99c36b64733b814a3bb437f13.tar.xz
yuzu-e1a3bda4d9881cb99c36b64733b814a3bb437f13.zip
Address review comments
Diffstat (limited to 'src/input_common/helpers/joycon_protocol/calibration.cpp')
-rw-r--r--src/input_common/helpers/joycon_protocol/calibration.cpp10
1 files changed, 3 insertions, 7 deletions
diff --git a/src/input_common/helpers/joycon_protocol/calibration.cpp b/src/input_common/helpers/joycon_protocol/calibration.cpp
index ce1ff7061..cd30ab869 100644
--- a/src/input_common/helpers/joycon_protocol/calibration.cpp
+++ b/src/input_common/helpers/joycon_protocol/calibration.cpp
@@ -9,7 +9,7 @@
9namespace InputCommon::Joycon { 9namespace InputCommon::Joycon {
10 10
11CalibrationProtocol::CalibrationProtocol(std::shared_ptr<JoyconHandle> handle) 11CalibrationProtocol::CalibrationProtocol(std::shared_ptr<JoyconHandle> handle)
12 : JoyconCommonProtocol(handle) {} 12 : JoyconCommonProtocol(std::move(handle)) {}
13 13
14DriverResult CalibrationProtocol::GetLeftJoyStickCalibration(JoyStickCalibration& calibration) { 14DriverResult CalibrationProtocol::GetLeftJoyStickCalibration(JoyStickCalibration& calibration) {
15 std::vector<u8> buffer; 15 std::vector<u8> buffer;
@@ -136,12 +136,8 @@ DriverResult CalibrationProtocol::GetRingCalibration(RingCalibration& calibratio
136 ring_data_min = current_value - 800; 136 ring_data_min = current_value - 800;
137 ring_data_default = current_value; 137 ring_data_default = current_value;
138 } 138 }
139 if (ring_data_max < current_value) { 139 ring_data_max = std::max(ring_data_max, current_value);
140 ring_data_max = current_value; 140 ring_data_min = std::min(ring_data_min, current_value);
141 }
142 if (ring_data_min > current_value) {
143 ring_data_min = current_value;
144 }
145 calibration = { 141 calibration = {
146 .default_value = ring_data_default, 142 .default_value = ring_data_default,
147 .max_value = ring_data_max, 143 .max_value = ring_data_max,