diff options
| author | 2019-10-05 20:41:20 -0400 | |
|---|---|---|
| committer | 2019-10-05 20:41:20 -0400 | |
| commit | deecd7f074a0547b8fc08a33fdc547eb63859e3e (patch) | |
| tree | d70efa81b1824d2dc351b7355d5016e75027ed8f /src/core | |
| parent | Merge pull request #2943 from DarkLordZach/azure-titlebars-v2 (diff) | |
| parent | audio/audout_u: Change formatting for old clang-format versions (diff) | |
| download | yuzu-deecd7f074a0547b8fc08a33fdc547eb63859e3e.tar.gz yuzu-deecd7f074a0547b8fc08a33fdc547eb63859e3e.tar.xz yuzu-deecd7f074a0547b8fc08a33fdc547eb63859e3e.zip | |
Merge pull request #2942 from ReinUsesLisp/clang-warnings
Silence miscellaneous warnings
Diffstat (limited to 'src/core')
29 files changed, 43 insertions, 43 deletions
diff --git a/src/core/hle/service/am/am.h b/src/core/hle/service/am/am.h index 9169eb2bd..ccd053c13 100644 --- a/src/core/hle/service/am/am.h +++ b/src/core/hle/service/am/am.h | |||
| @@ -147,6 +147,7 @@ private: | |||
| 147 | void GetAccumulatedSuspendedTickValue(Kernel::HLERequestContext& ctx); | 147 | void GetAccumulatedSuspendedTickValue(Kernel::HLERequestContext& ctx); |
| 148 | void GetAccumulatedSuspendedTickChangedEvent(Kernel::HLERequestContext& ctx); | 148 | void GetAccumulatedSuspendedTickChangedEvent(Kernel::HLERequestContext& ctx); |
| 149 | 149 | ||
| 150 | Core::System& system; | ||
| 150 | std::shared_ptr<NVFlinger::NVFlinger> nvflinger; | 151 | std::shared_ptr<NVFlinger::NVFlinger> nvflinger; |
| 151 | Kernel::EventPair launchable_event; | 152 | Kernel::EventPair launchable_event; |
| 152 | Kernel::EventPair accumulated_suspended_tick_changed_event; | 153 | Kernel::EventPair accumulated_suspended_tick_changed_event; |
| @@ -154,8 +155,6 @@ private: | |||
| 154 | u32 idle_time_detection_extension = 0; | 155 | u32 idle_time_detection_extension = 0; |
| 155 | u64 num_fatal_sections_entered = 0; | 156 | u64 num_fatal_sections_entered = 0; |
| 156 | bool is_auto_sleep_disabled = false; | 157 | bool is_auto_sleep_disabled = false; |
| 157 | |||
| 158 | Core::System& system; | ||
| 159 | }; | 158 | }; |
| 160 | 159 | ||
| 161 | class ICommonStateGetter final : public ServiceFramework<ICommonStateGetter> { | 160 | class ICommonStateGetter final : public ServiceFramework<ICommonStateGetter> { |
diff --git a/src/core/hle/service/apm/controller.cpp b/src/core/hle/service/apm/controller.cpp index 4376612eb..073d0f6fa 100644 --- a/src/core/hle/service/apm/controller.cpp +++ b/src/core/hle/service/apm/controller.cpp | |||
| @@ -13,7 +13,7 @@ constexpr PerformanceConfiguration DEFAULT_PERFORMANCE_CONFIGURATION = | |||
| 13 | PerformanceConfiguration::Config7; | 13 | PerformanceConfiguration::Config7; |
| 14 | 14 | ||
| 15 | Controller::Controller(Core::Timing::CoreTiming& core_timing) | 15 | Controller::Controller(Core::Timing::CoreTiming& core_timing) |
| 16 | : core_timing(core_timing), configs{ | 16 | : core_timing{core_timing}, configs{ |
| 17 | {PerformanceMode::Handheld, DEFAULT_PERFORMANCE_CONFIGURATION}, | 17 | {PerformanceMode::Handheld, DEFAULT_PERFORMANCE_CONFIGURATION}, |
| 18 | {PerformanceMode::Docked, DEFAULT_PERFORMANCE_CONFIGURATION}, | 18 | {PerformanceMode::Docked, DEFAULT_PERFORMANCE_CONFIGURATION}, |
| 19 | } {} | 19 | } {} |
| @@ -63,6 +63,7 @@ PerformanceConfiguration Controller::GetCurrentPerformanceConfiguration(Performa | |||
| 63 | void Controller::SetClockSpeed(u32 mhz) { | 63 | void Controller::SetClockSpeed(u32 mhz) { |
| 64 | LOG_INFO(Service_APM, "called, mhz={:08X}", mhz); | 64 | LOG_INFO(Service_APM, "called, mhz={:08X}", mhz); |
| 65 | // TODO(DarkLordZach): Actually signal core_timing to change clock speed. | 65 | // TODO(DarkLordZach): Actually signal core_timing to change clock speed. |
| 66 | // TODO(Rodrigo): Remove [[maybe_unused]] when core_timing is used. | ||
| 66 | } | 67 | } |
| 67 | 68 | ||
| 68 | } // namespace Service::APM | 69 | } // namespace Service::APM |
diff --git a/src/core/hle/service/apm/controller.h b/src/core/hle/service/apm/controller.h index 8ac80eaea..454caa6eb 100644 --- a/src/core/hle/service/apm/controller.h +++ b/src/core/hle/service/apm/controller.h | |||
| @@ -50,7 +50,7 @@ enum class PerformanceMode : u8 { | |||
| 50 | // system during times of high load -- this simply maps to different PerformanceConfigs to use. | 50 | // system during times of high load -- this simply maps to different PerformanceConfigs to use. |
| 51 | class Controller { | 51 | class Controller { |
| 52 | public: | 52 | public: |
| 53 | Controller(Core::Timing::CoreTiming& core_timing); | 53 | explicit Controller(Core::Timing::CoreTiming& core_timing); |
| 54 | ~Controller(); | 54 | ~Controller(); |
| 55 | 55 | ||
| 56 | void SetPerformanceConfiguration(PerformanceMode mode, PerformanceConfiguration config); | 56 | void SetPerformanceConfiguration(PerformanceMode mode, PerformanceConfiguration config); |
| @@ -62,9 +62,9 @@ public: | |||
| 62 | private: | 62 | private: |
| 63 | void SetClockSpeed(u32 mhz); | 63 | void SetClockSpeed(u32 mhz); |
| 64 | 64 | ||
| 65 | std::map<PerformanceMode, PerformanceConfiguration> configs; | 65 | [[maybe_unused]] Core::Timing::CoreTiming& core_timing; |
| 66 | 66 | ||
| 67 | Core::Timing::CoreTiming& core_timing; | 67 | std::map<PerformanceMode, PerformanceConfiguration> configs; |
| 68 | }; | 68 | }; |
| 69 | 69 | ||
| 70 | } // namespace Service::APM | 70 | } // namespace Service::APM |
diff --git a/src/core/hle/service/audio/audout_u.cpp b/src/core/hle/service/audio/audout_u.cpp index fb84a8f13..9afefb5c6 100644 --- a/src/core/hle/service/audio/audout_u.cpp +++ b/src/core/hle/service/audio/audout_u.cpp | |||
| @@ -205,7 +205,7 @@ private: | |||
| 205 | AudioCore::StreamPtr stream; | 205 | AudioCore::StreamPtr stream; |
| 206 | std::string device_name; | 206 | std::string device_name; |
| 207 | 207 | ||
| 208 | AudoutParams audio_params{}; | 208 | [[maybe_unused]] AudoutParams audio_params {}; |
| 209 | 209 | ||
| 210 | /// This is the event handle used to check if the audio buffer was released | 210 | /// This is the event handle used to check if the audio buffer was released |
| 211 | Kernel::EventPair buffer_event; | 211 | Kernel::EventPair buffer_event; |
diff --git a/src/core/hle/service/bcat/backend/boxcat.cpp b/src/core/hle/service/bcat/backend/boxcat.cpp index e6ee0810b..0e451e9c2 100644 --- a/src/core/hle/service/bcat/backend/boxcat.cpp +++ b/src/core/hle/service/bcat/backend/boxcat.cpp | |||
| @@ -88,7 +88,7 @@ std::ostream& operator<<(std::ostream& os, DownloadResult result) { | |||
| 88 | 88 | ||
| 89 | constexpr u32 PORT = 443; | 89 | constexpr u32 PORT = 443; |
| 90 | constexpr u32 TIMEOUT_SECONDS = 30; | 90 | constexpr u32 TIMEOUT_SECONDS = 30; |
| 91 | constexpr u64 VFS_COPY_BLOCK_SIZE = 1ull << 24; // 4MB | 91 | [[maybe_unused]] constexpr u64 VFS_COPY_BLOCK_SIZE = 1ULL << 24; // 4MB |
| 92 | 92 | ||
| 93 | namespace { | 93 | namespace { |
| 94 | 94 | ||
diff --git a/src/core/hle/service/bcat/module.cpp b/src/core/hle/service/bcat/module.cpp index b3fed56c7..4c01bcd99 100644 --- a/src/core/hle/service/bcat/module.cpp +++ b/src/core/hle/service/bcat/module.cpp | |||
| @@ -567,7 +567,7 @@ std::unique_ptr<Backend> CreateBackendFromSettings(DirectoryGetter getter) { | |||
| 567 | 567 | ||
| 568 | Module::Interface::Interface(std::shared_ptr<Module> module, FileSystem::FileSystemController& fsc, | 568 | Module::Interface::Interface(std::shared_ptr<Module> module, FileSystem::FileSystemController& fsc, |
| 569 | const char* name) | 569 | const char* name) |
| 570 | : ServiceFramework(name), module(std::move(module)), fsc(fsc), | 570 | : ServiceFramework(name), fsc(fsc), module(std::move(module)), |
| 571 | backend(CreateBackendFromSettings([&fsc](u64 tid) { return fsc.GetBCATDirectory(tid); })) {} | 571 | backend(CreateBackendFromSettings([&fsc](u64 tid) { return fsc.GetBCATDirectory(tid); })) {} |
| 572 | 572 | ||
| 573 | Module::Interface::~Interface() = default; | 573 | Module::Interface::~Interface() = default; |
diff --git a/src/core/hle/service/filesystem/fsp_srv.cpp b/src/core/hle/service/filesystem/fsp_srv.cpp index eb982ad49..cbd5466c1 100644 --- a/src/core/hle/service/filesystem/fsp_srv.cpp +++ b/src/core/hle/service/filesystem/fsp_srv.cpp | |||
| @@ -803,7 +803,7 @@ void FSP_SRV::CreateSaveDataFileSystem(Kernel::HLERequestContext& ctx) { | |||
| 803 | IPC::RequestParser rp{ctx}; | 803 | IPC::RequestParser rp{ctx}; |
| 804 | 804 | ||
| 805 | auto save_struct = rp.PopRaw<FileSys::SaveDataDescriptor>(); | 805 | auto save_struct = rp.PopRaw<FileSys::SaveDataDescriptor>(); |
| 806 | auto save_create_struct = rp.PopRaw<std::array<u8, 0x40>>(); | 806 | [[maybe_unused]] auto save_create_struct = rp.PopRaw<std::array<u8, 0x40>>(); |
| 807 | u128 uid = rp.PopRaw<u128>(); | 807 | u128 uid = rp.PopRaw<u128>(); |
| 808 | 808 | ||
| 809 | LOG_DEBUG(Service_FS, "called save_struct = {}, uid = {:016X}{:016X}", save_struct.DebugInfo(), | 809 | LOG_DEBUG(Service_FS, "called save_struct = {}, uid = {:016X}{:016X}", save_struct.DebugInfo(), |
diff --git a/src/core/hle/service/friend/friend.cpp b/src/core/hle/service/friend/friend.cpp index 42b4ee861..75dd9043b 100644 --- a/src/core/hle/service/friend/friend.cpp +++ b/src/core/hle/service/friend/friend.cpp | |||
| @@ -237,7 +237,6 @@ private: | |||
| 237 | }; | 237 | }; |
| 238 | 238 | ||
| 239 | Common::UUID uuid; | 239 | Common::UUID uuid; |
| 240 | bool is_event_created = false; | ||
| 241 | Kernel::EventPair notification_event; | 240 | Kernel::EventPair notification_event; |
| 242 | std::queue<SizedNotificationInfo> notifications; | 241 | std::queue<SizedNotificationInfo> notifications; |
| 243 | States states{}; | 242 | States states{}; |
diff --git a/src/core/hle/service/hid/controllers/debug_pad.cpp b/src/core/hle/service/hid/controllers/debug_pad.cpp index 8e8263f5b..1f2131ec8 100644 --- a/src/core/hle/service/hid/controllers/debug_pad.cpp +++ b/src/core/hle/service/hid/controllers/debug_pad.cpp | |||
| @@ -11,11 +11,10 @@ | |||
| 11 | namespace Service::HID { | 11 | namespace Service::HID { |
| 12 | 12 | ||
| 13 | constexpr s32 HID_JOYSTICK_MAX = 0x7fff; | 13 | constexpr s32 HID_JOYSTICK_MAX = 0x7fff; |
| 14 | constexpr s32 HID_JOYSTICK_MIN = -0x7fff; | 14 | [[maybe_unused]] constexpr s32 HID_JOYSTICK_MIN = -0x7fff; |
| 15 | enum class JoystickId : std::size_t { Joystick_Left, Joystick_Right }; | 15 | enum class JoystickId : std::size_t { Joystick_Left, Joystick_Right }; |
| 16 | 16 | ||
| 17 | Controller_DebugPad::Controller_DebugPad(Core::System& system) | 17 | Controller_DebugPad::Controller_DebugPad(Core::System& system) : ControllerBase(system) {} |
| 18 | : ControllerBase(system), system(system) {} | ||
| 19 | Controller_DebugPad::~Controller_DebugPad() = default; | 18 | Controller_DebugPad::~Controller_DebugPad() = default; |
| 20 | 19 | ||
| 21 | void Controller_DebugPad::OnInit() {} | 20 | void Controller_DebugPad::OnInit() {} |
diff --git a/src/core/hle/service/hid/controllers/debug_pad.h b/src/core/hle/service/hid/controllers/debug_pad.h index 6c4de817e..555b29d76 100644 --- a/src/core/hle/service/hid/controllers/debug_pad.h +++ b/src/core/hle/service/hid/controllers/debug_pad.h | |||
| @@ -89,6 +89,5 @@ private: | |||
| 89 | buttons; | 89 | buttons; |
| 90 | std::array<std::unique_ptr<Input::AnalogDevice>, Settings::NativeAnalog::NUM_STICKS_HID> | 90 | std::array<std::unique_ptr<Input::AnalogDevice>, Settings::NativeAnalog::NUM_STICKS_HID> |
| 91 | analogs; | 91 | analogs; |
| 92 | Core::System& system; | ||
| 93 | }; | 92 | }; |
| 94 | } // namespace Service::HID | 93 | } // namespace Service::HID |
diff --git a/src/core/hle/service/hid/controllers/gesture.cpp b/src/core/hle/service/hid/controllers/gesture.cpp index 80da0a0d3..6e990dd00 100644 --- a/src/core/hle/service/hid/controllers/gesture.cpp +++ b/src/core/hle/service/hid/controllers/gesture.cpp | |||
| @@ -10,8 +10,7 @@ | |||
| 10 | namespace Service::HID { | 10 | namespace Service::HID { |
| 11 | constexpr std::size_t SHARED_MEMORY_OFFSET = 0x3BA00; | 11 | constexpr std::size_t SHARED_MEMORY_OFFSET = 0x3BA00; |
| 12 | 12 | ||
| 13 | Controller_Gesture::Controller_Gesture(Core::System& system) | 13 | Controller_Gesture::Controller_Gesture(Core::System& system) : ControllerBase(system) {} |
| 14 | : ControllerBase(system), system(system) {} | ||
| 15 | Controller_Gesture::~Controller_Gesture() = default; | 14 | Controller_Gesture::~Controller_Gesture() = default; |
| 16 | 15 | ||
| 17 | void Controller_Gesture::OnInit() {} | 16 | void Controller_Gesture::OnInit() {} |
diff --git a/src/core/hle/service/hid/controllers/gesture.h b/src/core/hle/service/hid/controllers/gesture.h index 396897527..f650b8338 100644 --- a/src/core/hle/service/hid/controllers/gesture.h +++ b/src/core/hle/service/hid/controllers/gesture.h | |||
| @@ -59,6 +59,5 @@ private: | |||
| 59 | std::array<GestureState, 17> gesture_states; | 59 | std::array<GestureState, 17> gesture_states; |
| 60 | }; | 60 | }; |
| 61 | SharedMemory shared_memory{}; | 61 | SharedMemory shared_memory{}; |
| 62 | Core::System& system; | ||
| 63 | }; | 62 | }; |
| 64 | } // namespace Service::HID | 63 | } // namespace Service::HID |
diff --git a/src/core/hle/service/hid/controllers/keyboard.cpp b/src/core/hle/service/hid/controllers/keyboard.cpp index e587b2e15..358cb9329 100644 --- a/src/core/hle/service/hid/controllers/keyboard.cpp +++ b/src/core/hle/service/hid/controllers/keyboard.cpp | |||
| @@ -12,8 +12,7 @@ namespace Service::HID { | |||
| 12 | constexpr std::size_t SHARED_MEMORY_OFFSET = 0x3800; | 12 | constexpr std::size_t SHARED_MEMORY_OFFSET = 0x3800; |
| 13 | constexpr u8 KEYS_PER_BYTE = 8; | 13 | constexpr u8 KEYS_PER_BYTE = 8; |
| 14 | 14 | ||
| 15 | Controller_Keyboard::Controller_Keyboard(Core::System& system) | 15 | Controller_Keyboard::Controller_Keyboard(Core::System& system) : ControllerBase(system) {} |
| 16 | : ControllerBase(system), system(system) {} | ||
| 17 | Controller_Keyboard::~Controller_Keyboard() = default; | 16 | Controller_Keyboard::~Controller_Keyboard() = default; |
| 18 | 17 | ||
| 19 | void Controller_Keyboard::OnInit() {} | 18 | void Controller_Keyboard::OnInit() {} |
diff --git a/src/core/hle/service/hid/controllers/keyboard.h b/src/core/hle/service/hid/controllers/keyboard.h index ef586f7eb..f3eef5936 100644 --- a/src/core/hle/service/hid/controllers/keyboard.h +++ b/src/core/hle/service/hid/controllers/keyboard.h | |||
| @@ -53,6 +53,5 @@ private: | |||
| 53 | keyboard_keys; | 53 | keyboard_keys; |
| 54 | std::array<std::unique_ptr<Input::ButtonDevice>, Settings::NativeKeyboard::NumKeyboardMods> | 54 | std::array<std::unique_ptr<Input::ButtonDevice>, Settings::NativeKeyboard::NumKeyboardMods> |
| 55 | keyboard_mods; | 55 | keyboard_mods; |
| 56 | Core::System& system; | ||
| 57 | }; | 56 | }; |
| 58 | } // namespace Service::HID | 57 | } // namespace Service::HID |
diff --git a/src/core/hle/service/hid/controllers/mouse.cpp b/src/core/hle/service/hid/controllers/mouse.cpp index 88f2ca4c1..93d88ea50 100644 --- a/src/core/hle/service/hid/controllers/mouse.cpp +++ b/src/core/hle/service/hid/controllers/mouse.cpp | |||
| @@ -11,7 +11,7 @@ | |||
| 11 | namespace Service::HID { | 11 | namespace Service::HID { |
| 12 | constexpr std::size_t SHARED_MEMORY_OFFSET = 0x3400; | 12 | constexpr std::size_t SHARED_MEMORY_OFFSET = 0x3400; |
| 13 | 13 | ||
| 14 | Controller_Mouse::Controller_Mouse(Core::System& system) : ControllerBase(system), system(system) {} | 14 | Controller_Mouse::Controller_Mouse(Core::System& system) : ControllerBase(system) {} |
| 15 | Controller_Mouse::~Controller_Mouse() = default; | 15 | Controller_Mouse::~Controller_Mouse() = default; |
| 16 | 16 | ||
| 17 | void Controller_Mouse::OnInit() {} | 17 | void Controller_Mouse::OnInit() {} |
diff --git a/src/core/hle/service/hid/controllers/mouse.h b/src/core/hle/service/hid/controllers/mouse.h index df2da6ae3..357ab7107 100644 --- a/src/core/hle/service/hid/controllers/mouse.h +++ b/src/core/hle/service/hid/controllers/mouse.h | |||
| @@ -53,6 +53,5 @@ private: | |||
| 53 | std::unique_ptr<Input::MouseDevice> mouse_device; | 53 | std::unique_ptr<Input::MouseDevice> mouse_device; |
| 54 | std::array<std::unique_ptr<Input::ButtonDevice>, Settings::NativeMouseButton::NumMouseButtons> | 54 | std::array<std::unique_ptr<Input::ButtonDevice>, Settings::NativeMouseButton::NumMouseButtons> |
| 55 | mouse_button_devices; | 55 | mouse_button_devices; |
| 56 | Core::System& system; | ||
| 57 | }; | 56 | }; |
| 58 | } // namespace Service::HID | 57 | } // namespace Service::HID |
diff --git a/src/core/hle/service/hid/controllers/npad.cpp b/src/core/hle/service/hid/controllers/npad.cpp index a9cd119c4..a2b25a796 100644 --- a/src/core/hle/service/hid/controllers/npad.cpp +++ b/src/core/hle/service/hid/controllers/npad.cpp | |||
| @@ -20,7 +20,7 @@ | |||
| 20 | 20 | ||
| 21 | namespace Service::HID { | 21 | namespace Service::HID { |
| 22 | constexpr s32 HID_JOYSTICK_MAX = 0x7fff; | 22 | constexpr s32 HID_JOYSTICK_MAX = 0x7fff; |
| 23 | constexpr s32 HID_JOYSTICK_MIN = -0x7fff; | 23 | [[maybe_unused]] constexpr s32 HID_JOYSTICK_MIN = -0x7fff; |
| 24 | constexpr std::size_t NPAD_OFFSET = 0x9A00; | 24 | constexpr std::size_t NPAD_OFFSET = 0x9A00; |
| 25 | constexpr u32 BATTERY_FULL = 2; | 25 | constexpr u32 BATTERY_FULL = 2; |
| 26 | constexpr u32 MAX_NPAD_ID = 7; | 26 | constexpr u32 MAX_NPAD_ID = 7; |
| @@ -105,6 +105,8 @@ void Controller_NPad::InitNewlyAddedControler(std::size_t controller_idx) { | |||
| 105 | controller.joy_styles.raw = 0; // Zero out | 105 | controller.joy_styles.raw = 0; // Zero out |
| 106 | controller.device_type.raw = 0; | 106 | controller.device_type.raw = 0; |
| 107 | switch (controller_type) { | 107 | switch (controller_type) { |
| 108 | case NPadControllerType::None: | ||
| 109 | UNREACHABLE(); | ||
| 108 | case NPadControllerType::Handheld: | 110 | case NPadControllerType::Handheld: |
| 109 | controller.joy_styles.handheld.Assign(1); | 111 | controller.joy_styles.handheld.Assign(1); |
| 110 | controller.device_type.handheld.Assign(1); | 112 | controller.device_type.handheld.Assign(1); |
| @@ -239,7 +241,7 @@ void Controller_NPad::OnRelease() {} | |||
| 239 | 241 | ||
| 240 | void Controller_NPad::RequestPadStateUpdate(u32 npad_id) { | 242 | void Controller_NPad::RequestPadStateUpdate(u32 npad_id) { |
| 241 | const auto controller_idx = NPadIdToIndex(npad_id); | 243 | const auto controller_idx = NPadIdToIndex(npad_id); |
| 242 | const auto controller_type = connected_controllers[controller_idx].type; | 244 | [[maybe_unused]] const auto controller_type = connected_controllers[controller_idx].type; |
| 243 | if (!connected_controllers[controller_idx].is_connected) { | 245 | if (!connected_controllers[controller_idx].is_connected) { |
| 244 | return; | 246 | return; |
| 245 | } | 247 | } |
| @@ -346,6 +348,8 @@ void Controller_NPad::OnUpdate(const Core::Timing::CoreTiming& core_timing, u8* | |||
| 346 | libnx_entry.connection_status.raw = 0; | 348 | libnx_entry.connection_status.raw = 0; |
| 347 | 349 | ||
| 348 | switch (controller_type) { | 350 | switch (controller_type) { |
| 351 | case NPadControllerType::None: | ||
| 352 | UNREACHABLE(); | ||
| 349 | case NPadControllerType::Handheld: | 353 | case NPadControllerType::Handheld: |
| 350 | handheld_entry.connection_status.raw = 0; | 354 | handheld_entry.connection_status.raw = 0; |
| 351 | handheld_entry.connection_status.IsWired.Assign(1); | 355 | handheld_entry.connection_status.IsWired.Assign(1); |
diff --git a/src/core/hle/service/hid/controllers/stubbed.cpp b/src/core/hle/service/hid/controllers/stubbed.cpp index 9b829341e..9e527d176 100644 --- a/src/core/hle/service/hid/controllers/stubbed.cpp +++ b/src/core/hle/service/hid/controllers/stubbed.cpp | |||
| @@ -9,8 +9,7 @@ | |||
| 9 | 9 | ||
| 10 | namespace Service::HID { | 10 | namespace Service::HID { |
| 11 | 11 | ||
| 12 | Controller_Stubbed::Controller_Stubbed(Core::System& system) | 12 | Controller_Stubbed::Controller_Stubbed(Core::System& system) : ControllerBase(system) {} |
| 13 | : ControllerBase(system), system(system) {} | ||
| 14 | Controller_Stubbed::~Controller_Stubbed() = default; | 13 | Controller_Stubbed::~Controller_Stubbed() = default; |
| 15 | 14 | ||
| 16 | void Controller_Stubbed::OnInit() {} | 15 | void Controller_Stubbed::OnInit() {} |
diff --git a/src/core/hle/service/hid/controllers/stubbed.h b/src/core/hle/service/hid/controllers/stubbed.h index 37d7d8538..4fa83ac85 100644 --- a/src/core/hle/service/hid/controllers/stubbed.h +++ b/src/core/hle/service/hid/controllers/stubbed.h | |||
| @@ -30,6 +30,5 @@ public: | |||
| 30 | private: | 30 | private: |
| 31 | bool smart_update{}; | 31 | bool smart_update{}; |
| 32 | std::size_t common_offset{}; | 32 | std::size_t common_offset{}; |
| 33 | Core::System& system; | ||
| 34 | }; | 33 | }; |
| 35 | } // namespace Service::HID | 34 | } // namespace Service::HID |
diff --git a/src/core/hle/service/hid/controllers/touchscreen.cpp b/src/core/hle/service/hid/controllers/touchscreen.cpp index 25912fd69..1c6e55566 100644 --- a/src/core/hle/service/hid/controllers/touchscreen.cpp +++ b/src/core/hle/service/hid/controllers/touchscreen.cpp | |||
| @@ -13,8 +13,7 @@ | |||
| 13 | namespace Service::HID { | 13 | namespace Service::HID { |
| 14 | constexpr std::size_t SHARED_MEMORY_OFFSET = 0x400; | 14 | constexpr std::size_t SHARED_MEMORY_OFFSET = 0x400; |
| 15 | 15 | ||
| 16 | Controller_Touchscreen::Controller_Touchscreen(Core::System& system) | 16 | Controller_Touchscreen::Controller_Touchscreen(Core::System& system) : ControllerBase(system) {} |
| 17 | : ControllerBase(system), system(system) {} | ||
| 18 | Controller_Touchscreen::~Controller_Touchscreen() = default; | 17 | Controller_Touchscreen::~Controller_Touchscreen() = default; |
| 19 | 18 | ||
| 20 | void Controller_Touchscreen::OnInit() {} | 19 | void Controller_Touchscreen::OnInit() {} |
diff --git a/src/core/hle/service/hid/controllers/touchscreen.h b/src/core/hle/service/hid/controllers/touchscreen.h index 3429c84db..a1d97269e 100644 --- a/src/core/hle/service/hid/controllers/touchscreen.h +++ b/src/core/hle/service/hid/controllers/touchscreen.h | |||
| @@ -69,6 +69,5 @@ private: | |||
| 69 | TouchScreenSharedMemory shared_memory{}; | 69 | TouchScreenSharedMemory shared_memory{}; |
| 70 | std::unique_ptr<Input::TouchDevice> touch_device; | 70 | std::unique_ptr<Input::TouchDevice> touch_device; |
| 71 | s64_le last_touch{}; | 71 | s64_le last_touch{}; |
| 72 | Core::System& system; | ||
| 73 | }; | 72 | }; |
| 74 | } // namespace Service::HID | 73 | } // namespace Service::HID |
diff --git a/src/core/hle/service/hid/controllers/xpad.cpp b/src/core/hle/service/hid/controllers/xpad.cpp index 1bce044b4..27511b27b 100644 --- a/src/core/hle/service/hid/controllers/xpad.cpp +++ b/src/core/hle/service/hid/controllers/xpad.cpp | |||
| @@ -10,7 +10,7 @@ | |||
| 10 | namespace Service::HID { | 10 | namespace Service::HID { |
| 11 | constexpr std::size_t SHARED_MEMORY_OFFSET = 0x3C00; | 11 | constexpr std::size_t SHARED_MEMORY_OFFSET = 0x3C00; |
| 12 | 12 | ||
| 13 | Controller_XPad::Controller_XPad(Core::System& system) : ControllerBase(system), system(system) {} | 13 | Controller_XPad::Controller_XPad(Core::System& system) : ControllerBase(system) {} |
| 14 | Controller_XPad::~Controller_XPad() = default; | 14 | Controller_XPad::~Controller_XPad() = default; |
| 15 | 15 | ||
| 16 | void Controller_XPad::OnInit() {} | 16 | void Controller_XPad::OnInit() {} |
diff --git a/src/core/hle/service/hid/controllers/xpad.h b/src/core/hle/service/hid/controllers/xpad.h index c445ebec0..ad229787c 100644 --- a/src/core/hle/service/hid/controllers/xpad.h +++ b/src/core/hle/service/hid/controllers/xpad.h | |||
| @@ -56,6 +56,5 @@ private: | |||
| 56 | }; | 56 | }; |
| 57 | static_assert(sizeof(SharedMemory) == 0x1000, "SharedMemory is an invalid size"); | 57 | static_assert(sizeof(SharedMemory) == 0x1000, "SharedMemory is an invalid size"); |
| 58 | SharedMemory shared_memory{}; | 58 | SharedMemory shared_memory{}; |
| 59 | Core::System& system; | ||
| 60 | }; | 59 | }; |
| 61 | } // namespace Service::HID | 60 | } // namespace Service::HID |
diff --git a/src/core/hle/service/hid/hid.cpp b/src/core/hle/service/hid/hid.cpp index 8d76ba746..41bddf870 100644 --- a/src/core/hle/service/hid/hid.cpp +++ b/src/core/hle/service/hid/hid.cpp | |||
| @@ -38,8 +38,10 @@ namespace Service::HID { | |||
| 38 | // Updating period for each HID device. | 38 | // Updating period for each HID device. |
| 39 | // TODO(ogniK): Find actual polling rate of hid | 39 | // TODO(ogniK): Find actual polling rate of hid |
| 40 | constexpr s64 pad_update_ticks = static_cast<s64>(Core::Timing::BASE_CLOCK_RATE / 66); | 40 | constexpr s64 pad_update_ticks = static_cast<s64>(Core::Timing::BASE_CLOCK_RATE / 66); |
| 41 | constexpr s64 accelerometer_update_ticks = static_cast<s64>(Core::Timing::BASE_CLOCK_RATE / 100); | 41 | [[maybe_unused]] constexpr s64 accelerometer_update_ticks = |
| 42 | constexpr s64 gyroscope_update_ticks = static_cast<s64>(Core::Timing::BASE_CLOCK_RATE / 100); | 42 | static_cast<s64>(Core::Timing::BASE_CLOCK_RATE / 100); |
| 43 | [[maybe_unused]] constexpr s64 gyroscope_update_ticks = | ||
| 44 | static_cast<s64>(Core::Timing::BASE_CLOCK_RATE / 100); | ||
| 43 | constexpr std::size_t SHARED_MEMORY_SIZE = 0x40000; | 45 | constexpr std::size_t SHARED_MEMORY_SIZE = 0x40000; |
| 44 | 46 | ||
| 45 | IAppletResource::IAppletResource(Core::System& system) | 47 | IAppletResource::IAppletResource(Core::System& system) |
diff --git a/src/core/hle/service/nfp/nfp.cpp b/src/core/hle/service/nfp/nfp.cpp index a42c22d44..aa886cd3e 100644 --- a/src/core/hle/service/nfp/nfp.cpp +++ b/src/core/hle/service/nfp/nfp.cpp | |||
| @@ -18,8 +18,8 @@ | |||
| 18 | namespace Service::NFP { | 18 | namespace Service::NFP { |
| 19 | 19 | ||
| 20 | namespace ErrCodes { | 20 | namespace ErrCodes { |
| 21 | constexpr ResultCode ERR_TAG_FAILED(ErrorModule::NFP, | 21 | [[maybe_unused]] constexpr ResultCode ERR_TAG_FAILED(ErrorModule::NFP, |
| 22 | -1); // TODO(ogniK): Find the actual error code | 22 | -1); // TODO(ogniK): Find the actual error code |
| 23 | constexpr ResultCode ERR_NO_APPLICATION_AREA(ErrorModule::NFP, 152); | 23 | constexpr ResultCode ERR_NO_APPLICATION_AREA(ErrorModule::NFP, 152); |
| 24 | } // namespace ErrCodes | 24 | } // namespace ErrCodes |
| 25 | 25 | ||
| @@ -35,7 +35,7 @@ Module::Interface::~Interface() = default; | |||
| 35 | class IUser final : public ServiceFramework<IUser> { | 35 | class IUser final : public ServiceFramework<IUser> { |
| 36 | public: | 36 | public: |
| 37 | IUser(Module::Interface& nfp_interface, Core::System& system) | 37 | IUser(Module::Interface& nfp_interface, Core::System& system) |
| 38 | : ServiceFramework("NFP::IUser"), nfp_interface(nfp_interface), system(system) { | 38 | : ServiceFramework("NFP::IUser"), nfp_interface(nfp_interface) { |
| 39 | static const FunctionInfo functions[] = { | 39 | static const FunctionInfo functions[] = { |
| 40 | {0, &IUser::Initialize, "Initialize"}, | 40 | {0, &IUser::Initialize, "Initialize"}, |
| 41 | {1, &IUser::Finalize, "Finalize"}, | 41 | {1, &IUser::Finalize, "Finalize"}, |
| @@ -183,6 +183,8 @@ private: | |||
| 183 | case DeviceState::TagRemoved: | 183 | case DeviceState::TagRemoved: |
| 184 | device_state = DeviceState::Initialized; | 184 | device_state = DeviceState::Initialized; |
| 185 | break; | 185 | break; |
| 186 | default: | ||
| 187 | break; | ||
| 186 | } | 188 | } |
| 187 | IPC::ResponseBuilder rb{ctx, 2}; | 189 | IPC::ResponseBuilder rb{ctx, 2}; |
| 188 | rb.Push(RESULT_SUCCESS); | 190 | rb.Push(RESULT_SUCCESS); |
| @@ -324,7 +326,6 @@ private: | |||
| 324 | Kernel::EventPair deactivate_event; | 326 | Kernel::EventPair deactivate_event; |
| 325 | Kernel::EventPair availability_change_event; | 327 | Kernel::EventPair availability_change_event; |
| 326 | const Module::Interface& nfp_interface; | 328 | const Module::Interface& nfp_interface; |
| 327 | Core::System& system; | ||
| 328 | }; | 329 | }; |
| 329 | 330 | ||
| 330 | void Module::Interface::CreateUserInterface(Kernel::HLERequestContext& ctx) { | 331 | void Module::Interface::CreateUserInterface(Kernel::HLERequestContext& ctx) { |
diff --git a/src/core/hle/service/nvdrv/devices/nvhost_as_gpu.cpp b/src/core/hle/service/nvdrv/devices/nvhost_as_gpu.cpp index 6bc053f27..07c88465e 100644 --- a/src/core/hle/service/nvdrv/devices/nvhost_as_gpu.cpp +++ b/src/core/hle/service/nvdrv/devices/nvhost_as_gpu.cpp | |||
| @@ -45,6 +45,8 @@ u32 nvhost_as_gpu::ioctl(Ioctl command, const std::vector<u8>& input, const std: | |||
| 45 | return GetVARegions(input, output); | 45 | return GetVARegions(input, output); |
| 46 | case IoctlCommand::IocUnmapBufferCommand: | 46 | case IoctlCommand::IocUnmapBufferCommand: |
| 47 | return UnmapBuffer(input, output); | 47 | return UnmapBuffer(input, output); |
| 48 | default: | ||
| 49 | break; | ||
| 48 | } | 50 | } |
| 49 | 51 | ||
| 50 | if (static_cast<IoctlCommand>(command.cmd.Value()) == IoctlCommand::IocRemapCommand) | 52 | if (static_cast<IoctlCommand>(command.cmd.Value()) == IoctlCommand::IocRemapCommand) |
diff --git a/src/core/hle/service/nvdrv/devices/nvhost_ctrl.cpp b/src/core/hle/service/nvdrv/devices/nvhost_ctrl.cpp index ff6b1abae..eb88fee1b 100644 --- a/src/core/hle/service/nvdrv/devices/nvhost_ctrl.cpp +++ b/src/core/hle/service/nvdrv/devices/nvhost_ctrl.cpp | |||
| @@ -38,9 +38,10 @@ u32 nvhost_ctrl::ioctl(Ioctl command, const std::vector<u8>& input, const std::v | |||
| 38 | return IocCtrlEventUnregister(input, output); | 38 | return IocCtrlEventUnregister(input, output); |
| 39 | case IoctlCommand::IocCtrlEventSignalCommand: | 39 | case IoctlCommand::IocCtrlEventSignalCommand: |
| 40 | return IocCtrlEventSignal(input, output); | 40 | return IocCtrlEventSignal(input, output); |
| 41 | default: | ||
| 42 | UNIMPLEMENTED_MSG("Unimplemented ioctl"); | ||
| 43 | return 0; | ||
| 41 | } | 44 | } |
| 42 | UNIMPLEMENTED_MSG("Unimplemented ioctl"); | ||
| 43 | return 0; | ||
| 44 | } | 45 | } |
| 45 | 46 | ||
| 46 | u32 nvhost_ctrl::NvOsGetConfigU32(const std::vector<u8>& input, std::vector<u8>& output) { | 47 | u32 nvhost_ctrl::NvOsGetConfigU32(const std::vector<u8>& input, std::vector<u8>& output) { |
diff --git a/src/core/hle/service/nvdrv/devices/nvhost_ctrl_gpu.cpp b/src/core/hle/service/nvdrv/devices/nvhost_ctrl_gpu.cpp index 389ace76f..cc2192e5c 100644 --- a/src/core/hle/service/nvdrv/devices/nvhost_ctrl_gpu.cpp +++ b/src/core/hle/service/nvdrv/devices/nvhost_ctrl_gpu.cpp | |||
| @@ -40,9 +40,10 @@ u32 nvhost_ctrl_gpu::ioctl(Ioctl command, const std::vector<u8>& input, | |||
| 40 | return FlushL2(input, output); | 40 | return FlushL2(input, output); |
| 41 | case IoctlCommand::IocGetGpuTime: | 41 | case IoctlCommand::IocGetGpuTime: |
| 42 | return GetGpuTime(input, output); | 42 | return GetGpuTime(input, output); |
| 43 | default: | ||
| 44 | UNIMPLEMENTED_MSG("Unimplemented ioctl"); | ||
| 45 | return 0; | ||
| 43 | } | 46 | } |
| 44 | UNIMPLEMENTED_MSG("Unimplemented ioctl"); | ||
| 45 | return 0; | ||
| 46 | } | 47 | } |
| 47 | 48 | ||
| 48 | u32 nvhost_ctrl_gpu::GetCharacteristics(const std::vector<u8>& input, std::vector<u8>& output, | 49 | u32 nvhost_ctrl_gpu::GetCharacteristics(const std::vector<u8>& input, std::vector<u8>& output, |
diff --git a/src/core/hle/service/nvdrv/devices/nvhost_gpu.cpp b/src/core/hle/service/nvdrv/devices/nvhost_gpu.cpp index 2b8d1bef6..9de0ace22 100644 --- a/src/core/hle/service/nvdrv/devices/nvhost_gpu.cpp +++ b/src/core/hle/service/nvdrv/devices/nvhost_gpu.cpp | |||
| @@ -44,6 +44,8 @@ u32 nvhost_gpu::ioctl(Ioctl command, const std::vector<u8>& input, const std::ve | |||
| 44 | return GetWaitbase(input, output); | 44 | return GetWaitbase(input, output); |
| 45 | case IoctlCommand::IocChannelSetTimeoutCommand: | 45 | case IoctlCommand::IocChannelSetTimeoutCommand: |
| 46 | return ChannelSetTimeout(input, output); | 46 | return ChannelSetTimeout(input, output); |
| 47 | default: | ||
| 48 | break; | ||
| 47 | } | 49 | } |
| 48 | 50 | ||
| 49 | if (command.group == NVGPU_IOCTL_MAGIC) { | 51 | if (command.group == NVGPU_IOCTL_MAGIC) { |