diff options
| author |  Lioncash | 2019-05-23 14:24:11 -0400 |
|---|---|---|
| committer | Lioncash | 2019-05-23 14:24:13 -0400 |
| commit | 11e9bee91d645cba69e936916394a0a03875c878 (patch) | |
| tree | f27f82a7cfedb748013fa0d6f236f8dd3583d7e2 /src/core/telemetry_session.cpp | |
| parent | common/file_util: Remove duplicated documentation comments (diff) | |
| download | yuzu-11e9bee91d645cba69e936916394a0a03875c878.tar.gz yuzu-11e9bee91d645cba69e936916394a0a03875c878.tar.xz yuzu-11e9bee91d645cba69e936916394a0a03875c878.zip | |
common/file_util: Make GetCurrentDir() return a std::optional
nullptr was being returned in the error case, which, at a glance may
seem perfectly OK... until you realize that std::string has the
invariant that it may not be constructed from a null pointer. This
means that if this error case was ever hit, then the application would
most likely crash from a thrown exception in std::string's constructor.
Instead, we can change the function to return an optional value,
indicating if a failure occurred.
Diffstat (limited to 'src/core/telemetry_session.cpp')
0 files changed, 0 insertions, 0 deletions