diff options
| author | 2021-04-27 12:05:34 -0400 | |
|---|---|---|
| committer | 2021-04-27 12:48:15 -0400 | |
| commit | 724c19a307f31ce1122fb8047c86d5a126d0860f (patch) | |
| tree | 605b89f42d7897aac46f06add54c34201d9354bd /src/core/loader/nro.h | |
| parent | Merge pull request #6246 from lioncash/shadow (diff) | |
| download | yuzu-724c19a307f31ce1122fb8047c86d5a126d0860f.tar.gz yuzu-724c19a307f31ce1122fb8047c86d5a126d0860f.tar.xz yuzu-724c19a307f31ce1122fb8047c86d5a126d0860f.zip | |
loader: Resolve instances of variable shadowing
Eliminates variable shadowing cases across all the loaders to bring us
closer to enabling variable shadowing as an error in core.
Diffstat (limited to 'src/core/loader/nro.h')
| -rw-r--r-- | src/core/loader/nro.h | 14 |
1 files changed, 8 insertions, 6 deletions
diff --git a/src/core/loader/nro.h b/src/core/loader/nro.h index a82b66221..20bbaeb0e 100644 --- a/src/core/loader/nro.h +++ b/src/core/loader/nro.h | |||
| @@ -27,15 +27,17 @@ namespace Loader { | |||
| 27 | /// Loads an NRO file | 27 | /// Loads an NRO file |
| 28 | class AppLoader_NRO final : public AppLoader { | 28 | class AppLoader_NRO final : public AppLoader { |
| 29 | public: | 29 | public: |
| 30 | explicit AppLoader_NRO(FileSys::VirtualFile file); | 30 | explicit AppLoader_NRO(FileSys::VirtualFile file_); |
| 31 | ~AppLoader_NRO() override; | 31 | ~AppLoader_NRO() override; |
| 32 | 32 | ||
| 33 | /** | 33 | /** |
| 34 | * Returns the type of the file | 34 | * Identifies whether or not the given file is an NRO file. |
| 35 | * @param file open file | 35 | * |
| 36 | * @return FileType found, or FileType::Error if this loader doesn't know it | 36 | * @param nro_file The file to identify. |
| 37 | * | ||
| 38 | * @return FileType::NRO, or FileType::Error if the file is not an NRO file. | ||
| 37 | */ | 39 | */ |
| 38 | static FileType IdentifyType(const FileSys::VirtualFile& file); | 40 | static FileType IdentifyType(const FileSys::VirtualFile& nro_file); |
| 39 | 41 | ||
| 40 | FileType GetFileType() const override { | 42 | FileType GetFileType() const override { |
| 41 | return IdentifyType(file); | 43 | return IdentifyType(file); |
| @@ -51,7 +53,7 @@ public: | |||
| 51 | bool IsRomFSUpdatable() const override; | 53 | bool IsRomFSUpdatable() const override; |
| 52 | 54 | ||
| 53 | private: | 55 | private: |
| 54 | bool LoadNro(Kernel::Process& process, const FileSys::VfsFile& file); | 56 | bool LoadNro(Kernel::Process& process, const FileSys::VfsFile& nro_file); |
| 55 | 57 | ||
| 56 | std::vector<u8> icon_data; | 58 | std::vector<u8> icon_data; |
| 57 | std::unique_ptr<FileSys::NACP> nacp; | 59 | std::unique_ptr<FileSys::NACP> nacp; |