summaryrefslogtreecommitdiff
path: root/src/core/loader/linker.cpp
diff options
context:
space:
mode:
authorGravatar Lioncash2018-07-23 17:39:21 -0400
committerGravatar Lioncash2018-07-23 17:40:12 -0400
commit184c516182c6855f03ec9aec3f3d5e2cae0686cf (patch)
treef693b87093f3fdc149bb2d4230d42ebf1cd106dd /src/core/loader/linker.cpp
parentMerge pull request #695 from DarkLordZach/nro-asset (diff)
downloadyuzu-184c516182c6855f03ec9aec3f3d5e2cae0686cf.tar.gz
yuzu-184c516182c6855f03ec9aec3f3d5e2cae0686cf.tar.xz
yuzu-184c516182c6855f03ec9aec3f3d5e2cae0686cf.zip
linker: Remove unused parameter from WriteRelocations()
is_jump_relocation is never used within the function, so we can just remove it.
Diffstat (limited to 'src/core/loader/linker.cpp')
-rw-r--r--src/core/loader/linker.cpp8
1 files changed, 3 insertions, 5 deletions
diff --git a/src/core/loader/linker.cpp b/src/core/loader/linker.cpp
index 769516b6f..57ca8c3ee 100644
--- a/src/core/loader/linker.cpp
+++ b/src/core/loader/linker.cpp
@@ -49,8 +49,7 @@ struct Elf64_Sym {
49static_assert(sizeof(Elf64_Sym) == 0x18, "Elf64_Sym has incorrect size."); 49static_assert(sizeof(Elf64_Sym) == 0x18, "Elf64_Sym has incorrect size.");
50 50
51void Linker::WriteRelocations(std::vector<u8>& program_image, const std::vector<Symbol>& symbols, 51void Linker::WriteRelocations(std::vector<u8>& program_image, const std::vector<Symbol>& symbols,
52 u64 relocation_offset, u64 size, bool is_jump_relocation, 52 u64 relocation_offset, u64 size, VAddr load_base) {
53 VAddr load_base) {
54 for (u64 i = 0; i < size; i += sizeof(Elf64_Rela)) { 53 for (u64 i = 0; i < size; i += sizeof(Elf64_Rela)) {
55 Elf64_Rela rela; 54 Elf64_Rela rela;
56 std::memcpy(&rela, &program_image[relocation_offset + i], sizeof(Elf64_Rela)); 55 std::memcpy(&rela, &program_image[relocation_offset + i], sizeof(Elf64_Rela));
@@ -124,12 +123,11 @@ void Linker::Relocate(std::vector<u8>& program_image, u32 dynamic_section_offset
124 } 123 }
125 124
126 if (dynamic.find(DT_RELA) != dynamic.end()) { 125 if (dynamic.find(DT_RELA) != dynamic.end()) {
127 WriteRelocations(program_image, symbols, dynamic[DT_RELA], dynamic[DT_RELASZ], false, 126 WriteRelocations(program_image, symbols, dynamic[DT_RELA], dynamic[DT_RELASZ], load_base);
128 load_base);
129 } 127 }
130 128
131 if (dynamic.find(DT_JMPREL) != dynamic.end()) { 129 if (dynamic.find(DT_JMPREL) != dynamic.end()) {
132 WriteRelocations(program_image, symbols, dynamic[DT_JMPREL], dynamic[DT_PLTRELSZ], true, 130 WriteRelocations(program_image, symbols, dynamic[DT_JMPREL], dynamic[DT_PLTRELSZ],
133 load_base); 131 load_base);
134 } 132 }
135} 133}