summaryrefslogtreecommitdiff
path: root/src/core/hle
diff options
context:
space:
mode:
authorGravatar Subv2018-01-22 17:59:24 -0500
committerGravatar Subv2018-01-22 20:40:43 -0500
commitb0489c9a64588d2140d9a98b69c5a0adc541a436 (patch)
tree9b95ca11c277b6150dbc2e891e1ed2a83a3646fe /src/core/hle
parentTime: Don't create unnecessary ports when retrieving the clock service sessions. (diff)
downloadyuzu-b0489c9a64588d2140d9a98b69c5a0adc541a436.tar.gz
yuzu-b0489c9a64588d2140d9a98b69c5a0adc541a436.tar.xz
yuzu-b0489c9a64588d2140d9a98b69c5a0adc541a436.zip
Services: Added a todo about returning interfaces as domain objects in lm, hid and time.
Diffstat (limited to 'src/core/hle')
-rw-r--r--src/core/hle/service/hid/hid.cpp3
-rw-r--r--src/core/hle/service/lm/lm.cpp3
-rw-r--r--src/core/hle/service/time/time.cpp6
3 files changed, 12 insertions, 0 deletions
diff --git a/src/core/hle/service/hid/hid.cpp b/src/core/hle/service/hid/hid.cpp
index 9b1e680f1..ae60cc7b4 100644
--- a/src/core/hle/service/hid/hid.cpp
+++ b/src/core/hle/service/hid/hid.cpp
@@ -169,6 +169,9 @@ private:
169 applet_resource = std::make_shared<IAppletResource>(); 169 applet_resource = std::make_shared<IAppletResource>();
170 } 170 }
171 171
172 // TODO(Subv): Verify if this should return the interface as a domain object when called
173 // from within a domain.
174
172 auto sessions = Kernel::ServerSession::CreateSessionPair(applet_resource->GetServiceName()); 175 auto sessions = Kernel::ServerSession::CreateSessionPair(applet_resource->GetServiceName());
173 auto server = std::get<Kernel::SharedPtr<Kernel::ServerSession>>(sessions); 176 auto server = std::get<Kernel::SharedPtr<Kernel::ServerSession>>(sessions);
174 auto client = std::get<Kernel::SharedPtr<Kernel::ClientSession>>(sessions); 177 auto client = std::get<Kernel::SharedPtr<Kernel::ClientSession>>(sessions);
diff --git a/src/core/hle/service/lm/lm.cpp b/src/core/hle/service/lm/lm.cpp
index dd0f75ce1..b505cdcaf 100644
--- a/src/core/hle/service/lm/lm.cpp
+++ b/src/core/hle/service/lm/lm.cpp
@@ -146,6 +146,9 @@ void InstallInterfaces(SM::ServiceManager& service_manager) {
146 * 0: ResultCode 146 * 0: ResultCode
147 */ 147 */
148void LM::Initialize(Kernel::HLERequestContext& ctx) { 148void LM::Initialize(Kernel::HLERequestContext& ctx) {
149 // TODO(Subv): Verify if this should return the interface as a domain object when called from
150 // within a domain.
151
149 auto logger = std::make_shared<Logger>(); 152 auto logger = std::make_shared<Logger>();
150 auto sessions = Kernel::ServerSession::CreateSessionPair(logger->GetServiceName()); 153 auto sessions = Kernel::ServerSession::CreateSessionPair(logger->GetServiceName());
151 auto server = std::get<Kernel::SharedPtr<Kernel::ServerSession>>(sessions); 154 auto server = std::get<Kernel::SharedPtr<Kernel::ServerSession>>(sessions);
diff --git a/src/core/hle/service/time/time.cpp b/src/core/hle/service/time/time.cpp
index 9039a4cec..8abb2ce7a 100644
--- a/src/core/hle/service/time/time.cpp
+++ b/src/core/hle/service/time/time.cpp
@@ -83,6 +83,8 @@ private:
83}; 83};
84 84
85void Module::Interface::GetStandardUserSystemClock(Kernel::HLERequestContext& ctx) { 85void Module::Interface::GetStandardUserSystemClock(Kernel::HLERequestContext& ctx) {
86 // TODO(Subv): Verify if this should return the interface as a domain object when called from
87 // within a domain.
86 auto system_clock = std::make_shared<ISystemClock>(); 88 auto system_clock = std::make_shared<ISystemClock>();
87 auto sessions = Kernel::ServerSession::CreateSessionPair(system_clock->GetServiceName()); 89 auto sessions = Kernel::ServerSession::CreateSessionPair(system_clock->GetServiceName());
88 auto server = std::get<Kernel::SharedPtr<Kernel::ServerSession>>(sessions); 90 auto server = std::get<Kernel::SharedPtr<Kernel::ServerSession>>(sessions);
@@ -95,6 +97,8 @@ void Module::Interface::GetStandardUserSystemClock(Kernel::HLERequestContext& ct
95} 97}
96 98
97void Module::Interface::GetStandardNetworkSystemClock(Kernel::HLERequestContext& ctx) { 99void Module::Interface::GetStandardNetworkSystemClock(Kernel::HLERequestContext& ctx) {
100 // TODO(Subv): Verify if this should return the interface as a domain object when called from
101 // within a domain.
98 auto system_clock = std::make_shared<ISystemClock>(); 102 auto system_clock = std::make_shared<ISystemClock>();
99 auto sessions = Kernel::ServerSession::CreateSessionPair(system_clock->GetServiceName()); 103 auto sessions = Kernel::ServerSession::CreateSessionPair(system_clock->GetServiceName());
100 auto server = std::get<Kernel::SharedPtr<Kernel::ServerSession>>(sessions); 104 auto server = std::get<Kernel::SharedPtr<Kernel::ServerSession>>(sessions);
@@ -107,6 +111,8 @@ void Module::Interface::GetStandardNetworkSystemClock(Kernel::HLERequestContext&
107} 111}
108 112
109void Module::Interface::GetStandardSteadyClock(Kernel::HLERequestContext& ctx) { 113void Module::Interface::GetStandardSteadyClock(Kernel::HLERequestContext& ctx) {
114 // TODO(Subv): Verify if this should return the interface as a domain object when called from
115 // within a domain.
110 auto steady_clock = std::make_shared<ISteadyClock>(); 116 auto steady_clock = std::make_shared<ISteadyClock>();
111 auto sessions = Kernel::ServerSession::CreateSessionPair(steady_clock->GetServiceName()); 117 auto sessions = Kernel::ServerSession::CreateSessionPair(steady_clock->GetServiceName());
112 auto server = std::get<Kernel::SharedPtr<Kernel::ServerSession>>(sessions); 118 auto server = std::get<Kernel::SharedPtr<Kernel::ServerSession>>(sessions);