summaryrefslogtreecommitdiff
path: root/src/core/hle/service/service.cpp
diff options
context:
space:
mode:
authorGravatar bunnei2017-12-28 15:24:59 -0500
committerGravatar bunnei2017-12-28 15:24:59 -0500
commit16fb1c8fe75338ef9848d9ed75247c3b869bea57 (patch)
tree372c4ba41c00f2c35f8e23436108fa51a03ca286 /src/core/hle/service/service.cpp
parentservice: Add empty interface for aoc:u. (diff)
downloadyuzu-16fb1c8fe75338ef9848d9ed75247c3b869bea57.tar.gz
yuzu-16fb1c8fe75338ef9848d9ed75247c3b869bea57.tar.xz
yuzu-16fb1c8fe75338ef9848d9ed75247c3b869bea57.zip
service: Halt on ReportUnimplementedFunction and improve output log.
Diffstat (limited to 'src/core/hle/service/service.cpp')
-rw-r--r--src/core/hle/service/service.cpp6
1 files changed, 2 insertions, 4 deletions
diff --git a/src/core/hle/service/service.cpp b/src/core/hle/service/service.cpp
index 66125f52b..3394ea414 100644
--- a/src/core/hle/service/service.cpp
+++ b/src/core/hle/service/service.cpp
@@ -96,7 +96,7 @@ void ServiceFrameworkBase::RegisterHandlersBase(const FunctionInfoBase* function
96void ServiceFrameworkBase::ReportUnimplementedFunction(Kernel::HLERequestContext& ctx, 96void ServiceFrameworkBase::ReportUnimplementedFunction(Kernel::HLERequestContext& ctx,
97 const FunctionInfoBase* info) { 97 const FunctionInfoBase* info) {
98 auto cmd_buf = ctx.CommandBuffer(); 98 auto cmd_buf = ctx.CommandBuffer();
99 std::string function_name = info == nullptr ? fmt::format("{:#08x}", ctx.GetCommand()) : info->name; 99 std::string function_name = info == nullptr ? fmt::format("{}", ctx.GetCommand()) : info->name;
100 100
101 fmt::MemoryWriter w; 101 fmt::MemoryWriter w;
102 w.write("function '{}': port='{}' cmd_buf={{[0]={:#x}", function_name, service_name, 102 w.write("function '{}': port='{}' cmd_buf={{[0]={:#x}", function_name, service_name,
@@ -107,9 +107,7 @@ void ServiceFrameworkBase::ReportUnimplementedFunction(Kernel::HLERequestContext
107 w << '}'; 107 w << '}';
108 108
109 LOG_ERROR(Service, "unknown / unimplemented %s", w.c_str()); 109 LOG_ERROR(Service, "unknown / unimplemented %s", w.c_str());
110 // TODO(bunnei): Hack - ignore error 110 UNIMPLEMENTED();
111 IPC::RequestBuilder rb{ctx, 1};
112 rb.Push(RESULT_SUCCESS);
113} 111}
114 112
115void ServiceFrameworkBase::InvokeRequest(Kernel::HLERequestContext& ctx) { 113void ServiceFrameworkBase::InvokeRequest(Kernel::HLERequestContext& ctx) {