summaryrefslogtreecommitdiff
path: root/src/core/hle/service/nifm
diff options
context:
space:
mode:
authorGravatar VolcaEM2020-05-21 10:23:53 +0200
committerGravatar GitHub2020-05-21 10:23:53 +0200
commit235805edf30475131299fe6a1c3fd772cd6dba98 (patch)
tree2662ece11dd0cdc29b08328e7f8ac02126654358 /src/core/hle/service/nifm
parentMerge pull request #3946 from ogniK5377/sysverdat-10-0-2 (diff)
downloadyuzu-235805edf30475131299fe6a1c3fd772cd6dba98.tar.gz
yuzu-235805edf30475131299fe6a1c3fd772cd6dba98.tar.xz
yuzu-235805edf30475131299fe6a1c3fd772cd6dba98.zip
nifm: correct assert in CreateTemporaryNetworkProfile
This has been wrong since https://github.com/yuzu-emu/yuzu/commit/0432af5ad1ec34f02071f6fdc5fc78149b059f18 I haven't found a game that called this function (and I haven't tried this on a real Switch), and because of this I haven't been able to check if the number in assert OR the string in the assert is wrong, but one of the two is wrong: NetworkProfileData is 0x18E, while SfNetworkProfileData is 0x17C, according to Switchbrew Switchbrew doesn't officially say that NetworkProfileData's size is 0x18E but it's possible to calculate its size since Switchbrew provides the size and the offset of all the components of NetworkProfileData (which isn't currently implemented in yuzu, alongside SfNetworkProfileData) NetworkProfileData documentation: https://switchbrew.org/wiki/Network_Interface_services#NetworkProfileData SfNetworkProfileData documentation: https://switchbrew.org/wiki/Network_Interface_services#SfNetworkProfileData Since I trust ogniK's work on reversing NIFM, I'd assume this was just a typo in the string
Diffstat (limited to 'src/core/hle/service/nifm')
-rw-r--r--src/core/hle/service/nifm/nifm.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/core/hle/service/nifm/nifm.cpp b/src/core/hle/service/nifm/nifm.cpp
index 767158444..aa6fbf67f 100644
--- a/src/core/hle/service/nifm/nifm.cpp
+++ b/src/core/hle/service/nifm/nifm.cpp
@@ -177,7 +177,7 @@ private:
177 void CreateTemporaryNetworkProfile(Kernel::HLERequestContext& ctx) { 177 void CreateTemporaryNetworkProfile(Kernel::HLERequestContext& ctx) {
178 LOG_DEBUG(Service_NIFM, "called"); 178 LOG_DEBUG(Service_NIFM, "called");
179 179
180 ASSERT_MSG(ctx.GetReadBufferSize() == 0x17c, "NetworkProfileData is not the correct size"); 180 ASSERT_MSG(ctx.GetReadBufferSize() == 0x17c, "SfNetworkProfileData is not the correct size");
181 u128 uuid{}; 181 u128 uuid{};
182 auto buffer = ctx.ReadBuffer(); 182 auto buffer = ctx.ReadBuffer();
183 std::memcpy(&uuid, buffer.data() + 8, sizeof(u128)); 183 std::memcpy(&uuid, buffer.data() + 8, sizeof(u128));