summaryrefslogtreecommitdiff
path: root/src/core/hle/kernel
diff options
context:
space:
mode:
authorGravatar bunnei2019-11-03 04:10:12 -0500
committerGravatar bunnei2019-11-03 04:22:45 -0500
commitb0ab803ce853739a0b8595ee95599d0fab46c78a (patch)
tree0430782a5fae74d06891dad3732db26d5dd4a189 /src/core/hle/kernel
parentkernel: readable_event: Initialize members. (diff)
downloadyuzu-b0ab803ce853739a0b8595ee95599d0fab46c78a.tar.gz
yuzu-b0ab803ce853739a0b8595ee95599d0fab46c78a.tar.xz
yuzu-b0ab803ce853739a0b8595ee95599d0fab46c78a.zip
kernel: events: Remove ResetType::Automatic.
- This does not actually seem to exist in the real kernel - games reset these automatically. # Conflicts: # src/core/hle/service/am/applets/applets.cpp # src/core/hle/service/filesystem/fsp_srv.cpp
Diffstat (limited to 'src/core/hle/kernel')
-rw-r--r--src/core/hle/kernel/hle_ipc.cpp3
-rw-r--r--src/core/hle/kernel/object.h5
-rw-r--r--src/core/hle/kernel/readable_event.cpp4
-rw-r--r--src/core/hle/kernel/readable_event.h5
-rw-r--r--src/core/hle/kernel/svc.cpp2
-rw-r--r--src/core/hle/kernel/writable_event.cpp8
-rw-r--r--src/core/hle/kernel/writable_event.h6
7 files changed, 4 insertions, 29 deletions
diff --git a/src/core/hle/kernel/hle_ipc.cpp b/src/core/hle/kernel/hle_ipc.cpp
index f3da525d6..a7b5849b0 100644
--- a/src/core/hle/kernel/hle_ipc.cpp
+++ b/src/core/hle/kernel/hle_ipc.cpp
@@ -58,8 +58,7 @@ SharedPtr<WritableEvent> HLERequestContext::SleepClientThread(
58 auto& kernel = Core::System::GetInstance().Kernel(); 58 auto& kernel = Core::System::GetInstance().Kernel();
59 if (!writable_event) { 59 if (!writable_event) {
60 // Create event if not provided 60 // Create event if not provided
61 const auto pair = WritableEvent::CreateEventPair(kernel, ResetType::Automatic, 61 const auto pair = WritableEvent::CreateEventPair(kernel, "HLE Pause Event: " + reason);
62 "HLE Pause Event: " + reason);
63 writable_event = pair.writable; 62 writable_event = pair.writable;
64 } 63 }
65 64
diff --git a/src/core/hle/kernel/object.h b/src/core/hle/kernel/object.h
index 2821176a7..a6faeb83b 100644
--- a/src/core/hle/kernel/object.h
+++ b/src/core/hle/kernel/object.h
@@ -32,11 +32,6 @@ enum class HandleType : u32 {
32 ServerSession, 32 ServerSession,
33}; 33};
34 34
35enum class ResetType {
36 Automatic, ///< Reset automatically on object acquisition
37 Manual, ///< Never reset automatically
38};
39
40class Object : NonCopyable { 35class Object : NonCopyable {
41public: 36public:
42 explicit Object(KernelCore& kernel); 37 explicit Object(KernelCore& kernel);
diff --git a/src/core/hle/kernel/readable_event.cpp b/src/core/hle/kernel/readable_event.cpp
index 06463cd26..7c291b426 100644
--- a/src/core/hle/kernel/readable_event.cpp
+++ b/src/core/hle/kernel/readable_event.cpp
@@ -20,10 +20,6 @@ bool ReadableEvent::ShouldWait(const Thread* thread) const {
20 20
21void ReadableEvent::Acquire(Thread* thread) { 21void ReadableEvent::Acquire(Thread* thread) {
22 ASSERT_MSG(!ShouldWait(thread), "object unavailable!"); 22 ASSERT_MSG(!ShouldWait(thread), "object unavailable!");
23
24 if (reset_type == ResetType::Automatic) {
25 signaled = false;
26 }
27} 23}
28 24
29void ReadableEvent::Signal() { 25void ReadableEvent::Signal() {
diff --git a/src/core/hle/kernel/readable_event.h b/src/core/hle/kernel/readable_event.h
index 3bf9f95ac..11ff71c3a 100644
--- a/src/core/hle/kernel/readable_event.h
+++ b/src/core/hle/kernel/readable_event.h
@@ -27,10 +27,6 @@ public:
27 return name; 27 return name;
28 } 28 }
29 29
30 ResetType GetResetType() const {
31 return reset_type;
32 }
33
34 static constexpr HandleType HANDLE_TYPE = HandleType::ReadableEvent; 30 static constexpr HandleType HANDLE_TYPE = HandleType::ReadableEvent;
35 HandleType GetHandleType() const override { 31 HandleType GetHandleType() const override {
36 return HANDLE_TYPE; 32 return HANDLE_TYPE;
@@ -55,7 +51,6 @@ private:
55 51
56 void Signal(); 52 void Signal();
57 53
58 ResetType reset_type;
59 bool signaled{}; 54 bool signaled{};
60 55
61 std::string name; ///< Name of event (optional) 56 std::string name; ///< Name of event (optional)
diff --git a/src/core/hle/kernel/svc.cpp b/src/core/hle/kernel/svc.cpp
index f64236be1..c63a9ba8b 100644
--- a/src/core/hle/kernel/svc.cpp
+++ b/src/core/hle/kernel/svc.cpp
@@ -2099,7 +2099,7 @@ static ResultCode CreateEvent(Core::System& system, Handle* write_handle, Handle
2099 2099
2100 auto& kernel = system.Kernel(); 2100 auto& kernel = system.Kernel();
2101 const auto [readable_event, writable_event] = 2101 const auto [readable_event, writable_event] =
2102 WritableEvent::CreateEventPair(kernel, ResetType::Manual, "CreateEvent"); 2102 WritableEvent::CreateEventPair(kernel, "CreateEvent");
2103 2103
2104 HandleTable& handle_table = kernel.CurrentProcess()->GetHandleTable(); 2104 HandleTable& handle_table = kernel.CurrentProcess()->GetHandleTable();
2105 2105
diff --git a/src/core/hle/kernel/writable_event.cpp b/src/core/hle/kernel/writable_event.cpp
index a58ea6ec8..c783a34ee 100644
--- a/src/core/hle/kernel/writable_event.cpp
+++ b/src/core/hle/kernel/writable_event.cpp
@@ -15,8 +15,7 @@ namespace Kernel {
15WritableEvent::WritableEvent(KernelCore& kernel) : Object{kernel} {} 15WritableEvent::WritableEvent(KernelCore& kernel) : Object{kernel} {}
16WritableEvent::~WritableEvent() = default; 16WritableEvent::~WritableEvent() = default;
17 17
18EventPair WritableEvent::CreateEventPair(KernelCore& kernel, ResetType reset_type, 18EventPair WritableEvent::CreateEventPair(KernelCore& kernel, std::string name) {
19 std::string name) {
20 SharedPtr<WritableEvent> writable_event(new WritableEvent(kernel)); 19 SharedPtr<WritableEvent> writable_event(new WritableEvent(kernel));
21 SharedPtr<ReadableEvent> readable_event(new ReadableEvent(kernel)); 20 SharedPtr<ReadableEvent> readable_event(new ReadableEvent(kernel));
22 21
@@ -24,7 +23,6 @@ EventPair WritableEvent::CreateEventPair(KernelCore& kernel, ResetType reset_typ
24 writable_event->readable = readable_event; 23 writable_event->readable = readable_event;
25 readable_event->name = name + ":Readable"; 24 readable_event->name = name + ":Readable";
26 readable_event->signaled = false; 25 readable_event->signaled = false;
27 readable_event->reset_type = reset_type;
28 26
29 return {std::move(readable_event), std::move(writable_event)}; 27 return {std::move(readable_event), std::move(writable_event)};
30} 28}
@@ -33,10 +31,6 @@ SharedPtr<ReadableEvent> WritableEvent::GetReadableEvent() const {
33 return readable; 31 return readable;
34} 32}
35 33
36ResetType WritableEvent::GetResetType() const {
37 return readable->reset_type;
38}
39
40void WritableEvent::Signal() { 34void WritableEvent::Signal() {
41 readable->Signal(); 35 readable->Signal();
42} 36}
diff --git a/src/core/hle/kernel/writable_event.h b/src/core/hle/kernel/writable_event.h
index d00c92a6b..f46cf1dd8 100644
--- a/src/core/hle/kernel/writable_event.h
+++ b/src/core/hle/kernel/writable_event.h
@@ -24,11 +24,9 @@ public:
24 /** 24 /**
25 * Creates an event 25 * Creates an event
26 * @param kernel The kernel instance to create this event under. 26 * @param kernel The kernel instance to create this event under.
27 * @param reset_type ResetType describing how to create event
28 * @param name Optional name of event 27 * @param name Optional name of event
29 */ 28 */
30 static EventPair CreateEventPair(KernelCore& kernel, ResetType reset_type, 29 static EventPair CreateEventPair(KernelCore& kernel, std::string name = "Unknown");
31 std::string name = "Unknown");
32 30
33 std::string GetTypeName() const override { 31 std::string GetTypeName() const override {
34 return "WritableEvent"; 32 return "WritableEvent";
@@ -44,8 +42,6 @@ public:
44 42
45 SharedPtr<ReadableEvent> GetReadableEvent() const; 43 SharedPtr<ReadableEvent> GetReadableEvent() const;
46 44
47 ResetType GetResetType() const;
48
49 void Signal(); 45 void Signal();
50 void Clear(); 46 void Clear();
51 bool IsSignaled() const; 47 bool IsSignaled() const;