summaryrefslogtreecommitdiff
path: root/src/core/hle/kernel
diff options
context:
space:
mode:
authorGravatar Merry2024-01-02 21:13:04 +0000
committerGravatar Merry2024-01-02 21:34:34 +0000
commit0f7fc9411129c110ef751d18f80e02f18b63c201 (patch)
treecc793ffa918fddb241b8dd9d20a06debaaae87c9 /src/core/hle/kernel
parentMerge pull request #12554 from german77/directconnect (diff)
downloadyuzu-0f7fc9411129c110ef751d18f80e02f18b63c201.tar.gz
yuzu-0f7fc9411129c110ef751d18f80e02f18b63c201.tar.xz
yuzu-0f7fc9411129c110ef751d18f80e02f18b63c201.zip
KThread: Send termination interrupt to all cores a thread has affinity to
KThread::RequestTerminate may run from a thread which is not the CurrentCore, and thus masking this out is erroneous.
Diffstat (limited to 'src/core/hle/kernel')
-rw-r--r--src/core/hle/kernel/k_thread.cpp8
1 files changed, 4 insertions, 4 deletions
diff --git a/src/core/hle/kernel/k_thread.cpp b/src/core/hle/kernel/k_thread.cpp
index 24394d222..7d3421929 100644
--- a/src/core/hle/kernel/k_thread.cpp
+++ b/src/core/hle/kernel/k_thread.cpp
@@ -1258,11 +1258,11 @@ ThreadState KThread::RequestTerminate() {
1258 // Change the thread's priority to be higher than any system thread's. 1258 // Change the thread's priority to be higher than any system thread's.
1259 this->IncreaseBasePriority(TerminatingThreadPriority); 1259 this->IncreaseBasePriority(TerminatingThreadPriority);
1260 1260
1261 // If the thread is runnable, send a termination interrupt to other cores. 1261 // If the thread is runnable, send a termination interrupt to cores it may be running on.
1262 if (this->GetState() == ThreadState::Runnable) { 1262 if (this->GetState() == ThreadState::Runnable) {
1263 if (const u64 core_mask = m_physical_affinity_mask.GetAffinityMask() & 1263 // NOTE: We do not mask the "current core", because this code may not actually be
1264 ~(1ULL << GetCurrentCoreId(m_kernel)); 1264 // executing from the thread representing the "current core".
1265 core_mask != 0) { 1265 if (const u64 core_mask = m_physical_affinity_mask.GetAffinityMask(); core_mask != 0) {
1266 Kernel::KInterruptManager::SendInterProcessorInterrupt(m_kernel, core_mask); 1266 Kernel::KInterruptManager::SendInterProcessorInterrupt(m_kernel, core_mask);
1267 } 1267 }
1268 } 1268 }