diff options
| author | 2018-08-12 17:49:55 -0500 | |
|---|---|---|
| committer | 2018-08-12 18:41:11 -0500 | |
| commit | 84b542c386063339c03069b8f4db8221200a27cd (patch) | |
| tree | 458f04b71db6562257d1f5c1495433aaf70ce960 /src/core/hle/kernel/thread.cpp | |
| parent | Kernel/Thread: Always use the threadsafe option when scheduling wakeups. (diff) | |
| download | yuzu-84b542c386063339c03069b8f4db8221200a27cd.tar.gz yuzu-84b542c386063339c03069b8f4db8221200a27cd.tar.xz yuzu-84b542c386063339c03069b8f4db8221200a27cd.zip | |
Kernel/Threads: Lock the HLE mutex when executing the wakeup callback.
Another thread might be in the middle of a reschedule, thus altering the state of the schedulers.
Diffstat (limited to 'src/core/hle/kernel/thread.cpp')
| -rw-r--r-- | src/core/hle/kernel/thread.cpp | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/src/core/hle/kernel/thread.cpp b/src/core/hle/kernel/thread.cpp index e308b9c7b..5f87ff859 100644 --- a/src/core/hle/kernel/thread.cpp +++ b/src/core/hle/kernel/thread.cpp | |||
| @@ -23,6 +23,7 @@ | |||
| 23 | #include "core/hle/kernel/object.h" | 23 | #include "core/hle/kernel/object.h" |
| 24 | #include "core/hle/kernel/process.h" | 24 | #include "core/hle/kernel/process.h" |
| 25 | #include "core/hle/kernel/thread.h" | 25 | #include "core/hle/kernel/thread.h" |
| 26 | #include "core/hle/lock.h" | ||
| 26 | #include "core/hle/result.h" | 27 | #include "core/hle/result.h" |
| 27 | #include "core/memory.h" | 28 | #include "core/memory.h" |
| 28 | 29 | ||
| @@ -104,6 +105,10 @@ void ExitCurrentThread() { | |||
| 104 | */ | 105 | */ |
| 105 | static void ThreadWakeupCallback(u64 thread_handle, int cycles_late) { | 106 | static void ThreadWakeupCallback(u64 thread_handle, int cycles_late) { |
| 106 | const auto proper_handle = static_cast<Handle>(thread_handle); | 107 | const auto proper_handle = static_cast<Handle>(thread_handle); |
| 108 | |||
| 109 | // Lock the global kernel mutex when we enter the kernel HLE. | ||
| 110 | std::lock_guard<std::recursive_mutex> lock(HLE::g_hle_lock); | ||
| 111 | |||
| 107 | SharedPtr<Thread> thread = wakeup_callback_handle_table.Get<Thread>(proper_handle); | 112 | SharedPtr<Thread> thread = wakeup_callback_handle_table.Get<Thread>(proper_handle); |
| 108 | if (thread == nullptr) { | 113 | if (thread == nullptr) { |
| 109 | LOG_CRITICAL(Kernel, "Callback fired for invalid thread {:08X}", proper_handle); | 114 | LOG_CRITICAL(Kernel, "Callback fired for invalid thread {:08X}", proper_handle); |