diff options
| author | 2018-12-30 20:59:52 -0500 | |
|---|---|---|
| committer | 2018-12-30 20:59:54 -0500 | |
| commit | 205e6d3b975a7f699aeb0341c78a55562094c32b (patch) | |
| tree | 6708c8120ba81f355788a011989ed9886be32f37 /src/core/hle/kernel/svc.cpp | |
| parent | Merge pull request #1956 from lioncash/process-thread (diff) | |
| download | yuzu-205e6d3b975a7f699aeb0341c78a55562094c32b.tar.gz yuzu-205e6d3b975a7f699aeb0341c78a55562094c32b.tar.xz yuzu-205e6d3b975a7f699aeb0341c78a55562094c32b.zip | |
kernel/svc: Simplify thread core ID sanitizing in CreateThread
Rather than use a switch here, this can be collapsed into a simple range
check, which is a little easier on the eyes.
Diffstat (limited to 'src/core/hle/kernel/svc.cpp')
| -rw-r--r-- | src/core/hle/kernel/svc.cpp | 8 |
1 files changed, 1 insertions, 7 deletions
diff --git a/src/core/hle/kernel/svc.cpp b/src/core/hle/kernel/svc.cpp index 660e6f577..352ab2d14 100644 --- a/src/core/hle/kernel/svc.cpp +++ b/src/core/hle/kernel/svc.cpp | |||
| @@ -1233,13 +1233,7 @@ static ResultCode CreateThread(Handle* out_handle, VAddr entry_point, u64 arg, V | |||
| 1233 | ASSERT(processor_id != THREADPROCESSORID_IDEAL); | 1233 | ASSERT(processor_id != THREADPROCESSORID_IDEAL); |
| 1234 | } | 1234 | } |
| 1235 | 1235 | ||
| 1236 | switch (processor_id) { | 1236 | if (processor_id < THREADPROCESSORID_0 || processor_id > THREADPROCESSORID_3) { |
| 1237 | case THREADPROCESSORID_0: | ||
| 1238 | case THREADPROCESSORID_1: | ||
| 1239 | case THREADPROCESSORID_2: | ||
| 1240 | case THREADPROCESSORID_3: | ||
| 1241 | break; | ||
| 1242 | default: | ||
| 1243 | LOG_ERROR(Kernel_SVC, "Invalid thread processor ID: {}", processor_id); | 1237 | LOG_ERROR(Kernel_SVC, "Invalid thread processor ID: {}", processor_id); |
| 1244 | return ERR_INVALID_PROCESSOR_ID; | 1238 | return ERR_INVALID_PROCESSOR_ID; |
| 1245 | } | 1239 | } |