diff options
| author | 2015-01-31 19:22:40 -0200 | |
|---|---|---|
| committer | 2015-02-02 15:37:06 -0200 | |
| commit | 4e84df8be30c5bac65e4c4e9faf07bf0fc3fb33a (patch) | |
| tree | 4e5ea0a4d5525843f41ad19530da872bc5ccda25 /src/core/hle/kernel/mutex.cpp | |
| parent | HID: Fix crash when pressing a key when the emulator is stopped (diff) | |
| download | yuzu-4e84df8be30c5bac65e4c4e9faf07bf0fc3fb33a.tar.gz yuzu-4e84df8be30c5bac65e4c4e9faf07bf0fc3fb33a.tar.xz yuzu-4e84df8be30c5bac65e4c4e9faf07bf0fc3fb33a.zip | |
Mutex: Replace g_mutex_held_locks with a set inside Thread
Diffstat (limited to 'src/core/hle/kernel/mutex.cpp')
| -rw-r--r-- | src/core/hle/kernel/mutex.cpp | 28 |
1 files changed, 7 insertions, 21 deletions
diff --git a/src/core/hle/kernel/mutex.cpp b/src/core/hle/kernel/mutex.cpp index acf484659..6fdcc97ee 100644 --- a/src/core/hle/kernel/mutex.cpp +++ b/src/core/hle/kernel/mutex.cpp | |||
| @@ -5,6 +5,8 @@ | |||
| 5 | #include <map> | 5 | #include <map> |
| 6 | #include <vector> | 6 | #include <vector> |
| 7 | 7 | ||
| 8 | #include <boost/range/algorithm_ext/erase.hpp> | ||
| 9 | |||
| 8 | #include "common/common.h" | 10 | #include "common/common.h" |
| 9 | 11 | ||
| 10 | #include "core/hle/kernel/kernel.h" | 12 | #include "core/hle/kernel/kernel.h" |
| @@ -13,9 +15,6 @@ | |||
| 13 | 15 | ||
| 14 | namespace Kernel { | 16 | namespace Kernel { |
| 15 | 17 | ||
| 16 | typedef std::multimap<SharedPtr<Thread>, SharedPtr<Mutex>> MutexMap; | ||
| 17 | static MutexMap g_mutex_held_locks; | ||
| 18 | |||
| 19 | /** | 18 | /** |
| 20 | * Resumes a thread waiting for the specified mutex | 19 | * Resumes a thread waiting for the specified mutex |
| 21 | * @param mutex The mutex that some thread is waiting on | 20 | * @param mutex The mutex that some thread is waiting on |
| @@ -33,15 +32,10 @@ static void ResumeWaitingThread(Mutex* mutex) { | |||
| 33 | } | 32 | } |
| 34 | 33 | ||
| 35 | void ReleaseThreadMutexes(Thread* thread) { | 34 | void ReleaseThreadMutexes(Thread* thread) { |
| 36 | auto locked_range = g_mutex_held_locks.equal_range(thread); | 35 | for (auto& mtx : thread->held_mutexes) { |
| 37 | 36 | ResumeWaitingThread(mtx.get()); | |
| 38 | // Release every mutex that the thread holds, and resume execution on the waiting threads | ||
| 39 | for (auto iter = locked_range.first; iter != locked_range.second; ++iter) { | ||
| 40 | ResumeWaitingThread(iter->second.get()); | ||
| 41 | } | 37 | } |
| 42 | 38 | thread->held_mutexes.clear(); | |
| 43 | // Erase all the locks that this thread holds | ||
| 44 | g_mutex_held_locks.erase(thread); | ||
| 45 | } | 39 | } |
| 46 | 40 | ||
| 47 | ResultVal<SharedPtr<Mutex>> Mutex::Create(bool initial_locked, std::string name) { | 41 | ResultVal<SharedPtr<Mutex>> Mutex::Create(bool initial_locked, std::string name) { |
| @@ -76,7 +70,7 @@ void Mutex::Acquire(Thread* thread) { | |||
| 76 | 70 | ||
| 77 | locked = true; | 71 | locked = true; |
| 78 | 72 | ||
| 79 | g_mutex_held_locks.insert(std::make_pair(thread, this)); | 73 | thread->held_mutexes.insert(this); |
| 80 | holding_thread = thread; | 74 | holding_thread = thread; |
| 81 | } | 75 | } |
| 82 | 76 | ||
| @@ -84,15 +78,7 @@ void Mutex::Release() { | |||
| 84 | if (!locked) | 78 | if (!locked) |
| 85 | return; | 79 | return; |
| 86 | 80 | ||
| 87 | auto locked_range = g_mutex_held_locks.equal_range(holding_thread); | 81 | holding_thread->held_mutexes.erase(this); |
| 88 | |||
| 89 | for (MutexMap::iterator iter = locked_range.first; iter != locked_range.second; ++iter) { | ||
| 90 | if (iter->second == this) { | ||
| 91 | g_mutex_held_locks.erase(iter); | ||
| 92 | break; | ||
| 93 | } | ||
| 94 | } | ||
| 95 | |||
| 96 | ResumeWaitingThread(this); | 82 | ResumeWaitingThread(this); |
| 97 | } | 83 | } |
| 98 | 84 | ||