summaryrefslogtreecommitdiff
path: root/src/core/hid/input_interpreter.cpp
diff options
context:
space:
mode:
authorGravatar Morph2021-11-29 18:26:52 -0500
committerGravatar Morph2021-11-29 19:21:51 -0500
commit5deecd714b78233a4cec207b67d2a32c2defbf0a (patch)
tree53855035915fa79f9dd61e8d018f36d8cf5817d7 /src/core/hid/input_interpreter.cpp
parentnpad: Return NpadButton in GetAndResetPressState (diff)
downloadyuzu-5deecd714b78233a4cec207b67d2a32c2defbf0a.tar.gz
yuzu-5deecd714b78233a4cec207b67d2a32c2defbf0a.tar.xz
yuzu-5deecd714b78233a4cec207b67d2a32c2defbf0a.zip
input_interpreter: Make use of NpadButton instead of a u64
Allows us to be more explicit with the representation of button states and use the provided bit manipulation operators
Diffstat (limited to 'src/core/hid/input_interpreter.cpp')
-rw-r--r--src/core/hid/input_interpreter.cpp16
1 files changed, 8 insertions, 8 deletions
diff --git a/src/core/hid/input_interpreter.cpp b/src/core/hid/input_interpreter.cpp
index 870422d82..2dbda8814 100644
--- a/src/core/hid/input_interpreter.cpp
+++ b/src/core/hid/input_interpreter.cpp
@@ -20,7 +20,7 @@ InputInterpreter::InputInterpreter(Core::System& system)
20InputInterpreter::~InputInterpreter() = default; 20InputInterpreter::~InputInterpreter() = default;
21 21
22void InputInterpreter::PollInput() { 22void InputInterpreter::PollInput() {
23 const u64 button_state = npad.GetAndResetPressState(); 23 const auto button_state = npad.GetAndResetPressState();
24 24
25 previous_index = current_index; 25 previous_index = current_index;
26 current_index = (current_index + 1) % button_states.size(); 26 current_index = (current_index + 1) % button_states.size();
@@ -32,30 +32,30 @@ void InputInterpreter::ResetButtonStates() {
32 previous_index = 0; 32 previous_index = 0;
33 current_index = 0; 33 current_index = 0;
34 34
35 button_states[0] = 0xFFFFFFFFFFFFFFFF; 35 button_states[0] = Core::HID::NpadButton::All;
36 36
37 for (std::size_t i = 1; i < button_states.size(); ++i) { 37 for (std::size_t i = 1; i < button_states.size(); ++i) {
38 button_states[i] = 0; 38 button_states[i] = Core::HID::NpadButton::None;
39 } 39 }
40} 40}
41 41
42bool InputInterpreter::IsButtonPressed(Core::HID::NpadButton button) const { 42bool InputInterpreter::IsButtonPressed(Core::HID::NpadButton button) const {
43 return (button_states[current_index] & static_cast<u64>(button)) != 0; 43 return True(button_states[current_index] & button);
44} 44}
45 45
46bool InputInterpreter::IsButtonPressedOnce(Core::HID::NpadButton button) const { 46bool InputInterpreter::IsButtonPressedOnce(Core::HID::NpadButton button) const {
47 const bool current_press = (button_states[current_index] & static_cast<u64>(button)) != 0; 47 const bool current_press = True(button_states[current_index] & button);
48 const bool previous_press = (button_states[previous_index] & static_cast<u64>(button)) != 0; 48 const bool previous_press = True(button_states[previous_index] & button);
49 49
50 return current_press && !previous_press; 50 return current_press && !previous_press;
51} 51}
52 52
53bool InputInterpreter::IsButtonHeld(Core::HID::NpadButton button) const { 53bool InputInterpreter::IsButtonHeld(Core::HID::NpadButton button) const {
54 u64 held_buttons{button_states[0]}; 54 Core::HID::NpadButton held_buttons{button_states[0]};
55 55
56 for (std::size_t i = 1; i < button_states.size(); ++i) { 56 for (std::size_t i = 1; i < button_states.size(); ++i) {
57 held_buttons &= button_states[i]; 57 held_buttons &= button_states[i];
58 } 58 }
59 59
60 return (held_buttons & static_cast<u64>(button)) != 0; 60 return True(held_buttons & button);
61} 61}