summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGravatar Subv2017-01-05 14:14:22 -0500
committerGravatar Subv2017-01-05 19:11:34 -0500
commitfc2266130b450952777cd3a9e47adb36960de8e7 (patch)
tree98c4540c61e35fb29e1572583bd54a6dee080c22
parentMerge pull request #2393 from Subv/synch (diff)
downloadyuzu-fc2266130b450952777cd3a9e47adb36960de8e7.tar.gz
yuzu-fc2266130b450952777cd3a9e47adb36960de8e7.tar.xz
yuzu-fc2266130b450952777cd3a9e47adb36960de8e7.zip
Kernel: Don't attempt to yield execution in SleepThread(0) if there are no available threads to run.
With this we avoid an useless temporary deschedule of the current thread.
-rw-r--r--src/core/hle/kernel/thread.cpp4
-rw-r--r--src/core/hle/kernel/thread.h5
-rw-r--r--src/core/hle/svc.cpp5
3 files changed, 14 insertions, 0 deletions
diff --git a/src/core/hle/kernel/thread.cpp b/src/core/hle/kernel/thread.cpp
index 9109bd10b..6cd9ff327 100644
--- a/src/core/hle/kernel/thread.cpp
+++ b/src/core/hle/kernel/thread.cpp
@@ -556,6 +556,10 @@ SharedPtr<Thread> SetupMainThread(u32 entry_point, s32 priority) {
556 return thread; 556 return thread;
557} 557}
558 558
559bool HaveReadyThreads() {
560 return ready_queue.get_first() != nullptr;
561}
562
559void Reschedule() { 563void Reschedule() {
560 PriorityBoostStarvedThreads(); 564 PriorityBoostStarvedThreads();
561 565
diff --git a/src/core/hle/kernel/thread.h b/src/core/hle/kernel/thread.h
index af72b76ea..13a29a044 100644
--- a/src/core/hle/kernel/thread.h
+++ b/src/core/hle/kernel/thread.h
@@ -219,6 +219,11 @@ private:
219SharedPtr<Thread> SetupMainThread(u32 entry_point, s32 priority); 219SharedPtr<Thread> SetupMainThread(u32 entry_point, s32 priority);
220 220
221/** 221/**
222 * Returns whether there are any threads that are ready to run.
223 */
224bool HaveReadyThreads();
225
226/**
222 * Reschedules to the next available thread (call after current thread is suspended) 227 * Reschedules to the next available thread (call after current thread is suspended)
223 */ 228 */
224void Reschedule(); 229void Reschedule();
diff --git a/src/core/hle/svc.cpp b/src/core/hle/svc.cpp
index 855f3af82..50d35ab97 100644
--- a/src/core/hle/svc.cpp
+++ b/src/core/hle/svc.cpp
@@ -849,6 +849,11 @@ static ResultCode CancelTimer(Kernel::Handle handle) {
849static void SleepThread(s64 nanoseconds) { 849static void SleepThread(s64 nanoseconds) {
850 LOG_TRACE(Kernel_SVC, "called nanoseconds=%lld", nanoseconds); 850 LOG_TRACE(Kernel_SVC, "called nanoseconds=%lld", nanoseconds);
851 851
852 // Don't attempt to yield execution if there are no available threads to run,
853 // this way we avoid a useless reschedule to the idle thread.
854 if (nanoseconds == 0 && !Kernel::HaveReadyThreads())
855 return;
856
852 // Sleep current thread and check for next thread to schedule 857 // Sleep current thread and check for next thread to schedule
853 Kernel::WaitCurrentThread_Sleep(); 858 Kernel::WaitCurrentThread_Sleep();
854 859