diff options
| author | 2021-05-27 12:51:52 -0400 | |
|---|---|---|
| committer | 2021-05-27 12:51:52 -0400 | |
| commit | f94cb0bdb27775ed16635104076cc4f57605b80f (patch) | |
| tree | d658e6bce64bdb7af4816ee74a3b77f14f6bdf16 | |
| parent | Merge pull request #6366 from lat9nq/bundled-qt-linux (diff) | |
| download | yuzu-f94cb0bdb27775ed16635104076cc4f57605b80f.tar.gz yuzu-f94cb0bdb27775ed16635104076cc4f57605b80f.tar.xz yuzu-f94cb0bdb27775ed16635104076cc4f57605b80f.zip | |
cmake: Fix usage of CMAKE_DEPENDENT_OPTION
CMAKE_DEPENDENT_OPTION takes a value argument, but as a macro function
it will read a variable name as the name and not the value. For
YUZU_USE_BUNDLED_QT, ensure that we are reading the value of MSVC. For
YUZU_ALLOW_SYSTEM_SDL2, CMAKE_DEPENDENT_OPTION is redundant here anyway
as we don't use that path on any toolchain by default.
| -rw-r--r-- | CMakeLists.txt | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/CMakeLists.txt b/CMakeLists.txt index b17bc9c0f..10c5032dc 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt | |||
| @@ -13,11 +13,11 @@ project(yuzu) | |||
| 13 | option(ENABLE_SDL2 "Enable the SDL2 frontend" ON) | 13 | option(ENABLE_SDL2 "Enable the SDL2 frontend" ON) |
| 14 | CMAKE_DEPENDENT_OPTION(YUZU_USE_BUNDLED_SDL2 "Download bundled SDL2 binaries" ON "ENABLE_SDL2;MSVC" OFF) | 14 | CMAKE_DEPENDENT_OPTION(YUZU_USE_BUNDLED_SDL2 "Download bundled SDL2 binaries" ON "ENABLE_SDL2;MSVC" OFF) |
| 15 | # On Linux system SDL2 is likely to be lacking HIDAPI support which have drawbacks but is needed for SDL motion | 15 | # On Linux system SDL2 is likely to be lacking HIDAPI support which have drawbacks but is needed for SDL motion |
| 16 | CMAKE_DEPENDENT_OPTION(YUZU_ALLOW_SYSTEM_SDL2 "Try using system SDL2 before fallling back to one from externals" NOT UNIX "ENABLE_SDL2" OFF) | 16 | option(YUZU_ALLOW_SYSTEM_SDL2 "Try using system SDL2 before fallling back to one from externals" OFF) |
| 17 | 17 | ||
| 18 | option(ENABLE_QT "Enable the Qt frontend" ON) | 18 | option(ENABLE_QT "Enable the Qt frontend" ON) |
| 19 | option(ENABLE_QT_TRANSLATION "Enable translations for the Qt frontend" OFF) | 19 | option(ENABLE_QT_TRANSLATION "Enable translations for the Qt frontend" OFF) |
| 20 | CMAKE_DEPENDENT_OPTION(YUZU_USE_BUNDLED_QT "Download bundled Qt binaries" MSVC "ENABLE_QT" OFF) | 20 | CMAKE_DEPENDENT_OPTION(YUZU_USE_BUNDLED_QT "Download bundled Qt binaries" "${MSVC}" "ENABLE_QT" OFF) |
| 21 | 21 | ||
| 22 | option(ENABLE_WEB_SERVICE "Enable web services (telemetry, etc.)" ON) | 22 | option(ENABLE_WEB_SERVICE "Enable web services (telemetry, etc.)" ON) |
| 23 | 23 | ||