diff options
| author | 2020-05-22 20:53:27 -0300 | |
|---|---|---|
| committer | 2020-06-07 04:32:32 -0300 | |
| commit | dc27252352a27f466c65e9008b3d56a2540ce224 (patch) | |
| tree | 25d4004efe1b838e80a7892c86586235aa744bee | |
| parent | Merge pull request #4055 from ReinUsesLisp/nvidia-443-24 (diff) | |
| download | yuzu-dc27252352a27f466c65e9008b3d56a2540ce224.tar.gz yuzu-dc27252352a27f466c65e9008b3d56a2540ce224.tar.xz yuzu-dc27252352a27f466c65e9008b3d56a2540ce224.zip | |
shader_cache: Implement a generic shader cache
Implement a generic shader cache for fast lookups and invalidations.
Invalidations are cheap but expensive when a shader is invalidated.
Use two mutexes instead of one to avoid locking invalidations for
lookups and vice versa. When a shader has to be removed, lookups are
locked as expected.
| -rw-r--r-- | src/video_core/CMakeLists.txt | 1 | ||||
| -rw-r--r-- | src/video_core/shader_cache.h | 228 |
2 files changed, 229 insertions, 0 deletions
diff --git a/src/video_core/CMakeLists.txt b/src/video_core/CMakeLists.txt index 2bf8d68ce..cf1885f92 100644 --- a/src/video_core/CMakeLists.txt +++ b/src/video_core/CMakeLists.txt | |||
| @@ -93,6 +93,7 @@ add_library(video_core STATIC | |||
| 93 | renderer_opengl/utils.h | 93 | renderer_opengl/utils.h |
| 94 | sampler_cache.cpp | 94 | sampler_cache.cpp |
| 95 | sampler_cache.h | 95 | sampler_cache.h |
| 96 | shader_cache.h | ||
| 96 | shader/decode/arithmetic.cpp | 97 | shader/decode/arithmetic.cpp |
| 97 | shader/decode/arithmetic_immediate.cpp | 98 | shader/decode/arithmetic_immediate.cpp |
| 98 | shader/decode/bfe.cpp | 99 | shader/decode/bfe.cpp |
diff --git a/src/video_core/shader_cache.h b/src/video_core/shader_cache.h new file mode 100644 index 000000000..a23c23886 --- /dev/null +++ b/src/video_core/shader_cache.h | |||
| @@ -0,0 +1,228 @@ | |||
| 1 | // Copyright 2020 yuzu Emulator Project | ||
| 2 | // Licensed under GPLv2 or any later version | ||
| 3 | // Refer to the license.txt file included. | ||
| 4 | |||
| 5 | #pragma once | ||
| 6 | |||
| 7 | #include <algorithm> | ||
| 8 | #include <memory> | ||
| 9 | #include <mutex> | ||
| 10 | #include <unordered_map> | ||
| 11 | #include <utility> | ||
| 12 | #include <vector> | ||
| 13 | |||
| 14 | #include "common/assert.h" | ||
| 15 | #include "common/common_types.h" | ||
| 16 | #include "video_core/rasterizer_interface.h" | ||
| 17 | |||
| 18 | namespace VideoCommon { | ||
| 19 | |||
| 20 | template <class T> | ||
| 21 | class ShaderCache { | ||
| 22 | static constexpr u64 PAGE_SHIFT = 14; | ||
| 23 | |||
| 24 | struct Entry { | ||
| 25 | VAddr addr_start; | ||
| 26 | VAddr addr_end; | ||
| 27 | T* data; | ||
| 28 | |||
| 29 | bool is_memory_marked = true; | ||
| 30 | |||
| 31 | constexpr bool Overlaps(VAddr start, VAddr end) const noexcept { | ||
| 32 | return start < addr_end && addr_start < end; | ||
| 33 | } | ||
| 34 | }; | ||
| 35 | |||
| 36 | public: | ||
| 37 | virtual ~ShaderCache() = default; | ||
| 38 | |||
| 39 | /// @brief Removes shaders inside a given region | ||
| 40 | /// @note Checks for ranges | ||
| 41 | /// @param addr Start address of the invalidation | ||
| 42 | /// @param size Number of bytes of the invalidation | ||
| 43 | void InvalidateRegion(VAddr addr, std::size_t size) { | ||
| 44 | std::scoped_lock lock{invalidation_mutex}; | ||
| 45 | InvalidatePagesInRegion(addr, size); | ||
| 46 | RemovePendingShaders(); | ||
| 47 | } | ||
| 48 | |||
| 49 | /// @brief Unmarks a memory region as cached and marks it for removal | ||
| 50 | /// @param addr Start address of the CPU write operation | ||
| 51 | /// @param size Number of bytes of the CPU write operation | ||
| 52 | void OnCPUWrite(VAddr addr, std::size_t size) { | ||
| 53 | std::lock_guard lock{invalidation_mutex}; | ||
| 54 | InvalidatePagesInRegion(addr, size); | ||
| 55 | } | ||
| 56 | |||
| 57 | /// @brief Flushes delayed removal operations | ||
| 58 | void SyncGuestHost() { | ||
| 59 | std::scoped_lock lock{invalidation_mutex}; | ||
| 60 | RemovePendingShaders(); | ||
| 61 | } | ||
| 62 | |||
| 63 | /// @brief Tries to obtain a cached shader starting in a given address | ||
| 64 | /// @note Doesn't check for ranges, the given address has to be the start of the shader | ||
| 65 | /// @param addr Start address of the shader, this doesn't cache for region | ||
| 66 | /// @return Pointer to a valid shader, nullptr when nothing is found | ||
| 67 | T* TryGet(VAddr addr) const { | ||
| 68 | std::scoped_lock lock{lookup_mutex}; | ||
| 69 | |||
| 70 | const auto it = lookup_cache.find(addr); | ||
| 71 | if (it == lookup_cache.end()) { | ||
| 72 | return nullptr; | ||
| 73 | } | ||
| 74 | return it->second->data; | ||
| 75 | } | ||
| 76 | |||
| 77 | protected: | ||
| 78 | explicit ShaderCache(VideoCore::RasterizerInterface& rasterizer_) : rasterizer{rasterizer_} {} | ||
| 79 | |||
| 80 | /// @brief Register in the cache a given entry | ||
| 81 | /// @param data Shader to store in the cache | ||
| 82 | /// @param addr Start address of the shader that will be registered | ||
| 83 | /// @param size Size in bytes of the shader | ||
| 84 | void Register(std::unique_ptr<T> data, VAddr addr, std::size_t size) { | ||
| 85 | std::scoped_lock lock{invalidation_mutex, lookup_mutex}; | ||
| 86 | |||
| 87 | const VAddr addr_end = addr + size; | ||
| 88 | Entry* const entry = NewEntry(addr, addr_end, data.get()); | ||
| 89 | |||
| 90 | const u64 page_end = addr_end >> PAGE_SHIFT; | ||
| 91 | for (u64 page = addr >> PAGE_SHIFT; page <= page_end; ++page) { | ||
| 92 | invalidation_cache[page].push_back(entry); | ||
| 93 | } | ||
| 94 | |||
| 95 | storage.push_back(std::move(data)); | ||
| 96 | |||
| 97 | rasterizer.UpdatePagesCachedCount(addr, size, 1); | ||
| 98 | } | ||
| 99 | |||
| 100 | /// @brief Called when a shader is going to be removed | ||
| 101 | /// @param shader Shader that will be removed | ||
| 102 | /// @pre invalidation_cache is locked | ||
| 103 | /// @pre lookup_mutex is locked | ||
| 104 | virtual void OnShaderRemoval([[maybe_unused]] T* shader) {} | ||
| 105 | |||
| 106 | private: | ||
| 107 | /// @brief Invalidate pages in a given region | ||
| 108 | /// @pre invalidation_mutex is locked | ||
| 109 | void InvalidatePagesInRegion(VAddr addr, std::size_t size) { | ||
| 110 | const VAddr addr_end = addr + size; | ||
| 111 | const u64 page_end = addr_end >> PAGE_SHIFT; | ||
| 112 | for (u64 page = addr >> PAGE_SHIFT; page <= page_end; ++page) { | ||
| 113 | const auto it = invalidation_cache.find(page); | ||
| 114 | if (it == invalidation_cache.end()) { | ||
| 115 | continue; | ||
| 116 | } | ||
| 117 | |||
| 118 | std::vector<Entry*>& entries = it->second; | ||
| 119 | InvalidatePageEntries(entries, addr, addr_end); | ||
| 120 | |||
| 121 | // If there's nothing else in this page, remove it to avoid overpopulating the hash map. | ||
| 122 | if (entries.empty()) { | ||
| 123 | invalidation_cache.erase(it); | ||
| 124 | } | ||
| 125 | } | ||
| 126 | } | ||
| 127 | |||
| 128 | /// @brief Remove shaders marked for deletion | ||
| 129 | /// @pre invalidation_mutex is locked | ||
| 130 | void RemovePendingShaders() { | ||
| 131 | if (marked_for_removal.empty()) { | ||
| 132 | return; | ||
| 133 | } | ||
| 134 | std::scoped_lock lock{lookup_mutex}; | ||
| 135 | |||
| 136 | std::vector<T*> removed_shaders; | ||
| 137 | removed_shaders.reserve(marked_for_removal.size()); | ||
| 138 | |||
| 139 | for (Entry* const entry : marked_for_removal) { | ||
| 140 | if (lookup_cache.erase(entry->addr_start) > 0) { | ||
| 141 | removed_shaders.push_back(entry->data); | ||
| 142 | } | ||
| 143 | } | ||
| 144 | marked_for_removal.clear(); | ||
| 145 | |||
| 146 | if (!removed_shaders.empty()) { | ||
| 147 | RemoveShadersFromStorage(std::move(removed_shaders)); | ||
| 148 | } | ||
| 149 | } | ||
| 150 | |||
| 151 | /// @brief Invalidates entries in a given range for the passed page | ||
| 152 | /// @param entries Vector of entries in the page, it will be modified on overlaps | ||
| 153 | /// @param addr Start address of the invalidation | ||
| 154 | /// @param addr_end Non-inclusive end address of the invalidation | ||
| 155 | /// @pre invalidation_mutex is locked | ||
| 156 | void InvalidatePageEntries(std::vector<Entry*>& entries, VAddr addr, VAddr addr_end) { | ||
| 157 | auto it = entries.begin(); | ||
| 158 | while (it != entries.end()) { | ||
| 159 | Entry* const entry = *it; | ||
| 160 | if (!entry->Overlaps(addr, addr_end)) { | ||
| 161 | ++it; | ||
| 162 | continue; | ||
| 163 | } | ||
| 164 | UnmarkMemory(entry); | ||
| 165 | marked_for_removal.push_back(entry); | ||
| 166 | |||
| 167 | it = entries.erase(it); | ||
| 168 | } | ||
| 169 | } | ||
| 170 | |||
| 171 | /// @brief Unmarks an entry from the rasterizer cache | ||
| 172 | /// @param entry Entry to unmark from memory | ||
| 173 | void UnmarkMemory(Entry* entry) { | ||
| 174 | if (!entry->is_memory_marked) { | ||
| 175 | return; | ||
| 176 | } | ||
| 177 | entry->is_memory_marked = false; | ||
| 178 | |||
| 179 | const VAddr addr = entry->addr_start; | ||
| 180 | const std::size_t size = entry->addr_end - addr; | ||
| 181 | rasterizer.UpdatePagesCachedCount(addr, size, -1); | ||
| 182 | } | ||
| 183 | |||
| 184 | /// @brief Removes a vector of shaders from a list | ||
| 185 | /// @param removed_shaders Shaders to be removed from the storage, it can contain duplicates | ||
| 186 | /// @pre invalidation_mutex is locked | ||
| 187 | /// @pre lookup_mutex is locked | ||
| 188 | void RemoveShadersFromStorage(std::vector<T*> removed_shaders) { | ||
| 189 | // Remove duplicates | ||
| 190 | std::sort(removed_shaders.begin(), removed_shaders.end()); | ||
| 191 | removed_shaders.erase(std::unique(removed_shaders.begin(), removed_shaders.end()), | ||
| 192 | removed_shaders.end()); | ||
| 193 | |||
| 194 | // Now that there are no duplicates, we can notify removals | ||
| 195 | for (T* const shader : removed_shaders) { | ||
| 196 | OnShaderRemoval(shader); | ||
| 197 | } | ||
| 198 | |||
| 199 | // Remove them from the cache | ||
| 200 | const auto is_removed = [&removed_shaders](std::unique_ptr<T>& shader) { | ||
| 201 | return std::find(removed_shaders.begin(), removed_shaders.end(), shader.get()) != | ||
| 202 | removed_shaders.end(); | ||
| 203 | }; | ||
| 204 | storage.erase(std::remove_if(storage.begin(), storage.end(), is_removed), storage.end()); | ||
| 205 | } | ||
| 206 | |||
| 207 | /// @brief Creates a new entry in the lookup cache and returns its pointer | ||
| 208 | /// @pre lookup_mutex is locked | ||
| 209 | Entry* NewEntry(VAddr addr, VAddr addr_end, T* data) { | ||
| 210 | auto entry = std::make_unique<Entry>(Entry{addr, addr_end, data}); | ||
| 211 | Entry* const entry_pointer = entry.get(); | ||
| 212 | |||
| 213 | lookup_cache.emplace(addr, std::move(entry)); | ||
| 214 | return entry_pointer; | ||
| 215 | } | ||
| 216 | |||
| 217 | VideoCore::RasterizerInterface& rasterizer; | ||
| 218 | |||
| 219 | mutable std::mutex lookup_mutex; | ||
| 220 | std::mutex invalidation_mutex; | ||
| 221 | |||
| 222 | std::unordered_map<u64, std::unique_ptr<Entry>> lookup_cache; | ||
| 223 | std::unordered_map<u64, std::vector<Entry*>> invalidation_cache; | ||
| 224 | std::vector<std::unique_ptr<T>> storage; | ||
| 225 | std::vector<Entry*> marked_for_removal; | ||
| 226 | }; | ||
| 227 | |||
| 228 | } // namespace VideoCommon | ||