diff options
| author | 2019-11-03 04:10:12 -0500 | |
|---|---|---|
| committer | 2019-11-03 04:22:45 -0500 | |
| commit | b0ab803ce853739a0b8595ee95599d0fab46c78a (patch) | |
| tree | 0430782a5fae74d06891dad3732db26d5dd4a189 | |
| parent | kernel: readable_event: Initialize members. (diff) | |
| download | yuzu-b0ab803ce853739a0b8595ee95599d0fab46c78a.tar.gz yuzu-b0ab803ce853739a0b8595ee95599d0fab46c78a.tar.xz yuzu-b0ab803ce853739a0b8595ee95599d0fab46c78a.zip | |
kernel: events: Remove ResetType::Automatic.
- This does not actually seem to exist in the real kernel - games reset these automatically.
# Conflicts:
# src/core/hle/service/am/applets/applets.cpp
# src/core/hle/service/filesystem/fsp_srv.cpp
25 files changed, 48 insertions, 109 deletions
diff --git a/src/core/hle/kernel/hle_ipc.cpp b/src/core/hle/kernel/hle_ipc.cpp index f3da525d6..a7b5849b0 100644 --- a/src/core/hle/kernel/hle_ipc.cpp +++ b/src/core/hle/kernel/hle_ipc.cpp | |||
| @@ -58,8 +58,7 @@ SharedPtr<WritableEvent> HLERequestContext::SleepClientThread( | |||
| 58 | auto& kernel = Core::System::GetInstance().Kernel(); | 58 | auto& kernel = Core::System::GetInstance().Kernel(); |
| 59 | if (!writable_event) { | 59 | if (!writable_event) { |
| 60 | // Create event if not provided | 60 | // Create event if not provided |
| 61 | const auto pair = WritableEvent::CreateEventPair(kernel, ResetType::Automatic, | 61 | const auto pair = WritableEvent::CreateEventPair(kernel, "HLE Pause Event: " + reason); |
| 62 | "HLE Pause Event: " + reason); | ||
| 63 | writable_event = pair.writable; | 62 | writable_event = pair.writable; |
| 64 | } | 63 | } |
| 65 | 64 | ||
diff --git a/src/core/hle/kernel/object.h b/src/core/hle/kernel/object.h index 2821176a7..a6faeb83b 100644 --- a/src/core/hle/kernel/object.h +++ b/src/core/hle/kernel/object.h | |||
| @@ -32,11 +32,6 @@ enum class HandleType : u32 { | |||
| 32 | ServerSession, | 32 | ServerSession, |
| 33 | }; | 33 | }; |
| 34 | 34 | ||
| 35 | enum class ResetType { | ||
| 36 | Automatic, ///< Reset automatically on object acquisition | ||
| 37 | Manual, ///< Never reset automatically | ||
| 38 | }; | ||
| 39 | |||
| 40 | class Object : NonCopyable { | 35 | class Object : NonCopyable { |
| 41 | public: | 36 | public: |
| 42 | explicit Object(KernelCore& kernel); | 37 | explicit Object(KernelCore& kernel); |
diff --git a/src/core/hle/kernel/readable_event.cpp b/src/core/hle/kernel/readable_event.cpp index 06463cd26..7c291b426 100644 --- a/src/core/hle/kernel/readable_event.cpp +++ b/src/core/hle/kernel/readable_event.cpp | |||
| @@ -20,10 +20,6 @@ bool ReadableEvent::ShouldWait(const Thread* thread) const { | |||
| 20 | 20 | ||
| 21 | void ReadableEvent::Acquire(Thread* thread) { | 21 | void ReadableEvent::Acquire(Thread* thread) { |
| 22 | ASSERT_MSG(!ShouldWait(thread), "object unavailable!"); | 22 | ASSERT_MSG(!ShouldWait(thread), "object unavailable!"); |
| 23 | |||
| 24 | if (reset_type == ResetType::Automatic) { | ||
| 25 | signaled = false; | ||
| 26 | } | ||
| 27 | } | 23 | } |
| 28 | 24 | ||
| 29 | void ReadableEvent::Signal() { | 25 | void ReadableEvent::Signal() { |
diff --git a/src/core/hle/kernel/readable_event.h b/src/core/hle/kernel/readable_event.h index 3bf9f95ac..11ff71c3a 100644 --- a/src/core/hle/kernel/readable_event.h +++ b/src/core/hle/kernel/readable_event.h | |||
| @@ -27,10 +27,6 @@ public: | |||
| 27 | return name; | 27 | return name; |
| 28 | } | 28 | } |
| 29 | 29 | ||
| 30 | ResetType GetResetType() const { | ||
| 31 | return reset_type; | ||
| 32 | } | ||
| 33 | |||
| 34 | static constexpr HandleType HANDLE_TYPE = HandleType::ReadableEvent; | 30 | static constexpr HandleType HANDLE_TYPE = HandleType::ReadableEvent; |
| 35 | HandleType GetHandleType() const override { | 31 | HandleType GetHandleType() const override { |
| 36 | return HANDLE_TYPE; | 32 | return HANDLE_TYPE; |
| @@ -55,7 +51,6 @@ private: | |||
| 55 | 51 | ||
| 56 | void Signal(); | 52 | void Signal(); |
| 57 | 53 | ||
| 58 | ResetType reset_type; | ||
| 59 | bool signaled{}; | 54 | bool signaled{}; |
| 60 | 55 | ||
| 61 | std::string name; ///< Name of event (optional) | 56 | std::string name; ///< Name of event (optional) |
diff --git a/src/core/hle/kernel/svc.cpp b/src/core/hle/kernel/svc.cpp index f64236be1..c63a9ba8b 100644 --- a/src/core/hle/kernel/svc.cpp +++ b/src/core/hle/kernel/svc.cpp | |||
| @@ -2099,7 +2099,7 @@ static ResultCode CreateEvent(Core::System& system, Handle* write_handle, Handle | |||
| 2099 | 2099 | ||
| 2100 | auto& kernel = system.Kernel(); | 2100 | auto& kernel = system.Kernel(); |
| 2101 | const auto [readable_event, writable_event] = | 2101 | const auto [readable_event, writable_event] = |
| 2102 | WritableEvent::CreateEventPair(kernel, ResetType::Manual, "CreateEvent"); | 2102 | WritableEvent::CreateEventPair(kernel, "CreateEvent"); |
| 2103 | 2103 | ||
| 2104 | HandleTable& handle_table = kernel.CurrentProcess()->GetHandleTable(); | 2104 | HandleTable& handle_table = kernel.CurrentProcess()->GetHandleTable(); |
| 2105 | 2105 | ||
diff --git a/src/core/hle/kernel/writable_event.cpp b/src/core/hle/kernel/writable_event.cpp index a58ea6ec8..c783a34ee 100644 --- a/src/core/hle/kernel/writable_event.cpp +++ b/src/core/hle/kernel/writable_event.cpp | |||
| @@ -15,8 +15,7 @@ namespace Kernel { | |||
| 15 | WritableEvent::WritableEvent(KernelCore& kernel) : Object{kernel} {} | 15 | WritableEvent::WritableEvent(KernelCore& kernel) : Object{kernel} {} |
| 16 | WritableEvent::~WritableEvent() = default; | 16 | WritableEvent::~WritableEvent() = default; |
| 17 | 17 | ||
| 18 | EventPair WritableEvent::CreateEventPair(KernelCore& kernel, ResetType reset_type, | 18 | EventPair WritableEvent::CreateEventPair(KernelCore& kernel, std::string name) { |
| 19 | std::string name) { | ||
| 20 | SharedPtr<WritableEvent> writable_event(new WritableEvent(kernel)); | 19 | SharedPtr<WritableEvent> writable_event(new WritableEvent(kernel)); |
| 21 | SharedPtr<ReadableEvent> readable_event(new ReadableEvent(kernel)); | 20 | SharedPtr<ReadableEvent> readable_event(new ReadableEvent(kernel)); |
| 22 | 21 | ||
| @@ -24,7 +23,6 @@ EventPair WritableEvent::CreateEventPair(KernelCore& kernel, ResetType reset_typ | |||
| 24 | writable_event->readable = readable_event; | 23 | writable_event->readable = readable_event; |
| 25 | readable_event->name = name + ":Readable"; | 24 | readable_event->name = name + ":Readable"; |
| 26 | readable_event->signaled = false; | 25 | readable_event->signaled = false; |
| 27 | readable_event->reset_type = reset_type; | ||
| 28 | 26 | ||
| 29 | return {std::move(readable_event), std::move(writable_event)}; | 27 | return {std::move(readable_event), std::move(writable_event)}; |
| 30 | } | 28 | } |
| @@ -33,10 +31,6 @@ SharedPtr<ReadableEvent> WritableEvent::GetReadableEvent() const { | |||
| 33 | return readable; | 31 | return readable; |
| 34 | } | 32 | } |
| 35 | 33 | ||
| 36 | ResetType WritableEvent::GetResetType() const { | ||
| 37 | return readable->reset_type; | ||
| 38 | } | ||
| 39 | |||
| 40 | void WritableEvent::Signal() { | 34 | void WritableEvent::Signal() { |
| 41 | readable->Signal(); | 35 | readable->Signal(); |
| 42 | } | 36 | } |
diff --git a/src/core/hle/kernel/writable_event.h b/src/core/hle/kernel/writable_event.h index d00c92a6b..f46cf1dd8 100644 --- a/src/core/hle/kernel/writable_event.h +++ b/src/core/hle/kernel/writable_event.h | |||
| @@ -24,11 +24,9 @@ public: | |||
| 24 | /** | 24 | /** |
| 25 | * Creates an event | 25 | * Creates an event |
| 26 | * @param kernel The kernel instance to create this event under. | 26 | * @param kernel The kernel instance to create this event under. |
| 27 | * @param reset_type ResetType describing how to create event | ||
| 28 | * @param name Optional name of event | 27 | * @param name Optional name of event |
| 29 | */ | 28 | */ |
| 30 | static EventPair CreateEventPair(KernelCore& kernel, ResetType reset_type, | 29 | static EventPair CreateEventPair(KernelCore& kernel, std::string name = "Unknown"); |
| 31 | std::string name = "Unknown"); | ||
| 32 | 30 | ||
| 33 | std::string GetTypeName() const override { | 31 | std::string GetTypeName() const override { |
| 34 | return "WritableEvent"; | 32 | return "WritableEvent"; |
| @@ -44,8 +42,6 @@ public: | |||
| 44 | 42 | ||
| 45 | SharedPtr<ReadableEvent> GetReadableEvent() const; | 43 | SharedPtr<ReadableEvent> GetReadableEvent() const; |
| 46 | 44 | ||
| 47 | ResetType GetResetType() const; | ||
| 48 | |||
| 49 | void Signal(); | 45 | void Signal(); |
| 50 | void Clear(); | 46 | void Clear(); |
| 51 | bool IsSignaled() const; | 47 | bool IsSignaled() const; |
diff --git a/src/core/hle/service/am/am.cpp b/src/core/hle/service/am/am.cpp index 3a32d5b41..7d4532590 100644 --- a/src/core/hle/service/am/am.cpp +++ b/src/core/hle/service/am/am.cpp | |||
| @@ -289,8 +289,8 @@ ISelfController::ISelfController(Core::System& system, | |||
| 289 | RegisterHandlers(functions); | 289 | RegisterHandlers(functions); |
| 290 | 290 | ||
| 291 | auto& kernel = system.Kernel(); | 291 | auto& kernel = system.Kernel(); |
| 292 | launchable_event = Kernel::WritableEvent::CreateEventPair(kernel, Kernel::ResetType::Manual, | 292 | launchable_event = |
| 293 | "ISelfController:LaunchableEvent"); | 293 | Kernel::WritableEvent::CreateEventPair(kernel, "ISelfController:LaunchableEvent"); |
| 294 | 294 | ||
| 295 | // This event is created by AM on the first time GetAccumulatedSuspendedTickChangedEvent() is | 295 | // This event is created by AM on the first time GetAccumulatedSuspendedTickChangedEvent() is |
| 296 | // called. Yuzu can just create it unconditionally, since it doesn't need to support multiple | 296 | // called. Yuzu can just create it unconditionally, since it doesn't need to support multiple |
| @@ -298,7 +298,7 @@ ISelfController::ISelfController(Core::System& system, | |||
| 298 | // suspended if the event has previously been created by a call to | 298 | // suspended if the event has previously been created by a call to |
| 299 | // GetAccumulatedSuspendedTickChangedEvent. | 299 | // GetAccumulatedSuspendedTickChangedEvent. |
| 300 | accumulated_suspended_tick_changed_event = Kernel::WritableEvent::CreateEventPair( | 300 | accumulated_suspended_tick_changed_event = Kernel::WritableEvent::CreateEventPair( |
| 301 | kernel, Kernel::ResetType::Manual, "ISelfController:AccumulatedSuspendedTickChangedEvent"); | 301 | kernel, "ISelfController:AccumulatedSuspendedTickChangedEvent"); |
| 302 | accumulated_suspended_tick_changed_event.writable->Signal(); | 302 | accumulated_suspended_tick_changed_event.writable->Signal(); |
| 303 | } | 303 | } |
| 304 | 304 | ||
| @@ -523,10 +523,10 @@ void ISelfController::GetAccumulatedSuspendedTickChangedEvent(Kernel::HLERequest | |||
| 523 | } | 523 | } |
| 524 | 524 | ||
| 525 | AppletMessageQueue::AppletMessageQueue(Kernel::KernelCore& kernel) { | 525 | AppletMessageQueue::AppletMessageQueue(Kernel::KernelCore& kernel) { |
| 526 | on_new_message = Kernel::WritableEvent::CreateEventPair(kernel, Kernel::ResetType::Manual, | 526 | on_new_message = |
| 527 | "AMMessageQueue:OnMessageRecieved"); | 527 | Kernel::WritableEvent::CreateEventPair(kernel, "AMMessageQueue:OnMessageRecieved"); |
| 528 | on_operation_mode_changed = Kernel::WritableEvent::CreateEventPair( | 528 | on_operation_mode_changed = |
| 529 | kernel, Kernel::ResetType::Automatic, "AMMessageQueue:OperationModeChanged"); | 529 | Kernel::WritableEvent::CreateEventPair(kernel, "AMMessageQueue:OperationModeChanged"); |
| 530 | } | 530 | } |
| 531 | 531 | ||
| 532 | AppletMessageQueue::~AppletMessageQueue() = default; | 532 | AppletMessageQueue::~AppletMessageQueue() = default; |
| @@ -1091,7 +1091,7 @@ IApplicationFunctions::IApplicationFunctions(Core::System& system_) | |||
| 1091 | 1091 | ||
| 1092 | auto& kernel = system.Kernel(); | 1092 | auto& kernel = system.Kernel(); |
| 1093 | gpu_error_detected_event = Kernel::WritableEvent::CreateEventPair( | 1093 | gpu_error_detected_event = Kernel::WritableEvent::CreateEventPair( |
| 1094 | kernel, Kernel::ResetType::Manual, "IApplicationFunctions:GpuErrorDetectedSystemEvent"); | 1094 | kernel, "IApplicationFunctions:GpuErrorDetectedSystemEvent"); |
| 1095 | } | 1095 | } |
| 1096 | 1096 | ||
| 1097 | IApplicationFunctions::~IApplicationFunctions() = default; | 1097 | IApplicationFunctions::~IApplicationFunctions() = default; |
diff --git a/src/core/hle/service/am/applets/applets.cpp b/src/core/hle/service/am/applets/applets.cpp index 720fe766f..673ad1f7f 100644 --- a/src/core/hle/service/am/applets/applets.cpp +++ b/src/core/hle/service/am/applets/applets.cpp | |||
| @@ -24,12 +24,12 @@ | |||
| 24 | namespace Service::AM::Applets { | 24 | namespace Service::AM::Applets { |
| 25 | 25 | ||
| 26 | AppletDataBroker::AppletDataBroker(Kernel::KernelCore& kernel) { | 26 | AppletDataBroker::AppletDataBroker(Kernel::KernelCore& kernel) { |
| 27 | state_changed_event = Kernel::WritableEvent::CreateEventPair( | 27 | state_changed_event = |
| 28 | kernel, Kernel::ResetType::Manual, "ILibraryAppletAccessor:StateChangedEvent"); | 28 | Kernel::WritableEvent::CreateEventPair(kernel, "ILibraryAppletAccessor:StateChangedEvent"); |
| 29 | pop_out_data_event = Kernel::WritableEvent::CreateEventPair( | 29 | pop_out_data_event = |
| 30 | kernel, Kernel::ResetType::Manual, "ILibraryAppletAccessor:PopDataOutEvent"); | 30 | Kernel::WritableEvent::CreateEventPair(kernel, "ILibraryAppletAccessor:PopDataOutEvent"); |
| 31 | pop_interactive_out_data_event = Kernel::WritableEvent::CreateEventPair( | 31 | pop_interactive_out_data_event = Kernel::WritableEvent::CreateEventPair( |
| 32 | kernel, Kernel::ResetType::Manual, "ILibraryAppletAccessor:PopInteractiveDataOutEvent"); | 32 | kernel, "ILibraryAppletAccessor:PopInteractiveDataOutEvent"); |
| 33 | } | 33 | } |
| 34 | 34 | ||
| 35 | AppletDataBroker::~AppletDataBroker() = default; | 35 | AppletDataBroker::~AppletDataBroker() = default; |
diff --git a/src/core/hle/service/aoc/aoc_u.cpp b/src/core/hle/service/aoc/aoc_u.cpp index e9cf1e840..f36ccbc49 100644 --- a/src/core/hle/service/aoc/aoc_u.cpp +++ b/src/core/hle/service/aoc/aoc_u.cpp | |||
| @@ -67,8 +67,8 @@ AOC_U::AOC_U(Core::System& system) | |||
| 67 | RegisterHandlers(functions); | 67 | RegisterHandlers(functions); |
| 68 | 68 | ||
| 69 | auto& kernel = system.Kernel(); | 69 | auto& kernel = system.Kernel(); |
| 70 | aoc_change_event = Kernel::WritableEvent::CreateEventPair(kernel, Kernel::ResetType::Manual, | 70 | aoc_change_event = |
| 71 | "GetAddOnContentListChanged:Event"); | 71 | Kernel::WritableEvent::CreateEventPair(kernel, "GetAddOnContentListChanged:Event"); |
| 72 | } | 72 | } |
| 73 | 73 | ||
| 74 | AOC_U::~AOC_U() = default; | 74 | AOC_U::~AOC_U() = default; |
diff --git a/src/core/hle/service/audio/audout_u.cpp b/src/core/hle/service/audio/audout_u.cpp index 9afefb5c6..6a29377e3 100644 --- a/src/core/hle/service/audio/audout_u.cpp +++ b/src/core/hle/service/audio/audout_u.cpp | |||
| @@ -65,8 +65,8 @@ public: | |||
| 65 | RegisterHandlers(functions); | 65 | RegisterHandlers(functions); |
| 66 | 66 | ||
| 67 | // This is the event handle used to check if the audio buffer was released | 67 | // This is the event handle used to check if the audio buffer was released |
| 68 | buffer_event = Kernel::WritableEvent::CreateEventPair( | 68 | buffer_event = |
| 69 | system.Kernel(), Kernel::ResetType::Manual, "IAudioOutBufferReleased"); | 69 | Kernel::WritableEvent::CreateEventPair(system.Kernel(), "IAudioOutBufferReleased"); |
| 70 | 70 | ||
| 71 | stream = audio_core.OpenStream(system.CoreTiming(), audio_params.sample_rate, | 71 | stream = audio_core.OpenStream(system.CoreTiming(), audio_params.sample_rate, |
| 72 | audio_params.channel_count, std::move(unique_name), | 72 | audio_params.channel_count, std::move(unique_name), |
diff --git a/src/core/hle/service/audio/audren_u.cpp b/src/core/hle/service/audio/audren_u.cpp index f162249ed..4ea7ade6e 100644 --- a/src/core/hle/service/audio/audren_u.cpp +++ b/src/core/hle/service/audio/audren_u.cpp | |||
| @@ -47,8 +47,8 @@ public: | |||
| 47 | // clang-format on | 47 | // clang-format on |
| 48 | RegisterHandlers(functions); | 48 | RegisterHandlers(functions); |
| 49 | 49 | ||
| 50 | system_event = Kernel::WritableEvent::CreateEventPair( | 50 | system_event = |
| 51 | system.Kernel(), Kernel::ResetType::Manual, "IAudioRenderer:SystemEvent"); | 51 | Kernel::WritableEvent::CreateEventPair(system.Kernel(), "IAudioRenderer:SystemEvent"); |
| 52 | renderer = std::make_unique<AudioCore::AudioRenderer>( | 52 | renderer = std::make_unique<AudioCore::AudioRenderer>( |
| 53 | system.CoreTiming(), audren_params, system_event.writable, instance_number); | 53 | system.CoreTiming(), audren_params, system_event.writable, instance_number); |
| 54 | } | 54 | } |
| @@ -180,17 +180,17 @@ public: | |||
| 180 | RegisterHandlers(functions); | 180 | RegisterHandlers(functions); |
| 181 | 181 | ||
| 182 | auto& kernel = system.Kernel(); | 182 | auto& kernel = system.Kernel(); |
| 183 | buffer_event = Kernel::WritableEvent::CreateEventPair(kernel, Kernel::ResetType::Automatic, | 183 | buffer_event = |
| 184 | "IAudioOutBufferReleasedEvent"); | 184 | Kernel::WritableEvent::CreateEventPair(kernel, "IAudioOutBufferReleasedEvent"); |
| 185 | 185 | ||
| 186 | // Should be similar to audio_output_device_switch_event | 186 | // Should be similar to audio_output_device_switch_event |
| 187 | audio_input_device_switch_event = Kernel::WritableEvent::CreateEventPair( | 187 | audio_input_device_switch_event = Kernel::WritableEvent::CreateEventPair( |
| 188 | kernel, Kernel::ResetType::Automatic, "IAudioDevice:AudioInputDeviceSwitchedEvent"); | 188 | kernel, "IAudioDevice:AudioInputDeviceSwitchedEvent"); |
| 189 | 189 | ||
| 190 | // Should only be signalled when an audio output device has been changed, example: speaker | 190 | // Should only be signalled when an audio output device has been changed, example: speaker |
| 191 | // to headset | 191 | // to headset |
| 192 | audio_output_device_switch_event = Kernel::WritableEvent::CreateEventPair( | 192 | audio_output_device_switch_event = Kernel::WritableEvent::CreateEventPair( |
| 193 | kernel, Kernel::ResetType::Automatic, "IAudioDevice:AudioOutputDeviceSwitchedEvent"); | 193 | kernel, "IAudioDevice:AudioOutputDeviceSwitchedEvent"); |
| 194 | } | 194 | } |
| 195 | 195 | ||
| 196 | private: | 196 | private: |
diff --git a/src/core/hle/service/bcat/backend/backend.cpp b/src/core/hle/service/bcat/backend/backend.cpp index b86fda29a..dec0849b8 100644 --- a/src/core/hle/service/bcat/backend/backend.cpp +++ b/src/core/hle/service/bcat/backend/backend.cpp | |||
| @@ -13,8 +13,7 @@ namespace Service::BCAT { | |||
| 13 | ProgressServiceBackend::ProgressServiceBackend(Kernel::KernelCore& kernel, | 13 | ProgressServiceBackend::ProgressServiceBackend(Kernel::KernelCore& kernel, |
| 14 | std::string_view event_name) { | 14 | std::string_view event_name) { |
| 15 | event = Kernel::WritableEvent::CreateEventPair( | 15 | event = Kernel::WritableEvent::CreateEventPair( |
| 16 | kernel, Kernel::ResetType::Automatic, | 16 | kernel, std::string("ProgressServiceBackend:UpdateEvent:").append(event_name)); |
| 17 | std::string("ProgressServiceBackend:UpdateEvent:").append(event_name)); | ||
| 18 | } | 17 | } |
| 19 | 18 | ||
| 20 | Kernel::SharedPtr<Kernel::ReadableEvent> ProgressServiceBackend::GetEvent() const { | 19 | Kernel::SharedPtr<Kernel::ReadableEvent> ProgressServiceBackend::GetEvent() const { |
diff --git a/src/core/hle/service/btdrv/btdrv.cpp b/src/core/hle/service/btdrv/btdrv.cpp index afce581e5..4574d9572 100644 --- a/src/core/hle/service/btdrv/btdrv.cpp +++ b/src/core/hle/service/btdrv/btdrv.cpp | |||
| @@ -34,8 +34,7 @@ public: | |||
| 34 | RegisterHandlers(functions); | 34 | RegisterHandlers(functions); |
| 35 | 35 | ||
| 36 | auto& kernel = system.Kernel(); | 36 | auto& kernel = system.Kernel(); |
| 37 | register_event = Kernel::WritableEvent::CreateEventPair( | 37 | register_event = Kernel::WritableEvent::CreateEventPair(kernel, "BT:RegisterEvent"); |
| 38 | kernel, Kernel::ResetType::Automatic, "BT:RegisterEvent"); | ||
| 39 | } | 38 | } |
| 40 | 39 | ||
| 41 | private: | 40 | private: |
diff --git a/src/core/hle/service/btm/btm.cpp b/src/core/hle/service/btm/btm.cpp index 920fc6ff7..251b3c9df 100644 --- a/src/core/hle/service/btm/btm.cpp +++ b/src/core/hle/service/btm/btm.cpp | |||
| @@ -57,14 +57,12 @@ public: | |||
| 57 | RegisterHandlers(functions); | 57 | RegisterHandlers(functions); |
| 58 | 58 | ||
| 59 | auto& kernel = system.Kernel(); | 59 | auto& kernel = system.Kernel(); |
| 60 | scan_event = Kernel::WritableEvent::CreateEventPair(kernel, Kernel::ResetType::Automatic, | 60 | scan_event = Kernel::WritableEvent::CreateEventPair(kernel, "IBtmUserCore:ScanEvent"); |
| 61 | "IBtmUserCore:ScanEvent"); | 61 | connection_event = |
| 62 | connection_event = Kernel::WritableEvent::CreateEventPair( | 62 | Kernel::WritableEvent::CreateEventPair(kernel, "IBtmUserCore:ConnectionEvent"); |
| 63 | kernel, Kernel::ResetType::Automatic, "IBtmUserCore:ConnectionEvent"); | 63 | service_discovery = |
| 64 | service_discovery = Kernel::WritableEvent::CreateEventPair( | 64 | Kernel::WritableEvent::CreateEventPair(kernel, "IBtmUserCore:Discovery"); |
| 65 | kernel, Kernel::ResetType::Automatic, "IBtmUserCore:Discovery"); | 65 | config_event = Kernel::WritableEvent::CreateEventPair(kernel, "IBtmUserCore:ConfigEvent"); |
| 66 | config_event = Kernel::WritableEvent::CreateEventPair(kernel, Kernel::ResetType::Automatic, | ||
| 67 | "IBtmUserCore:ConfigEvent"); | ||
| 68 | } | 66 | } |
| 69 | 67 | ||
| 70 | private: | 68 | private: |
diff --git a/src/core/hle/service/friend/friend.cpp b/src/core/hle/service/friend/friend.cpp index 75dd9043b..1a0214f08 100644 --- a/src/core/hle/service/friend/friend.cpp +++ b/src/core/hle/service/friend/friend.cpp | |||
| @@ -162,7 +162,7 @@ public: | |||
| 162 | RegisterHandlers(functions); | 162 | RegisterHandlers(functions); |
| 163 | 163 | ||
| 164 | notification_event = Kernel::WritableEvent::CreateEventPair( | 164 | notification_event = Kernel::WritableEvent::CreateEventPair( |
| 165 | system.Kernel(), Kernel::ResetType::Manual, "INotificationService:NotifyEvent"); | 165 | system.Kernel(), "INotificationService:NotifyEvent"); |
| 166 | } | 166 | } |
| 167 | 167 | ||
| 168 | private: | 168 | private: |
diff --git a/src/core/hle/service/hid/controllers/npad.cpp b/src/core/hle/service/hid/controllers/npad.cpp index 81bd2f3cb..79fff517e 100644 --- a/src/core/hle/service/hid/controllers/npad.cpp +++ b/src/core/hle/service/hid/controllers/npad.cpp | |||
| @@ -174,7 +174,7 @@ void Controller_NPad::OnInit() { | |||
| 174 | auto& kernel = system.Kernel(); | 174 | auto& kernel = system.Kernel(); |
| 175 | for (std::size_t i = 0; i < styleset_changed_events.size(); i++) { | 175 | for (std::size_t i = 0; i < styleset_changed_events.size(); i++) { |
| 176 | styleset_changed_events[i] = Kernel::WritableEvent::CreateEventPair( | 176 | styleset_changed_events[i] = Kernel::WritableEvent::CreateEventPair( |
| 177 | kernel, Kernel::ResetType::Manual, fmt::format("npad:NpadStyleSetChanged_{}", i)); | 177 | kernel, fmt::format("npad:NpadStyleSetChanged_{}", i)); |
| 178 | } | 178 | } |
| 179 | 179 | ||
| 180 | if (!IsControllerActivated()) { | 180 | if (!IsControllerActivated()) { |
diff --git a/src/core/hle/service/nfp/nfp.cpp b/src/core/hle/service/nfp/nfp.cpp index aa886cd3e..795d7b716 100644 --- a/src/core/hle/service/nfp/nfp.cpp +++ b/src/core/hle/service/nfp/nfp.cpp | |||
| @@ -26,8 +26,7 @@ constexpr ResultCode ERR_NO_APPLICATION_AREA(ErrorModule::NFP, 152); | |||
| 26 | Module::Interface::Interface(std::shared_ptr<Module> module, Core::System& system, const char* name) | 26 | Module::Interface::Interface(std::shared_ptr<Module> module, Core::System& system, const char* name) |
| 27 | : ServiceFramework(name), module(std::move(module)), system(system) { | 27 | : ServiceFramework(name), module(std::move(module)), system(system) { |
| 28 | auto& kernel = system.Kernel(); | 28 | auto& kernel = system.Kernel(); |
| 29 | nfc_tag_load = Kernel::WritableEvent::CreateEventPair(kernel, Kernel::ResetType::Automatic, | 29 | nfc_tag_load = Kernel::WritableEvent::CreateEventPair(kernel, "IUser:NFCTagDetected"); |
| 30 | "IUser:NFCTagDetected"); | ||
| 31 | } | 30 | } |
| 32 | 31 | ||
| 33 | Module::Interface::~Interface() = default; | 32 | Module::Interface::~Interface() = default; |
| @@ -66,10 +65,9 @@ public: | |||
| 66 | RegisterHandlers(functions); | 65 | RegisterHandlers(functions); |
| 67 | 66 | ||
| 68 | auto& kernel = system.Kernel(); | 67 | auto& kernel = system.Kernel(); |
| 69 | deactivate_event = Kernel::WritableEvent::CreateEventPair( | 68 | deactivate_event = Kernel::WritableEvent::CreateEventPair(kernel, "IUser:DeactivateEvent"); |
| 70 | kernel, Kernel::ResetType::Automatic, "IUser:DeactivateEvent"); | 69 | availability_change_event = |
| 71 | availability_change_event = Kernel::WritableEvent::CreateEventPair( | 70 | Kernel::WritableEvent::CreateEventPair(kernel, "IUser:AvailabilityChangeEvent"); |
| 72 | kernel, Kernel::ResetType::Automatic, "IUser:AvailabilityChangeEvent"); | ||
| 73 | } | 71 | } |
| 74 | 72 | ||
| 75 | private: | 73 | private: |
diff --git a/src/core/hle/service/nifm/nifm.cpp b/src/core/hle/service/nifm/nifm.cpp index 756a2af57..01d557c7a 100644 --- a/src/core/hle/service/nifm/nifm.cpp +++ b/src/core/hle/service/nifm/nifm.cpp | |||
| @@ -69,10 +69,8 @@ public: | |||
| 69 | RegisterHandlers(functions); | 69 | RegisterHandlers(functions); |
| 70 | 70 | ||
| 71 | auto& kernel = system.Kernel(); | 71 | auto& kernel = system.Kernel(); |
| 72 | event1 = Kernel::WritableEvent::CreateEventPair(kernel, Kernel::ResetType::Automatic, | 72 | event1 = Kernel::WritableEvent::CreateEventPair(kernel, "IRequest:Event1"); |
| 73 | "IRequest:Event1"); | 73 | event2 = Kernel::WritableEvent::CreateEventPair(kernel, "IRequest:Event2"); |
| 74 | event2 = Kernel::WritableEvent::CreateEventPair(kernel, Kernel::ResetType::Automatic, | ||
| 75 | "IRequest:Event2"); | ||
| 76 | } | 74 | } |
| 77 | 75 | ||
| 78 | private: | 76 | private: |
diff --git a/src/core/hle/service/nim/nim.cpp b/src/core/hle/service/nim/nim.cpp index 75d414952..7d6cf2070 100644 --- a/src/core/hle/service/nim/nim.cpp +++ b/src/core/hle/service/nim/nim.cpp | |||
| @@ -141,8 +141,7 @@ public: | |||
| 141 | 141 | ||
| 142 | auto& kernel = system.Kernel(); | 142 | auto& kernel = system.Kernel(); |
| 143 | finished_event = Kernel::WritableEvent::CreateEventPair( | 143 | finished_event = Kernel::WritableEvent::CreateEventPair( |
| 144 | kernel, Kernel::ResetType::Automatic, | 144 | kernel, "IEnsureNetworkClockAvailabilityService:FinishEvent"); |
| 145 | "IEnsureNetworkClockAvailabilityService:FinishEvent"); | ||
| 146 | } | 145 | } |
| 147 | 146 | ||
| 148 | private: | 147 | private: |
diff --git a/src/core/hle/service/nvdrv/nvdrv.cpp b/src/core/hle/service/nvdrv/nvdrv.cpp index 7bfb99e34..cc9cd3fd1 100644 --- a/src/core/hle/service/nvdrv/nvdrv.cpp +++ b/src/core/hle/service/nvdrv/nvdrv.cpp | |||
| @@ -40,8 +40,7 @@ Module::Module(Core::System& system) { | |||
| 40 | auto& kernel = system.Kernel(); | 40 | auto& kernel = system.Kernel(); |
| 41 | for (u32 i = 0; i < MaxNvEvents; i++) { | 41 | for (u32 i = 0; i < MaxNvEvents; i++) { |
| 42 | std::string event_label = fmt::format("NVDRV::NvEvent_{}", i); | 42 | std::string event_label = fmt::format("NVDRV::NvEvent_{}", i); |
| 43 | events_interface.events[i] = | 43 | events_interface.events[i] = Kernel::WritableEvent::CreateEventPair(kernel, event_label); |
| 44 | Kernel::WritableEvent::CreateEventPair(kernel, Kernel::ResetType::Manual, event_label); | ||
| 45 | events_interface.status[i] = EventState::Free; | 44 | events_interface.status[i] = EventState::Free; |
| 46 | events_interface.registered[i] = false; | 45 | events_interface.registered[i] = false; |
| 47 | } | 46 | } |
diff --git a/src/core/hle/service/nvflinger/buffer_queue.cpp b/src/core/hle/service/nvflinger/buffer_queue.cpp index 55b68eb0c..1af11e80c 100644 --- a/src/core/hle/service/nvflinger/buffer_queue.cpp +++ b/src/core/hle/service/nvflinger/buffer_queue.cpp | |||
| @@ -16,8 +16,7 @@ namespace Service::NVFlinger { | |||
| 16 | 16 | ||
| 17 | BufferQueue::BufferQueue(Kernel::KernelCore& kernel, u32 id, u64 layer_id) | 17 | BufferQueue::BufferQueue(Kernel::KernelCore& kernel, u32 id, u64 layer_id) |
| 18 | : id(id), layer_id(layer_id) { | 18 | : id(id), layer_id(layer_id) { |
| 19 | buffer_wait_event = Kernel::WritableEvent::CreateEventPair(kernel, Kernel::ResetType::Manual, | 19 | buffer_wait_event = Kernel::WritableEvent::CreateEventPair(kernel, "BufferQueue NativeHandle"); |
| 20 | "BufferQueue NativeHandle"); | ||
| 21 | } | 20 | } |
| 22 | 21 | ||
| 23 | BufferQueue::~BufferQueue() = default; | 22 | BufferQueue::~BufferQueue() = default; |
diff --git a/src/core/hle/service/vi/display/vi_display.cpp b/src/core/hle/service/vi/display/vi_display.cpp index 006a6d9ff..07033fb98 100644 --- a/src/core/hle/service/vi/display/vi_display.cpp +++ b/src/core/hle/service/vi/display/vi_display.cpp | |||
| @@ -17,8 +17,8 @@ namespace Service::VI { | |||
| 17 | 17 | ||
| 18 | Display::Display(u64 id, std::string name, Core::System& system) : id{id}, name{std::move(name)} { | 18 | Display::Display(u64 id, std::string name, Core::System& system) : id{id}, name{std::move(name)} { |
| 19 | auto& kernel = system.Kernel(); | 19 | auto& kernel = system.Kernel(); |
| 20 | vsync_event = Kernel::WritableEvent::CreateEventPair(kernel, Kernel::ResetType::Manual, | 20 | vsync_event = |
| 21 | fmt::format("Display VSync Event {}", id)); | 21 | Kernel::WritableEvent::CreateEventPair(kernel, fmt::format("Display VSync Event {}", id)); |
| 22 | } | 22 | } |
| 23 | 23 | ||
| 24 | Display::~Display() = default; | 24 | Display::~Display() = default; |
diff --git a/src/yuzu/debugger/wait_tree.cpp b/src/yuzu/debugger/wait_tree.cpp index c5b9aa08f..188f798c0 100644 --- a/src/yuzu/debugger/wait_tree.cpp +++ b/src/yuzu/debugger/wait_tree.cpp | |||
| @@ -172,17 +172,6 @@ std::vector<std::unique_ptr<WaitTreeItem>> WaitTreeWaitObject::GetChildren() con | |||
| 172 | return list; | 172 | return list; |
| 173 | } | 173 | } |
| 174 | 174 | ||
| 175 | QString WaitTreeWaitObject::GetResetTypeQString(Kernel::ResetType reset_type) { | ||
| 176 | switch (reset_type) { | ||
| 177 | case Kernel::ResetType::Automatic: | ||
| 178 | return tr("automatic reset"); | ||
| 179 | case Kernel::ResetType::Manual: | ||
| 180 | return tr("manual reset"); | ||
| 181 | } | ||
| 182 | UNREACHABLE(); | ||
| 183 | return {}; | ||
| 184 | } | ||
| 185 | |||
| 186 | WaitTreeObjectList::WaitTreeObjectList( | 175 | WaitTreeObjectList::WaitTreeObjectList( |
| 187 | const std::vector<Kernel::SharedPtr<Kernel::WaitObject>>& list, bool w_all) | 176 | const std::vector<Kernel::SharedPtr<Kernel::WaitObject>>& list, bool w_all) |
| 188 | : object_list(list), wait_all(w_all) {} | 177 | : object_list(list), wait_all(w_all) {} |
| @@ -336,16 +325,6 @@ std::vector<std::unique_ptr<WaitTreeItem>> WaitTreeThread::GetChildren() const { | |||
| 336 | WaitTreeEvent::WaitTreeEvent(const Kernel::ReadableEvent& object) : WaitTreeWaitObject(object) {} | 325 | WaitTreeEvent::WaitTreeEvent(const Kernel::ReadableEvent& object) : WaitTreeWaitObject(object) {} |
| 337 | WaitTreeEvent::~WaitTreeEvent() = default; | 326 | WaitTreeEvent::~WaitTreeEvent() = default; |
| 338 | 327 | ||
| 339 | std::vector<std::unique_ptr<WaitTreeItem>> WaitTreeEvent::GetChildren() const { | ||
| 340 | std::vector<std::unique_ptr<WaitTreeItem>> list(WaitTreeWaitObject::GetChildren()); | ||
| 341 | |||
| 342 | list.push_back(std::make_unique<WaitTreeText>( | ||
| 343 | tr("reset type = %1") | ||
| 344 | .arg(GetResetTypeQString( | ||
| 345 | static_cast<const Kernel::ReadableEvent&>(object).GetResetType())))); | ||
| 346 | return list; | ||
| 347 | } | ||
| 348 | |||
| 349 | WaitTreeThreadList::WaitTreeThreadList(const std::vector<Kernel::SharedPtr<Kernel::Thread>>& list) | 328 | WaitTreeThreadList::WaitTreeThreadList(const std::vector<Kernel::SharedPtr<Kernel::Thread>>& list) |
| 350 | : thread_list(list) {} | 329 | : thread_list(list) {} |
| 351 | WaitTreeThreadList::~WaitTreeThreadList() = default; | 330 | WaitTreeThreadList::~WaitTreeThreadList() = default; |
diff --git a/src/yuzu/debugger/wait_tree.h b/src/yuzu/debugger/wait_tree.h index 62886609d..f2b13be24 100644 --- a/src/yuzu/debugger/wait_tree.h +++ b/src/yuzu/debugger/wait_tree.h | |||
| @@ -111,8 +111,6 @@ public: | |||
| 111 | 111 | ||
| 112 | protected: | 112 | protected: |
| 113 | const Kernel::WaitObject& object; | 113 | const Kernel::WaitObject& object; |
| 114 | |||
| 115 | static QString GetResetTypeQString(Kernel::ResetType reset_type); | ||
| 116 | }; | 114 | }; |
| 117 | 115 | ||
| 118 | class WaitTreeObjectList : public WaitTreeExpandableItem { | 116 | class WaitTreeObjectList : public WaitTreeExpandableItem { |
| @@ -146,8 +144,6 @@ class WaitTreeEvent : public WaitTreeWaitObject { | |||
| 146 | public: | 144 | public: |
| 147 | explicit WaitTreeEvent(const Kernel::ReadableEvent& object); | 145 | explicit WaitTreeEvent(const Kernel::ReadableEvent& object); |
| 148 | ~WaitTreeEvent() override; | 146 | ~WaitTreeEvent() override; |
| 149 | |||
| 150 | std::vector<std::unique_ptr<WaitTreeItem>> GetChildren() const override; | ||
| 151 | }; | 147 | }; |
| 152 | 148 | ||
| 153 | class WaitTreeThreadList : public WaitTreeExpandableItem { | 149 | class WaitTreeThreadList : public WaitTreeExpandableItem { |