diff options
| author | 2018-12-05 22:37:14 -0500 | |
|---|---|---|
| committer | 2018-12-05 22:37:14 -0500 | |
| commit | 4c106b43a9cb41f22935b4405373ca05a15dc7a9 (patch) | |
| tree | 7735c506ed6ce4a7f6d93414063eeb2f5cb6938b | |
| parent | Merge pull request #1866 from lioncash/cache (diff) | |
| parent | ng_word: Deduplicate use of a constant value (diff) | |
| download | yuzu-4c106b43a9cb41f22935b4405373ca05a15dc7a9.tar.gz yuzu-4c106b43a9cb41f22935b4405373ca05a15dc7a9.tar.xz yuzu-4c106b43a9cb41f22935b4405373ca05a15dc7a9.zip | |
Merge pull request #1867 from lioncash/alloc
system_archive: Use a regular function pointer instead of std::function for the file-scope system archive array
| -rw-r--r-- | src/core/file_sys/system_archive/ng_word.cpp | 2 | ||||
| -rw-r--r-- | src/core/file_sys/system_archive/system_archive.cpp | 5 |
2 files changed, 3 insertions, 4 deletions
diff --git a/src/core/file_sys/system_archive/ng_word.cpp b/src/core/file_sys/system_archive/ng_word.cpp index d0acdbd49..a24f1e496 100644 --- a/src/core/file_sys/system_archive/ng_word.cpp +++ b/src/core/file_sys/system_archive/ng_word.cpp | |||
| @@ -26,7 +26,7 @@ constexpr std::array<u8, 30> WORD_TXT{ | |||
| 26 | VirtualDir NgWord1() { | 26 | VirtualDir NgWord1() { |
| 27 | std::vector<VirtualFile> files(NgWord1Data::NUMBER_WORD_TXT_FILES); | 27 | std::vector<VirtualFile> files(NgWord1Data::NUMBER_WORD_TXT_FILES); |
| 28 | 28 | ||
| 29 | for (std::size_t i = 0; i < NgWord1Data::NUMBER_WORD_TXT_FILES; ++i) { | 29 | for (std::size_t i = 0; i < files.size(); ++i) { |
| 30 | files[i] = std::make_shared<ArrayVfsFile<NgWord1Data::WORD_TXT.size()>>( | 30 | files[i] = std::make_shared<ArrayVfsFile<NgWord1Data::WORD_TXT.size()>>( |
| 31 | NgWord1Data::WORD_TXT, fmt::format("{}.txt", i)); | 31 | NgWord1Data::WORD_TXT, fmt::format("{}.txt", i)); |
| 32 | } | 32 | } |
diff --git a/src/core/file_sys/system_archive/system_archive.cpp b/src/core/file_sys/system_archive/system_archive.cpp index c9c40a07d..d3883267c 100644 --- a/src/core/file_sys/system_archive/system_archive.cpp +++ b/src/core/file_sys/system_archive/system_archive.cpp | |||
| @@ -2,7 +2,6 @@ | |||
| 2 | // Licensed under GPLv2 or any later version | 2 | // Licensed under GPLv2 or any later version |
| 3 | // Refer to the license.txt file included. | 3 | // Refer to the license.txt file included. |
| 4 | 4 | ||
| 5 | #include <functional> | ||
| 6 | #include "common/logging/log.h" | 5 | #include "common/logging/log.h" |
| 7 | #include "core/file_sys/romfs.h" | 6 | #include "core/file_sys/romfs.h" |
| 8 | #include "core/file_sys/system_archive/ng_word.h" | 7 | #include "core/file_sys/system_archive/ng_word.h" |
| @@ -13,7 +12,7 @@ namespace FileSys::SystemArchive { | |||
| 13 | constexpr u64 SYSTEM_ARCHIVE_BASE_TITLE_ID = 0x0100000000000800; | 12 | constexpr u64 SYSTEM_ARCHIVE_BASE_TITLE_ID = 0x0100000000000800; |
| 14 | constexpr std::size_t SYSTEM_ARCHIVE_COUNT = 0x28; | 13 | constexpr std::size_t SYSTEM_ARCHIVE_COUNT = 0x28; |
| 15 | 14 | ||
| 16 | using SystemArchiveSupplier = std::function<VirtualDir()>; | 15 | using SystemArchiveSupplier = VirtualDir (*)(); |
| 17 | 16 | ||
| 18 | struct SystemArchiveDescriptor { | 17 | struct SystemArchiveDescriptor { |
| 19 | u64 title_id; | 18 | u64 title_id; |
| @@ -21,7 +20,7 @@ struct SystemArchiveDescriptor { | |||
| 21 | SystemArchiveSupplier supplier; | 20 | SystemArchiveSupplier supplier; |
| 22 | }; | 21 | }; |
| 23 | 22 | ||
| 24 | const std::array<SystemArchiveDescriptor, SYSTEM_ARCHIVE_COUNT> SYSTEM_ARCHIVES = {{ | 23 | constexpr std::array<SystemArchiveDescriptor, SYSTEM_ARCHIVE_COUNT> SYSTEM_ARCHIVES{{ |
| 25 | {0x0100000000000800, "CertStore", nullptr}, | 24 | {0x0100000000000800, "CertStore", nullptr}, |
| 26 | {0x0100000000000801, "ErrorMessage", nullptr}, | 25 | {0x0100000000000801, "ErrorMessage", nullptr}, |
| 27 | {0x0100000000000802, "MiiModel", nullptr}, | 26 | {0x0100000000000802, "MiiModel", nullptr}, |