diff options
| author |  lat9nq | 2021-04-04 15:02:35 -0400 |
|---|---|---|
| committer | lat9nq | 2021-04-04 15:05:22 -0400 |
| commit | 33ed02a239752b7db26e89b5d707a0f28274bbc8 (patch) | |
| tree | 6ec5a0a8e3fd86ade87bcf8506b8fa685e2ead7b | |
| parent | Merge pull request #6139 from Morph1984/cmake-fix-build (diff) | |
| download | yuzu-33ed02a239752b7db26e89b5d707a0f28274bbc8.tar.gz yuzu-33ed02a239752b7db26e89b5d707a0f28274bbc8.tar.xz yuzu-33ed02a239752b7db26e89b5d707a0f28274bbc8.zip | |
configure_graphics: Prevent stack-use-after-scope
Address Sanitizer reports stack-use-after-scope on line 231
`vulkan_devices.push_back(QString::fromStdString(name));`. Instead of
using a pointer, copy the string into a std::string and use that,
instead.
| -rw-r--r-- | src/yuzu/configuration/configure_graphics.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/yuzu/configuration/configure_graphics.cpp b/src/yuzu/configuration/configure_graphics.cpp index 9ff32aec4..49acc48b2 100644 --- a/src/yuzu/configuration/configure_graphics.cpp +++ b/src/yuzu/configuration/configure_graphics.cpp | |||
| @@ -227,7 +227,7 @@ void ConfigureGraphics::RetrieveVulkanDevices() try { | |||
| 227 | vulkan_devices.clear(); | 227 | vulkan_devices.clear(); |
| 228 | vulkan_devices.reserve(physical_devices.size()); | 228 | vulkan_devices.reserve(physical_devices.size()); |
| 229 | for (const VkPhysicalDevice device : physical_devices) { | 229 | for (const VkPhysicalDevice device : physical_devices) { |
| 230 | const char* const name = vk::PhysicalDevice(device, dld).GetProperties().deviceName; | 230 | const std::string name = vk::PhysicalDevice(device, dld).GetProperties().deviceName; |
| 231 | vulkan_devices.push_back(QString::fromStdString(name)); | 231 | vulkan_devices.push_back(QString::fromStdString(name)); |
| 232 | } | 232 | } |
| 233 | 233 | ||