diff options
| author | 2021-12-05 23:49:26 -0800 | |
|---|---|---|
| committer | 2021-12-06 16:39:18 -0800 | |
| commit | 0d1bdfc1d4f9cb9ceecdb2dd9c784a664f6ba0c8 (patch) | |
| tree | 40ee98688585e116a0773c23eb7bd12f3d488d5c | |
| parent | hle: kernel: service_thread: Force stop threads on destruction. (diff) | |
| download | yuzu-0d1bdfc1d4f9cb9ceecdb2dd9c784a664f6ba0c8.tar.gz yuzu-0d1bdfc1d4f9cb9ceecdb2dd9c784a664f6ba0c8.tar.xz yuzu-0d1bdfc1d4f9cb9ceecdb2dd9c784a664f6ba0c8.zip | |
hle: kernel: Remove unnecessary virtual specifier on CancelWait.
| -rw-r--r-- | src/core/hle/kernel/k_address_arbiter.cpp | 4 | ||||
| -rw-r--r-- | src/core/hle/kernel/k_condition_variable.cpp | 8 | ||||
| -rw-r--r-- | src/core/hle/kernel/k_light_condition_variable.cpp | 4 | ||||
| -rw-r--r-- | src/core/hle/kernel/k_light_lock.cpp | 4 | ||||
| -rw-r--r-- | src/core/hle/kernel/k_synchronization_object.cpp | 4 | ||||
| -rw-r--r-- | src/core/hle/kernel/k_thread.cpp | 4 |
6 files changed, 14 insertions, 14 deletions
diff --git a/src/core/hle/kernel/k_address_arbiter.cpp b/src/core/hle/kernel/k_address_arbiter.cpp index a4ce99402..783c69858 100644 --- a/src/core/hle/kernel/k_address_arbiter.cpp +++ b/src/core/hle/kernel/k_address_arbiter.cpp | |||
| @@ -91,8 +91,8 @@ public: | |||
| 91 | explicit ThreadQueueImplForKAddressArbiter(KernelCore& kernel_, KAddressArbiter::ThreadTree* t) | 91 | explicit ThreadQueueImplForKAddressArbiter(KernelCore& kernel_, KAddressArbiter::ThreadTree* t) |
| 92 | : KThreadQueue(kernel_), m_tree(t) {} | 92 | : KThreadQueue(kernel_), m_tree(t) {} |
| 93 | 93 | ||
| 94 | virtual void CancelWait(KThread* waiting_thread, ResultCode wait_result, | 94 | void CancelWait(KThread* waiting_thread, ResultCode wait_result, |
| 95 | bool cancel_timer_task) override { | 95 | bool cancel_timer_task) override { |
| 96 | // If the thread is waiting on an address arbiter, remove it from the tree. | 96 | // If the thread is waiting on an address arbiter, remove it from the tree. |
| 97 | if (waiting_thread->IsWaitingForAddressArbiter()) { | 97 | if (waiting_thread->IsWaitingForAddressArbiter()) { |
| 98 | m_tree->erase(m_tree->iterator_to(*waiting_thread)); | 98 | m_tree->erase(m_tree->iterator_to(*waiting_thread)); |
diff --git a/src/core/hle/kernel/k_condition_variable.cpp b/src/core/hle/kernel/k_condition_variable.cpp index f343e3c2f..fcfb74ec1 100644 --- a/src/core/hle/kernel/k_condition_variable.cpp +++ b/src/core/hle/kernel/k_condition_variable.cpp | |||
| @@ -63,8 +63,8 @@ public: | |||
| 63 | explicit ThreadQueueImplForKConditionVariableWaitForAddress(KernelCore& kernel_) | 63 | explicit ThreadQueueImplForKConditionVariableWaitForAddress(KernelCore& kernel_) |
| 64 | : KThreadQueue(kernel_) {} | 64 | : KThreadQueue(kernel_) {} |
| 65 | 65 | ||
| 66 | virtual void CancelWait(KThread* waiting_thread, ResultCode wait_result, | 66 | void CancelWait(KThread* waiting_thread, ResultCode wait_result, |
| 67 | bool cancel_timer_task) override { | 67 | bool cancel_timer_task) override { |
| 68 | // Remove the thread as a waiter from its owner. | 68 | // Remove the thread as a waiter from its owner. |
| 69 | waiting_thread->GetLockOwner()->RemoveWaiter(waiting_thread); | 69 | waiting_thread->GetLockOwner()->RemoveWaiter(waiting_thread); |
| 70 | 70 | ||
| @@ -82,8 +82,8 @@ public: | |||
| 82 | KernelCore& kernel_, KConditionVariable::ThreadTree* t) | 82 | KernelCore& kernel_, KConditionVariable::ThreadTree* t) |
| 83 | : KThreadQueue(kernel_), m_tree(t) {} | 83 | : KThreadQueue(kernel_), m_tree(t) {} |
| 84 | 84 | ||
| 85 | virtual void CancelWait(KThread* waiting_thread, ResultCode wait_result, | 85 | void CancelWait(KThread* waiting_thread, ResultCode wait_result, |
| 86 | bool cancel_timer_task) override { | 86 | bool cancel_timer_task) override { |
| 87 | // Remove the thread as a waiter from its owner. | 87 | // Remove the thread as a waiter from its owner. |
| 88 | if (KThread* owner = waiting_thread->GetLockOwner(); owner != nullptr) { | 88 | if (KThread* owner = waiting_thread->GetLockOwner(); owner != nullptr) { |
| 89 | owner->RemoveWaiter(waiting_thread); | 89 | owner->RemoveWaiter(waiting_thread); |
diff --git a/src/core/hle/kernel/k_light_condition_variable.cpp b/src/core/hle/kernel/k_light_condition_variable.cpp index 7319a0ca0..a8001fffc 100644 --- a/src/core/hle/kernel/k_light_condition_variable.cpp +++ b/src/core/hle/kernel/k_light_condition_variable.cpp | |||
| @@ -18,8 +18,8 @@ public: | |||
| 18 | bool term) | 18 | bool term) |
| 19 | : KThreadQueue(kernel_), m_wait_list(wl), m_allow_terminating_thread(term) {} | 19 | : KThreadQueue(kernel_), m_wait_list(wl), m_allow_terminating_thread(term) {} |
| 20 | 20 | ||
| 21 | virtual void CancelWait(KThread* waiting_thread, ResultCode wait_result, | 21 | void CancelWait(KThread* waiting_thread, ResultCode wait_result, |
| 22 | bool cancel_timer_task) override { | 22 | bool cancel_timer_task) override { |
| 23 | // Only process waits if we're allowed to. | 23 | // Only process waits if we're allowed to. |
| 24 | if (ResultTerminationRequested == wait_result && m_allow_terminating_thread) { | 24 | if (ResultTerminationRequested == wait_result && m_allow_terminating_thread) { |
| 25 | return; | 25 | return; |
diff --git a/src/core/hle/kernel/k_light_lock.cpp b/src/core/hle/kernel/k_light_lock.cpp index 9830506ff..4620342eb 100644 --- a/src/core/hle/kernel/k_light_lock.cpp +++ b/src/core/hle/kernel/k_light_lock.cpp | |||
| @@ -16,8 +16,8 @@ class ThreadQueueImplForKLightLock final : public KThreadQueue { | |||
| 16 | public: | 16 | public: |
| 17 | explicit ThreadQueueImplForKLightLock(KernelCore& kernel_) : KThreadQueue(kernel_) {} | 17 | explicit ThreadQueueImplForKLightLock(KernelCore& kernel_) : KThreadQueue(kernel_) {} |
| 18 | 18 | ||
| 19 | virtual void CancelWait(KThread* waiting_thread, ResultCode wait_result, | 19 | void CancelWait(KThread* waiting_thread, ResultCode wait_result, |
| 20 | bool cancel_timer_task) override { | 20 | bool cancel_timer_task) override { |
| 21 | // Remove the thread as a waiter from its owner. | 21 | // Remove the thread as a waiter from its owner. |
| 22 | if (KThread* owner = waiting_thread->GetLockOwner(); owner != nullptr) { | 22 | if (KThread* owner = waiting_thread->GetLockOwner(); owner != nullptr) { |
| 23 | owner->RemoveWaiter(waiting_thread); | 23 | owner->RemoveWaiter(waiting_thread); |
diff --git a/src/core/hle/kernel/k_synchronization_object.cpp b/src/core/hle/kernel/k_synchronization_object.cpp index ffeb4b73f..6ae93b0ad 100644 --- a/src/core/hle/kernel/k_synchronization_object.cpp +++ b/src/core/hle/kernel/k_synchronization_object.cpp | |||
| @@ -46,8 +46,8 @@ public: | |||
| 46 | KThreadQueue::EndWait(waiting_thread, wait_result); | 46 | KThreadQueue::EndWait(waiting_thread, wait_result); |
| 47 | } | 47 | } |
| 48 | 48 | ||
| 49 | virtual void CancelWait(KThread* waiting_thread, ResultCode wait_result, | 49 | void CancelWait(KThread* waiting_thread, ResultCode wait_result, |
| 50 | bool cancel_timer_task) override { | 50 | bool cancel_timer_task) override { |
| 51 | // Remove all nodes from our list. | 51 | // Remove all nodes from our list. |
| 52 | for (auto i = 0; i < m_count; ++i) { | 52 | for (auto i = 0; i < m_count; ++i) { |
| 53 | m_objects[i]->UnlinkNode(std::addressof(m_nodes[i])); | 53 | m_objects[i]->UnlinkNode(std::addressof(m_nodes[i])); |
diff --git a/src/core/hle/kernel/k_thread.cpp b/src/core/hle/kernel/k_thread.cpp index 03175e5c2..752592e2e 100644 --- a/src/core/hle/kernel/k_thread.cpp +++ b/src/core/hle/kernel/k_thread.cpp | |||
| @@ -72,8 +72,8 @@ public: | |||
| 72 | explicit ThreadQueueImplForKThreadSetProperty(KernelCore& kernel_, KThread::WaiterList* wl) | 72 | explicit ThreadQueueImplForKThreadSetProperty(KernelCore& kernel_, KThread::WaiterList* wl) |
| 73 | : KThreadQueue(kernel_), m_wait_list(wl) {} | 73 | : KThreadQueue(kernel_), m_wait_list(wl) {} |
| 74 | 74 | ||
| 75 | virtual void CancelWait(KThread* waiting_thread, ResultCode wait_result, | 75 | void CancelWait(KThread* waiting_thread, ResultCode wait_result, |
| 76 | bool cancel_timer_task) override { | 76 | bool cancel_timer_task) override { |
| 77 | // Remove the thread from the wait list. | 77 | // Remove the thread from the wait list. |
| 78 | m_wait_list->erase(m_wait_list->iterator_to(*waiting_thread)); | 78 | m_wait_list->erase(m_wait_list->iterator_to(*waiting_thread)); |
| 79 | 79 | ||