diff options
| author | 2023-01-05 06:06:33 -0500 | |
|---|---|---|
| committer | 2023-01-05 06:06:33 -0500 | |
| commit | af5ecb0b15d4449f58434e70eed835cf71fc5527 (patch) | |
| tree | 668943cf63ff7dd94fcbbea26dcf321863e9a54a | |
| parent | video_core: Cache GPU internal writes. (diff) | |
| download | yuzu-af5ecb0b15d4449f58434e70eed835cf71fc5527.tar.gz yuzu-af5ecb0b15d4449f58434e70eed835cf71fc5527.tar.xz yuzu-af5ecb0b15d4449f58434e70eed835cf71fc5527.zip | |
MemoryManager: use fastmem directly.
Diffstat (limited to '')
| -rw-r--r-- | src/core/memory.cpp | 2 | ||||
| -rw-r--r-- | src/video_core/memory_manager.cpp | 40 | ||||
| -rw-r--r-- | src/video_core/memory_manager.h | 3 |
3 files changed, 34 insertions, 11 deletions
diff --git a/src/core/memory.cpp b/src/core/memory.cpp index 26be74df4..a1e41faff 100644 --- a/src/core/memory.cpp +++ b/src/core/memory.cpp | |||
| @@ -436,7 +436,7 @@ struct Memory::Impl { | |||
| 436 | } | 436 | } |
| 437 | 437 | ||
| 438 | if (Settings::IsFastmemEnabled()) { | 438 | if (Settings::IsFastmemEnabled()) { |
| 439 | const bool is_read_enable = Settings::IsGPULevelHigh() || !cached; | 439 | const bool is_read_enable = !Settings::IsGPULevelExtreme() || !cached; |
| 440 | system.DeviceMemory().buffer.Protect(vaddr, size, is_read_enable, !cached); | 440 | system.DeviceMemory().buffer.Protect(vaddr, size, is_read_enable, !cached); |
| 441 | } | 441 | } |
| 442 | 442 | ||
diff --git a/src/video_core/memory_manager.cpp b/src/video_core/memory_manager.cpp index 83924475b..0a6390054 100644 --- a/src/video_core/memory_manager.cpp +++ b/src/video_core/memory_manager.cpp | |||
| @@ -6,6 +6,7 @@ | |||
| 6 | #include "common/alignment.h" | 6 | #include "common/alignment.h" |
| 7 | #include "common/assert.h" | 7 | #include "common/assert.h" |
| 8 | #include "common/logging/log.h" | 8 | #include "common/logging/log.h" |
| 9 | #include "common/settings.h" | ||
| 9 | #include "core/core.h" | 10 | #include "core/core.h" |
| 10 | #include "core/device_memory.h" | 11 | #include "core/device_memory.h" |
| 11 | #include "core/hle/kernel/k_page_table.h" | 12 | #include "core/hle/kernel/k_page_table.h" |
| @@ -45,6 +46,11 @@ MemoryManager::MemoryManager(Core::System& system_, u64 address_space_bits_, u64 | |||
| 45 | big_page_table_cpu.resize(big_page_table_size); | 46 | big_page_table_cpu.resize(big_page_table_size); |
| 46 | big_page_continous.resize(big_page_table_size / continous_bits, 0); | 47 | big_page_continous.resize(big_page_table_size / continous_bits, 0); |
| 47 | entries.resize(page_table_size / 32, 0); | 48 | entries.resize(page_table_size / 32, 0); |
| 49 | if (!Settings::IsGPULevelExtreme()) { | ||
| 50 | fastmem_arena = system.DeviceMemory().buffer.VirtualBasePointer(); | ||
| 51 | } else { | ||
| 52 | fastmem_arena = nullptr; | ||
| 53 | } | ||
| 48 | } | 54 | } |
| 49 | 55 | ||
| 50 | MemoryManager::~MemoryManager() = default; | 56 | MemoryManager::~MemoryManager() = default; |
| @@ -354,7 +360,7 @@ inline void MemoryManager::MemoryOperation(GPUVAddr gpu_src_addr, std::size_t si | |||
| 354 | } | 360 | } |
| 355 | } | 361 | } |
| 356 | 362 | ||
| 357 | template <bool is_safe> | 363 | template <bool is_safe, bool use_fastmem> |
| 358 | void MemoryManager::ReadBlockImpl(GPUVAddr gpu_src_addr, void* dest_buffer, std::size_t size, | 364 | void MemoryManager::ReadBlockImpl(GPUVAddr gpu_src_addr, void* dest_buffer, std::size_t size, |
| 359 | [[maybe_unused]] VideoCommon::CacheType which) const { | 365 | [[maybe_unused]] VideoCommon::CacheType which) const { |
| 360 | auto set_to_zero = [&]([[maybe_unused]] std::size_t page_index, | 366 | auto set_to_zero = [&]([[maybe_unused]] std::size_t page_index, |
| @@ -368,8 +374,12 @@ void MemoryManager::ReadBlockImpl(GPUVAddr gpu_src_addr, void* dest_buffer, std: | |||
| 368 | if constexpr (is_safe) { | 374 | if constexpr (is_safe) { |
| 369 | rasterizer->FlushRegion(cpu_addr_base, copy_amount, which); | 375 | rasterizer->FlushRegion(cpu_addr_base, copy_amount, which); |
| 370 | } | 376 | } |
| 371 | u8* physical = memory.GetPointer(cpu_addr_base); | 377 | if constexpr (use_fastmem) { |
| 372 | std::memcpy(dest_buffer, physical, copy_amount); | 378 | std::memcpy(dest_buffer, &fastmem_arena[cpu_addr_base], copy_amount); |
| 379 | } else { | ||
| 380 | u8* physical = memory.GetPointer(cpu_addr_base); | ||
| 381 | std::memcpy(dest_buffer, physical, copy_amount); | ||
| 382 | } | ||
| 373 | dest_buffer = static_cast<u8*>(dest_buffer) + copy_amount; | 383 | dest_buffer = static_cast<u8*>(dest_buffer) + copy_amount; |
| 374 | }; | 384 | }; |
| 375 | auto mapped_big = [&](std::size_t page_index, std::size_t offset, std::size_t copy_amount) { | 385 | auto mapped_big = [&](std::size_t page_index, std::size_t offset, std::size_t copy_amount) { |
| @@ -378,11 +388,15 @@ void MemoryManager::ReadBlockImpl(GPUVAddr gpu_src_addr, void* dest_buffer, std: | |||
| 378 | if constexpr (is_safe) { | 388 | if constexpr (is_safe) { |
| 379 | rasterizer->FlushRegion(cpu_addr_base, copy_amount, which); | 389 | rasterizer->FlushRegion(cpu_addr_base, copy_amount, which); |
| 380 | } | 390 | } |
| 381 | if (!IsBigPageContinous(page_index)) [[unlikely]] { | 391 | if constexpr (use_fastmem) { |
| 382 | memory.ReadBlockUnsafe(cpu_addr_base, dest_buffer, copy_amount); | 392 | std::memcpy(dest_buffer, &fastmem_arena[cpu_addr_base], copy_amount); |
| 383 | } else { | 393 | } else { |
| 384 | u8* physical = memory.GetPointer(cpu_addr_base); | 394 | if (!IsBigPageContinous(page_index)) [[unlikely]] { |
| 385 | std::memcpy(dest_buffer, physical, copy_amount); | 395 | memory.ReadBlockUnsafe(cpu_addr_base, dest_buffer, copy_amount); |
| 396 | } else { | ||
| 397 | u8* physical = memory.GetPointer(cpu_addr_base); | ||
| 398 | std::memcpy(dest_buffer, physical, copy_amount); | ||
| 399 | } | ||
| 386 | } | 400 | } |
| 387 | dest_buffer = static_cast<u8*>(dest_buffer) + copy_amount; | 401 | dest_buffer = static_cast<u8*>(dest_buffer) + copy_amount; |
| 388 | }; | 402 | }; |
| @@ -396,12 +410,20 @@ void MemoryManager::ReadBlockImpl(GPUVAddr gpu_src_addr, void* dest_buffer, std: | |||
| 396 | 410 | ||
| 397 | void MemoryManager::ReadBlock(GPUVAddr gpu_src_addr, void* dest_buffer, std::size_t size, | 411 | void MemoryManager::ReadBlock(GPUVAddr gpu_src_addr, void* dest_buffer, std::size_t size, |
| 398 | VideoCommon::CacheType which) const { | 412 | VideoCommon::CacheType which) const { |
| 399 | ReadBlockImpl<true>(gpu_src_addr, dest_buffer, size, which); | 413 | if (fastmem_arena) [[likely]] { |
| 414 | ReadBlockImpl<true, true>(gpu_src_addr, dest_buffer, size, which); | ||
| 415 | return; | ||
| 416 | } | ||
| 417 | ReadBlockImpl<true, false>(gpu_src_addr, dest_buffer, size, which); | ||
| 400 | } | 418 | } |
| 401 | 419 | ||
| 402 | void MemoryManager::ReadBlockUnsafe(GPUVAddr gpu_src_addr, void* dest_buffer, | 420 | void MemoryManager::ReadBlockUnsafe(GPUVAddr gpu_src_addr, void* dest_buffer, |
| 403 | const std::size_t size) const { | 421 | const std::size_t size) const { |
| 404 | ReadBlockImpl<false>(gpu_src_addr, dest_buffer, size, VideoCommon::CacheType::None); | 422 | if (fastmem_arena) [[likely]] { |
| 423 | ReadBlockImpl<false, true>(gpu_src_addr, dest_buffer, size, VideoCommon::CacheType::None); | ||
| 424 | return; | ||
| 425 | } | ||
| 426 | ReadBlockImpl<false, false>(gpu_src_addr, dest_buffer, size, VideoCommon::CacheType::None); | ||
| 405 | } | 427 | } |
| 406 | 428 | ||
| 407 | template <bool is_safe> | 429 | template <bool is_safe> |
diff --git a/src/video_core/memory_manager.h b/src/video_core/memory_manager.h index e6de0d0cb..ff9e3c0b3 100644 --- a/src/video_core/memory_manager.h +++ b/src/video_core/memory_manager.h | |||
| @@ -141,7 +141,7 @@ private: | |||
| 141 | inline void MemoryOperation(GPUVAddr gpu_src_addr, std::size_t size, FuncMapped&& func_mapped, | 141 | inline void MemoryOperation(GPUVAddr gpu_src_addr, std::size_t size, FuncMapped&& func_mapped, |
| 142 | FuncReserved&& func_reserved, FuncUnmapped&& func_unmapped) const; | 142 | FuncReserved&& func_reserved, FuncUnmapped&& func_unmapped) const; |
| 143 | 143 | ||
| 144 | template <bool is_safe> | 144 | template <bool is_safe, bool use_fastmem> |
| 145 | void ReadBlockImpl(GPUVAddr gpu_src_addr, void* dest_buffer, std::size_t size, | 145 | void ReadBlockImpl(GPUVAddr gpu_src_addr, void* dest_buffer, std::size_t size, |
| 146 | VideoCommon::CacheType which) const; | 146 | VideoCommon::CacheType which) const; |
| 147 | 147 | ||
| @@ -215,6 +215,7 @@ private: | |||
| 215 | 215 | ||
| 216 | std::vector<u64> big_page_continous; | 216 | std::vector<u64> big_page_continous; |
| 217 | std::vector<std::pair<VAddr, std::size_t>> page_stash{}; | 217 | std::vector<std::pair<VAddr, std::size_t>> page_stash{}; |
| 218 | u8* fastmem_arena{}; | ||
| 218 | 219 | ||
| 219 | constexpr static size_t continous_bits = 64; | 220 | constexpr static size_t continous_bits = 64; |
| 220 | 221 | ||