diff options
| author | 2020-05-22 21:03:57 -0300 | |
|---|---|---|
| committer | 2020-06-07 04:32:57 -0300 | |
| commit | abcea1bb188cb4db0ee7e27bea26d6458c881c2d (patch) | |
| tree | 80d0ac5c2bb51d321c36c0d46c0f5284f18a3a3a | |
| parent | vk_pipeline_cache: Use generic shader cache (diff) | |
| download | yuzu-abcea1bb188cb4db0ee7e27bea26d6458c881c2d.tar.gz yuzu-abcea1bb188cb4db0ee7e27bea26d6458c881c2d.tar.xz yuzu-abcea1bb188cb4db0ee7e27bea26d6458c881c2d.zip | |
rasterizer_cache: Remove files and includes
The rasterizer cache is no longer used. Each cache has its own generic
implementation optimized for the cached data.
Diffstat (limited to '')
| -rw-r--r-- | src/video_core/CMakeLists.txt | 2 | ||||
| -rw-r--r-- | src/video_core/rasterizer_cache.cpp | 7 | ||||
| -rw-r--r-- | src/video_core/rasterizer_cache.h | 253 | ||||
| -rw-r--r-- | src/video_core/renderer_opengl/gl_buffer_cache.h | 1 | ||||
| -rw-r--r-- | src/video_core/renderer_opengl/gl_rasterizer.h | 1 | ||||
| -rw-r--r-- | src/video_core/renderer_vulkan/vk_buffer_cache.h | 1 | ||||
| -rw-r--r-- | src/video_core/renderer_vulkan/vk_pipeline_cache.cpp | 7 |
7 files changed, 3 insertions, 269 deletions
diff --git a/src/video_core/CMakeLists.txt b/src/video_core/CMakeLists.txt index cf1885f92..39d5d8401 100644 --- a/src/video_core/CMakeLists.txt +++ b/src/video_core/CMakeLists.txt | |||
| @@ -49,8 +49,6 @@ add_library(video_core STATIC | |||
| 49 | query_cache.h | 49 | query_cache.h |
| 50 | rasterizer_accelerated.cpp | 50 | rasterizer_accelerated.cpp |
| 51 | rasterizer_accelerated.h | 51 | rasterizer_accelerated.h |
| 52 | rasterizer_cache.cpp | ||
| 53 | rasterizer_cache.h | ||
| 54 | rasterizer_interface.h | 52 | rasterizer_interface.h |
| 55 | renderer_base.cpp | 53 | renderer_base.cpp |
| 56 | renderer_base.h | 54 | renderer_base.h |
diff --git a/src/video_core/rasterizer_cache.cpp b/src/video_core/rasterizer_cache.cpp deleted file mode 100644 index 093b2cdf4..000000000 --- a/src/video_core/rasterizer_cache.cpp +++ /dev/null | |||
| @@ -1,7 +0,0 @@ | |||
| 1 | // Copyright 2018 yuzu Emulator Project | ||
| 2 | // Licensed under GPLv2 or any later version | ||
| 3 | // Refer to the license.txt file included. | ||
| 4 | |||
| 5 | #include "video_core/rasterizer_cache.h" | ||
| 6 | |||
| 7 | RasterizerCacheObject::~RasterizerCacheObject() = default; | ||
diff --git a/src/video_core/rasterizer_cache.h b/src/video_core/rasterizer_cache.h deleted file mode 100644 index 096ee337c..000000000 --- a/src/video_core/rasterizer_cache.h +++ /dev/null | |||
| @@ -1,253 +0,0 @@ | |||
| 1 | // Copyright 2018 yuzu Emulator Project | ||
| 2 | // Licensed under GPLv2 or any later version | ||
| 3 | // Refer to the license.txt file included. | ||
| 4 | |||
| 5 | #pragma once | ||
| 6 | |||
| 7 | #include <mutex> | ||
| 8 | #include <set> | ||
| 9 | #include <unordered_map> | ||
| 10 | |||
| 11 | #include <boost/icl/interval_map.hpp> | ||
| 12 | #include <boost/range/iterator_range_core.hpp> | ||
| 13 | |||
| 14 | #include "common/common_types.h" | ||
| 15 | #include "core/settings.h" | ||
| 16 | #include "video_core/gpu.h" | ||
| 17 | #include "video_core/rasterizer_interface.h" | ||
| 18 | |||
| 19 | class RasterizerCacheObject { | ||
| 20 | public: | ||
| 21 | explicit RasterizerCacheObject(const VAddr cpu_addr) : cpu_addr{cpu_addr} {} | ||
| 22 | |||
| 23 | virtual ~RasterizerCacheObject(); | ||
| 24 | |||
| 25 | VAddr GetCpuAddr() const { | ||
| 26 | return cpu_addr; | ||
| 27 | } | ||
| 28 | |||
| 29 | /// Gets the size of the shader in guest memory, required for cache management | ||
| 30 | virtual std::size_t GetSizeInBytes() const = 0; | ||
| 31 | |||
| 32 | /// Sets whether the cached object should be considered registered | ||
| 33 | void SetIsRegistered(bool registered) { | ||
| 34 | is_registered = registered; | ||
| 35 | } | ||
| 36 | |||
| 37 | /// Returns true if the cached object is registered | ||
| 38 | bool IsRegistered() const { | ||
| 39 | return is_registered; | ||
| 40 | } | ||
| 41 | |||
| 42 | /// Returns true if the cached object is dirty | ||
| 43 | bool IsDirty() const { | ||
| 44 | return is_dirty; | ||
| 45 | } | ||
| 46 | |||
| 47 | /// Returns ticks from when this cached object was last modified | ||
| 48 | u64 GetLastModifiedTicks() const { | ||
| 49 | return last_modified_ticks; | ||
| 50 | } | ||
| 51 | |||
| 52 | /// Marks an object as recently modified, used to specify whether it is clean or dirty | ||
| 53 | template <class T> | ||
| 54 | void MarkAsModified(bool dirty, T& cache) { | ||
| 55 | is_dirty = dirty; | ||
| 56 | last_modified_ticks = cache.GetModifiedTicks(); | ||
| 57 | } | ||
| 58 | |||
| 59 | void SetMemoryMarked(bool is_memory_marked_) { | ||
| 60 | is_memory_marked = is_memory_marked_; | ||
| 61 | } | ||
| 62 | |||
| 63 | bool IsMemoryMarked() const { | ||
| 64 | return is_memory_marked; | ||
| 65 | } | ||
| 66 | |||
| 67 | void SetSyncPending(bool is_sync_pending_) { | ||
| 68 | is_sync_pending = is_sync_pending_; | ||
| 69 | } | ||
| 70 | |||
| 71 | bool IsSyncPending() const { | ||
| 72 | return is_sync_pending; | ||
| 73 | } | ||
| 74 | |||
| 75 | private: | ||
| 76 | bool is_registered{}; ///< Whether the object is currently registered with the cache | ||
| 77 | bool is_dirty{}; ///< Whether the object is dirty (out of sync with guest memory) | ||
| 78 | bool is_memory_marked{}; ///< Whether the object is marking rasterizer memory. | ||
| 79 | bool is_sync_pending{}; ///< Whether the object is pending deletion. | ||
| 80 | u64 last_modified_ticks{}; ///< When the object was last modified, used for in-order flushing | ||
| 81 | VAddr cpu_addr{}; ///< Cpu address memory, unique from emulated virtual address space | ||
| 82 | }; | ||
| 83 | |||
| 84 | template <class T> | ||
| 85 | class RasterizerCache : NonCopyable { | ||
| 86 | friend class RasterizerCacheObject; | ||
| 87 | |||
| 88 | public: | ||
| 89 | explicit RasterizerCache(VideoCore::RasterizerInterface& rasterizer) : rasterizer{rasterizer} {} | ||
| 90 | |||
| 91 | /// Write any cached resources overlapping the specified region back to memory | ||
| 92 | void FlushRegion(VAddr addr, std::size_t size) { | ||
| 93 | std::lock_guard lock{mutex}; | ||
| 94 | |||
| 95 | const auto& objects{GetSortedObjectsFromRegion(addr, size)}; | ||
| 96 | for (auto& object : objects) { | ||
| 97 | FlushObject(object); | ||
| 98 | } | ||
| 99 | } | ||
| 100 | |||
| 101 | /// Mark the specified region as being invalidated | ||
| 102 | void InvalidateRegion(VAddr addr, u64 size) { | ||
| 103 | std::lock_guard lock{mutex}; | ||
| 104 | |||
| 105 | const auto& objects{GetSortedObjectsFromRegion(addr, size)}; | ||
| 106 | for (auto& object : objects) { | ||
| 107 | if (!object->IsRegistered()) { | ||
| 108 | // Skip duplicates | ||
| 109 | continue; | ||
| 110 | } | ||
| 111 | Unregister(object); | ||
| 112 | } | ||
| 113 | } | ||
| 114 | |||
| 115 | void OnCPUWrite(VAddr addr, std::size_t size) { | ||
| 116 | std::lock_guard lock{mutex}; | ||
| 117 | |||
| 118 | for (const auto& object : GetSortedObjectsFromRegion(addr, size)) { | ||
| 119 | if (object->IsRegistered()) { | ||
| 120 | UnmarkMemory(object); | ||
| 121 | object->SetSyncPending(true); | ||
| 122 | marked_for_unregister.emplace_back(object); | ||
| 123 | } | ||
| 124 | } | ||
| 125 | } | ||
| 126 | |||
| 127 | void SyncGuestHost() { | ||
| 128 | std::lock_guard lock{mutex}; | ||
| 129 | |||
| 130 | for (const auto& object : marked_for_unregister) { | ||
| 131 | if (object->IsRegistered()) { | ||
| 132 | object->SetSyncPending(false); | ||
| 133 | Unregister(object); | ||
| 134 | } | ||
| 135 | } | ||
| 136 | marked_for_unregister.clear(); | ||
| 137 | } | ||
| 138 | |||
| 139 | /// Invalidates everything in the cache | ||
| 140 | void InvalidateAll() { | ||
| 141 | std::lock_guard lock{mutex}; | ||
| 142 | |||
| 143 | while (interval_cache.begin() != interval_cache.end()) { | ||
| 144 | Unregister(*interval_cache.begin()->second.begin()); | ||
| 145 | } | ||
| 146 | } | ||
| 147 | |||
| 148 | protected: | ||
| 149 | /// Tries to get an object from the cache with the specified cache address | ||
| 150 | T TryGet(VAddr addr) const { | ||
| 151 | const auto iter = map_cache.find(addr); | ||
| 152 | if (iter != map_cache.end()) | ||
| 153 | return iter->second; | ||
| 154 | return nullptr; | ||
| 155 | } | ||
| 156 | |||
| 157 | /// Register an object into the cache | ||
| 158 | virtual void Register(const T& object) { | ||
| 159 | std::lock_guard lock{mutex}; | ||
| 160 | |||
| 161 | object->SetIsRegistered(true); | ||
| 162 | interval_cache.add({GetInterval(object), ObjectSet{object}}); | ||
| 163 | map_cache.insert({object->GetCpuAddr(), object}); | ||
| 164 | rasterizer.UpdatePagesCachedCount(object->GetCpuAddr(), object->GetSizeInBytes(), 1); | ||
| 165 | object->SetMemoryMarked(true); | ||
| 166 | } | ||
| 167 | |||
| 168 | /// Unregisters an object from the cache | ||
| 169 | virtual void Unregister(const T& object) { | ||
| 170 | std::lock_guard lock{mutex}; | ||
| 171 | |||
| 172 | UnmarkMemory(object); | ||
| 173 | object->SetIsRegistered(false); | ||
| 174 | if (object->IsSyncPending()) { | ||
| 175 | marked_for_unregister.remove(object); | ||
| 176 | object->SetSyncPending(false); | ||
| 177 | } | ||
| 178 | const VAddr addr = object->GetCpuAddr(); | ||
| 179 | interval_cache.subtract({GetInterval(object), ObjectSet{object}}); | ||
| 180 | map_cache.erase(addr); | ||
| 181 | } | ||
| 182 | |||
| 183 | void UnmarkMemory(const T& object) { | ||
| 184 | if (!object->IsMemoryMarked()) { | ||
| 185 | return; | ||
| 186 | } | ||
| 187 | rasterizer.UpdatePagesCachedCount(object->GetCpuAddr(), object->GetSizeInBytes(), -1); | ||
| 188 | object->SetMemoryMarked(false); | ||
| 189 | } | ||
| 190 | |||
| 191 | /// Returns a ticks counter used for tracking when cached objects were last modified | ||
| 192 | u64 GetModifiedTicks() { | ||
| 193 | std::lock_guard lock{mutex}; | ||
| 194 | |||
| 195 | return ++modified_ticks; | ||
| 196 | } | ||
| 197 | |||
| 198 | virtual void FlushObjectInner(const T& object) = 0; | ||
| 199 | |||
| 200 | /// Flushes the specified object, updating appropriate cache state as needed | ||
| 201 | void FlushObject(const T& object) { | ||
| 202 | std::lock_guard lock{mutex}; | ||
| 203 | |||
| 204 | if (!object->IsDirty()) { | ||
| 205 | return; | ||
| 206 | } | ||
| 207 | FlushObjectInner(object); | ||
| 208 | object->MarkAsModified(false, *this); | ||
| 209 | } | ||
| 210 | |||
| 211 | std::recursive_mutex mutex; | ||
| 212 | |||
| 213 | private: | ||
| 214 | /// Returns a list of cached objects from the specified memory region, ordered by access time | ||
| 215 | std::vector<T> GetSortedObjectsFromRegion(VAddr addr, u64 size) { | ||
| 216 | if (size == 0) { | ||
| 217 | return {}; | ||
| 218 | } | ||
| 219 | |||
| 220 | std::vector<T> objects; | ||
| 221 | const ObjectInterval interval{addr, addr + size}; | ||
| 222 | for (auto& pair : boost::make_iterator_range(interval_cache.equal_range(interval))) { | ||
| 223 | for (auto& cached_object : pair.second) { | ||
| 224 | if (!cached_object) { | ||
| 225 | continue; | ||
| 226 | } | ||
| 227 | objects.push_back(cached_object); | ||
| 228 | } | ||
| 229 | } | ||
| 230 | |||
| 231 | std::sort(objects.begin(), objects.end(), [](const T& a, const T& b) -> bool { | ||
| 232 | return a->GetLastModifiedTicks() < b->GetLastModifiedTicks(); | ||
| 233 | }); | ||
| 234 | |||
| 235 | return objects; | ||
| 236 | } | ||
| 237 | |||
| 238 | using ObjectSet = std::set<T>; | ||
| 239 | using ObjectCache = std::unordered_map<VAddr, T>; | ||
| 240 | using IntervalCache = boost::icl::interval_map<VAddr, ObjectSet>; | ||
| 241 | using ObjectInterval = typename IntervalCache::interval_type; | ||
| 242 | |||
| 243 | static auto GetInterval(const T& object) { | ||
| 244 | return ObjectInterval::right_open(object->GetCpuAddr(), | ||
| 245 | object->GetCpuAddr() + object->GetSizeInBytes()); | ||
| 246 | } | ||
| 247 | |||
| 248 | ObjectCache map_cache; | ||
| 249 | IntervalCache interval_cache; ///< Cache of objects | ||
| 250 | u64 modified_ticks{}; ///< Counter of cache state ticks, used for in-order flushing | ||
| 251 | VideoCore::RasterizerInterface& rasterizer; | ||
| 252 | std::list<T> marked_for_unregister; | ||
| 253 | }; | ||
diff --git a/src/video_core/renderer_opengl/gl_buffer_cache.h b/src/video_core/renderer_opengl/gl_buffer_cache.h index a9e86cfc7..679b9b1d7 100644 --- a/src/video_core/renderer_opengl/gl_buffer_cache.h +++ b/src/video_core/renderer_opengl/gl_buffer_cache.h | |||
| @@ -10,7 +10,6 @@ | |||
| 10 | #include "common/common_types.h" | 10 | #include "common/common_types.h" |
| 11 | #include "video_core/buffer_cache/buffer_cache.h" | 11 | #include "video_core/buffer_cache/buffer_cache.h" |
| 12 | #include "video_core/engines/maxwell_3d.h" | 12 | #include "video_core/engines/maxwell_3d.h" |
| 13 | #include "video_core/rasterizer_cache.h" | ||
| 14 | #include "video_core/renderer_opengl/gl_resource_manager.h" | 13 | #include "video_core/renderer_opengl/gl_resource_manager.h" |
| 15 | #include "video_core/renderer_opengl/gl_stream_buffer.h" | 14 | #include "video_core/renderer_opengl/gl_stream_buffer.h" |
| 16 | 15 | ||
diff --git a/src/video_core/renderer_opengl/gl_rasterizer.h b/src/video_core/renderer_opengl/gl_rasterizer.h index 1f8d45eac..208a4485b 100644 --- a/src/video_core/renderer_opengl/gl_rasterizer.h +++ b/src/video_core/renderer_opengl/gl_rasterizer.h | |||
| @@ -19,7 +19,6 @@ | |||
| 19 | #include "video_core/engines/const_buffer_info.h" | 19 | #include "video_core/engines/const_buffer_info.h" |
| 20 | #include "video_core/engines/maxwell_3d.h" | 20 | #include "video_core/engines/maxwell_3d.h" |
| 21 | #include "video_core/rasterizer_accelerated.h" | 21 | #include "video_core/rasterizer_accelerated.h" |
| 22 | #include "video_core/rasterizer_cache.h" | ||
| 23 | #include "video_core/rasterizer_interface.h" | 22 | #include "video_core/rasterizer_interface.h" |
| 24 | #include "video_core/renderer_opengl/gl_buffer_cache.h" | 23 | #include "video_core/renderer_opengl/gl_buffer_cache.h" |
| 25 | #include "video_core/renderer_opengl/gl_device.h" | 24 | #include "video_core/renderer_opengl/gl_device.h" |
diff --git a/src/video_core/renderer_vulkan/vk_buffer_cache.h b/src/video_core/renderer_vulkan/vk_buffer_cache.h index a54583e7d..65cb3c8ad 100644 --- a/src/video_core/renderer_vulkan/vk_buffer_cache.h +++ b/src/video_core/renderer_vulkan/vk_buffer_cache.h | |||
| @@ -8,7 +8,6 @@ | |||
| 8 | 8 | ||
| 9 | #include "common/common_types.h" | 9 | #include "common/common_types.h" |
| 10 | #include "video_core/buffer_cache/buffer_cache.h" | 10 | #include "video_core/buffer_cache/buffer_cache.h" |
| 11 | #include "video_core/rasterizer_cache.h" | ||
| 12 | #include "video_core/renderer_vulkan/vk_memory_manager.h" | 11 | #include "video_core/renderer_vulkan/vk_memory_manager.h" |
| 13 | #include "video_core/renderer_vulkan/vk_staging_buffer_pool.h" | 12 | #include "video_core/renderer_vulkan/vk_staging_buffer_pool.h" |
| 14 | #include "video_core/renderer_vulkan/vk_stream_buffer.h" | 13 | #include "video_core/renderer_vulkan/vk_stream_buffer.h" |
diff --git a/src/video_core/renderer_vulkan/vk_pipeline_cache.cpp b/src/video_core/renderer_vulkan/vk_pipeline_cache.cpp index 20cbeb671..150d86b62 100644 --- a/src/video_core/renderer_vulkan/vk_pipeline_cache.cpp +++ b/src/video_core/renderer_vulkan/vk_pipeline_cache.cpp | |||
| @@ -335,12 +335,11 @@ VKPipelineCache::DecompileShaders(const GraphicsPipelineCacheKey& key) { | |||
| 335 | } | 335 | } |
| 336 | 336 | ||
| 337 | const GPUVAddr gpu_addr = GetShaderAddress(system, program_enum); | 337 | const GPUVAddr gpu_addr = GetShaderAddress(system, program_enum); |
| 338 | const auto cpu_addr = memory_manager.GpuToCpuAddress(gpu_addr); | 338 | const std::optional<VAddr> cpu_addr = memory_manager.GpuToCpuAddress(gpu_addr); |
| 339 | const auto shader = cpu_addr ? TryGet(*cpu_addr) : null_shader; | 339 | Shader* const shader = cpu_addr ? TryGet(*cpu_addr) : null_shader.get(); |
| 340 | ASSERT(shader); | ||
| 341 | 340 | ||
| 342 | const std::size_t stage = index == 0 ? 0 : index - 1; // Stage indices are 0 - 5 | 341 | const std::size_t stage = index == 0 ? 0 : index - 1; // Stage indices are 0 - 5 |
| 343 | const auto program_type = GetShaderType(program_enum); | 342 | const ShaderType program_type = GetShaderType(program_enum); |
| 344 | const auto& entries = shader->GetEntries(); | 343 | const auto& entries = shader->GetEntries(); |
| 345 | program[stage] = { | 344 | program[stage] = { |
| 346 | Decompile(device, shader->GetIR(), program_type, shader->GetRegistry(), specialization), | 345 | Decompile(device, shader->GetIR(), program_type, shader->GetRegistry(), specialization), |