summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGravatar Lioncash2019-03-22 11:08:04 -0400
committerGravatar Lioncash2019-03-22 14:43:41 -0400
commit733cf179b84a098955f0b7296d90da0aac3ddf7b (patch)
treeac956d572471abb004afe7833a9052839727fef3
parentfile_sys/cheat_engine: Remove use of global system accessors (diff)
downloadyuzu-733cf179b84a098955f0b7296d90da0aac3ddf7b.tar.gz
yuzu-733cf179b84a098955f0b7296d90da0aac3ddf7b.tar.xz
yuzu-733cf179b84a098955f0b7296d90da0aac3ddf7b.zip
file_sys/cheat_engine: Silence truncation and sign-conversion warnings
Diffstat (limited to '')
-rw-r--r--src/core/file_sys/cheat_engine.cpp9
-rw-r--r--src/core/file_sys/cheat_engine.h2
2 files changed, 6 insertions, 5 deletions
diff --git a/src/core/file_sys/cheat_engine.cpp b/src/core/file_sys/cheat_engine.cpp
index 1cbdc6020..247fbc864 100644
--- a/src/core/file_sys/cheat_engine.cpp
+++ b/src/core/file_sys/cheat_engine.cpp
@@ -17,7 +17,7 @@
17 17
18namespace FileSys { 18namespace FileSys {
19 19
20constexpr u64 CHEAT_ENGINE_TICKS = Core::Timing::BASE_CLOCK_RATE / 60; 20constexpr s64 CHEAT_ENGINE_TICKS = static_cast<s64>(Core::Timing::BASE_CLOCK_RATE / 60);
21constexpr u32 KEYPAD_BITMASK = 0x3FFFFFF; 21constexpr u32 KEYPAD_BITMASK = 0x3FFFFFF;
22 22
23u64 Cheat::Address() const { 23u64 Cheat::Address() const {
@@ -185,8 +185,9 @@ void CheatList::Loop(const Cheat& cheat) {
185 ASSERT(iter != block_pairs.end()); 185 ASSERT(iter != block_pairs.end());
186 ASSERT(iter->first < iter->second); 186 ASSERT(iter->first < iter->second);
187 187
188 for (int i = cheat.Value(4, 4); i >= 0; --i) { 188 const s32 initial_value = static_cast<s32>(cheat.Value(4, sizeof(s32)));
189 register_3 = i; 189 for (s32 i = initial_value; i >= 0; --i) {
190 register_3 = static_cast<u64>(i);
190 for (std::size_t c = iter->first + 1; c < iter->second; ++c) { 191 for (std::size_t c = iter->first + 1; c < iter->second; ++c) {
191 current_index = c; 192 current_index = c;
192 ExecuteSingleCheat( 193 ExecuteSingleCheat(
@@ -478,7 +479,7 @@ CheatEngine::~CheatEngine() {
478 core_timing.UnscheduleEvent(event, 0); 479 core_timing.UnscheduleEvent(event, 0);
479} 480}
480 481
481void CheatEngine::FrameCallback(u64 userdata, int cycles_late) { 482void CheatEngine::FrameCallback(u64 userdata, s64 cycles_late) {
482 for (auto& list : cheats) { 483 for (auto& list : cheats) {
483 list.Execute(); 484 list.Execute();
484 } 485 }
diff --git a/src/core/file_sys/cheat_engine.h b/src/core/file_sys/cheat_engine.h
index c2de3198c..ac22a82cb 100644
--- a/src/core/file_sys/cheat_engine.h
+++ b/src/core/file_sys/cheat_engine.h
@@ -223,7 +223,7 @@ public:
223 ~CheatEngine(); 223 ~CheatEngine();
224 224
225private: 225private:
226 void FrameCallback(u64 userdata, int cycles_late); 226 void FrameCallback(u64 userdata, s64 cycles_late);
227 227
228 std::vector<CheatList> cheats; 228 std::vector<CheatList> cheats;
229 229