diff options
| author | 2022-06-01 02:27:48 -0400 | |
|---|---|---|
| committer | 2022-06-01 02:28:34 -0400 | |
| commit | 69511aed3d66db89bcc4db286649d06f96e622e8 (patch) | |
| tree | dc708a09194d6a2ed9c362a283360b8c1c2fee10 | |
| parent | Merge pull request #8394 from liamwhite/debugger (diff) | |
| download | yuzu-69511aed3d66db89bcc4db286649d06f96e622e8.tar.gz yuzu-69511aed3d66db89bcc4db286649d06f96e622e8.tar.xz yuzu-69511aed3d66db89bcc4db286649d06f96e622e8.zip | |
core/debugger: Define defaulted virtual destructors
Resolves an MSVC warning where a virtual destructor is not defined in the base class with virtual functions.
Diffstat (limited to '')
| -rw-r--r-- | src/core/debugger/debugger.cpp | 2 | ||||
| -rw-r--r-- | src/core/debugger/debugger_interface.h | 4 | ||||
| -rw-r--r-- | src/core/debugger/gdbstub.h | 2 |
3 files changed, 6 insertions, 2 deletions
diff --git a/src/core/debugger/debugger.cpp b/src/core/debugger/debugger.cpp index 7a2012d3c..dd3e330e6 100644 --- a/src/core/debugger/debugger.cpp +++ b/src/core/debugger/debugger.cpp | |||
| @@ -50,7 +50,7 @@ public: | |||
| 50 | InitializeServer(port); | 50 | InitializeServer(port); |
| 51 | } | 51 | } |
| 52 | 52 | ||
| 53 | ~DebuggerImpl() { | 53 | ~DebuggerImpl() override { |
| 54 | ShutdownServer(); | 54 | ShutdownServer(); |
| 55 | } | 55 | } |
| 56 | 56 | ||
diff --git a/src/core/debugger/debugger_interface.h b/src/core/debugger/debugger_interface.h index 0b357fcb5..e6d4c0190 100644 --- a/src/core/debugger/debugger_interface.h +++ b/src/core/debugger/debugger_interface.h | |||
| @@ -24,6 +24,8 @@ enum class DebuggerAction { | |||
| 24 | 24 | ||
| 25 | class DebuggerBackend { | 25 | class DebuggerBackend { |
| 26 | public: | 26 | public: |
| 27 | virtual ~DebuggerBackend() = default; | ||
| 28 | |||
| 27 | /** | 29 | /** |
| 28 | * Can be invoked from a callback to synchronously wait for more data. | 30 | * Can be invoked from a callback to synchronously wait for more data. |
| 29 | * Will return as soon as least one byte is received. Reads up to 4096 bytes. | 31 | * Will return as soon as least one byte is received. Reads up to 4096 bytes. |
| @@ -51,6 +53,8 @@ class DebuggerFrontend { | |||
| 51 | public: | 53 | public: |
| 52 | explicit DebuggerFrontend(DebuggerBackend& backend_) : backend{backend_} {} | 54 | explicit DebuggerFrontend(DebuggerBackend& backend_) : backend{backend_} {} |
| 53 | 55 | ||
| 56 | virtual ~DebuggerFrontend() = default; | ||
| 57 | |||
| 54 | /** | 58 | /** |
| 55 | * Called after the client has successfully connected to the port. | 59 | * Called after the client has successfully connected to the port. |
| 56 | */ | 60 | */ |
diff --git a/src/core/debugger/gdbstub.h b/src/core/debugger/gdbstub.h index b93a3a511..e58d60719 100644 --- a/src/core/debugger/gdbstub.h +++ b/src/core/debugger/gdbstub.h | |||
| @@ -19,7 +19,7 @@ class System; | |||
| 19 | class GDBStub : public DebuggerFrontend { | 19 | class GDBStub : public DebuggerFrontend { |
| 20 | public: | 20 | public: |
| 21 | explicit GDBStub(DebuggerBackend& backend, Core::System& system); | 21 | explicit GDBStub(DebuggerBackend& backend, Core::System& system); |
| 22 | ~GDBStub(); | 22 | ~GDBStub() override; |
| 23 | 23 | ||
| 24 | void Connected() override; | 24 | void Connected() override; |
| 25 | void Stopped(Kernel::KThread* thread) override; | 25 | void Stopped(Kernel::KThread* thread) override; |