diff options
| author | 2023-07-01 15:19:31 +0300 | |
|---|---|---|
| committer | 2023-07-01 16:03:35 +0300 | |
| commit | 272916eeaf91f2430104b5454d765f762aa22cdc (patch) | |
| tree | fa10f02646c4078b7256e738790f2238eeba5609 | |
| parent | renderer_vulkan: Add support for VK_KHR_image_format_list (diff) | |
| download | yuzu-272916eeaf91f2430104b5454d765f762aa22cdc.tar.gz yuzu-272916eeaf91f2430104b5454d765f762aa22cdc.tar.xz yuzu-272916eeaf91f2430104b5454d765f762aa22cdc.zip | |
renderer_vulkan: Fix some missing view formats
* Many times the format itself wouldn't have been added to the list causing device losses for nvidia GPUs
* Also account for ASTC acceleration storage views
Diffstat (limited to '')
| -rw-r--r-- | src/video_core/compatible_formats.cpp | 6 | ||||
| -rw-r--r-- | src/video_core/renderer_vulkan/vk_texture_cache.cpp | 5 |
2 files changed, 8 insertions, 3 deletions
diff --git a/src/video_core/compatible_formats.cpp b/src/video_core/compatible_formats.cpp index ab4f4d407..87d69ebc5 100644 --- a/src/video_core/compatible_formats.cpp +++ b/src/video_core/compatible_formats.cpp | |||
| @@ -272,6 +272,9 @@ constexpr Table MakeNonNativeBgrCopyTable() { | |||
| 272 | 272 | ||
| 273 | bool IsViewCompatible(PixelFormat format_a, PixelFormat format_b, bool broken_views, | 273 | bool IsViewCompatible(PixelFormat format_a, PixelFormat format_b, bool broken_views, |
| 274 | bool native_bgr) { | 274 | bool native_bgr) { |
| 275 | if (format_a == format_b) { | ||
| 276 | return true; | ||
| 277 | } | ||
| 275 | if (broken_views) { | 278 | if (broken_views) { |
| 276 | // If format views are broken, only accept formats that are identical. | 279 | // If format views are broken, only accept formats that are identical. |
| 277 | return format_a == format_b; | 280 | return format_a == format_b; |
| @@ -282,6 +285,9 @@ bool IsViewCompatible(PixelFormat format_a, PixelFormat format_b, bool broken_vi | |||
| 282 | } | 285 | } |
| 283 | 286 | ||
| 284 | bool IsCopyCompatible(PixelFormat format_a, PixelFormat format_b, bool native_bgr) { | 287 | bool IsCopyCompatible(PixelFormat format_a, PixelFormat format_b, bool native_bgr) { |
| 288 | if (format_a == format_b) { | ||
| 289 | return true; | ||
| 290 | } | ||
| 285 | static constexpr Table BGR_TABLE = MakeNativeBgrCopyTable(); | 291 | static constexpr Table BGR_TABLE = MakeNativeBgrCopyTable(); |
| 286 | static constexpr Table NO_BGR_TABLE = MakeNonNativeBgrCopyTable(); | 292 | static constexpr Table NO_BGR_TABLE = MakeNonNativeBgrCopyTable(); |
| 287 | return IsSupported(native_bgr ? BGR_TABLE : NO_BGR_TABLE, format_a, format_b); | 293 | return IsSupported(native_bgr ? BGR_TABLE : NO_BGR_TABLE, format_a, format_b); |
diff --git a/src/video_core/renderer_vulkan/vk_texture_cache.cpp b/src/video_core/renderer_vulkan/vk_texture_cache.cpp index f1b696e01..3aac3cfab 100644 --- a/src/video_core/renderer_vulkan/vk_texture_cache.cpp +++ b/src/video_core/renderer_vulkan/vk_texture_cache.cpp | |||
| @@ -826,9 +826,8 @@ TextureCacheRuntime::TextureCacheRuntime(const Device& device_, Scheduler& sched | |||
| 826 | } | 826 | } |
| 827 | for (size_t index_a = 0; index_a < VideoCore::Surface::MaxPixelFormat; index_a++) { | 827 | for (size_t index_a = 0; index_a < VideoCore::Surface::MaxPixelFormat; index_a++) { |
| 828 | const auto image_format = static_cast<PixelFormat>(index_a); | 828 | const auto image_format = static_cast<PixelFormat>(index_a); |
| 829 | const auto type_a = VideoCore::Surface::GetFormatType(image_format); | 829 | if (IsPixelFormatASTC(image_format) && !device.IsOptimalAstcSupported()) { |
| 830 | if (type_a != SurfaceType::ColorTexture) { | 830 | view_formats[index_a].push_back(VK_FORMAT_A8B8G8R8_UNORM_PACK32); |
| 831 | continue; | ||
| 832 | } | 831 | } |
| 833 | for (size_t index_b = 0; index_b < VideoCore::Surface::MaxPixelFormat; index_b++) { | 832 | for (size_t index_b = 0; index_b < VideoCore::Surface::MaxPixelFormat; index_b++) { |
| 834 | const auto view_format = static_cast<PixelFormat>(index_b); | 833 | const auto view_format = static_cast<PixelFormat>(index_b); |