1 files changed, 19 insertions, 6 deletions

diff --git a/activitypub.c b/activitypub.c
index 1efd9ec..4ed2805 100644
--- a/activitypub.c
+++ b/activitypub.c
@@ -17,25 +17,25 @@
 
 #include <sys/wait.h>
 
-const char *public_address = "https:/" "/www.w3.org/ns/activitystreams#Public";
+const char * const public_address = "https:/" "/www.w3.org/ns/activitystreams#Public";
 
 /* susie.png */
 
-const char *susie =
+const char * const susie =
     "iVBORw0KGgoAAAANSUhEUgAAAEAAAABAAQAAAAC"
     "CEkxzAAAAUUlEQVQoz43R0QkAMQwCUDdw/y3dwE"
     "vsvzlL4X1IoQkAisKmwfAFT3RgJHbQezpSRoXEq"
     "eqCL9BJBf7h3QbOCCxV5EVWMEMwG7K1/WODtlvx"
     "AYTtEsDU9F34AAAAAElFTkSuQmCC";
 
-const char *susie_cool =
+const char * const susie_cool =
     "iVBORw0KGgoAAAANSUhEUgAAAEAAAABAAQAAAAC"
     "CEkxzAAAAV0lEQVQoz43RwQ3AMAwCQDZg/y3ZgN"
     "qo3+JaedwDOUQBQFHYaTB8wTM6sGl2cMPu+DFzn"
     "+ZcgN7wF7ZVihXkfSlWIVzIA6dbQzaygllpNuTX"
     "ZmmFNlvxADX1+o0cUPMbAAAAAElFTkSuQmCC";
 
-const char *susie_muertos =
+const char * const susie_muertos =
     "iVBORw0KGgoAAAANSUhEUgAAAEAAAABAAQAAAAC"
     "CEkxzAAAAV0lEQVQoz4XQsQ0AMQxCUW/A/lv+DT"
     "ic6zGRolekIMyMELNp8PiCEw6Q4w4NoAt53IH5m"
@@ -3101,6 +3101,11 @@ void process_user_queue_item(snac *user, xs_dict *q_item)
         const char *actor = xs_dict_get(q_item, "actor");
         double mtime = object_mtime(actor);
 
+        if (actor_failure(actor, 0) == -1) {
+            /* actor is broken beyond repair */
+            snac_debug(user, 1, xs_fmt("actor_refresh skipped broken actor %s", actor));
+        }
+        else
         /* only refresh if it was refreshed more than an hour ago */
         if (mtime + 3600.0 < (double) time(NULL)) {
             xs *actor_o = NULL;
@@ -3108,8 +3113,16 @@ void process_user_queue_item(snac *user, xs_dict *q_item)
 
             if (valid_status((status = activitypub_request(user, actor, &actor_o))))
                 actor_add(actor, actor_o);
-            else
-                object_touch(actor);
+            else {
+                if (status == HTTP_STATUS_GONE) {
+                    actor_failure(actor, 1);
+                    snac_log(user, xs_fmt("actor_refresh marking actor %s as broken %d", actor, status));
+                }
+                else {
+                    actor_failure(actor, 2);
+                    object_touch(actor);
+                }
+            }
 
             snac_log(user, xs_fmt("actor_refresh %s %d", actor, status));
         }