From b4aaff683d78ab92b83f3a7257c33b8e27d1affa Mon Sep 17 00:00:00 2001 From: Thog Date: Tue, 7 Mar 2017 21:24:39 +0100 Subject: Drop unix case style and implement hashCode when equals is overrided Also update Guava to version 21 --- .../cuchaz/enigma/convert/MappingsConverter.java | 53 +++++++++------------- 1 file changed, 22 insertions(+), 31 deletions(-) (limited to 'src/main/java/cuchaz/enigma/convert/MappingsConverter.java') diff --git a/src/main/java/cuchaz/enigma/convert/MappingsConverter.java b/src/main/java/cuchaz/enigma/convert/MappingsConverter.java index 929c89f..a5ded67 100644 --- a/src/main/java/cuchaz/enigma/convert/MappingsConverter.java +++ b/src/main/java/cuchaz/enigma/convert/MappingsConverter.java @@ -11,7 +11,6 @@ package cuchaz.enigma.convert; import com.google.common.collect.*; -import cuchaz.enigma.Constants; import cuchaz.enigma.Deobfuscator; import cuchaz.enigma.TranslatingTypeLoader; import cuchaz.enigma.analysis.JarIndex; @@ -24,7 +23,6 @@ import javassist.NotFoundException; import javassist.bytecode.BadBytecode; import javassist.bytecode.CodeAttribute; import javassist.bytecode.CodeIterator; -import javassist.bytecode.MethodInfo; import java.util.*; import java.util.jar.JarFile; @@ -174,15 +172,13 @@ public class MappingsConverter { private static ClassMapping migrateClassMapping(ClassEntry newObfClass, ClassMapping oldClassMapping, final ClassMatches matches, boolean useSimpleName) { - ClassNameReplacer replacer = new ClassNameReplacer() { - @Override - public String replace(String className) { - ClassEntry newClassEntry = matches.getUniqueMatches().get(new ClassEntry(className)); - if (newClassEntry != null) { - return newClassEntry.getName(); - } - return null; + ClassNameReplacer replacer = className -> + { + ClassEntry newClassEntry = matches.getUniqueMatches().get(new ClassEntry(className)); + if (newClassEntry != null) { + return newClassEntry.getName(); } + return null; }; ClassMapping newClassMapping; @@ -434,13 +430,12 @@ public class MappingsConverter { // Empty method body, ignore! if (sourceAttribute == null) return null; - Iterator it = obfDestEntries.iterator(); - while (it.hasNext()) + for (BehaviorEntry desEntry : obfDestEntries) { - BehaviorEntry desEntry = it.next(); try { - CtMethod destCtClassMethod = destCtClass.getMethod(desEntry.getName(), desEntry.getSignature().toString()); + CtMethod destCtClassMethod = destCtClass + .getMethod(desEntry.getName(), desEntry.getSignature().toString()); CodeAttribute destAttribute = destCtClassMethod.getMethodInfo().getCodeAttribute(); // Ignore empty body methods @@ -533,7 +528,7 @@ public class MappingsConverter { public static MemberMatches computeMemberMatches(Deobfuscator destDeobfuscator, Mappings destMappings, ClassMatches classMatches, Doer doer) { - MemberMatches memberMatches = new MemberMatches(); + MemberMatches memberMatches = new MemberMatches<>(); // unmatched source fields are easy MappingsChecker checker = new MappingsChecker(destDeobfuscator.getJarIndex()); @@ -624,15 +619,13 @@ public class MappingsConverter { } private static Type translate(Type type, final BiMap map) { - return new Type(type, new ClassNameReplacer() { - @Override - public String replace(String inClassName) { - ClassEntry outClassEntry = map.get(new ClassEntry(inClassName)); - if (outClassEntry == null) { - return null; - } - return outClassEntry.getName(); + return new Type(type, inClassName -> + { + ClassEntry outClassEntry = map.get(new ClassEntry(inClassName)); + if (outClassEntry == null) { + return null; } + return outClassEntry.getName(); }); } @@ -640,15 +633,13 @@ public class MappingsConverter { if (signature == null) { return null; } - return new Signature(signature, new ClassNameReplacer() { - @Override - public String replace(String inClassName) { - ClassEntry outClassEntry = map.get(new ClassEntry(inClassName)); - if (outClassEntry == null) { - return null; - } - return outClassEntry.getName(); + return new Signature(signature, inClassName -> + { + ClassEntry outClassEntry = map.get(new ClassEntry(inClassName)); + if (outClassEntry == null) { + return null; } + return outClassEntry.getName(); }); } -- cgit v1.2.3