ASM Based Class Translator (#1)

* Initial port to ASM

* Package updates

* Annotation + inner class translation

* Fix inner class mapping

* More bytecode translation

* Signature refactoring

* Fix highlighting of mapped names

* Fix parameter name offset

* Fix anonymous class generation

* Fix issues with inner class signature transformation

* Fix bridged method detection

* Fix compile issues

* Resolve all failed tests

* Apply deobfuscated name to transformed classes

* Fix class signatures not being translated

* Fix frame array type translation

* Fix frame array type translation

* Fix array translation in method calls

* Fix method reference and bridge detection

* Fix handling of null deobf mappings

* Parameter translation in interfaces

* Fix enum parameter index offset

* Fix parsed local variable indexing

* Fix stackoverflow on rebuilding method names

* Ignore invalid decompiled variable indices

* basic source jar

* Output directly to file on source export

* Make decompile parallel

* fix incorrect super calls

* Use previous save state to delete old mapping files

* Fix old mappings not properly being removed

* Fix old mappings not properly being removed

* make isMethodProvider public

(cherry picked from commit ebad6a9)

* speed up Deobfuscator's getSources by using a single TranslatingTypeloader and caching the ClassLoaderTypeloader

* ignore .idea project folders

* move SynchronizedTypeLoader to a non-inner

* fix signature remap of inners for now

* index & resolve method/field references for usages view

* Allow reader/writer subclasses to provide the underlying file operations

* fix giving obf classes a name not removing them from the panel

* buffer the ParsedJar class entry inputstream, allow use with a jarinputstream

* make CachingClasspathTypeLoader public

* make CachingClasspathTypeLoader public

* support enum switches with obfuscated SwitchMaps

1 files changed, 24 insertions, 43 deletions

diff --git a/src/main/java/cuchaz/enigma/gui/Gui.java b/src/main/java/cuchaz/enigma/gui/Gui.java
index 4a891cf..cfac8ad 100644
--- a/src/main/java/cuchaz/enigma/gui/Gui.java
+++ b/src/main/java/cuchaz/enigma/gui/Gui.java
@@ -32,10 +32,10 @@ import cuchaz.enigma.gui.panels.PanelEditor;
 import cuchaz.enigma.gui.panels.PanelIdentifier;
 import cuchaz.enigma.gui.panels.PanelObf;
 import cuchaz.enigma.mapping.*;
+import cuchaz.enigma.mapping.entry.*;
 import cuchaz.enigma.throwables.IllegalNameException;
 import cuchaz.enigma.utils.Utils;
 import de.sciss.syntaxpane.DefaultSyntaxKit;
-import javassist.bytecode.Descriptor;
 
 import javax.swing.*;
 import javax.swing.text.BadLocationException;
@@ -48,8 +48,10 @@ import java.awt.*;
 import java.awt.event.*;
 import java.io.File;
 import java.io.IOException;
-import java.util.*;
+import java.util.Collection;
+import java.util.Collections;
 import java.util.List;
+import java.util.Vector;
 import java.util.function.Function;
 
 public class Gui {
@@ -438,14 +440,10 @@ public class Gui {
                         showFieldEntry((FieldEntry) this.reference.entry);
                 } else if (this.reference.entry instanceof MethodEntry) {
                         showMethodEntry((MethodEntry) this.reference.entry);
-                } else if (this.reference.entry instanceof ConstructorEntry) {
-                        showConstructorEntry((ConstructorEntry) this.reference.entry);
-                } else if (this.reference.entry instanceof ArgumentEntry) {
-                        showArgumentEntry((ArgumentEntry) this.reference.entry);
                 } else if (this.reference.entry instanceof LocalVariableEntry) {
                         showLocalVariableEntry((LocalVariableEntry) this.reference.entry);
                 } else {
-                        throw new Error("Unknown entry type: " + this.reference.entry.getClass().getName());
+                        throw new Error("Unknown entry desc: " + this.reference.entry.getClass().getName());
                 }
 
                 redraw();
@@ -453,10 +451,9 @@ public class Gui {
 
         private void showLocalVariableEntry(LocalVariableEntry entry) {
                 addNameValue(infoPanel, "Variable", entry.getName());
-                addNameValue(infoPanel, "Class", entry.getClassEntry().getName());
-                addNameValue(infoPanel, "Method", entry.getBehaviorEntry().getName());
+                addNameValue(infoPanel, "Class", entry.getOwnerClassEntry().getName());
+                addNameValue(infoPanel, "Method", entry.getOwnerEntry().getName());
                 addNameValue(infoPanel, "Index", Integer.toString(entry.getIndex()));
-                addNameValue(infoPanel, "Type", entry.getType().toString());
         }
 
         private void showClassEntry(ClassEntry entry) {
@@ -466,32 +463,20 @@ public class Gui {
 
         private void showFieldEntry(FieldEntry entry) {
                 addNameValue(infoPanel, "Field", entry.getName());
-                addNameValue(infoPanel, "Class", entry.getClassEntry().getName());
-                addNameValue(infoPanel, "Type", entry.getType().toString());
+                addNameValue(infoPanel, "Class", entry.getOwnerClassEntry().getName());
+                addNameValue(infoPanel, "TypeDescriptor", entry.getDesc().toString());
                 addModifierComboBox(infoPanel, "Modifier", entry);
         }
 
         private void showMethodEntry(MethodEntry entry) {
-                addNameValue(infoPanel, "Method", entry.getName());
-                addNameValue(infoPanel, "Class", entry.getClassEntry().getName());
-                addNameValue(infoPanel, "Signature", entry.getSignature().toString());
-                addModifierComboBox(infoPanel, "Modifier", entry);
-
-        }
-
-        private void showConstructorEntry(ConstructorEntry entry) {
-                addNameValue(infoPanel, "Constructor", entry.getClassEntry().getName());
-                if (!entry.isStatic()) {
-                        addNameValue(infoPanel, "Signature", entry.getSignature().toString());
-                        addModifierComboBox(infoPanel, "Modifier", entry);
+                if (entry.isConstructor()) {
+                        addNameValue(infoPanel, "Constructor", entry.getOwnerClassEntry().getName());
+                } else {
+                        addNameValue(infoPanel, "Method", entry.getName());
+                        addNameValue(infoPanel, "Class", entry.getOwnerClassEntry().getName());
                 }
-        }
-
-        private void showArgumentEntry(ArgumentEntry entry) {
-                addNameValue(infoPanel, "Argument", entry.getName());
-                addNameValue(infoPanel, "Class", entry.getClassEntry().getName());
-                addNameValue(infoPanel, "Method", entry.getBehaviorEntry().getName());
-                addNameValue(infoPanel, "Index", Integer.toString(entry.getIndex()));
+                addNameValue(infoPanel, "MethodDescriptor", entry.getDesc().toString());
+                addModifierComboBox(infoPanel, "Modifier", entry);
         }
 
         private void addNameValue(JPanel container, String name, String value) {
@@ -532,8 +517,8 @@ public class Gui {
                 reference = this.controller.getDeobfReference(token);
                 boolean isClassEntry = isToken && reference.entry instanceof ClassEntry;
                 boolean isFieldEntry = isToken && reference.entry instanceof FieldEntry;
-                boolean isMethodEntry = isToken && reference.entry instanceof MethodEntry;
-                boolean isConstructorEntry = isToken && reference.entry instanceof ConstructorEntry;
+                boolean isMethodEntry = isToken && reference.entry instanceof MethodEntry && !((MethodEntry) reference.entry).isConstructor();
+                boolean isConstructorEntry = isToken && reference.entry instanceof MethodEntry && ((MethodEntry) reference.entry).isConstructor();
                 boolean isInJar = isToken && this.controller.entryIsInJar(reference.entry);
                 boolean isRenameable = isToken && this.controller.referenceIsRenameable(reference);
 
@@ -710,16 +695,13 @@ public class Gui {
                 if (reference.entry instanceof ClassEntry) {
                         // look for calls to the default constructor
                         // TODO: get a list of all the constructors and find calls to all of them
-                        BehaviorReferenceTreeNode node = this.controller.getMethodReferences(new ConstructorEntry((ClassEntry) reference.entry, new Signature("()V")));
+                        MethodReferenceTreeNode node = this.controller.getMethodReferences(new MethodEntry((ClassEntry) reference.entry, "<init>", new MethodDescriptor("()V")));
                         callsTree.setModel(new DefaultTreeModel(node));
                 } else if (reference.entry instanceof FieldEntry) {
                         FieldReferenceTreeNode node = this.controller.getFieldReferences((FieldEntry) reference.entry);
                         callsTree.setModel(new DefaultTreeModel(node));
                 } else if (reference.entry instanceof MethodEntry) {
-                        BehaviorReferenceTreeNode node = this.controller.getMethodReferences((MethodEntry) reference.entry);
-                        callsTree.setModel(new DefaultTreeModel(node));
-                } else if (reference.entry instanceof ConstructorEntry) {
-                        BehaviorReferenceTreeNode node = this.controller.getMethodReferences((ConstructorEntry) reference.entry);
+                        MethodReferenceTreeNode node = this.controller.getMethodReferences((MethodEntry) reference.entry);
                         callsTree.setModel(new DefaultTreeModel(node));
                 }
 
@@ -790,7 +772,6 @@ public class Gui {
                 // package rename
                 if (data instanceof String) {
                         for (int i = 0; i < node.getChildCount(); i++) {
-                                data = Descriptor.toJvmName((String) data);
                                 DefaultMutableTreeNode childNode = (DefaultMutableTreeNode) node.getChildAt(i);
                                 ClassEntry prevDataChild = (ClassEntry) childNode.getUserObject();
                                 ClassEntry dataChild = new ClassEntry(data + "/" + prevDataChild.getSimpleName());
@@ -807,15 +788,15 @@ public class Gui {
         }
 
         public void moveClassTree(EntryReference<Entry, Entry> deobfReference, String newName) {
-                String oldEntry = deobfReference.entry.getClassEntry().getPackageName();
-                String newEntry = new ClassEntry(Descriptor.toJvmName(newName)).getPackageName();
+                String oldEntry = deobfReference.entry.getOwnerClassEntry().getPackageName();
+                String newEntry = new ClassEntry(newName).getPackageName();
                 moveClassTree(deobfReference, newName, oldEntry == null,
                         newEntry == null);
         }
 
         public void moveClassTree(EntryReference<Entry, Entry> deobfReference, String newName, boolean isOldOb, boolean isNewOb) {
-                ClassEntry oldEntry = deobfReference.entry.getClassEntry();
-                ClassEntry newEntry = new ClassEntry(Descriptor.toJvmName(newName));
+                ClassEntry oldEntry = deobfReference.entry.getOwnerClassEntry();
+                ClassEntry newEntry = new ClassEntry(newName);
 
                 // Ob -> deob
                 if (isOldOb && !isNewOb) {