ASM Based Class Translator (#1)

* Initial port to ASM

* Package updates

* Annotation + inner class translation

* Fix inner class mapping

* More bytecode translation

* Signature refactoring

* Fix highlighting of mapped names

* Fix parameter name offset

* Fix anonymous class generation

* Fix issues with inner class signature transformation

* Fix bridged method detection

* Fix compile issues

* Resolve all failed tests

* Apply deobfuscated name to transformed classes

* Fix class signatures not being translated

* Fix frame array type translation

* Fix frame array type translation

* Fix array translation in method calls

* Fix method reference and bridge detection

* Fix handling of null deobf mappings

* Parameter translation in interfaces

* Fix enum parameter index offset

* Fix parsed local variable indexing

* Fix stackoverflow on rebuilding method names

* Ignore invalid decompiled variable indices

* basic source jar

* Output directly to file on source export

* Make decompile parallel

* fix incorrect super calls

* Use previous save state to delete old mapping files

* Fix old mappings not properly being removed

* Fix old mappings not properly being removed

* make isMethodProvider public

(cherry picked from commit ebad6a9)

* speed up Deobfuscator's getSources by using a single TranslatingTypeloader and caching the ClassLoaderTypeloader

* ignore .idea project folders

* move SynchronizedTypeLoader to a non-inner

* fix signature remap of inners for now

* index & resolve method/field references for usages view

* Allow reader/writer subclasses to provide the underlying file operations

* fix giving obf classes a name not removing them from the panel

* buffer the ParsedJar class entry inputstream, allow use with a jarinputstream

* make CachingClasspathTypeLoader public

* make CachingClasspathTypeLoader public

* support enum switches with obfuscated SwitchMaps

1 files changed, 41 insertions, 22 deletions

diff --git a/src/main/java/cuchaz/enigma/analysis/EntryRenamer.java b/src/main/java/cuchaz/enigma/analysis/EntryRenamer.java
index 75806c3..9be8378 100644
--- a/src/main/java/cuchaz/enigma/analysis/EntryRenamer.java
+++ b/src/main/java/cuchaz/enigma/analysis/EntryRenamer.java
@@ -15,6 +15,7 @@ import com.google.common.collect.Lists;
 import com.google.common.collect.Multimap;
 import com.google.common.collect.Sets;
 import cuchaz.enigma.mapping.*;
+import cuchaz.enigma.mapping.entry.*;
 
 import java.util.AbstractMap;
 import java.util.List;
@@ -87,18 +88,18 @@ public class EntryRenamer {
                         MethodEntry newMethodEntry = renames.get(methodEntry);
                         if (newMethodEntry != null) {
                                 return (T) new MethodEntry(
-                                        methodEntry.getClassEntry(),
-                                        newMethodEntry.getName(),
-                                        methodEntry.getSignature()
+                                                methodEntry.getOwnerClassEntry(),
+                                                newMethodEntry.getName(),
+                                                methodEntry.getDesc()
                                 );
                         }
                         return thing;
-                } else if (thing instanceof ArgumentEntry) {
-                        ArgumentEntry argumentEntry = (ArgumentEntry) thing;
-                        return (T) new ArgumentEntry(
-                                renameMethodsInThing(renames, argumentEntry.getBehaviorEntry()),
-                                argumentEntry.getIndex(),
-                                argumentEntry.getName()
+                } else if (thing instanceof LocalVariableEntry) {
+                        LocalVariableEntry variableEntry = (LocalVariableEntry) thing;
+                        return (T) new LocalVariableEntry(
+                                        renameMethodsInThing(renames, variableEntry.getOwnerEntry()),
+                                        variableEntry.getIndex(),
+                                        variableEntry.getName()
                         );
                 } else if (thing instanceof EntryReference) {
                         EntryReference<Entry, Entry> reference = (EntryReference<Entry, Entry>) thing;
@@ -119,27 +120,45 @@ public class EntryRenamer {
                 } else if (thing instanceof ClassEntry) {
                         ClassEntry classEntry = (ClassEntry) thing;
                         return (T) new ClassEntry(renameClassesInThing(renames, classEntry.getClassName()));
-                } else if (thing instanceof FieldEntry) {
-                        FieldEntry fieldEntry = (FieldEntry) thing;
-                        return (T) new FieldEntry(renameClassesInThing(renames, fieldEntry.getClassEntry()), fieldEntry.getName(), renameClassesInThing(renames, fieldEntry.getType()));
-                } else if (thing instanceof ConstructorEntry) {
-                        ConstructorEntry constructorEntry = (ConstructorEntry) thing;
-                        return (T) new ConstructorEntry(renameClassesInThing(renames, constructorEntry.getClassEntry()), renameClassesInThing(renames, constructorEntry.getSignature()));
+                } else if (thing instanceof FieldDefEntry) {
+                        FieldDefEntry fieldEntry = (FieldDefEntry) thing;
+                        return (T) new FieldDefEntry(
+                                        renameClassesInThing(renames, fieldEntry.getOwnerClassEntry()),
+                                        fieldEntry.getName(),
+                                        renameClassesInThing(renames, fieldEntry.getDesc()),
+                                        renameClassesInThing(renames, fieldEntry.getSignature()),
+                                        fieldEntry.getAccess()
+                        );
+                } else if (thing instanceof MethodDefEntry) {
+                        MethodDefEntry methodEntry = (MethodDefEntry) thing;
+                        return (T) new MethodDefEntry(
+                                        renameClassesInThing(renames, methodEntry.getOwnerClassEntry()),
+                                        methodEntry.getName(),
+                                        renameClassesInThing(renames, methodEntry.getDesc()),
+                                        renameClassesInThing(renames, methodEntry.getSignature()),
+                                        methodEntry.getAccess()
+                        );
                 } else if (thing instanceof MethodEntry) {
                         MethodEntry methodEntry = (MethodEntry) thing;
-                        return (T) new MethodEntry(renameClassesInThing(renames, methodEntry.getClassEntry()), methodEntry.getName(), renameClassesInThing(renames, methodEntry.getSignature()));
-                } else if (thing instanceof ArgumentEntry) {
-                        ArgumentEntry argumentEntry = (ArgumentEntry) thing;
-                        return (T) new ArgumentEntry(renameClassesInThing(renames, argumentEntry.getBehaviorEntry()), argumentEntry.getIndex(), argumentEntry.getName());
+                        return (T) new MethodEntry(
+                                        renameClassesInThing(renames, methodEntry.getOwnerClassEntry()),
+                                        methodEntry.getName(),
+                                        renameClassesInThing(renames, methodEntry.getDesc())
+                        );
+                } else if (thing instanceof LocalVariableEntry) {
+                        LocalVariableEntry argumentEntry = (LocalVariableEntry) thing;
+                        return (T) new LocalVariableEntry(renameClassesInThing(renames, argumentEntry.getOwnerEntry()), argumentEntry.getIndex(), argumentEntry.getName());
                 } else if (thing instanceof EntryReference) {
                         EntryReference<Entry, Entry> reference = (EntryReference<Entry, Entry>) thing;
                         reference.entry = renameClassesInThing(renames, reference.entry);
                         reference.context = renameClassesInThing(renames, reference.context);
                         return thing;
+                } else if (thing instanceof MethodDescriptor) {
+                        return (T) ((MethodDescriptor) thing).remap(className -> renameClassesInThing(renames, className));
+                } else if (thing instanceof TypeDescriptor) {
+                        return (T) ((TypeDescriptor) thing).remap(className -> renameClassesInThing(renames, className));
                 } else if (thing instanceof Signature) {
-                        return (T) new Signature((Signature) thing, className -> renameClassesInThing(renames, className));
-                } else if (thing instanceof Type) {
-                        return (T) new Type((Type) thing, className -> renameClassesInThing(renames, className));
+                        return (T) ((Signature) thing).remap(className -> renameClassesInThing(renames, className));
                 }
 
                 return thing;