Add progress listener to Mapping-IO conversion; deduplicate lang files

6 files changed, 28 insertions, 18 deletions

diff --git a/enigma/src/main/java/cuchaz/enigma/translation/mapping/serde/MappingIoConverter.java b/enigma/src/main/java/cuchaz/enigma/translation/mapping/serde/MappingIoConverter.java
index d3fd341..171f252 100644
--- a/enigma/src/main/java/cuchaz/enigma/translation/mapping/serde/MappingIoConverter.java
+++ b/enigma/src/main/java/cuchaz/enigma/translation/mapping/serde/MappingIoConverter.java
@@ -3,6 +3,7 @@ package cuchaz.enigma.translation.mapping.serde;
 import java.util.Deque;
 import java.util.LinkedList;
 import java.util.List;
+import java.util.stream.StreamSupport;
 
 import net.fabricmc.mappingio.MappedElementKind;
 import net.fabricmc.mappingio.tree.MemoryMappingTree;
@@ -11,6 +12,7 @@ import net.fabricmc.mappingio.tree.MappingTree.FieldMapping;
 import net.fabricmc.mappingio.tree.MappingTree.MethodArgMapping;
 import net.fabricmc.mappingio.tree.MappingTree.MethodMapping;
 
+import cuchaz.enigma.ProgressListener;
 import cuchaz.enigma.translation.mapping.EntryMap;
 import cuchaz.enigma.translation.mapping.EntryMapping;
 import cuchaz.enigma.translation.mapping.tree.EntryTree;
@@ -23,16 +25,23 @@ import cuchaz.enigma.translation.representation.entry.Entry;
 import cuchaz.enigma.translation.representation.entry.FieldEntry;
 import cuchaz.enigma.translation.representation.entry.LocalVariableEntry;
 import cuchaz.enigma.translation.representation.entry.MethodEntry;
+import cuchaz.enigma.utils.I18n;
 
 public class MappingIoConverter {
-        public static MemoryMappingTree toMappingIo(EntryTree<EntryMapping> mappings) {
+        public static MemoryMappingTree toMappingIo(EntryTree<EntryMapping> mappings, ProgressListener progress) {
+                List<EntryTreeNode<EntryMapping>> classes = StreamSupport.stream(mappings.spliterator(), false)
+                                .filter(node -> node.getEntry() instanceof ClassEntry)
+                                .toList();
+
+                progress.init(classes.size(), I18n.translate("progress.mappings.converting.to_mappingio"));
+                int steps = 0;
+
                 MemoryMappingTree mappingTree = new MemoryMappingTree();
                 mappingTree.visitNamespaces("intermediary", List.of("named"));
 
-                for (EntryTreeNode<EntryMapping> node : mappings) {
-                        if (node.getEntry() instanceof ClassEntry) {
-                                writeClass(node, mappings, mappingTree);
-                        }
+                for (EntryTreeNode<EntryMapping> classNode : classes) {
+                        progress.step(steps++, classNode.getEntry().getFullName());
+                        writeClass(classNode, mappings, mappingTree);
                 }
 
                 mappingTree.visitEnd();
@@ -131,10 +140,13 @@ public class MappingIoConverter {
                 mappingTree.visitComment(MappedElementKind.METHOD_ARG, methodArgMapping.javadoc());
         }
 
-        public static EntryTree<EntryMapping> fromMappingIo(MemoryMappingTree mappingTree) {
+        public static EntryTree<EntryMapping> fromMappingIo(MemoryMappingTree mappingTree, ProgressListener progress) {
                 EntryTree<EntryMapping> dstMappingTree = new HashEntryTree<>();
+                progress.init(mappingTree.getClasses().size(), I18n.translate("progress.mappings.converting.from_mappingio"));
+                int steps = 0;
 
                 for (ClassMapping classMapping : mappingTree.getClasses()) {
+                        progress.step(steps++, classMapping.getDstName(0) != null ? classMapping.getDstName(0) : classMapping.getSrcName());
                         readClass(classMapping, dstMappingTree);
                 }
 
diff --git a/enigma/src/main/java/cuchaz/enigma/translation/mapping/serde/enigma/EnigmaMappingsReader.java b/enigma/src/main/java/cuchaz/enigma/translation/mapping/serde/enigma/EnigmaMappingsReader.java
index 5461342..d5570e9 100644
--- a/enigma/src/main/java/cuchaz/enigma/translation/mapping/serde/enigma/EnigmaMappingsReader.java
+++ b/enigma/src/main/java/cuchaz/enigma/translation/mapping/serde/enigma/EnigmaMappingsReader.java
@@ -40,12 +40,12 @@ public enum EnigmaMappingsReader implements MappingsReader {
         FILE {
                 @Override
                 public EntryTree<EntryMapping> read(Path path, ProgressListener progress, MappingSaveParameters saveParameters) throws IOException, MappingParseException {
-                        progress.init(1, I18n.translate("progress.mappings.enigma_file.loading"));
+                        progress.init(1, I18n.translate("progress.mappings.loading_file"));
 
                         EntryTree<EntryMapping> mappings = new HashEntryTree<>();
                         readFile(path, mappings);
 
-                        progress.step(1, I18n.translate("progress.mappings.enigma_file.done"));
+                        progress.step(1, I18n.translate("progress.done"));
 
                         return mappings;
                 }
@@ -60,7 +60,7 @@ public enum EnigmaMappingsReader implements MappingsReader {
                         EntryTree<EntryMapping> mappings = new HashEntryTree<>();
                         List<Path> files = Files.walk(root).filter(f -> !Files.isDirectory(f)).filter(f -> f.toString().endsWith(".mapping")).toList();
 
-                        progress.init(files.size(), I18n.translate("progress.mappings.enigma_directory.loading"));
+                        progress.init(files.size(), I18n.translate("progress.mappings.loading_directory"));
                         int step = 0;
 
                         for (Path file : files) {
@@ -102,7 +102,7 @@ public enum EnigmaMappingsReader implements MappingsReader {
                         throw new IllegalArgumentException("No paths to read mappings from");
                 }
 
-                progress.init(paths.length, I18n.translate("progress.mappings.enigma_directory.loading"));
+                progress.init(paths.length, I18n.translate("progress.mappings.loading_directory"));
                 int step = 0;
 
                 for (Path file : paths) {
diff --git a/enigma/src/main/java/cuchaz/enigma/translation/mapping/serde/enigma/EnigmaMappingsWriter.java b/enigma/src/main/java/cuchaz/enigma/translation/mapping/serde/enigma/EnigmaMappingsWriter.java
index df1af91..73f29a1 100644
--- a/enigma/src/main/java/cuchaz/enigma/translation/mapping/serde/enigma/EnigmaMappingsWriter.java
+++ b/enigma/src/main/java/cuchaz/enigma/translation/mapping/serde/enigma/EnigmaMappingsWriter.java
@@ -58,7 +58,7 @@ public enum EnigmaMappingsWriter implements MappingsWriter {
                 public void write(EntryTree<EntryMapping> mappings, MappingDelta<EntryMapping> delta, Path path, ProgressListener progress, MappingSaveParameters saveParameters) {
                         Collection<ClassEntry> classes = mappings.getRootNodes().filter(entry -> entry.getEntry() instanceof ClassEntry).map(entry -> (ClassEntry) entry.getEntry()).toList();
 
-                        progress.init(classes.size(), I18n.translate("progress.mappings.enigma_file.writing"));
+                        progress.init(classes.size(), I18n.translate("progress.mappings.writing"));
 
                         int steps = 0;
 
@@ -78,11 +78,9 @@ public enum EnigmaMappingsWriter implements MappingsWriter {
                         Collection<ClassEntry> changedClasses = delta.getChangedRoots().filter(entry -> entry instanceof ClassEntry).map(entry -> (ClassEntry) entry).toList();
 
                         applyDeletions(path, changedClasses, mappings, delta.getBaseMappings(), saveParameters.getFileNameFormat());
-
                         changedClasses = changedClasses.stream().filter(entry -> !isClassEmpty(mappings, entry)).collect(Collectors.toList());
 
-                        progress.init(changedClasses.size(), I18n.translate("progress.mappings.enigma_directory.writing"));
-
+                        progress.init(changedClasses.size(), I18n.translate("progress.mappings.writing"));
                         AtomicInteger steps = new AtomicInteger();
 
                         Translator translator = new MappingTranslator(mappings, VoidEntryResolver.INSTANCE);
diff --git a/enigma/src/main/java/cuchaz/enigma/translation/mapping/serde/srg/SrgMappingsWriter.java b/enigma/src/main/java/cuchaz/enigma/translation/mapping/serde/srg/SrgMappingsWriter.java
index 4621efe..5addcad 100644
--- a/enigma/src/main/java/cuchaz/enigma/translation/mapping/serde/srg/SrgMappingsWriter.java
+++ b/enigma/src/main/java/cuchaz/enigma/translation/mapping/serde/srg/SrgMappingsWriter.java
@@ -45,7 +45,7 @@ public enum SrgMappingsWriter implements MappingsWriter {
                 List<String> methodLines = new ArrayList<>();
 
                 List<? extends Entry<?>> rootEntries = Lists.newArrayList(mappings).stream().map(EntryTreeNode::getEntry).toList();
-                progress.init(rootEntries.size(), I18n.translate("progress.mappings.srg_file.generating"));
+                progress.init(rootEntries.size(), I18n.translate("progress.mappings.converting"));
 
                 int steps = 0;
 
@@ -54,7 +54,7 @@ public enum SrgMappingsWriter implements MappingsWriter {
                         writeEntry(classLines, fieldLines, methodLines, mappings, entry);
                 }
 
-                progress.init(3, I18n.translate("progress.mappings.srg_file.writing"));
+                progress.init(3, I18n.translate("progress.mappings.writing"));
 
                 try (PrintWriter writer = new LfPrintWriter(Files.newBufferedWriter(path))) {
                         progress.step(0, I18n.translate("type.classes"));
diff --git a/enigma/src/main/java/cuchaz/enigma/translation/mapping/serde/tiny/TinyMappingsReader.java b/enigma/src/main/java/cuchaz/enigma/translation/mapping/serde/tiny/TinyMappingsReader.java
index 534a567..1575f46 100644
--- a/enigma/src/main/java/cuchaz/enigma/translation/mapping/serde/tiny/TinyMappingsReader.java
+++ b/enigma/src/main/java/cuchaz/enigma/translation/mapping/serde/tiny/TinyMappingsReader.java
@@ -35,7 +35,7 @@ public enum TinyMappingsReader implements MappingsReader {
                 EntryTree<EntryMapping> mappings = new HashEntryTree<>();
                 lines.remove(0);
 
-                progress.init(lines.size(), I18n.translate("progress.mappings.tiny_file.loading"));
+                progress.init(lines.size(), I18n.translate("progress.mappings.loading_file"));
 
                 for (int lineNumber = 0; lineNumber < lines.size(); lineNumber++) {
                         progress.step(lineNumber, "");
diff --git a/enigma/src/main/java/cuchaz/enigma/translation/mapping/serde/tinyv2/TinyV2Reader.java b/enigma/src/main/java/cuchaz/enigma/translation/mapping/serde/tinyv2/TinyV2Reader.java
index eecbc35..28185f5 100644
--- a/enigma/src/main/java/cuchaz/enigma/translation/mapping/serde/tinyv2/TinyV2Reader.java
+++ b/enigma/src/main/java/cuchaz/enigma/translation/mapping/serde/tinyv2/TinyV2Reader.java
@@ -46,7 +46,7 @@ public final class TinyV2Reader implements MappingsReader {
         private EntryTree<EntryMapping> read(Path path, List<String> lines, ProgressListener progress) throws MappingParseException {
                 EntryTree<EntryMapping> mappings = new HashEntryTree<>();
 
-                progress.init(lines.size(), "progress.mappings.tiny_v2.loading");
+                progress.init(lines.size(), "progress.mappings.loading_file");
 
                 BitSet state = new BitSet(STATE_SIZE);
                 @SuppressWarnings({"unchecked", "rawtypes"}) MappingPair<? extends Entry<?>, RawEntryMapping>[] holds = new MappingPair[STATE_SIZE];